Re: [ath9k-devel] [PATCH 4/6] ath9k: remove return value from ath9k_hw_init_macaddr

Hi All, On Fri, Jun 24, 2016 at 12:57 AM, Martin Blumenstingl wrote: > ath9k_hw_init_macaddr unconditionally returns 0 in all cases, making the > return value unnecessary. > > Signed-off-by: Martin Blumenstingl Looks right

Re: [ath9k-devel] [PATCH 2/6] ath9k: remove variable which is set but never read

Hi All, On Fri, Jun 24, 2016 at 12:57 AM, Martin Blumenstingl wrote: > No functional changes - this only removes a variable which is set but > never read. > > Signed-off-by: Martin Blumenstingl Looks right to me.

Re: [ath9k-devel] [PATCH RFC v2 1/2] Documentation: dt: net: add ath9k wireless device binding

On Thu, Jun 23, 2016 at 9:25 PM, Arend Van Spriel wrote: >> +Optional properties: >> +- reg: Address and length of the register set for the device. > > Is 'reg' property handled. I don't see it in patch 2/2. for AHB we would probably have to handle it separately, but

Re: [ath9k-devel] [PATCH RFC v2 1/2] Documentation: dt: net: add ath9k wireless device binding

On Thu, Jun 23, 2016 at 7:58 PM, Mark Rutland wrote: > On Thu, Jun 23, 2016 at 07:45:35PM +0200, Martin Blumenstingl wrote: >> Add documentation how devicetree can be used to configure ath9k based >> devices. >> >> Signed-off-by: Martin Blumenstingl

[ath9k-devel] [PATCH RFC v2 2/2] ath9k: parse the device configuration from an OF node

This makes it possible to configure ath9k based devices using devicetree. That makes some out-of-tree "convert devicetree to ath9k_platform_data glue"-code obsolete. Signed-off-by: Martin Blumenstingl --- changes in v1 -> v2: - use vendor prefix "qca" instead

[ath9k-devel] [PATCH RFC v2 1/2] Documentation: dt: net: add ath9k wireless device binding

Add documentation how devicetree can be used to configure ath9k based devices. Signed-off-by: Martin Blumenstingl --- changes in v1 -> v2: - use vendor prefix "qca" instead of "ath" - extend the example so it includes the "compatible" property

[ath9k-devel] [RFC v2] ath9k: add devicetree support to ath9k

This series adds support for configuring ath9k based devices via devicetree. This was tested on PCI(e) based devices. This should work for AHB based devices as well as soon as the ath79 platform is ready to populate the ath9k wmac via devicetree. This series depends on my previous series: "ath9k:

Re: [ath9k-devel] [PATCH 2/2] Documentation: dt: net: add ath9k wireless device binding

On Thursday, June 23, 2016 05:13:28 PM Martin Blumenstingl wrote: > Add documentation how devicetree can be used to configure ath9k based > devices. > > Signed-off-by: Martin Blumenstingl You need to CC' the devicetree maintainers: Mark Rutland

Re: [ath9k-devel] [PATCH 1/2] ath9k: parse the device configuration from an OF node

On Thursday, June 23, 2016 05:13:27 PM Martin Blumenstingl wrote: > This makes it possible to configure ath9k based devices using > devicetree. That makes some out-of-tree "convert devicetree to > ath9k_platform_data glue"-code obsolete. > > Signed-off-by: Martin Blumenstingl

[ath9k-devel] ath9k: extend and improve handling of ath9k_platform_data

This series improves handling of ath9k_platform_data inside ath9k. A quick summary of the changes is: - led_active_high can now be configured via ath9k_platform_data: This change is based on a patch originally written by Vittorio Gambaletta which is part of OpenWrt's ath9k patches. - small

[ath9k-devel] [PATCH 1/6] ath9k: Allow configuration of LED polarity in platform data.

Some devices running OpenWrt need this and it makes sense to add this to ath9k_platform_data as the next patches will add a devicetree (boolean) property for it as well. Suggested-by: Vittorio Gambaletta Signed-off-by: Martin Blumenstingl

[ath9k-devel] [PATCH 2/6] ath9k: remove variable which is set but never read

No functional changes - this only removes a variable which is set but never read. Signed-off-by: Martin Blumenstingl --- drivers/net/wireless/ath/ath9k/hw.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/hw.c

[ath9k-devel] [PATCH 1/2] ath9k: parse the device configuration from an OF node

This makes it possible to configure ath9k based devices using devicetree. That makes some out-of-tree "convert devicetree to ath9k_platform_data glue"-code obsolete. Signed-off-by: Martin Blumenstingl --- drivers/net/wireless/ath/ath9k/init.c | 70

[ath9k-devel] [PATCH 5/6] ath9k: move all ath9k_platform_data initialization into one function

No functional changes, this simply makes the code easier to understand because all initialization based on ath9k_platform_data is now within one function. Signed-off-by: Martin Blumenstingl --- drivers/net/wireless/ath/ath9k/init.c | 49

[ath9k-devel] [PATCH 2/2] Documentation: dt: net: add ath9k wireless device binding

Add documentation how devicetree can be used to configure ath9k based devices. Signed-off-by: Martin Blumenstingl --- .../devicetree/bindings/net/wireless/ath,ath9k.txt | 40 ++ 1 file changed, 40 insertions(+) create mode 100644

[ath9k-devel] [RFC] ath9k: add devicetree support to ath9k

This series adds support for configuring ath9k based devices via devicetree. This was tested on PCI(e) based devices. This should work for AHB based devices as well as soon as the ath79 platform is ready to populate the ath9k wmac via devicetree. This series depends on my previous series: "ath9k:

[ath9k-devel] [PATCH 3/6] ath9k: ath9k_hw_init_macaddr should not overwrite valid MAC addresses

Currently setting the MAC address via ath9k_platform_data works only due to the order in which init.c sets common->macaddr, which is done after ath9k_hw_init_macaddr was executed. It would be better if the latter was independent of the order in which it's being called. Signed-off-by: Martin

[ath9k-devel] [PATCH 6/6] ath9k: simplify the code-paths when not using the built-in EEPROM

There were two paths in the code for "external" eeprom sources. The code in eeprom.c only handled the cases where the eeprom data was loaded via request_firmware. ahb.c and pci.c on the other hand had some duplicate code which was only used when the eeprom data was passed via ath9k_platform_data.

[ath9k-devel] [PATCH 4/6] ath9k: remove return value from ath9k_hw_init_macaddr

ath9k_hw_init_macaddr unconditionally returns 0 in all cases, making the return value unnecessary. Signed-off-by: Martin Blumenstingl --- drivers/net/wireless/ath/ath9k/hw.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git