Re: [ath9k-devel] Atheros Linux wireless support - ramifications of reverse engineering alien technology

2009-04-03 Thread David Miller
From: Larry Finger larry.fin...@lwfinger.net Date: Thu, 02 Apr 2009 15:02:23 -0500 Maxim Levitsky wrote: On Wed, 2009-04-01 at 11:47 -0700, Luis R. Rodriguez wrote: Fellow Linux wireless hackers, I have just three words: This is not funny. No sense of humor, and cannot count.

Re: [ath9k-devel] [PATCH 00/62] drivers/net: Use static const

2010-11-20 Thread David Miller
From: Joe Perches j...@perches.com Date: Sat, 20 Nov 2010 18:38:01 -0800 Using static const generally increases object text and decreases data size. It also generally decreases overall object size. Joe, I'm going to be frank and say that I'm not going to review and apply such a large chunk of

Re: [ath9k-devel] [PATCH 00/62] drivers/net: Use static const

2010-11-22 Thread David Miller
From: Joe Perches j...@perches.com Date: Mon, 22 Nov 2010 14:10:46 -0800 btw: it doesn't seem that, other than John Linville for wireless, you currently pull from many (any?) other people. Do let me know if you'd consider pulling these sorts of changes from me. Expand your horizon beyond

Re: [ath9k-devel] [PATCH 00/62] drivers/net: Use static const

2010-11-23 Thread David Miller
From: Joe Perches j...@perches.com Date: Mon, 22 Nov 2010 14:40:05 -0800 I'll see who picks up or acks what and send a pull request to you for the remainder of these patches mid December or so. Thanks. Do you want micro patches or a single patch? You can group them by directory or similar

Re: [ath9k-devel] [PATCH 1/3] drivers/net: Convert compare_ether_addr to ether_addr_equal

2012-05-10 Thread David Miller
Never, EVER, quote an entire large patch just to make a comment on one small hunk. I very nearly missed what you had to say because when scrolling through it it appeared as if you made no comments at all. Again, NEVER, EVER, do this. It's extremely anti-social. Edit out the irrelevant quoted

Re: [ath9k-devel] [PATCH 1/3] drivers/net: Convert compare_ether_addr to ether_addr_equal

2012-05-10 Thread David Miller
From: Joe Perches j...@perches.com Date: Wed, 9 May 2012 20:17:46 -0700 Use the new bool function ether_addr_equal to add some clarity and reduce the likelihood for misuse of compare_ether_addr for sorting. Done via cocci script: ... Signed-off-by: Joe Perches j...@perches.com Applied.

Re: [ath9k-devel] [PATCH 0/8] drivers/net: Remove unnecessary alloc/OOM messages

2013-02-04 Thread David Miller
From: Joe Perches j...@perches.com Date: Sun, 3 Feb 2013 19:28:07 -0800 Remove all the OOM messages that follow kernel alloc failures as there is already a generic equivalent to these messages in the mm subsystem. Joe Perches (8): caif: Remove unnecessary alloc/OOM messages can:

Re: [ath9k-devel] [PATCH] drivers: net: Remove remaining alloc/OOM messages

2013-02-08 Thread David Miller
From: Joe Perches j...@perches.com Date: Thu, 07 Feb 2013 13:46:27 -0800 alloc failures already get standardized OOM messages and a dump_stack. For the affected mallocs around these OOM messages: Converted kmallocs with multiplies to kmalloc_array. Converted a kmalloc/memcpy to kmemdup.

Re: [ath9k-devel] [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-20 Thread David Miller
From: Benoit Taine benoit.ta...@lip6.fr Date: Fri, 18 Jul 2014 17:26:47 +0200 We should prefer `const struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes