Re: [ath9k-devel] [RFC] ath9k: make npending frames check as bool

On Mon, May 09, 2011 at 02:58:54PM +0530, Vasanth Thiagarajan wrote: > On Mon, May 09, 2011 at 10:00:17AM +0530, Mohammed Shajakhan wrote: > > On Friday 06 May 2011 09:45 PM, Vasanth Thiagarajan wrote: > > > On Fri, May 06, 2011 at 09:24:51PM +0530, Mohammed Shafi Shajakhan wrote: > > >> From: Moha

Re: [ath9k-devel] [RFC] ath9k: make npending frames check as bool

On Mon, May 09, 2011 at 10:00:17AM +0530, Mohammed Shajakhan wrote: > On Friday 06 May 2011 09:45 PM, Vasanth Thiagarajan wrote: > > On Fri, May 06, 2011 at 09:24:51PM +0530, Mohammed Shafi Shajakhan wrote: > >> From: Mohammed Shafi Shajakhan > >> > >> Signed-off-by: Mohammed Shafi Shajakhan > >> -

Re: [ath9k-devel] [RFC] ath9k: make npending frames check as bool

On Fri, May 06, 2011 at 09:24:51PM +0530, Mohammed Shafi Shajakhan wrote: > From: Mohammed Shafi Shajakhan > > Signed-off-by: Mohammed Shafi Shajakhan > --- > drivers/net/wireless/ath/ath9k/main.c |7 +-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/w

Re: [ath9k-devel] [RFC/WIP 15/33] ath9k_htc: Add ANI for AP mode

On Fri, Jan 21, 2011 at 08:31:24AM +0530, Sujith wrote: > From: Sujith Manoharan > > + if (priv->ah->opmode == NL80211_IFTYPE_AP) > + cancel_delayed_work_sync(&priv->ath9k_ani_work); > + What about ANI for other vifs? Vasanth ___ ath9k

Re: [ath9k-devel] [RFC/WIP 30/33] ath9k_htc: Fix host RX initialization

On Fri, Jan 21, 2011 at 08:33:41AM +0530, Sujith wrote: > From: Sujith Manoharan > > There is no need to set the BSSID mask or opmode when > initializing RX, they would be set correctly in the HW reset > routine. > > Signed-off-by: Sujith Manoharan > --- > drivers/net/wireless/ath/ath9k/htc_dr

Re: [ath9k-devel] [PATCH] [RFC] ath9k: Fix reporting of RX STBC streams to userspace

On Tue, Jan 11, 2011 at 10:29:54PM +0530, Bernhard Walle wrote: > While the driver reports > > ath: TX streams 2, RX streams: 2 > > in the kernel log (with ATH_DBG_CONFIG set in the debug module > parameter), "iw list" only reported > > [...] > Capabilities: 0x12ce >

Re: [ath9k-devel] [PATCH 2/2] ath9k: Fix incorrect tx-hang detection logic.

On Fri, Jan 07, 2011 at 11:30:59PM +0530, gree...@candelatech.com wrote: > From: Ben Greear > > It is not guaranteed that the ath_tx_complete_poll_work runs > after some fixed duration because the channel-reset logic > removes the work and then re-adds it to run immediately. > Two channel-changes

Re: [ath9k-devel] [PATCH 2/3] ath9k: Re-start xmit logic in xmit watchdog timer.

On Fri, Jan 07, 2011 at 08:41:48PM +0530, Peter Stuge wrote: > Vasanthakumar Thiagarajan wrote: > > > +++ b/drivers/net/wireless/ath/ath9k/xmit.c > > > @@ -2110,6 +2110,27 @@ static void ath_tx_complete_poll_work(struct > > > work_struct *work) > >

Re: [ath9k-devel] [PATCH 2/3] ath9k: Re-start xmit logic in xmit watchdog timer.

On Fri, Jan 07, 2011 at 06:16:04AM +0530, gree...@candelatech.com wrote: > From: Ben Greear > > We should not get to this state, but we do. What is > worse, many times the xmit logic still will not start, > probably due to tids being paused when they shouldn't be. > > Signed-off-by: Ben Greear

Re: [ath9k-devel] smatch stuff: potential read past the end of the buffer

On Mon, Dec 20, 2010 at 02:00:41PM +0530, Dan Carpenter wrote: > Hello Vasanthakumar, > > Smatch complains that in linux-next 60e0c3a7 "ath9k_hw: Eeeprom changes > for AR9485" means there is a potential read past the end of the buffer > int ar9300_eeprom_restore_internal(). > > drivers/net/wirele

Re: [ath9k-devel] [PATCH] ath9k: Check for NULL sta in ath_tx_start

On Tue, Dec 07, 2010 at 10:43:38PM +0530, Ben Greear wrote: > On 12/07/2010 12:31 AM, Vasanthakumar Thiagarajan wrote: > > On Tue, Dec 07, 2010 at 01:19:22PM +0530, Ben Greear wrote: > >> On 12/06/2010 11:42 PM, Vasanthakumar Thiagarajan wrote: > >>> On Tue, Dec 07,

Re: [ath9k-devel] [PATCH] ath9k: Check for NULL sta in ath_tx_start

On Tue, Dec 07, 2010 at 01:19:22PM +0530, Ben Greear wrote: > On 12/06/2010 11:42 PM, Vasanthakumar Thiagarajan wrote: > > On Tue, Dec 07, 2010 at 11:06:24AM +0530, Ben Greear wrote: > >> On 12/06/2010 09:21 PM, Luis R. Rodriguez wrote: > >>> On Mon, Dec 6, 2010 at

Re: [ath9k-devel] [PATCH] ath9k: Check for NULL sta in ath_tx_start

On Tue, Dec 07, 2010 at 11:06:24AM +0530, Ben Greear wrote: > On 12/06/2010 09:21 PM, Luis R. Rodriguez wrote: > > On Mon, Dec 6, 2010 at 9:13 PM, wrote: > >> From: Ben Greear > >> > >> It can be NULL according to docs, and logging showed it > >> to be NULL in practice. > >> > >> Signed-off-by: Be

Re: [ath9k-devel] [PATCH] ath9k: make ath_ant_div_conf_fast_divbias static

On Thu, Sep 16, 2010 at 12:56:13AM +0530, John W. Linville wrote: > CHECK drivers/net/wireless/ath/ath9k/recv.c > drivers/net/wireless/ath/ath9k/recv.c:1341:6: warning: symbol > 'ath_ant_div_conf_fast_divbias' was not declared. Should it be static? > > Signed-off-by: John W. Linville > --- >

Re: [ath9k-devel] RFC: v3: Support multiple STA on same AP with ath9k

On Tue, Sep 14, 2010 at 08:09:54PM +0530, Ben Greear wrote: > On 09/14/2010 06:46 AM, Vasanthakumar Thiagarajan wrote: > > On Tue, Sep 14, 2010 at 12:53:29AM +0530, Ben Greear wrote: > >> Any suggestions for fixing the bssid mask setting in ath_opmode_init? > >> My chan

Re: [ath9k-devel] RFC: v3: Support multiple STA on same AP with ath9k

On Tue, Sep 14, 2010 at 12:53:29AM +0530, Ben Greear wrote: > Any suggestions for fixing the bssid mask setting in ath_opmode_init? > My change, appears to work because it's set in ath9k_add_interface, even > if not in the ath_opmode_init method. checking for ah->hw in ath_opmode_init() is buggy.

Re: [ath9k-devel] RFC: v3: Support multiple STA on same AP with ath9k

> /* configure operational mode */ > diff --git a/drivers/net/wireless/ath/ath9k/recv.c > b/drivers/net/wireless/ath/ath9k/recv.c > index b32c8f0..4ce4029 100644 > --- a/drivers/net/wireless/ath/ath9k/recv.c > +++ b/drivers/net/wireless/ath/ath9k/recv.c > @@ -110,7 +110,6 @@ static void ath_

Re: [ath9k-devel] [RFC] ath9k: 4ms frame length table update

On Thu, Mar 18, 2010 at 09:30:34PM +0530, Luis R. Rodriguez wrote: > On Wed, Mar 17, 2010 at 11:37:29PM -0700, selvam wrote: > > Hi, > > > > The 4 ms frame length table is updated to support up to MCS 31. > > > > These values are calculated based on the equation 9.1 from the IEEE 802.11n > > sta

Re: [ath9k-devel] [PATCH 2/2] ath9k_hw: Fix AR_GPIO_INPUT_EN_VAL_BT_PRIORITY_BB and its shift value in 0x4054

this > > wrong value in 0x4054 sometimes affects bt quality on btcoex environment. > > > > Signed-off-by: Vasanthakumar Thiagarajan > > These both seem small enough and reasonable for stable fixes no? yeah, I'll resend them CC'ing stable. > Although I

[ath9k-devel] [PATCH 2/2] ath9k_hw: Fix AR_GPIO_INPUT_EN_VAL_BT_PRIORITY_BB and its shift value in 0x4054

The bit value of AR_GPIO_INPUT_EN_VAL_BT_PRIORITY_BB is wrong, it should be 0x400 and the number of bits to be right shifted is 10. Having this wrong value in 0x4054 sometimes affects bt quality on btcoex environment. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k

[ath9k-devel] [PATCH 1/2] ath9k_hw: Fix possible OOB array indexing in gen_timer_index[] on 64-bit

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/hw.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/hw.h b/drivers/net/wireless/ath/ath9k/hw.h index 6d3e314..abaa2f0 100644 --- a/drivers/net/wireless/ath/ath9k

Re: [ath9k-devel] [RFC] ath9k: fix listening to idle requests

On Sat, Oct 31, 2009 at 10:59:53AM +0530, Vasanth Thiagarajan wrote: > On Fri, Oct 30, 2009 at 08:08:22PM +0530, Luis Rodriguez wrote: > > On Thu, Oct 29, 2009 at 11:33 PM, Vasanthakumar Thiagarajan > > wrote: > > > On Fri, Oct 30, 2009 at 02:22:26AM +0530, Luis Rodrigu

Re: [ath9k-devel] [RFC] ath9k: fix listening to idle requests

On Fri, Oct 30, 2009 at 08:08:22PM +0530, Luis Rodriguez wrote: > On Thu, Oct 29, 2009 at 11:33 PM, Vasanthakumar Thiagarajan > wrote: > > On Fri, Oct 30, 2009 at 02:22:26AM +0530, Luis Rodriguez wrote: > >> The way idle configuration detection was implemented as > >&g

Re: [ath9k-devel] [RFC] ath9k: fix listening to idle requests

for > one device this code was doing nothing. > > Reported-by: Vasanthakumar Thiagarajan > Signed-off-by: Luis R. Rodriguez > --- > > Vasanth, what do you think? Still we will have issue when bringing up a sec wiphy while the primary wiphy is in idle state. ath9k_star

Re: [ath9k-devel] ath9k rate control - rc.c

On Tue, Oct 20, 2009 at 11:28:41AM +0530, Rakesh Kumar wrote: >I am having trouble identifying what information is available to the driver >programmer? Is there a comprehensive document or something which explains it, >if so is it available in public domain? As far as rate control parameters ar

Re: [ath9k-devel] ath9k rate control - rc.c

On Thu, Oct 15, 2009 at 03:58:56AM +0530, Luis Rodriguez wrote: > On Wed, Oct 14, 2009 at 03:10:10PM -0700, Rakesh Kumar wrote: > > Is RSSI a parameter to rate control algorithm? > > I am not sure but it may be there for historical purposes. RSSI is never used to determine the tx rate. The code s

Re: [ath9k-devel] [RFT 0/4] ath9k: fix oops during driver unload

On Tue, Oct 06, 2009 at 09:23:17AM +0530, Luis Rodriguez wrote: > This should fix an oops reported by Vasanth. > Vasanth my rc3 poos out, can you let me know if this > fixes the issue you saw? > > Luis R. Rodriguez (4): > ath9k: move common->debug_mask setting to ath_init_softc() > ath9k: fix

Re: [ath9k-devel] [PATCH 09/15] ath9k: remove unused bt_duty_cycle

On Thu, Sep 10, 2009 at 05:14:55AM +0530, Luis Rodriguez wrote: > Signed-off-by: Luis R. Rodriguez > --- > drivers/net/wireless/ath/ath9k/btcoex.h |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath9k/btcoex.h > b/drivers/net/wireless/ath/a

[ath9k-devel] [PATCH 4/4] ath9k: Initialize the priority gpio for BT coex 3-wire

Oops, a stupid mistake in the original patch which adds coex 3-wire support. Bluetooth priority gpio needs to be gpio 7. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/btcoex.h |1 + drivers/net/wireless/ath/ath9k/hw.c |6 -- 2 files changed, 5

[ath9k-devel] [PATCH 3/4] ath9k: Get rid of the modparam btcoex_enable

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/hw.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c index 8d77817..c39693b 100644 --- a/drivers/net/wireless/ath

[ath9k-devel] [PATCH 2/4] ath9k: Enable btcoex based on the subsystem id of the device

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/btcoex.c | 23 +++ drivers/net/wireless/ath/ath9k/btcoex.h |1 + drivers/net/wireless/ath/ath9k/hw.c |3 ++- drivers/net/wireless/ath/ath9k/hw.h |4 4 files changed, 30

[ath9k-devel] [PATCH 1/4] ath9k: Store subsystem id in struct hw_version

This subsystem id will be used later to turn on the btcoex support. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/ahb.c |2 +- drivers/net/wireless/ath/ath9k/ath9k.h |2 +- drivers/net/wireless/ath/ath9k/hw.h|1 + drivers/net/wireless/ath/ath9k

[ath9k-devel] [PATCH] ath9k: Remove unnecessary casting to u8 in pci_read_config_byte() call

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/pci.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/pci.c b/drivers/net/wireless/ath/ath9k/pci.c index 8bb286d..8b28814 100644 --- a/drivers/net/wireless/ath

[ath9k-devel] [PATCH] ath9k: Disable ASPM when btcoex is active

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/hw.c | 14 ++ drivers/net/wireless/ath/ath9k/hw.h |5 + drivers/net/wireless/ath/ath9k/main.c |1 + 3 files changed, 20 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath

[ath9k-devel] [PATCH 2/2] ath9k: Call spin_lock_bh() on btcoex_lock

As generic hw timer interrupt handler is moved to tasklet, we no more need to call spin_lock_irqsave(). Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/btcoex.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath

[ath9k-devel] [PATCH 1/2] ath9k: Move generic hw timer intr handler to bottom-half

There is no point handling this in hard irq, move it to tasklet. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/main.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless

[ath9k-devel] [PATCH] ath9k: Do an AHB reset before doing RTC reset

Doing an RTC reset when DMA is active may corrupt memory, make sure no DMA is active at this moment by doing an AHB reset. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/hw.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/net

[ath9k-devel] [PATCH 8/8] ath9k: Add Bluetooth Coexistence 3-wire support

This patch adds 3-wire bluetooth coex support for AR9285. This support can be enabled through btcoex_enable modparam. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/ath9k.h |2 + drivers/net/wireless/ath/ath9k/btcoex.c | 290

[ath9k-devel] [PATCH 7/8] ath9k: Add infrastructure for generic hw timers

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/debug.h |1 + drivers/net/wireless/ath/ath9k/hw.c| 212 drivers/net/wireless/ath/ath9k/hw.h| 52 drivers/net/wireless/ath/ath9k/reg.h | 15 ++- 4 files changed

[ath9k-devel] [PATCH 6/8] ath9k: Remove hw capability bit meant for btcoex

We don't need a hw cap bit for btcoex anymore as btcoex scheme type is enough to do this. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/hw.c |1 - drivers/net/wireless/ath/ath9k/hw.h |1 - drivers/net/wireless/ath/ath9k/main.c |8 +++- 3

[ath9k-devel] [PATCH 5/8] ath9k: Determine btcoex scheme type based on chip version

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/btcoex.h |7 +++ drivers/net/wireless/ath/ath9k/hw.c | 12 ++-- drivers/net/wireless/ath/ath9k/main.c |4 +++- 3 files changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/net

[ath9k-devel] [PATCH 4/8] ath9k: Move btcoex related data to a separate struct

Also define macros for wlanactive and btactive (5 & 6) gpios. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/ath9k.h |1 + drivers/net/wireless/ath/ath9k/btcoex.c | 16 +++- drivers/net/wireless/ath/ath9k/btcoex.h |8 drivers

[ath9k-devel] [PATCH 3/8] ath9k: Configure btcoex register during every reset

Make sure btcoex register configured with appropriate values after it is initialized with the default values from initvals.h during reset. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/hw.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a

[ath9k-devel] [PATCH 2/8] ath9k: Move btcoex stuff from hw.[ch] to new btcoex.[ch]

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/Makefile |3 +- drivers/net/wireless/ath/ath9k/ath9k.h |1 + drivers/net/wireless/ath/ath9k/btcoex.c | 55 +++ drivers/net/wireless/ath/ath9k/btcoex.h | 24 + drivers

[ath9k-devel] [PATCH 1/8] ath9k: Split ath9k_hw_btcoex_enable() into two logical pieces

(). Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/ath9k.h |1 + drivers/net/wireless/ath/ath9k/hw.c| 17 - drivers/net/wireless/ath/ath9k/hw.h|2 ++ drivers/net/wireless/ath/ath9k/main.c | 11 +-- 4 files changed, 28

[ath9k-devel] [PATCH 0/8] ath9k: WLAN-BT coexistence clean up and 3-wire support

John, This series has WLAN-BT coex 3-wire support and clean ups in BT coex part. Vasanth Vasanthakumar Thiagarajan (8): ath9k: Split ath9k_hw_btcoex_enable() into two logical pieces ath9k: Move btcoex stuff from hw.[ch] to new btcoex.[ch] ath9k: Configure btcoex register during every

[ath9k-devel] [PATCH v2] ath9k: Fix bug in retrieving average beacon rssi

ady valid average rssi. Also removes the redundant macros to find average rssi. Signed-off-by: Vasanthakumar Thiagarajan --- Added more description in commit msg, no code change over v1 drivers/net/wireless/ath/ath9k/ani.h |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --

[ath9k-devel] [PATCH] ath9k: Nuke struct ath9k_node_stats

Other than ns_avgbrssi (Average beacon rssi) no data of ath9k_node_stats is being used anywhere. Nuke this structure and move its only useful member to ar5416Anistate. Also cleanup this redundant data in ath_softc. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k

[ath9k-devel] [PATCH] ath9k: Fix bug in retrieving average beacon rssi

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/ani.h |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/ani.h b/drivers/net/wireless/ath/ath9k/ani.h index 1199245..6273fd0 100644 --- a/drivers/net/wireless

Re: [ath9k-devel] [PATCH] ath9k: Prevent read buffer overflow

On Wed, Aug 12, 2009 at 06:05:55PM +0530, roel kluin wrote: > On Wed, Aug 12, 2009 at 1:58 PM, Vasanthakumar > Thiagarajan wrote: > > On Wed, Aug 12, 2009 at 12:10:30AM +0530, Roel Kluin wrote: > >> Prevent a read from valid_rate_index[] with a negative index > >>

Re: [ath9k-devel] [PATCH] ath9k: Prevent read buffer overflow

On Wed, Aug 12, 2009 at 12:10:30AM +0530, Roel Kluin wrote: > Prevent a read from valid_rate_index[] with a negative index > > Signed-off-by: Roel Kluin > --- > Maybe we should add this? > > diff --git a/drivers/net/wireless/ath/ath9k/rc.c > b/drivers/net/wireless/ath/ath9k/rc.c > index ba06e78

[ath9k-devel] [PATCH 3/3] ath9k: Remove unused ath9k_hw_intrget()

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/hw.c |5 - drivers/net/wireless/ath/ath9k/hw.h |1 - 2 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c index 431854c

[ath9k-devel] [PATCH 2/3] ath9k: Maintain monotonicity of PER while going across different phy

Monotonicity of packet error rate should be kept when moving from one phy to another (legacy to ht, ht single stream to dual, etc). Current code skips updating per for other phys. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/rc.c |3 --- 1 files changed, 0

[ath9k-devel] [PATCH 1/3] ath9k: Update rate control for 11NA HT40 mode

it also has basic rates (1, 2, 5.5 and 11). Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/rc.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/rc.c b/drivers/net/wireless/ath/ath9k/rc.c index a07efa2..59ad47c

Re: [ath9k-devel] [PATCH 1/2] ath9k: wake up the chip for PS config changes

On Thu, Jul 23, 2009 at 02:04:11PM +0530, Gabor Juhos wrote: > If we are in NETWORK_SLEEP state, calling of 'ath9k_hw_setrxabort' in > 'ath9k_config' will fail with the following error: > > ath9k: timeout (10 us) on reg 0x806c: 0xdeadbeef & 0x01f0 != > 0x > ath9k: RX failed to go

[ath9k-devel] [PATCH 3/3] ath9k: Remove pointless ath9k_ps_restore() in ath_detach()

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/main.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c index 961b0ce..16e5f6e 100644 --- a/drivers/net/wireless/ath

[ath9k-devel] [PATCH 2/3] ath9k: Handle tx desc shortage more appropriately

Update tx BA window and complete the frame as failed one if we can't clone the holding descriptor due to unavailability of descriptors. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/xmit.c | 17 - 1 files changed, 16 insertions(+), 1 dele

[ath9k-devel] [PATCH 1/3] ath9k: Remove bogus assert in ath_clone_txbuf()

oops, this one should be part of the original patch "ath9k: downgrade assert in ath_clone_txbuf()" Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/xmit.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k

[ath9k-devel] [PATCH] ath9k: Fix leak in tx descriptor

-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/xmit.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c index c140f81..5de9878 100644 --- a/drivers/net/wireless/ath

Re: [ath9k-devel] ath9k: ath9k_ps_restore used after ath9k_hw_detach

On Mon, Jun 22, 2009 at 09:53:43PM +0530, Jiri Slaby wrote: > Hi, > > In ath_detach, there is: > ath9k_hw_detach(sc->sc_ah); > ath9k_exit_debug(sc); > ath9k_ps_restore(sc); > which is obviously wrong. sc->ah is dereferenced in restore, but it's > already freed since detach. Yes, this is wrong. >

Re: [ath9k-devel] [PATCH 4/4] ath9k: Nuke struct ath_tx_ratectrl_state

On Thu, Jun 18, 2009 at 11:31:21AM +0530, Luis R. Rodriguez wrote: > On Wed, Jun 17, 2009 at 10:23 PM, Vasanthakumar > Thiagarajan wrote: > > Move its only member (u8 per) to struct ath_rate_priv. > > yay! BTW are these based on top of my rate series?

[ath9k-devel] [PATCH 4/4] ath9k: Nuke struct ath_tx_ratectrl_state

Move its only member (u8 per) to struct ath_rate_priv. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/rc.c | 50 +- drivers/net/wireless/ath/ath9k/rc.h |7 +--- 2 files changed, 27 insertions(+), 30 deletions(-) diff --git a

[ath9k-devel] [PATCH 3/4] ath9k: Use probe interval instead of rssi reduce interval

Get rid of rssi reduce interval. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/rc.c |6 +- drivers/net/wireless/ath/ath9k/rc.h |1 - 2 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/rc.c b/drivers/net

[ath9k-devel] [PATCH 2/4] ath9k: Remove unused members from rate control structure

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/rc.c | 216 +- drivers/net/wireless/ath/ath9k/rc.h | 21 2 files changed, 108 insertions(+), 129 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/rc.c b/drivers/net

[ath9k-devel] [PATCH 1/4] ath9k: Remove dead code in rate control

ath9k rate control is based on only PER (packet error rate), remove unused code which was intented to do rssi based rate selection. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/rc.c | 163 +-- 1 files changed, 4 insertions(+), 159

[ath9k-devel] [PATCH 3/3] ath9k: port to cfg80211 rfkill

From: Johannes Berg This ports the ath9k rfkill code to the new API offered by cfg80211 and thus removes a lot of useless stuff. Signed-off-by: Johannes Berg Cc: Luis Rodriguez Tested-by: Vasanthakumar Thiagarajan Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k

[ath9k-devel] [PATCH 2/3] ath9k: Make sure we have current channel in ah_curchan before rf disable/enable

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/main.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c index 5fd17a4..48b117d 100644 --- a/drivers/net/wireless

[ath9k-devel] [PATCH 1/3] ath9k: Add helper to get ath9k specific current channel

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/main.c | 21 - 1 files changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c index afac281..5fd17a4 100644 --- a

[ath9k-devel] [PATCH 0/3] Porting to cfg80211 rfkill

nload disappears. Johannes Berg (1): ath9k: port to cfg80211 rfkill Vasanthakumar Thiagarajan (2): ath9k: Add helper to get ath9k specific current channel ath9k: Make sure we have current channel in ah_curchan before rf disable/enable drivers/net/wireless/ath/ath9k/Kconfig |1 - driver

[ath9k-devel] [PATCH] ath9k: Make sure we configure a non-zero beacon interval

This patch moves the sanity check on beacon interval which was done only for mesh mode to all operating modes just to be safe. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/beacon.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff

[ath9k-devel] [PATCH 3/3] ath9k: downgrade ASSERT() in ath_clone_txbuf()

We can easily run out of tx buf if there is any stuck in transmission, so downgrade it to WARN_ON(). Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/xmit.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k

[ath9k-devel] [PATCH 2/3] ath9k: Remove unnecessary count for addba attempt

mac80211 already has one to keep track of number of failure addba attempts. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/ath9k.h |1 - drivers/net/wireless/ath/ath9k/xmit.c | 13 + 2 files changed, 1 insertions(+), 13 deletions(-) diff --git a

[ath9k-devel] [PATCH 1/3] ath9k: Nuke unneccesary helper function to see if aggr is active

IEEE80211_TX_CTL_AMPDU in tx control flags should be enough to confirm BA is negotiated for that tid. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/xmit.c | 14 +- 1 files changed, 1 insertions(+), 13 deletions(-) diff --git a/drivers/net/wireless

[ath9k-devel] [PATCH 0/3] Few clean ups

These are few clean ups which apply over Luis' rc cleanup series. Vasanthakumar Thiagarajan (3): ath9k: Nuke unneccesary helper function to see if aggr is active ath9k: Remove unnecessary count for addba attempt ath9k: downgrade ASSERT() in ath_clone_txbuf() drivers/net/wireles

[ath9k-devel] [PATCH] ath9k: Fix tx stuck when connected to aggr disabled HT AP

med out or addba is denied by the AP. With out clearing this bit, all frames are queued onto s/w queue for getting tx'd as aggr and will never be scheduled onto hw queue. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/xmit.c |1 + 1 files changed, 1 i

Re: [ath9k-devel] [PATCH 01/15] ath9k: fix oops by downgrading assert in rc.c

On Tue, Jun 09, 2009 at 10:54:00AM +0530, Vasanth Thiagarajan wrote: > On Tue, Jun 09, 2009 at 06:28:21AM +0530, Luis Rodriguez wrote: > > On Mon, Jun 08, 2009 at 05:26:41PM -0700, Luis R. Rodriguez wrote: > > > On Fri, Jun 5, 2009 at 11:55 PM, Vasanth > > > Thiagarajan wrote: > > > > > > > > _

Re: [ath9k-devel] [PATCH 01/15] ath9k: fix oops by downgrading assert in rc.c

On Tue, Jun 09, 2009 at 10:54:00AM +0530, Vasanth Thiagarajan wrote: > On Tue, Jun 09, 2009 at 06:28:21AM +0530, Luis Rodriguez wrote: > > On Mon, Jun 08, 2009 at 05:26:41PM -0700, Luis R. Rodriguez wrote: > > > On Fri, Jun 5, 2009 at 11:55 PM, Vasanth > > > Thiagarajan wrote: > > > > > > > > _

Re: [ath9k-devel] [PATCH 01/15] ath9k: fix oops by downgrading assert in rc.c

On Tue, Jun 09, 2009 at 06:28:21AM +0530, Luis Rodriguez wrote: > On Mon, Jun 08, 2009 at 05:26:41PM -0700, Luis R. Rodriguez wrote: > > On Fri, Jun 5, 2009 at 11:55 PM, Vasanth > > Thiagarajan wrote: > > > > > > > > > > > >> > >> + /* > > >> > >> +

Re: [ath9k-devel] [PATCH 01/15] ath9k: fix oops by downgrading assert in rc.c

On Tue, Jun 09, 2009 at 05:56:41AM +0530, Luis R. Rodriguez wrote: > On Fri, Jun 5, 2009 at 11:55 PM, Vasanth > Thiagarajan wrote: > > > > > > > >> > >> + /* > >> > >> +* Fine tuning for when no decent rate was found, the > >> > >> +* l

Re: [ath9k-devel] [PATCH 01/15] ath9k: fix oops by downgrading assert in rc.c

On Fri, Jun 05, 2009 at 01:17:16PM +0530, Luis Rodriguez wrote: > On Thu, Jun 4, 2009 at 11:30 PM, Vasanthakumar > Thiagarajan wrote: > > > >> + > >> + /* > >> +* Fine tuning for when no decent rate was found, the > >> +* lowest

Re: [ath9k-devel] [PATCH 01/15] ath9k: fix oops by downgrading assert in rc.c

> + > + /* > +* Fine tuning for when no decent rate was found, the > +* lowest should *not* be used under normal circumstances. > +*/ > + if (rix == ath_rc_priv->valid_rate_index[0]) { > + DPRINTF(sc, ATH_DBG_RATE, "lowest rate being used, " > +

Re: [ath9k-devel] [PATCH] ath9k: Remove modparam 'debug'

On Tue, Jun 02, 2009 at 07:28:56PM +0530, Vasanth Thiagarajan wrote: John, > Signed-off-by: Vasanthakumar Thiagarajan > --- > drivers/net/wireless/ath/ath9k/Kconfig |4 ++-- > drivers/net/wireless/ath/ath9k/debug.c |5 + > 2 files changed, 3 insertions(+), 6 deletio

Re: [ath9k-devel] [PATCH] ath9k: Remove modparam 'debug'

On Tue, Jun 02, 2009 at 10:13:38PM +0530, Luis Rodriguez wrote: > On Tue, Jun 02, 2009 at 06:58:56AM -0700, Vasanth Thiagarajan wrote: > > - modprobe ath9k debug=0x2000 > > + echo > //ath9k/phyX/debug > > This means no debugging available during module init which does seem > u

[ath9k-devel] [PATCH] ath9k: Remove modparam 'debug'

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/Kconfig |4 ++-- drivers/net/wireless/ath/ath9k/debug.c |5 + 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/Kconfig b/drivers/net/wireless/ath/ath9k/Kconfig

[ath9k-devel] [PATCH] ath9k: Fix write callback of 'debug' which configures debug mask

Handle error condition on copy_from_user() properly and make sure a NUL terminated char[] is sent to strict_strtoul() for proper conversion. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/debug.c | 22 ++ 1 files changed, 14 insertions(+), 8

Re: [ath9k-devel] Pending ath9k bugs

> BUG_ON in rc.c when using 11n. This could be caused by an incorrect > assumption in ath9k that the rc priv is correctly for the target rate. > The issue may be seen when trying to associate and changing between > legacy and HT rates on SMP systems when mac80211 passes frames on > different queu

Re: [ath9k-devel] [PATCH 2/4] ath9k: Combine legacy and 11n rc statistics

On Wed, May 27, 2009 at 10:35:13AM +0530, Jeff Hansen wrote: > + max = 80 + sc->cur_rate_table->rate_cnt * 64; > + buf = vmalloc(max + 1); I think kmalloc() is the better option here, you are not even allocating a page, you are allocating 2952B at max. Vasanth ___

Re: [ath9k-devel] [PATCH 2/4] ath9k: Combine legacy and 11n rc statistics

On Wed, May 27, 2009 at 10:35:13AM +0530, Jeff Hansen wrote: > + max = 80 + sc->cur_rate_table->rate_cnt * 64; > + buf = vmalloc(max + 1); I think kmalloc is a better option here, the memory you are allocating is not even a page (at max 2952B). Vasanth

[ath9k-devel] [PATCH] ath9k: cleanup beacon parameters configuration

This patch configures the beacon timers with beacon interval and beacon period passed through vif.bss_conf. Also cache the currecnt beacon configuration which will be used to configure the beacon timers when the driver triggers it after reset. Signed-off-by: Vasanthakumar Thiagarajan

[ath9k-devel] [PATCH] ath9k: Remove unused parameters which are passed to ath_beacon_config_X()

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/beacon.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/beacon.c b/drivers/net/wireless/ath/ath9k/beacon.c index 3a7154b..af5edb8 100644 --- a/drivers

[ath9k-devel] [PATCH] ath9k: Print hw reset failure status as signed int

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/main.c | 10 +- drivers/net/wireless/ath/ath9k/xmit.c |2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c

[ath9k-devel] [PATCH 2/2] ath9k: Cleanup ineffective return values

This patch makes the return type of some of the functions void as those functions always return true Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/eeprom.c | 51 ++- drivers/net/wireless/ath/ath9k/eeprom.h |2 +- drivers/net/wireless

[ath9k-devel] [PATCH 1/2] ath9k: Remove bogus break after return

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath9k/hw.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c index 5879c73..9e1db85 100644 --- a/drivers/net/wireless/ath/ath9k

[ath9k-devel] [PATCH 2/2] ath9k: Nuke struct ath_xmit_status

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath9k/ath9k.h |4 drivers/net/wireless/ath9k/xmit.c | 25 - 2 files changed, 8 insertions(+), 21 deletions(-) diff --git a/drivers/net/wireless/ath9k/ath9k.h b/drivers/net/wireless/ath9k

[ath9k-devel] [PATCH 1/2] ath9k: Fix bug in reporting status of tx rate

This patch updates count of every hw tried rate with appropriate tries before reporting tx status of a frame. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath9k/xmit.c | 35 ++- 1 files changed, 22 insertions(+), 13 deletions(-) diff --git

[ath9k-devel] [PATCH] ath9k: Fix rate control update for aggregated frames

first A-MPDU of an aggregation) to mac80211. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath9k/xmit.c | 26 ++ 1 files changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/ath9k/xmit.c b/drivers/net/wireless/ath9k/xmit.c

[ath9k-devel] [PATCH] ath9k: Keep LED on in idle state after association

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath9k/main.c | 19 +-- 1 files changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath9k/main.c b/drivers/net/wireless/ath9k/main.c index 8db75f6..b14c4d9 100644 --- a/drivers/net

[ath9k-devel] [PATCH V2] ath9k: Set IEEE80211_TX_CTL_RATE_CTRL_PROBE in rate control for probe rate

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath9k/rc.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath9k/rc.c b/drivers/net/wireless/ath9k/rc.c index 8327356..a4f2d0a 100644 --- a/drivers/net/wireless/ath9k/rc.c +++ b

Re: [ath9k-devel] [PATCH] ath9k: Set IEEE80211_TX_CTL_RATE_CTRL_PROBE in rate control for probe rates

On Fri, Mar 06, 2009 at 08:58:39PM +0530, Sujith wrote: > Vasanthakumar Thiagarajan wrote: > > --- > > drivers/net/wireless/ath9k/rc.c | 13 - > > 1 files changed, 8 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/net/wireless/ath9k/rc.c

[ath9k-devel] [PATCH] ath9k: Set IEEE80211_TX_CTL_RATE_CTRL_PROBE in rate control for probe rates

Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath9k/rc.c | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath9k/rc.c b/drivers/net/wireless/ath9k/rc.c index 8327356..a35b525 100644 --- a/drivers/net/wireless/ath9k/rc.c

  1   2   >