Re: [ath9k-devel] [PATCH] ath9k: fix NULL-deref in hw_per_calibration() for ar9002

2014-05-13 Thread Rajkumar Manoharan
On Tue, May 13, 2014 at 08:50:00AM +0200, David Herrmann wrote: Hi On Mon, May 12, 2014 at 8:43 PM, Felix Fietkau n...@openwrt.org wrote: I looked into it again, the scenario where I assumed that this problem could occur didn't turn out to be true. I have no idea how this crash can

Re: [ath9k-devel] [PATCH] ath9k: fix NULL-deref in hw_per_calibration() for ar9002

2014-05-13 Thread David Herrmann
Hi On Tue, May 13, 2014 at 11:00 AM, Rajkumar Manoharan rmano...@qti.qualcomm.com wrote: On Tue, May 13, 2014 at 08:50:00AM +0200, David Herrmann wrote: Hi On Mon, May 12, 2014 at 8:43 PM, Felix Fietkau n...@openwrt.org wrote: I looked into it again, the scenario where I assumed that this

Re: [ath9k-devel] [PATCH] ath9k: fix NULL-deref in hw_per_calibration() for ar9002

2014-05-13 Thread David Herrmann
Hi On Tue, May 13, 2014 at 12:41 PM, Rajkumar Manoharan rmano...@qti.qualcomm.com wrote: On Tue, May 13, 2014 at 11:09:48AM +0200, David Herrmann wrote: Unlike ath9k driver, the ani work is stopped in sw_scan_start callback for htc driver. So during scan process, ani work is stopped well

[ath9k-devel] [PATCH] ath9k: fix NULL-deref in hw_per_calibration() for ar9002

2014-05-07 Thread David Herrmann
ah-caldata may be NULL if no channel is selected. Check for that before accessing it. Signed-off-by: David Herrmann dh.herrm...@gmail.com --- Hi This is _definitely_ only a workaround, given that no-one guarantees ah-caldata is freed while we run in hw_per_calibration(). However, this patch

Re: [ath9k-devel] [PATCH] ath9k: fix NULL-deref in hw_per_calibration() for ar9002

2014-05-07 Thread John W. Linville
On Wed, May 07, 2014 at 09:22:58AM +0200, David Herrmann wrote: ah-caldata may be NULL if no channel is selected. Check for that before accessing it. Signed-off-by: David Herrmann dh.herrm...@gmail.com --- Hi This is _definitely_ only a workaround, given that no-one guarantees

Re: [ath9k-devel] [PATCH] ath9k: fix NULL-deref in hw_per_calibration() for ar9002

2014-05-07 Thread Luis R. Rodriguez
On Wed, May 7, 2014 at 12:54 PM, John W. Linville linvi...@tuxdriver.com wrote: Is there any hope for getting a more complete fix from the ath9k guys in short order? Wait, who are the ath9k folks now exactly ? Luis ___ ath9k-devel mailing list

Re: [ath9k-devel] [PATCH] ath9k: fix NULL-deref in hw_per_calibration() for ar9002

2014-05-07 Thread Felix Fietkau
On 2014-05-07 21:54, John W. Linville wrote: On Wed, May 07, 2014 at 09:22:58AM +0200, David Herrmann wrote: ah-caldata may be NULL if no channel is selected. Check for that before accessing it. Signed-off-by: David Herrmann dh.herrm...@gmail.com --- Hi This is _definitely_ only a

Re: [ath9k-devel] [PATCH] ath9k: fix NULL-deref in hw_per_calibration() for ar9002

2014-05-07 Thread John W. Linville
On Wed, May 07, 2014 at 01:03:00PM -0700, Luis R. Rodriguez wrote: On Wed, May 7, 2014 at 12:54 PM, John W. Linville linvi...@tuxdriver.com wrote: Is there any hope for getting a more complete fix from the ath9k guys in short order? Wait, who are the ath9k folks now exactly ? A better