Re: [ath9k-devel] UNDERRUN / PHY ERR in /sys/kernel/debug/ath9k/phy0/recv

2011-01-20 Thread Mohammed Shafi
On Thu, Jan 20, 2011 at 3:23 PM, Bernhard Walle wa...@corscience.de wrote: Hi again, Am 11.01.2011 17:24, schrieb Bernhard Walle: can somebody explain what [...]            PHY ERR :      96196 [...]           UNDERRUN :      96196 [...] in /sys/kernel/debug/ath9k/phy0/recv actually

Re: [ath9k-devel] UNDERRUN / PHY ERR in /sys/kernel/debug/ath9k/phy0/recv

2011-01-20 Thread Bernhard Walle
Hello, Am 20.01.2011 11:07, schrieb Mohammed Shafi: On Thu, Jan 20, 2011 at 3:23 PM, Bernhard Walle wa...@corscience.de wrote: Am 11.01.2011 17:24, schrieb Bernhard Walle: can somebody explain what [...] PHY ERR : 96196 [...] UNDERRUN : 96196 [...] in

Re: [ath9k-devel] UNDERRUN / PHY ERR in /sys/kernel/debug/ath9k/phy0/recv

2011-01-20 Thread Mohammed Shafi
On Thu, Jan 20, 2011 at 3:43 PM, Bernhard Walle wa...@corscience.de wrote: Hello, Am 20.01.2011 11:07, schrieb Mohammed Shafi: On Thu, Jan 20, 2011 at 3:23 PM, Bernhard Walle wa...@corscience.de wrote: Am 11.01.2011 17:24, schrieb Bernhard Walle: can somebody explain what [...]          

Re: [ath9k-devel] ath9k_htc in master mode / 0cf3:9271 Atheros Communications AR9271 802.11n / USB TP-Link TL-WN722N / detachable antenna - RSMA

2011-01-20 Thread Mohammed Shafi
On Wed, Jan 19, 2011 at 6:30 AM, Jorge Luis at...@luisnet.com wrote: Senthilkumar Balasubramanian senthil.balasubramanian at gmail.com writes: On Mon, Dec 27, 2010 at 9:58 AM, Mohammed Shafi shafi.ath9k at gmail.com wrote: 2010/12/27 . .m. mulisak at hotmail.com: My first post, please

Re: [ath9k-devel] [PATCH] ath9k: Try more than one queue when scheduling new aggregate.

2011-01-20 Thread Felix Fietkau
On 2011-01-19 2:30 AM, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com Try all xmit queues until the hardware buffers are full. Acked-by: Felix Fietkau n...@openwrt.org ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org

Re: [ath9k-devel] Why 2 beacon_interval variables?

2011-01-20 Thread Björn Smedman
On Wed, Jan 19, 2011 at 12:58 PM, Steve Brown sbr...@cortland.com wrote: Thanks for the reference. The beacon_interval in that commit looks redundant to me too. It turned up while I was testing some code for beacons at different intervals. It's simpler if there is just beacon_interval. How

Re: [ath9k-devel] Why 2 beacon_interval variables?

2011-01-20 Thread Steve Brown
On Thu, 2011-01-20 at 18:16 +0100, Björn Smedman wrote: On Wed, Jan 19, 2011 at 12:58 PM, Steve Brown sbr...@cortland.com wrote: Thanks for the reference. The beacon_interval in that commit looks redundant to me too. It turned up while I was testing some code for beacons at different

[ath9k-devel] Should we remove all the virtual wiphy code from ath9k?

2011-01-20 Thread Ben Greear
Seems I saw a note a long time ago about virtual wiphy being removed sometime soon. Should we go ahead and remove it? It doesn't seem useful to me (virtual interfaces appear to work much better), and it would likely simplify the code a bit to have it gone. Thanks, Ben -- Ben Greear

Re: [ath9k-devel] Should we remove all the virtual wiphy code from ath9k?

2011-01-20 Thread Jouni Malinen
On Thu, 2011-01-20 at 10:27 -0800, Ben Greear wrote: Seems I saw a note a long time ago about virtual wiphy being removed sometime soon. Should we go ahead and remove it? It doesn't seem useful to me (virtual interfaces appear to work much better), and it would likely simplify the code a

Re: [ath9k-devel] Should we remove all the virtual wiphy code from ath9k?

2011-01-20 Thread Luis R. Rodriguez
On Thu, Jan 20, 2011 at 10:27:01AM -0800, Ben Greear wrote: Seems I saw a note a long time ago about virtual wiphy being removed sometime soon. Should we go ahead and remove it? It doesn't seem useful to me (virtual interfaces appear to work much better), and it would likely simplify the

Re: [ath9k-devel] ath9k_htc in master mode / 0cf3:9271 Atheros Communications AR9271 802.11n / USB TP-Link TL-WN722N / detachable antenna - RSMA

2011-01-20 Thread C Anthony Risinger
On Thu, Jan 20, 2011 at 5:12 AM, Mohammed Shafi shafi.wirel...@gmail.com wrote: On Wed, Jan 19, 2011 at 6:30 AM, Jorge Luis at...@luisnet.com wrote: Senthilkumar Balasubramanian senthil.balasubramanian at gmail.com writes: On Mon, Dec 27, 2010 at 9:58 AM, Mohammed Shafi shafi.ath9k at gmail.com

Re: [ath9k-devel] ath9k_htc in master mode / 0cf3:9271 Atheros Communications AR9271 802.11n / USB TP-Link TL-WN722N / detachable antenna - RSMA

2011-01-20 Thread Jorge Luis
On 20 Jan 2011 20:14, C Anthony Risinger anth...@extof.me wrote: On Thu, Jan 20, 2011 at 5:12 AM, Mohammed Shafi shafi.wirel...@gmail.com wrote: On Wed, Jan 19, 2011 at 6:30 AM, Jorge Luis at...@luisnet.com wrote: Senthilkumar Balasubramanian senthil.balasubramanian at gmail.com writes:

Re: [ath9k-devel] UNDERRUN / PHY ERR in /sys/kernel/debug/ath9k/phy0/recv

2011-01-20 Thread Luis R. Rodriguez
On Tue, Jan 11, 2011 at 8:24 AM, Bernhard Walle wa...@corscience.de wrote: Hello ath9k experts, can somebody explain what [...]            PHY ERR :      96196 [...]           UNDERRUN :      96196 [...] in /sys/kernel/debug/ath9k/phy0/recv actually means. Is that normal, or a hardware

[ath9k-devel] [RFC/WIP 00/33] ath9k_htc AP mode

2011-01-20 Thread Sujith
This series is the preliminary work for enabling AP mode for ath9k_htc. A firmware update is needed, place look at: http://wireless.kernel.org/en/users/Drivers/ath9k_htc#AP_Mode Known issues: * Beacon misses under heavy TX load ( hopefully, a fix would be sent out soon). This has not been

[ath9k-devel] [RFC/WIP 01/33] ath9k_htc: Allow upto two simultaneous interfaces

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com Multiple interfaces can be configured if a slot is free on the target. Monitor mode also requires a slot. The maximum number of stations that can be handled in the firmware is 8, manage the station slots accordingly. Signed-off-by: Sujith

[ath9k-devel] [RFC/WIP 02/33] ath9k_htc: Unify target capability updation

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com Update capabilites on the target once, when start() is called, there is no need for redundant updation on adding an interface. Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com --- drivers/net/wireless/ath/ath9k/htc_drv_main.c |

[ath9k-devel] [RFC/WIP 03/33] ath9k_htc: Fix error handling in add_interface

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com Addition of a station might fail - handle this error properly by removing the VAP on the target. Also, bail out immediately if the max. no of interfaces has been reached. Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com ---

[ath9k-devel] [RFC/WIP 04/33] ath9k_htc: Remove OP_PREAMBLE_SHORT

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com mac80211's BSS info can be used for this. Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com --- drivers/net/wireless/ath/ath9k/htc.h | 13 ++--- drivers/net/wireless/ath/ath9k/htc_drv_main.c |9 - 2

[ath9k-devel] [RFC/WIP 06/33] ath9k_htc: Remove OP_ASSOCIATED variable

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com mac80211 stores the association state in ieee80211_bss_conf. Use this and remove the local state, which is incorrect anyway since it is stored globally and not on a per-VIF basis. Restarting ANI and reconfiguration of HW beacon timers when a

[ath9k-devel] [RFC/WIP 07/33] ath9k_htc: Set the BSSID mask for multiple interfaces

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com --- drivers/net/wireless/ath/ath9k/htc.h |5 +++ drivers/net/wireless/ath/ath9k/htc_drv_main.c | 35 + 2 files changed, 40 insertions(+), 0

[ath9k-devel] [RFC/WIP 08/33] ath9k_htc: Make sequence number calculation per-VIF

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com --- drivers/net/wireless/ath/ath9k/htc.h|2 +- drivers/net/wireless/ath/ath9k/htc_drv_beacon.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff

[ath9k-devel] [RFC/WIP 10/33] ath9k_htc: Protect ampdu_action with a mutex

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com This is required when issuing commands to the firmware. Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com --- drivers/net/wireless/ath/ath9k/htc_drv_main.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git

[ath9k-devel] [RFC/WIP 11/33] ath9k_htc: Fix WMI and beacon header

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com Match the beacon header with that of the firmware. Also, the firmware reports the TSF for an SWBA, so store it. Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com --- drivers/net/wireless/ath/ath9k/htc.h |2 +-

[ath9k-devel] [RFC/WIP 12/33] ath9k_htc: Maintain individual counters for interfaces

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com This is required for allowing only one IBSS interface to be configured. Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com --- drivers/net/wireless/ath/ath9k/htc.h | 28 +

[ath9k-devel] [RFC/WIP 13/33] ath9k_htc: Allow AP interface to be created

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com --- drivers/net/wireless/ath/ath9k/htc.h |8 drivers/net/wireless/ath/ath9k/htc_drv_main.c | 11 +++ 2 files changed, 19 insertions(+), 0 deletions(-)

[ath9k-devel] [RFC/WIP 14/33] ath9k_htc: Calculate and set the HW opmode

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com --- drivers/net/wireless/ath/ath9k/htc_drv_main.c | 15 ++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c

[ath9k-devel] [RFC/WIP 15/33] ath9k_htc: Add ANI for AP mode

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com The time granularity for the ANI task is different for AP and station mode. Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com --- drivers/net/wireless/ath/ath9k/htc.h |1 + drivers/net/wireless/ath/ath9k/htc_drv_main.c

[ath9k-devel] [RFC/WIP 16/33] ath9k_htc: Disable powersave if an AP interface is present

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com --- drivers/net/wireless/ath/ath9k/htc_drv_main.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c

[ath9k-devel] [RFC/WIP 17/33] ath9k_htc: Configure beacon timers in AP mode

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com Handle multi-interface situations by checking if AP interfaces are already present. Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com --- drivers/net/wireless/ath/ath9k/htc.h|3 +-

[ath9k-devel] [RFC/WIP 19/33] ath9k_htc: Fix TBTT calculation for IBSS mode

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com The target beacon transmission time has to be synced with the HW TSF when configuring beacon timers in Adhoc mode. Failing to do this would cause erroneous beacon transmission, for example, on completion of a scan run to check for IBSS merges.

[ath9k-devel] [RFC/WIP 20/33] ath9k_htc: Add TSF adjust capability

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com In multi-interface mode, beacons/probe responses that are sent out must have their timestamp field updated. Calculate the TSF adjustment value for each beaconing interface and set it in the frame properly. Signed-off-by: Sujith Manoharan

[ath9k-devel] [RFC/WIP 21/33] ath9k_htc: Configure the beacon queue

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com Set operating parameters (cwmin, cwmax) for the beacon queue in AP mode. Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com --- drivers/net/wireless/ath/ath9k/htc_drv_beacon.c | 77 ++- 1 files changed, 46

[ath9k-devel] [RFC/WIP 22/33] ath9k_htc: Handle buffered frames in AP mode

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com Use the CAB endpoint to send buffered multicast or broadcast frames after each SWBA event. Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com --- drivers/net/wireless/ath/ath9k/htc.h|6 +++-

[ath9k-devel] [RFC/WIP 25/33] ath9k_htc: Queue WMI events

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com Use a queue to handle WMI events and schedule a tasklet to process the events. This fixes the race between the WMI event ISR and the SWBA tasklet when the arrival of WMI events in quick succession could overwrite the SWBA data before the tasklet

[ath9k-devel] [RFC/WIP 26/33] ath9k_htc: Handle BSSID/AID for multiple interfaces

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com The AID and BSSID should be set in the HW only for the first station interface or adhoc interface. Also, cancel the ANI timer in stop() for multi-STA scenario. And finally configure the HW beacon timers only for the first station interface.

[ath9k-devel] [RFC/WIP 29/33] ath9k_htc: Fix RX length check

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com The length of the received SKB could be equal to HTC_RX_FRAME_HEADER_SIZE in case of packets with phy/crc errors, in which case they are dropped without being processed. Fix this check so that the error counters are updated correctly.

[ath9k-devel] [RFC/WIP 30/33] ath9k_htc: Fix host RX initialization

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com There is no need to set the BSSID mask or opmode when initializing RX, they would be set correctly in the HW reset routine. Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com --- drivers/net/wireless/ath/ath9k/htc_drv_txrx.c |8

[ath9k-devel] [RFC/WIP 31/33] ath9k_htc: Remove unused WMI commands

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com WMI_TGT_TXQ_ENABLE_CMDID WMI_HOST_ATTACH WMI_DEBUG_INFO_CMDID WMI_BEACON_UPDATE_CMDID WMI_RESET_CMDID WMI_RX_LINK_CMDID WMI_ABORT_TXQ_CMDID WMI_STOP_DMA_RECV_CMDID Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com ---

[ath9k-devel] [RFC/WIP 32/33] ath9k_htc: Use SKB's private area for TX parameters

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com For all packets sent through the USB_WLAN_TX_PIPE endpoint, the private area of the SKB's tx_info can be used to store driver-specific information. For packets sent through USB_REG_OUT_PIPE, this will not make a difference since they are routed

[ath9k-devel] [RFC/WIP 05/33] ath9k_htc: Remove OP_PROTECT_ENABLE

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com CTS protection can be obtained from mac80211 directly. Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com --- drivers/net/wireless/ath/ath9k/htc.h | 11 +-- drivers/net/wireless/ath/ath9k/htc_drv_main.c | 10

[ath9k-devel] [RFC/WIP 24/33] ath9k_htc: Fix beacon miss under heavy load

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com Transmission of beacons becomes erratic when TX load is high, since the latency involved in the generation of a SWBA interrupt on the target to the actual sending of a beacon is quite high for USB devices. Fix this by adjusting the beacon

[ath9k-devel] [RFC/WIP 27/33] ath9k_htc: Move debug code to a separate file

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com --- drivers/net/wireless/ath/ath9k/Makefile|2 + drivers/net/wireless/ath/ath9k/htc_drv_debug.c | 219

[ath9k-devel] [RFC/WIP 28/33] ath9k_htc: Add RX error statistics

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com --- drivers/net/wireless/ath/ath9k/htc.h | 16 drivers/net/wireless/ath/ath9k/htc_drv_debug.c | 107 ++--

[ath9k-devel] [RFC/WIP 23/33] ath9k_htc: Enable AP mode

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com Signed-off-by: Sujith Manoharan sujith.manoha...@atheros.com --- drivers/net/wireless/ath/ath9k/htc_drv_init.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_init.c

[ath9k-devel] [RFC/WIP 00/33] ath9k_htc AP mode

2011-01-20 Thread Sujith
Sujith wrote: This series is the preliminary work for enabling AP mode for ath9k_htc. A unified patchset can be obtained here: http://wireless.kernel.org/en/users/Drivers/ath9k_htc#AP_Mode Sujith ___ ath9k-devel mailing list

[ath9k-devel] [RFC/WIP 33/33] ath9k_htc: Drain packets on station removal

2011-01-20 Thread Sujith
From: Sujith Manoharan sujith.manoha...@atheros.com When a station entry is removed, there could still be pending packets destined for that station in the HIF layer. Sending these to the target is not necessary, so drain them in the driver itself. Signed-off-by: Sujith Manoharan

[ath9k-devel] [RFC/RFT] ath9k_htc: fix race conditions when stop device

2011-01-20 Thread Stanislaw Gruszka
Similar fix I already posted for ath9k. When stopping device, disable interrupts, kill tasklets and then works, in correct order. Patch drop mutex in them middle of a function, which I don't like and can possibly not be correct. Perhaps this can be arranged differently. Also there is no

Re: [ath9k-devel] [RFC/WIP 30/33] ath9k_htc: Fix host RX initialization

2011-01-20 Thread Vasanthakumar Thiagarajan
On Fri, Jan 21, 2011 at 08:33:41AM +0530, Sujith wrote: From: Sujith Manoharan sujith.manoha...@atheros.com There is no need to set the BSSID mask or opmode when initializing RX, they would be set correctly in the HW reset routine. Signed-off-by: Sujith Manoharan

Re: [ath9k-devel] [RFC/WIP 15/33] ath9k_htc: Add ANI for AP mode

2011-01-20 Thread Vasanthakumar Thiagarajan
On Fri, Jan 21, 2011 at 08:31:24AM +0530, Sujith wrote: From: Sujith Manoharan sujith.manoha...@atheros.com + if (priv-ah-opmode == NL80211_IFTYPE_AP) + cancel_delayed_work_sync(priv-ath9k_ani_work); + What about ANI for other vifs? Vasanth

Re: [ath9k-devel] [RFC/WIP 30/33] ath9k_htc: Fix host RX initialization

2011-01-20 Thread Sujith
Vasanthakumar Thiagarajan wrote: I think we need to take care a bug in reg AR_STA_ID1 configuration. During hw reset, operating mode is set in AR_STA_ID1 but right after it's overwritten. See the following code segment in ath9k_hw_reset(). ath9k_hw_set_operating_mode(ah, ah-opmode);

[ath9k-devel] [RFC] ath9k: fix race conditions when stop device

2011-01-20 Thread Stanislaw Gruszka
We do not kill any scheduled tasklets when stopping device, that may cause usage of resources after free. Moreover we enable interrupts in tasklet function, so we could potentially end with interrupts enabled when driver is not ready to receive them. I think patch could fix Ben's kernel crash

Re: [ath9k-devel] ath9k_htc in master mode / 0cf3:9271 Atheros Communications AR9271 802.11n / USB TP-Link TL-WN722N / detachable antenna - RSMA

2011-01-20 Thread Mohammed Shafi
On Fri, Jan 21, 2011 at 3:09 AM, Jorge Luis jo...@luisnet.com wrote: On 20 Jan 2011 20:14, C Anthony Risinger anth...@extof.me wrote: On Thu, Jan 20, 2011 at 5:12 AM, Mohammed Shafi shafi.wirel...@gmail.com wrote: On Wed, Jan 19, 2011 at 6:30 AM, Jorge Luis at...@luisnet.com wrote: