Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-11-11 Thread Vincent Belaïche
Ooops... I had completely forgotten about that. At least that demonstrate how constant I am in my way of thinking. So, the only thing to do is to replace the assoc-string by this TeX-assoc-string, right ?    Vincent. > From: m...@gnu.org > Date: Mon, 9

Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-11-11 Thread Mosè Giordano
Hi Vincent, 2015-11-11 15:32 GMT+01:00 Vincent Belaïche : > Ooops... I had completely forgotten about that. At least that demonstrate how > constant I am in my way of thinking. > So, the only thing to do is to replace the assoc-string by this > TeX-assoc-string, right ?

Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-11-09 Thread Mosè Giordano
Hi Vincent, 2015-11-09 17:55 GMT+01:00 Vincent Belaïche : > Dear Mosé, > > No there was no strong reason for assoc-string rather than assoc, the > point was just that when you know that the key is a string assoc-string > is supposed to be faster. > > My opinion --- with no

Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-11-09 Thread Vincent Belaïche
Dear Mosé, No there was no strong reason for assoc-string rather than assoc, the point was just that when you know that the key is a string assoc-string is supposed to be faster. My opinion --- with no regard to this specific patch --- is that it would better in the case of XEmacs to define

Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-11-07 Thread Mosè Giordano
Hi Vincent, 2015-10-25 21:15 GMT+01:00 Vincent Belaïche : > Dear AUCTeX experts, > > I would like to submit to you the attached patch. > > [...] XEmacs doesn't have `assoc-string', is it possible to use `assoc' or there was a strong reason for using `assoc-string'

Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-10-28 Thread Tassilo Horn
Vincent Belaïche writes: >> If there's something else I have to do, please tell me. > > Indeed, this revision which I had proposed seems to be useless as far > as execution speed is concerned --- at least that was not why Stefan > did the change, and nobody had

Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-10-28 Thread Mosè Giordano
Il 28/ott/2015 10:33, "Tassilo Horn" ha scritto: > > Vincent Belaïche writes: > > > I have not tested the change, but reading this: > > > > (message "There are duplicate nodes:") > > (dolist (dup (nreverse dups)) > > (message "%s on line

Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-10-28 Thread Tassilo Horn
Mosè Giordano writes: >> Ok, now I've fixed it and use `display-warning' with CLASS set to >> 'AUCTeX so that users also see who issued the warning. That's much >> better. But I'm not entirely sure if very old emacsen have that: I >> checked GNU Emacs 22+ and XEmacs 21.5 but it

Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-10-28 Thread Vincent Belaïche
> From: t...@gnu.org > To: vincent@hotmail.fr > CC: auctex@gnu.org > Subject: Re: [AUCTeX] Patch to tex-info.el to support node name completion in > @..ref commands, and solve a few other pbs > Date: Wed, 28 Oct 2015 08:43:08 +0100 > > Vincent

Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-10-28 Thread Tassilo Horn
Vincent Belaïche writes: > I have not tested the change, but reading this: > >   (message "There are duplicate nodes:") >   (dolist (dup (nreverse dups)) >     (message "    %s on line %d" (car dup) (cdr dup > > I gather that the "There are duplicate nodes:"

Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-10-27 Thread Tassilo Horn
Stefan Monnier writes: Hi guys, I'm somehow lost. It seems that some mail, presumably Stefan -> Vincent, started this discussion but that hasn't been delivered to me. So well, yes, `pushnew' does the right thing, and in Vincent's patch to tex-info.el, I replaced his

Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-10-27 Thread Tassilo Horn
Joost Kremers writes: > On Di, Okt 27 2015, Tassilo Horn wrote: >> A bit too long given that the first sentence of a docstring should fit >> into one line and still mention all parameters. > > Just a nit pick, but AFAIK the convention is that the first

Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-10-27 Thread Joost Kremers
On Di, Okt 27 2015, Tassilo Horn wrote: > A bit too long given that the first sentence of a docstring should fit > into one line and still mention all parameters. Just a nit pick, but AFAIK the convention is that the first line should summarise what the function does, but there is

Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-10-27 Thread David Kastrup
Joost Kremers writes: > On Di, Okt 27 2015, Tassilo Horn wrote: >> A bit too long given that the first sentence of a docstring should fit >> into one line and still mention all parameters. > > Just a nit pick, but AFAIK the convention is that the first

Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-10-27 Thread Vincent Belaïche
> Hi guys, > Hello Tassilo, > I'm somehow lost.  It seems that some mail, presumably Stefan -> > Vincent, started this discussion but that hasn't been delivered to me. > So well, yes, `pushnew' does the right thing, and in Vincent's patch > to tex-info.el, I replaced his `add-to-list' call with

Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-10-26 Thread Tassilo Horn
Vincent Belaïche writes: Hi Vincent, > I would like to submit to you the attached patch. Very cool, thanks a lot. > + [snip] > + > 2014-09-13 Vincent Belaïche As you see, the patch was against a pretty old version and didn't apply anymore

Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-10-26 Thread Vincent Belaïche
Ok, I should have read the *Help* more carefully, it states (cl-pushnew X PLACE): insert X at the head of the list if not already there. and I understood "there" as meaning "head of the list", instead of just "list". Of course the next sentence in the docstring clarifies the point, but I

Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-10-26 Thread Vincent Belaïche
Ok, I should have read the *Help* more carefully, it states    (cl-pushnew X PLACE): insert X at the head of the list if not already there. and I understood "there" as meaning "head of the list", instead of just "list". Of course the second sentence clarifies the point, but I overlooked it.

Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-10-26 Thread Stefan Monnier
> interest. Some time ago Stefan Monnier changed add-to-list by pushnew, I > don't know what the motivation was, probably somebody had complained > that add-to-list was taking too much time. add-to-list doesn't work on lexical variables. > However these are not functionally equivalent, pushnew

Re: [AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-10-26 Thread Vincent Belaïche
Hello Tassilo, To Stefan also concerning add-to-list -> pushnew change... Feedback inserted below... > From: t...@gnu.org > To: vincent@hotmail.fr > Subject: Re: [AUCTeX] Patch to tex-info.el to support node name completion in > @..ref commands, and

[AUCTeX] Patch to tex-info.el to support node name completion in @..ref commands, and solve a few other pbs

2015-10-25 Thread Vincent Belaïche
Dear AUCTeX experts, I would like to submit to you the attached patch. VBR, Vincent Belaïche --- L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast. https://www.avast.com/antivirus diff --git a/ChangeLog b/ChangeLog index ca4d1e6..407d1dd