Re: [PATCH] notify.py: Use a/an correctly when sending request notifications

2019-08-09 Thread Morten Linderud
On Fri, Aug 09, 2019 at 02:59:13PM -0400, Eli Schwartz wrote: > On 8/9/19 2:08 PM, Lars Rustand wrote: > > Argh, gmail replies to the wrong address. > > > > On Fri, Aug 9, 2019, 20:06 Lars Rustand wrote: > > > >> Thank you for the feedback, I totally agree with your remarks. I might be > >> a

Re: [PATCH] notify.py: Use a/an correctly when sending request notifications

2019-08-09 Thread Eli Schwartz
On 8/9/19 2:08 PM, Lars Rustand wrote: > Argh, gmail replies to the wrong address. > > On Fri, Aug 9, 2019, 20:06 Lars Rustand wrote: > >> Thank you for the feedback, I totally agree with your remarks. I might be >> a little too fond of codegolfing, that's where I got the idea to use True >> as

Re: [PATCH] notify.py: Use a/an correctly when sending request notifications

2019-08-09 Thread Eli Schwartz
On 8/9/19 12:37 PM, Lars Rustand wrote: > Will no longer send notifications about "a orphan request", but determine > whether to use a/an based on the first character of the request type. Thanks, looks like a reasonable change. See below for implementation nitpicks. > Signed-off-by: Lars Rustand

[PATCH] notify.py: Use a/an correctly when sending request notifications

2019-08-09 Thread Lars Rustand
Will no longer send notifications about "a orphan request", but determine whether to use a/an based on the first character of the request type. Signed-off-by: Lars Rustand --- aurweb/scripts/notify.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git