Re: [aur-dev] [PATCH] PKGBUILD syntax highlight

2010-10-05 Thread Lukas Fleischer
On Mon, Oct 04, 2010 at 10:51:54PM +0200, PyroPeter wrote: > >It changes / to %2F so /etc/passwd would result in a broken path. > > > > Assuming that basename does what basename(1) does, it will never > output a slash. /etc/passwd would yield "passwd". Yes, there's no need to additionally use url

Re: [aur-dev] [PATCH] PKGBUILD syntax highlight

2010-10-04 Thread PyroPeter
On 10/04/2010 04:54 PM, Florian Pritz wrote: On 03.10.2010 20:08, Lukas Fleischer wrote: I don't get the point of using urlencode() here tho. It changes / to %2F so /etc/passwd would result in a broken path. Assuming that basename does what basename(1) does, it will never output a slash. /e

Re: [aur-dev] [PATCH] PKGBUILD syntax highlight

2010-10-04 Thread Florian Pritz
On 03.10.2010 20:08, Lukas Fleischer wrote: > I don't get the point of using urlencode() > here tho. It changes / to %2F so /etc/passwd would result in a broken path. -- Florian Pritz -- {flo,bluewi...@server-speed.net signature.asc Description: OpenPGP digital signature

Re: [aur-dev] [PATCH] PKGBUILD syntax highlight

2010-10-03 Thread Lukas Fleischer
On Sun, Oct 03, 2010 at 11:37:46AM +0200, Manuel Tortosa wrote: > +$file = URL_DIR . "/". > urlencode(basename($_GET['p']))."/".urlencode(basename($_GET['p']))."/PKGBUILD"; > > + > +if (is_file($file)) { > + $text = file_get_contents($file); > +} else { > + $text = ""; > +} This looks m

[aur-dev] [PATCH] PKGBUILD syntax highlight

2010-10-03 Thread Manuel Tortosa
This is another approach. Greez. From 9d4517705b4a1647e2039ddda9d4bda7632b0e96 Mon Sep 17 00:00:00 2001 From: Manuel Tortosa Date: Sun, 3 Oct 2010 11:32:28 +0200 Subject: [PATCH] Add pkgbuild syntax highlight with GeShi --- web/html/pkgbuild_view.php | 35 +++