Re: [aur-dev] Fix for some plural strings
Hi, How about view all (1 comment) view all (n comments) On July 21, 2014 9:03:52 AM CEST, Lukas Fleischer archli...@cryptocrack.de wrote: On Thu, 17 Jul 2014 at 17:00:26, Safa Alfulaij wrote: Hello Lukas, About the constants no problem leave them as they are, but the rest not. Not all of the languages has one form only after 1, Arabic (for example) has 6 forms, 4 of them is after 1. This is not a good reason for not accepting my patch for these at least :) So the only thing that is left is View all %s comments and I am not sure how to pluralize that, View all 1 comment sounds very wrong. Suggestions? Note: I mix always between has and have, so I am sorry for my poor language :\ Regards, Safa
Re: [aur-dev] Fix for some plural strings
On 07/21/2014 10:37 AM, Sebastian Wilzbach wrote: Hi, How about view all (1 comment) view all (n comments) On July 21, 2014 9:03:52 AM CEST, Lukas Fleischer archli...@cryptocrack.de wrote: On Thu, 17 Jul 2014 at 17:00:26, Safa Alfulaij wrote: Hello Lukas, About the constants no problem leave them as they are, but the rest not. Not all of the languages has one form only after 1, Arabic (for example) has 6 forms, 4 of them is after 1. This is not a good reason for not accepting my patch for these at least :) So the only thing that is left is View all %s comments and I am not sure how to pluralize that, View all 1 comment sounds very wrong. Suggestions? Note: I mix always between has and have, so I am sorry for my poor language :\ Regards, Safa Or drop all: View %s comment(s)
Re: [aur-dev] Fix for some plural strings
On Mon, 21 Jul 2014 at 11:59:45, Safa Alfulaij wrote: Hello. There is It must be between %s and %s characters long and Your password must be at least %s characters. besides the View all %n comments. Please, English differs from other languages. If a string don't need to pluralize in English, It will need to pluralize in other languages. These are constant as well. You might argue that the constants can be changed by modifying the global configuration but the package submission form will be dropped before the 4.0.0 release anyway, so there is not much point in fixing that now. About View all %s comments, There is no problem if you patch it as I sent. There is already an if statement that checks if $count is higher than 10. Hard-coding View all %s comment don't give any problems as it won't be used. It is not a problem when displaying the string but translators might be confused by View all 1 comment. I currently like Sebastian's suggestion (View all (%d comments)) best. Regards, Safa
