Re: [PATCH v2 2/2] Introduce conf/config.dev for development

2020-06-02 Thread Frédéric Mangano-Tarumi
Lukas Fleischer [2020-06-01 21:05:57 -0400] > On Mon, 01 Jun 2020 at 12:50:23, Frédéric Mangano-Tarumi wrote: > > diff --git a/conf/config.dev b/conf/config.dev > > new file mode 100644 > > index ..e9c2112e > > --- /dev/null > > +++ b/conf/config.dev > > @@ -0,0 +1,36 @@ > > +;

Re: Tech stack for Python aurweb

2020-06-02 Thread Baptiste Jonglez
Hi, While I don't plan to work on the new AUR, I have experience with both Flask and Django. I generally don't like the kind of comments that go "it would be nicer if you do X and Y" from people that won't actually participate, but I still feel it's relevant: On 24-05-20, Ricardo Band wrote: >

Re: [PATCH v2 1/5] refactor code to comply with flake8 and isort

2020-06-02 Thread Lukas Fleischer
Nit: We usually capitalize the first word in commit messages. On Mon, 01 Jun 2020 at 18:35:25, Filipe Laíns wrote: > Signed-off-by: Filipe Laíns > --- > aurweb/git/auth.py | 3 +- > aurweb/git/serve.py | 14 +- > aurweb/git/update.py| 6 +- >

Re: [PATCH v2 2/2] Introduce conf/config.dev for development

2020-06-02 Thread Frédéric Mangano-Tarumi
Lukas Fleischer [2020-06-02 17:40:23 -0400] > On Tue, 02 Jun 2020 at 08:41:28, Frédéric Mangano-Tarumi wrote: > > Developers need to set AUR_CONFIG to spawn aurweb. If we introduced it > > earlier like \u201cDefine the path to you configuration: > > export AUR_CONFIG="\u2026"\u201d, I think it

Re: [PATCH v3 2/2] Introduce conf/config.dev for development

2020-06-02 Thread Lukas Fleischer
On Tue, 02 Jun 2020 at 20:04:02, Frédéric Mangano-Tarumi wrote: > conf/config.dev\u2019s purpose is to provide a lighter configuration template > for developers, and split development-specific options off the default > configuration file. > --- > TESTING | 11 ++- >

[PATCH v3 2/2] Introduce conf/config.dev for development

2020-06-02 Thread Frédéric Mangano-Tarumi
conf/config.dev’s purpose is to provide a lighter configuration template for developers, and split development-specific options off the default configuration file. --- TESTING | 11 ++- conf/config.defaults | 10 -- conf/config.dev | 32

Re: [PATCH v2 2/2] Introduce conf/config.dev for development

2020-06-02 Thread Lukas Fleischer
On Tue, 02 Jun 2020 at 08:41:28, Frédéric Mangano-Tarumi wrote: > > Saying ${AUR_CONFIG}.defaults here is elegant, short, precise and clear > > to everybody who is familiar with the code base. However, given that > > those comments are mainly relevant to new contributors setting up a dev > >

Re: Tech stack for Python aurweb

2020-06-02 Thread Lukas Fleischer
Thank you for your comments Ricardo and Baptiste. On Tue, 02 Jun 2020 at 09:07:21, Baptiste Jonglez wrote: > I generally don't like the kind of comments that go "it would be nicer if > you do X and Y" from people that won't actually participate, but I still > feel it's relevant: One of the