Re: [aur-dev] [PATCH 1/2] Fix performance issues with new PackageDepends lookups

2011-06-24 Thread Lukas Fleischer
On Wed, Jun 22, 2011 at 10:04:10AM -0500, Dan McGee wrote: We do a lookup by DepName in the package details view, but I made the silly mistake of forgetting this index addition in the upgrade steps. Signed-off-by: Dan McGee d...@archlinux.org --- Not sure if this fell through the cracks

Re: [aur-dev] [PATCH 2/2] Use sane ORDER BY clauses in package list queries

2011-06-24 Thread Lukas Fleischer
On Wed, Jun 22, 2011 at 10:04:11AM -0500, Dan McGee wrote: We were doing some silly things here with an ORDER BY Name, CategoryID clause, due to the fact that Name is unique, and thus any additional ordering after Name will have no effect. Of course, the dumb as a box of rocks MySQL query

Re: [aur-dev] [PATCH 2/5] use valid_email() from codeigniter's email helper

2011-06-24 Thread Lukas Fleischer
On Wed, Jun 22, 2011 at 10:11:28PM +0200, Cédric Girard wrote: On Wed, Jun 22, 2011 at 9:36 PM, Florian Pritz bluew...@xinu.at wrote: + return ( ! preg_match(/^([a-z0-9\+_\-]+)(\.[a-z0-9\+_\-]+)*@([a-z0-9\-]+\.)+[a-z]{2,6}$/ix, $addy)) ? FALSE : TRUE; Some legitimate email

Re: [aur-dev] [PATCH 5/5] check if new SessionID already exists

2011-06-24 Thread Lukas Fleischer
On Wed, Jun 22, 2011 at 09:36:44PM +0200, Florian Pritz wrote: Signed-off-by: Florian Pritz bluew...@xinu.at --- web/lib/aur.inc.php | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/web/lib/aur.inc.php b/web/lib/aur.inc.php index 382578c..3d1688a 100644

Re: [aur-dev] epoch fields for packages are completely ignored

2011-06-24 Thread Lukas Fleischer
On Fri, Jun 24, 2011 at 08:47:49AM +0300, Slavi Pantaleev wrote: From 43edc10872ede698a647805e6b1c798f6a13e8b8 Mon Sep 17 00:00:00 2001 From: Slavi Pantaleev s.pantal...@gmail.com Date: Fri, 24 Jun 2011 08:27:55 +0300 Subject: [PATCH] Honor epoch field in PKGBUILD files. The epoch field in

Re: [aur-dev] epoch fields for packages are completely ignored

2011-06-24 Thread Slavi Pantaleev
By the AUR helpers cannot update packages comment, I really meant that scripts/helpers that use rpc.php to get the parsed version were being confused about the actual AUR version of the package, meaning they couldn't update locale packages (which always seemed newer if they had an epoch 0).