Re: [aur-dev] [PATCH] FS#45834 - Remove trailing slash from git https://link.git/

2015-08-14 Thread Stefan Auditor


On 14.08.2015 06:53, Lukas Fleischer wrote:
 On Wed, 12 Aug 2015 at 13:20:37, Stefan Auditor wrote:
 Signed-off-by: Stefan Auditor stefan.audi...@erdfisch.de
 ---
  conf/config.proto | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

 diff --git a/conf/config.proto b/conf/config.proto
 index 2fbc27a..b2198e5 100644
 --- a/conf/config.proto
 +++ b/conf/config.proto
 @@ -18,8 +18,8 @@ persistent_cookie_timeout = 2592000
  max_filesize_uncompressed = 8388608
  disable_http_login = 1
  aur_location = https://aur.archlinux.org
 -git_clone_uri_anon = https://aur.archlinux.org/%s.git/
 -git_clone_uri_priv = ssh+git://a...@aur.archlinux.org/%s.git/
 +git_clone_uri_anon = https://aur.archlinux.org/%s.git
 +git_clone_uri_priv = ssh+git://a...@aur.archlinux.org/%s.git
 [...]
 As I already mentioned in the bug report, this is a regression in Git
 that will be fixed in the next Git maintenance release...

As I already asked in the bug report:
 Any reason not to remove the trailing slash?
 In my eyes it looks odd to have one after a file extension.
All git hosting services I'm aware of do it that way.
The most famos examples being

Github
https://github.com/owner/repository.git
g...@github.com:owner/repository.git

Gitlab
https://example.org/group/repository.git
g...@example.org:group/repository.git

regards,
Stefan

-- 
erdfisch
Stefan Auditor, Frank Holldorff  Fabian Lorenzen GbR

Internet: http://erdfisch.de
E-Mail : stefan.audi...@erdfisch.de
Telefon : +49 6221 751 560 0
Fax : +49 6221 751 560 99
Hans-Bunte-Str. 6
69123 Heidelberg


Re: [aur-dev] [PATCH] FS#45834 - Remove trailing slash from git https://link.git/

2015-08-14 Thread Loui Chang
On Fri 14 Aug 2015 11:47 +0200, Johannes Löthberg wrote:
 On 14/08, Stefan Auditor wrote:
 Any reason not to remove the trailing slash?
 In my eyes it looks odd to have one after a file extension.
 
 It's not a file extension, it's just the suffix of a directory.

huh


Re: [aur-dev] [PATCH] FS#45834 - Remove trailing slash from git https://link.git/

2015-08-14 Thread Johannes Löthberg

On 14/08, Stefan Auditor wrote:



On 14.08.2015 06:53, Lukas Fleischer wrote:

On Wed, 12 Aug 2015 at 13:20:37, Stefan Auditor wrote:

Signed-off-by: Stefan Auditor stefan.audi...@erdfisch.de
---
 conf/config.proto | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/conf/config.proto b/conf/config.proto
index 2fbc27a..b2198e5 100644
--- a/conf/config.proto
+++ b/conf/config.proto
@@ -18,8 +18,8 @@ persistent_cookie_timeout = 2592000
 max_filesize_uncompressed = 8388608
 disable_http_login = 1
 aur_location = https://aur.archlinux.org
-git_clone_uri_anon = https://aur.archlinux.org/%s.git/
-git_clone_uri_priv = ssh+git://a...@aur.archlinux.org/%s.git/
+git_clone_uri_anon = https://aur.archlinux.org/%s.git
+git_clone_uri_priv = ssh+git://a...@aur.archlinux.org/%s.git
[...]

As I already mentioned in the bug report, this is a regression in Git
that will be fixed in the next Git maintenance release...


As I already asked in the bug report:

Any reason not to remove the trailing slash?
In my eyes it looks odd to have one after a file extension.


It's not a file extension, it's just the suffix of a directory.

--
Sincerely,
 Johannes Löthberg
 PGP Key ID: 0x50FB9B273A9D0BB5
 https://theos.kyriasis.com/~kyrias/


signature.asc
Description: PGP signature