Re: [aur-dev] [PATCH] Let the user verify their email address

2015-08-16 Thread Lukas Fleischer
On Mon, 17 Aug 2015 at 02:42:31, Loui Chang wrote: > On Sun 16 Aug 2015 19:24 -0400, Eli Schwartz wrote: > > On Sun, Aug 16, 2015 at 7:04 PM, Marcel Korpel > > wrote: > [...] > > > I completely understand your frustration, I really hate it, too, but to > > > let someone confirm their email address

Re: [aur-dev] [PATCH] Let the user verify their email address

2015-08-16 Thread Loui Chang
On Sun 16 Aug 2015 19:24 -0400, Eli Schwartz wrote: > On Sun, Aug 16, 2015 at 7:04 PM, Marcel Korpel > wrote: > > > * "Patrick Burroughs (Celti)" (Sun, 16 Aug 2015 > > 15:59:38 -0700): > > > On Mon, 17 Aug 2015 00:54:54 +0200 > > > Marcel Korpel wrote: > > > > > >> On registering and updating a

Re: [aur-dev] [PATCH] Let the user verify their email address

2015-08-16 Thread Eli Schwartz
On Sun, Aug 16, 2015 at 7:04 PM, Marcel Korpel wrote: > * "Patrick Burroughs (Celti)" (Sun, 16 Aug 2015 > 15:59:38 -0700): > > On Mon, 17 Aug 2015 00:54:54 +0200 > > Marcel Korpel wrote: > > > >> On registering and updating an email address, the user has to type > >> their email address twice.

Re: [aur-dev] [PATCH] Let the user verify their email address

2015-08-16 Thread Marcel Korpel
* "Patrick Burroughs (Celti)" (Sun, 16 Aug 2015 15:59:38 -0700): > On Mon, 17 Aug 2015 00:54:54 +0200 > Marcel Korpel wrote: > >> On registering and updating an email address, the user has to type >> their email address twice. Do not allow autocomplete and pasting in >> the verification field. >

Re: [aur-dev] [PATCH] Let the user verify their email address

2015-08-16 Thread Patrick Burroughs (Celti)
On Mon, 17 Aug 2015 00:54:54 +0200 Marcel Korpel wrote: > On registering and updating an email address, the user has to type > their email address twice. Do not allow autocomplete and pasting in > the verification field. Please, do NOT forbid pasting in any field! Some of us (many, perhaps?) use

Re: [aur-dev] [PATCH] Let the user verify their email address

2015-08-16 Thread Marcel Korpel
* Marcel Korpel (Mon, 17 Aug 2015 00:54:54 +0200): > + > +var verify_field = document.getElementById('id_email_verify'); > +verify_field.addEventListener('paste', function (e) { > + e.preventDefault(); > +}, false); > + Note that this (ugly) hack currently does not work in Firefox, it allows

[aur-dev] [PATCH] Let the user verify their email address

2015-08-16 Thread Marcel Korpel
On registering and updating an email address, the user has to type their email address twice. Do not allow autocomplete and pasting in the verification field. Fixes FS#45792. Signed-off-by: Marcel Korpel --- web/html/account.php | 17 + web/html/register.php

[aur-dev] [PATCH 2/2] Do not allow empty comments

2015-08-16 Thread Marcel Korpel
Fixes FS#45870. Signed-off-by: Marcel Korpel --- web/html/pkgbase.php | 3 +-- web/lib/pkgbasefuncs.inc.php | 10 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/web/html/pkgbase.php b/web/html/pkgbase.php index 1581869..bc32e43 100644 --- a/web/html/pkgbase.p

[aur-dev] [PATCH 1/2] Remove success message from comment form

2015-08-16 Thread Marcel Korpel
To be more flexible with messages, we shouldn't always output this message when a comment has been sent. Moreover, currently it is not displayed due to the POST-Redirect-GET pattern, where the comment parameter is lost after redirection. Signed-off-by: Marcel Korpel --- web/template/pkg_comment_

[aur-dev] [PATCH] Display sources count on package details page

2015-08-16 Thread Stefan Auditor
Show item count on sources section just like it is done for dependencies and required by. Fixes FS#45881. Signed-off-by: Stefan Auditor --- web/template/pkg_details.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/template/pkg_details.php b/web/template/pkg_details.ph

[aur-dev] [PATCH] Update link to package submission documentation

2015-08-16 Thread Stefan Auditor
Fixes FS#45942. Signed-off-by: Stefan Auditor --- web/html/home.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/html/home.php b/web/html/home.php index 3252876..5b7081f 100644 --- a/web/html/home.php +++ b/web/html/home.php @@ -77,7 +77,7 @@ html_header( __("Home") );

Re: [aur-dev] [PATCH] Remove trailing slash from git urls

2015-08-16 Thread Lukas Fleischer
On Sun, 16 Aug 2015 at 14:18:42, Stefan Auditor wrote: > Circumvents the temporary regression in git that clones a repository > as foo-git.git instead of foo-git and matches the format used by > other commonly used git hosting providers. > > Fixes FS#45834 > > Signed-off-by: Stefan Auditor > ---

Re: [aur-dev] [PATCH] Update translation documentation

2015-08-16 Thread Lukas Fleischer
On Sun, 16 Aug 2015 at 20:13:58, Stefan Auditor wrote: > Update the link to the project page on Transifex and remove an outdated link > to the Arch Wiki. > > Fixes FS#45966. > > Signed-off-by: Stefan Auditor > --- > TRANSLATING | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > [...

[aur-dev] [PATCH] Update translation documentation

2015-08-16 Thread Stefan Auditor
Update the link to the project page on Transifex and remove an outdated link to the Arch Wiki. Fixes FS#45966. Signed-off-by: Stefan Auditor --- TRANSLATING | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/TRANSLATING b/TRANSLATING index e450640..d5b6764 100644 --- a/TRA

Re: [aur-dev] [PATCH] Update translation documentation

2015-08-16 Thread Marcel Korpel
* Stefan Auditor (Sun, 16 Aug 2015 19:54:10 +0200): >> As Lukas already said, "[p]lease use >> http://www.transifex.com/projects/p/aur/ instead". > > Any hints on where he said that? https://lists.archlinux.org/pipermail/aur-dev/2015-August/003709.html

Re: [aur-dev] [PATCH] Update translation documentation

2015-08-16 Thread Stefan Auditor
On 16.08.2015 19:48, Marcel Korpel wrote: > * Stefan Auditor (Sun, 16 Aug 2015 > 13:40:06 +0200): >> Update the link to the project page on Transifex and remove an >> outdated link to the arch wiki. > I think "arch" and "wiki" should start with an uppercase letter. > >> Fixes FS#45966 > Please a

Re: [aur-dev] [PATCH] Update translation documentation

2015-08-16 Thread Marcel Korpel
* Stefan Auditor (Sun, 16 Aug 2015 13:40:06 +0200): > Update the link to the project page on Transifex and remove an > outdated link to the arch wiki. I think "arch" and "wiki" should start with an uppercase letter. > Fixes FS#45966 Please add a full stop after sentences in the message body. >

[aur-dev] [PATCH] Remove trailing slash from git urls

2015-08-16 Thread Stefan Auditor
Circumvents the temporary regression in git that clones a repository as foo-git.git instead of foo-git and matches the format used by other commonly used git hosting providers. Fixes FS#45834 Signed-off-by: Stefan Auditor --- conf/config.proto | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[aur-dev] [PATCH] Update translation documentation

2015-08-16 Thread Stefan Auditor
Update the link to the project page on Transifex and remove an outdated link to the arch wiki. Fixes FS#45966 Signed-off-by: Stefan Auditor --- TRANSLATING | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/TRANSLATING b/TRANSLATING index e450640..1a97276 100644 --- a/TRAN