[aur-dev][PATCH] config: allow reading both the proto file and the modified config

2018-04-15 Thread Eli Schwartz
On 04/12/2018 02:22 PM, Nodiv Byzero wrote: > The point is that there are few places where config_load() gets called > in the sequential order (the same request) and every time it loads and > parses data. Are these also places where if (!isset($AUR_CONFIG)) fails to actually fulfill its sole

Re: [aur-dev][PATCH] config: allow reading both the proto file and the modified config

2018-04-15 Thread Eli Schwartz
On 04/15/2018 06:11 AM, Lukas Fleischer wrote: > Maybe even better: make AUR_CONFIG default to /etc/aurweb/config and > AUR_CONFIG_DEFAULTS default to the value of AUR_CONFIG with an > additional ".defaults" suffix. Great minds think alike. :) -- Eli Schwartz Bug Wrangler and Trusted User

[aur-dev][PATCH v2] config: allow reading both the defaults file and the modified config

2018-04-15 Thread Eli Schwartz
In the process, rename config.proto to config.defaults (because that is what it is now). Also use dict.get('key', default_value) when querying os.environ, rather than an if block, as it is more pythonic/readable/concise, and reduces the number of dict lookups. This change allows aurweb

Re: [aur-dev][PATCH] config: allow reading both the proto file and the modified config

2018-04-15 Thread Lukas Fleischer
On Sat, 14 Apr 2018 at 16:04:58, Lukas Fleischer wrote: > On Thu, 12 Apr 2018 at 19:44:15, Eli Schwartz wrote: > > This change allows aurweb configuration to be done via either: > > - copying config.proto to config and modifying values > > - creating a new config only containing modified values,