Re: [PATCH] Support conjunctive keyword search in RPC interface

2020-07-04 Thread Kevin Morris
Alright, patch sent; I used `-v1` this time with `git send-email`... I can't find documentation for that switch yet. I've tested basic search through both paths; the only refactoring that needed to be done was to remove the extra "AND (" and ")" from the generic function, and add it where we need

[PATCH] Support conjunctive keyword search in RPC interface

2020-07-04 Thread Kevin Morris
Newly supported API Version 6 modifies `type=search` functionality; it now behaves the same as `name` or `name-desc` search through the https://aur.archlinux.org/packages/ search page. Search for packages containing the literal keyword `blah blah` AND `haha`:

Re: [PATCH] Bump RPC API Version 6

2020-07-04 Thread Lukas Fleischer
On Sat, 04 Jul 2020 at 20:52:09, Kevin Morris wrote: > Awesome! I do like the sound better of using the same exact search sql for > both RPC and Web, and so your suggestion seems like a great idea to me. > I'll start looking at this today! Sounds great, I am looking forward to a new patch. And

Re: [PATCH] Bump RPC API Version 6

2020-07-04 Thread Kevin Morris
Hey Lukas, Awesome! I do like the sound better of using the same exact search sql for both RPC and Web, and so your suggestion seems like a great idea to me. I'll start looking at this today! On Sat, Jul 4, 2020 at 5:30 PM Lukas Fleischer wrote: > On Sat, 04 Jul 2020 at 17:14:26, Kevin Morris

Re: [PATCH] Bump RPC API Version 6

2020-07-04 Thread Lukas Fleischer
On Sat, 04 Jul 2020 at 17:14:26, Kevin Morris wrote: > API Version 6 modifies `type=search` functionality: Split `arg` into > keywords separated by spaces (quoted keywords are preserved). > [...] > Signed-off-by: Kevin Morris > --- > doc/rpc.txt | 4 +++ >

Re: [PATCH] Exclude suspended Users from being notified

2020-07-04 Thread Kevin Morris
No problem, Lukas! Yeah, basically all my patches except the most recent one are obsolete.. pretty new to git send-email, wasn't sure about that -- I'll check out -v for future submissions. Thanks for the tip! On Sat, Jul 4, 2020 at 5:50 AM Lukas Fleischer wrote: > On Fri, 03 Jul 2020 at

[PATCH] Bump RPC API Version 6

2020-07-04 Thread Kevin Morris
API Version 6 modifies `type=search` functionality: Split `arg` into keywords separated by spaces (quoted keywords are preserved). Search for packages containing the literal keyword `blah blah` AND `haha`: https://aur.archlinux.org/rpc/?v=6=search="blah blah"%20haha Search for packages

Re: [PATCH] Bump RPC API Version 6

2020-07-04 Thread Kevin Morris
Thanks for the look/review Lukas; fixed up some things in the code that clears all these points up -- the comments for `join_where` were outdated, forgot to update it -- renamed some variables and swapped to `array_reduce` instead of the manual loop. Now that I can see, there's no reason that it

Re: [PATCH] Bump RPC API Version 6

2020-07-04 Thread Lukas Fleischer
On Thu, 02 Jul 2020 at 23:10:40, Kevin Morris wrote: > [...] > Signed-off-by: Kevin Morris > --- > doc/rpc.txt | 4 +++ > web/lib/aurjson.class.php | 66 ++- > 2 files changed, 62 insertions(+), 8 deletions(-) Thanks Kevin! A few comments

Re: [PATCH] Exclude suspended Users from being notified

2020-07-04 Thread Lukas Fleischer
On Fri, 03 Jul 2020 at 21:29:16, Kevin Morris wrote: > The existing notify.py script was grabbing entries regardless > of user suspension. This has been modified to only send notifications > to unsuspended users. > > This change was written as a solution to >