.
Any thoughts on this?
As far as I am concerned, do whatever you want. Lastpass overrides the
autocomplete=off setting, anyway.
-- Eli Schwartz
.. why not add the full url of the bug report?
> That will make it a little easier to find.
>
On https://projects.archlinux.org/ that automatically gets rendered as a
link. :)
--
Eli Schwartz
mit Request" satisfies everyone, then so be it -- but sticking an
"a" in there would basically go against the pattern of every other piece
of text on the page.
[1]
https://lists.archlinux.org/pipermail/aur-general/2015-November/031783.html
--
Eli Schwartz
Apparently the reference to "files" can be confusing.
Fixes FS#47167
Signed-off-by: Eli Schwartz <eschwart...@gmail.com>
---
web/html/pkgreq.php | 2 +-
web/template/pkgbase_actions.php | 2 +-
web/template/pkgreq_form.php | 4 ++--
3 files changed, 4 insertions
ndex c522e25..21a2677 100644
> --- a/web/html/pkgdel.php
> +++ b/web/html/pkgdel.php
> @@ -12,7 +12,7 @@ html_header(__("Package Deletion"));
>
> if (has_credential(CRED_PKGBASE_DELETE)): ?>
>
> - ?>
> + : ?>
It looks like you forgot to remove most of the closing parentheses,
except this first one.
--
Eli Schwartz
Apparently it confuses some people, and there appears to be enough space
in the Package Actions section anyway.
Fixes:
https://lists.archlinux.org/pipermail/aur-general/2015-November/031776.html
Because a 37-post flame war is fun. :rolleyes:
Signed-off-by: Eli Schwartz <eschwart...@gmail.
On 11/25/2015 02:06 AM, Lukas Fleischer wrote:
> On Wed, 25 Nov 2015 at 07:51:08, Eli Schwartz wrote:
>> Apparently the reference to "files" can be confusing.
>>
>> Fixes FS#47167
>>
>> Signed-off-by: Eli Schwartz <eschwart...@gmail.com>
>>
>> I think it's more natural to provide the whole "verb" up front.
>>
>
> +1 for set-keywords
>
+2
There aren't so many verbs that we are drowning in them and need to
group them...
Alternatively, use "keywords".
Maybe using it without feeding a keyword could
there was an existing package.
Signed-off-by: Eli Schwartz <eschwa...@archlinux.org>
---
Similar to the warn_or_die function, except that doesn't take
alternative messages and there is no nice universal message here.
I think I prefer something that allows the TU to set whether they reall
/ )
Use .ssh/config "SendEnv" on the TU's side and and sshd_config
"AcceptEnv" in the AUR server to specifically request privileged access.
TUs should use: `export AUR_PRIVILEGED=1; git push`
Signed-off-by: Eli Schwartz <eschwa...@archlinux.org>
---
INSTALL| 1
/ )
Switch to using allow_overwrite to check for destructive actions.
Use .ssh/config "SendEnv" on the TU's side and and sshd_config
"AcceptEnv" in the AUR server to specifically request overwrite access.
TUs should use: `export AUR_OVERWRITE=1; git push`
Signed-off-by:
/ )
Switch to using allow_overwrite to check for destructive actions.
Use .ssh/config "SendEnv" on the TU's side and and sshd_config
"AcceptEnv" in the AUR server to specifically request overwrite access.
TUs should use: `export AUR_OVERWRITE=1; git push`
Signed-off-by:
/ )
Switch to using allow_overwrite to check for destructive actions.
Use .ssh/config "SendEnv" on the TU's side and and sshd_config
"AcceptEnv" in the AUR server to specifically request overwrite access.
TUs should use: `AUR_OVERWRITE=1 git push --force`
Signed-off-by:
we could clear the keywords, we could not set them.
Signed-off-by: Eli Schwartz <eschwa...@archlinux.org>
---
aurweb/git/serve.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/aurweb/git/serve.py b/aurweb/git/serve.py
index 3eef26a..eea0c9c 100755
--- a/aurweb/git/se
Double-quoted "strings" were surrounded by the tag, but what we
actually want is fenced-in `strings` to create the tag.
Signed-off-by: Eli Schwartz <eschwa...@archlinux.org>
---
doc/git-interface.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
Signed-off-by: Eli Schwartz <eschwa...@archlinux.org>
---
doc/Makefile | 2 +-
web/html/git-interface.php | 3 +++
web/lib/routing.inc.php| 1 +
3 files changed, 5 insertions(+), 1 deletion(-)
create mode 100644 web/html/git-interface.php
diff --git a/doc/Makefile
.
>
> I plan on sending the email on Sunday, 2017-11-05, which is exactly four
> weeks before the scheduled release date.
Hmm, nice! Can't wait for that markdown support. :D
--
Eli Schwartz
signature.asc
Description: OpenPGP digital signature
he package.
This is wrong, and should show (will show, if you manually add it or use
the close button instead of the accept button):
Request #XX has been rejected by YYY [1]:
Fixes FS#56606
Signed-off-by: Eli Schwartz <eschwa...@archlinux.org>
---
web/template/pkgreq_results.php | 6 +-
1
f, there's no reason to hardcode the
arches to check for at all. We can get this information too, from the
.SRCINFO itself. Detecting this dynamically is not incompatible with a
blacklist, should we ever decide to implement such a thing.
Signed-off-by: Eli Schwartz <eschwa...@archlinux.org>
-
Signed-off-by: Eli Schwartz <eschwa...@archlinux.org>
---
web/template/cgit/footer.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/web/template/cgit/footer.html b/web/template/cgit/footer.html
index 36e0f1b..6ceec28 100644
--- a/web/template/cgit/footer.html
+++
On 01/28/2018 04:48 PM, Baptiste Jonglez wrote:
> From: Baptiste Jonglez <g...@bitsofnetworks.org>
>
> Also clarify what to change in the configuration.
There is already another patch that does this in the pu branch,
submitted 3 weeks ago and merged on Friday.
--
Eli Schwar
ted behavior)?
If it *is* possible to be both, maybe we should fix that instead? :p
Anyway, if you click the disown button we assume you want to ditch the
package altogether... if you are the maintainer and want to edit the
comaintainer list we have a UI for that already.
--
Eli Schwartz
Bug Wrangler and
In commit 8c98db0b82cc85a4498589e5d60299fefd93b421 support was added for
package comaintainers to pin comments in addition to maintainers.
Due to a typo, the SQL query was reset halfway through and only added
the comaintainer IDs to the list of allowed users.
Fixes FS#56783
Signed-off-by: Eli
random userid with the same id as the pkgbase, got sent a
notification regarding some package with the same id as the real user's id.
Signed-off-by: Eli Schwartz
---
aurweb/git/serve.py | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/aurweb/git/serve.py b/aurweb/git
On 8/11/18 4:25 AM, Lukas Fleischer wrote:
> On Fri, 10 Aug 2018 at 23:26:28, Eli Schwartz wrote:
>> The notify script expects to see the userid followed by additional
>> arguments like the pkgbase id, however, these were getting sent swapped
>> around (presumably due to the s
> pushed around.
We're still getting a small handful of reports about this, and I'm not
sure why. When was this deployed to aur.archlinux.org?
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
translation file found for domain',
domain)
remote: FileNotFoundError: [Errno 2] No translation file found for domain: 'aur'
Signed-off-by: Eli Schwartz
---
aurweb/l10n.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/aurweb/l10n.py b/aurweb/l10n.py
index e58e3fe..66e0f1c
line 514, in translation
remote: raise OSError(ENOENT, 'No translation file found for
domain', domain)
remote: FileNotFoundError: [Errno 2] No translation file found for
domain: 'aur'
--
Eli Schwartz
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
translation file found for domain',
domain)
remote: FileNotFoundError: [Errno 2] No translation file found for domain: 'aur'
Signed-off-by: Eli Schwartz
---
v2: fix PHP code too
aurweb/l10n.py | 2 +-
web/lib/translator.inc.php | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-
On 03/07/2018 09:52 PM, Actionless Loveless wrote:
> Btw do you have docker or some other other kind of container
> prepopulated with AUR db so i can test the changes before submitting?
No, but there are instructions in the "TESTING" file.
--
Eli Schwartz
Bug Wrangler
sync and replace existing packages, which would simply be
incorrect.
No thanks, let's stick to adding provides as an alias for the package
they provide.
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
On 03/08/2018 04:27 PM, Actionless Loveless wrote:
> Done:
Your patch does not appear to be git formatted, please resubmit it using
for example git-send-email(1)
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
ering to install something totally
different is wrong. Even pacman will allow you to install a pkgname that
you specify regardless of whether there is a replaces available
instead And generally speaking, the rate at which the replaces
keyword is misused in AUR packages makes me think any implementation
would simply not work out in practice.
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
interface is not one of these.) But if you've never
done it before... don't try. Just use git-send-email(1) which will ask
for the email to/from addresses and can be given the in-reply-to message
id, and will *guarantee* that the patch is not corrupted.
--
Eli Schwartz
Bug Wrangler and Tr
by
storing only changed values, and deferring to config.proto otherwise.
If a config.proto file does not exist next to /etc/aurweb/config or
$AUR_CONFIG, it is ignored and *all* values are expected to live in the
modified config file.
Signed-off-by: Eli Schwartz <eschwa...@archlinux.org>
---
note, Bluewind suggested renaming the config.proto to
config.defaults, so if Lukas agrees with this patch I will send in an
amended version.
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
On 04/15/2018 06:11 AM, Lukas Fleischer wrote:
> Maybe even better: make AUR_CONFIG default to /etc/aurweb/config and
> AUR_CONFIG_DEFAULTS default to the value of AUR_CONFIG with an
> additional ".defaults" suffix.
Great minds think alike. :)
--
Eli Schwartz
Bug Wrangl
are expected to
live in the modified config file.
Signed-off-by: Eli Schwartz <eschwa...@archlinux.org>
---
v2: I opted to make the default location of the defaults config dependent on
the location of the site config, since I think that makes more sense...
Also reimplement the env gettin
be spent to fix this, rather than introducing
painful, non-obvious code, we should introduce some sort of proper cache.
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
> +"list-voted": "List voted packages.",
But I think this should be "List packages you have voted for".
You will also need to update the documentation in doc/git-interface.txt
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
ANNER_RAW);
> + if (file_exists($path)) {
> + $AUR_CONFIG = parse_ini_file($path, true,
> INI_SCANNER_RAW);
> + } else {
> + die("aurweb config file not found");
> + }
> }
> }
Very minor nit. The commit
Because filtering by matching the sender && regular expressions on the
subject is awkward.
Signed-off-by: Eli Schwartz
---
In order to remain generic enough to allow the notify script to be
imported from and used elsewhere, we cannot just use sys.argv[1] as the
reason.
aurweb
;
> + for="id_enable_notifications">
> +
> +
>
>
>
>
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
+++ b/web/html/css/aurweb.css
> @@ -122,7 +122,7 @@
> top: 4px;
> }
>
> -.flagged a {
> +.flagged a, a.date {
> color: inherit;
> }
This causes the link color to be the same black as the rest of the
"commented on" text. Question is, do we actually want that
t; w.r.t. coloring,
but I think it's reasonable to make it stand out, and this matches what
I've seen on many other websites, so, merged to pu.
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
ere is a difference between forum posts, which start on the
first page and add new posts to a new page, vs. the AUR which shows the
newest comments first. Is there any way to make truly stable links like
that?
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
On 10/26/18 10:00 AM, Eli Schwartz wrote:
> Notifications are still going to the wrong people. We tried to fix this
> in commit b702e5c0e7f13103fc764b7e5613f78f3e7acd30, but only fixed it
> for the python callers. There's another caller in the php code, which
> needs to use the
Notifications are still going to the wrong people. We tried to fix this
in commit b702e5c0e7f13103fc764b7e5613f78f3e7acd30, but only fixed it
for the python callers. There's another caller in the php code, which
needs to use the right order of arguments as well.
Fixes FS#60602
Signed-off-by: Eli
ever used once, and I
don't think listing search qualifiers here really helps code clarity vs.
a case statement. Moreso when we need to drop the special handling of
finding NULL maintainers, and don't do provides here because it doesn't
fit into the architecture at all.
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
similar concept (and a little different
> than those in v5), I've implemented them in a separate function. I'd
> like to know if this is the way to go, or I should try to reuse the
> existing structure.
Can you update doc/rpc.txt to describe the new version? Looks like the
github wiki
On 11/6/18 2:07 AM, 尤立宇 wrote:
> Eli Schwartz :
>> Can you update doc/rpc.txt to describe the new version? Looks like the
>> github wiki contains partial work towards this, but it's not in asciidoc
>> format.
> Sure.
>
> Eli Schwartz :
>>>
>>&g
"malformed" URI by treating it as another
example of a source with a schema, and linking it as-is.
See https://lists.archlinux.org/pipermail/aur-general/2019-January/034782.html
for details.
Signed-off-by: Eli Schwartz
---
This fixes the case of local:///, but are there other cases w
web/lib/pkgfuncs.inc.php | 2 +-
> 6 files changed, 11 insertions(+), 11 deletions(-)
Merged to pu and the live instance is hotpatched.
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
epo, Provides) "
> "VALUES (?, ?, ?)", [pkg, repo, provides])
> -for pkg, provides in oldproviders.difference(providers):
> -conn.execute("DELETE FROM OfficialProviders "
> - "WHERE Name = ? AND Provides = ?&quo
On 11/6/18 2:07 AM, 尤立宇 wrote:
> Of course, v6 should absolutely support what is possible now in v5.
> The previous patch is more about asking if we can agree on the interface.
> I'll work on to bring the v6 patch up to date with the new rpc methods
> supported in v5.
Any upda
Plain copy of reply
Forwarded Message
Subject: Re: [PATCH] Make delete and merge links create an auto-accepted
request
Date: Sun, 23 Dec 2018 23:19:47 +0100
From: Johannes Löthberg
To: Eli Schwartz
Excerpts from Eli Schwartz's message of December 23, 2018 22:58:
> On 12/23
ing information. e.g., the following cases:
- user submits deletion request, Eli Schwartz uses "close" instead of
"accept", with the message "merged instead". Do we really need
additional notifications here?
- deletion of spam packages
Moreover, the current pro
in how they expose functionality regardless.
Maybe there is some way we could revamp all this in the process? Maybe
if we exposed the comment box in the "delete/merge/orphan this package"
landing page, we could unify comments and notifications across all three
action paths? (request-accept, request-close, and direct action links)
Rather than submitting an auto-accepted request, we'd simply prompt for
an optional comment, then perform the final notification (and if "via"
is passed, do so using pkgreq_close, else just use notify).
This would also mean we only send out one email, instead of two.
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
ot;multiple by[] and arg[] are possible", and add a
new example in the unified examples section showing how that can be done.
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
On 4/27/19 8:39 AM, Lukas Fleischer wrote:
> On Sun, 06 Jan 2019 at 18:56:04, Eli Schwartz wrote:
>> php's parse_url does not handle proper rfc3986 URIs, specifically, it
>> does not handle the case of an empty authority such as file:/// or
>> local:/// and only han
On 4/28/19 8:26 AM, Lukas Fleischer wrote:
> On Sat, 27 Apr 2019 at 23:49:11, Eli Schwartz wrote:
>> Ah... yeah, that is a pretty good point. I'd probably want to display
>> that as straight up plaintext.
>>
>> It definitely should not be appended to the cgit url if it i
ly can
users view anyone's comments, which doesn't seem to have been the
intended goal, users could also view anyone's *deleted* comments which
was entirely not wanted at all. :/
It should be simple to allow users to view the /comments page for their
own profile alone.
--
Eli Schwartz
Bug Wr
wever, set this credential for all
users, contrary to the intention of the commit.
In order to preserve the ability to list a person's own comments, also
declare the allowed uids based on the profile being viewed.
Signed-off-by: Eli Schwartz
---
v2: allow users to view their own comments
web/html/a
wever, set this credential for all
users, contrary to the intention of the commit.
In order to preserve the ability to list a person's own comments, also
declare the allowed uids based on the profile being viewed.
Signed-off-by: Eli Schwartz
---
v3: fix:
- typoed end parens in the wrong place causin
enge($salt) {
> + $token = substr(md5($salt), 0, 3);
> + return "pacman -V|sed -r 's#[0-9]+#" . $token . "#g'|md5sum|cut -c1-6";
> +}
But I think we need to mention LC_ALL=C here. See e.g.
https://bugs.archlinux.org/task/63808
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
mmit
09cb61a will ever have an assumed default used. I think all the others
should need user input stored when first adding the row, which is fine...
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
body = '%s [1] filed %s %s request for %s [2]:' % \
> + (self._user, an, self._reqtype, self._pkgbase)
> body += '\n\n' + self._text
> return body
>
>
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
got the idea to use True
>> as an index.
>> I posted an updated patch where I added your changes.
No problem. ;) Thanks.
As an aside, I have now seen int(True)-indexed lists used "in the wild"!
A clever fox saw what I wrote and PM'ed me a Fizzbuzz implementation
which relied on th
inux.org website -- for general
discussion about AUR packages, you should use the aur-general list.
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
limit, though i don't remember
> what. still, the number of separate RPCs would likely be in the
> thousands.
The limitations are described on the wiki page you were referred to:
https://wiki.archlinux.org/index.php/Aurweb_RPC_interface#Limitations
(Also, it is "multiinfo", n
giant git repo of every PKGBUILD in the AUR (this
was before the migration to git, so everything was tarballs, and this
was meant to pull them all together and provide history for the daily
snapshots). Today, I guess you could clone 55603 package bases from git,
thus ensuring you had fully up to date of
ls -skh packages*.gz
> : 1.5M packages-md5sums.gz 344K packages.gz
>
> the inflation for version numbers and/or "last modified time" (as
> seconds since the epoch) would probably be less, maybe double the size
> of packages.gz?
The package details key "last modified
f it?)
The gz files are simply on-disk files. A cron job regenerates it, and
IIRC the job fires every 5 minutes. The AUR website simply serves the
contents as-is.
As for load balancing, we only use one machine. (It is located at
luna.archlinux.org)
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
You could try the generic arch-general mailing list, or contact the
security team directly.
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
If a db query returned NULL instead of an array, then accessing $row[0]
now throws a warning. The undocumented behavior of evaluating to NULL
is maintained, and we want to return NULL anyway, so add a check for the
value and fall back on the default function return type.
Signed-off-by: Eli
I had this sitting around since December and forgot to send it in,
offered FWIW. It's slightly different in implementation and has more
wordy commit messages.
Eli Schwartz (2):
fix php 7.4 warnings
fix more php 7.4 warnings
web/lib/acctfuncs.inc.php | 1 +
web/lib/aur.inc.php | 28
either return the error or return default null. But, for
now, I'm just going to fix it to return what it's actually supposed to,
without changing the API.
Signed-off-by: Eli Schwartz
---
web/lib/acctfuncs.inc.php | 1 +
1 file changed, 1 insertion(+)
diff --git a/web/lib/acctfuncs.inc.php b/web/lib
he idea is to make it simpler for contributors to test out the live
instance, adding additional layers (multiple interconnected containers)
just makes it more complicated again, thus defeating the initial premise.
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
.
Aborting...
==> ERROR: Makepkg was unable to build openoffice.
==> Restart building openoffice ? [y/N]
==> ---
==>
interesting...
I see maintainers nothing doing for last 1,5 year.
The aurweb software contains a (presumably working) feature to su
On 02/12/2017 10:17 AM, Eli Schwartz wrote:
> On 02/12/2017 09:56 AM, Lukas Fleischer wrote:
>> Hi,
>>
>> One of the new features of the upcoming aurweb release is a dashboard
>> which will be displayed in place of the regular home page after login.
>> Righ
apparently get used on occasion, can
you see about getting that added to the certificate?
(I have just mentioned it on #archlinux-devops.)
> What are your thoughts on this? Are there any other suggestions for
> useful things to display on that page?
I'll be happy to trial it (I was waiting for t
the recently-closed deletion request for
firefox-dev (PRQ #7448, filed 2/07/2017), which was accepted, but then
restored by the maintainer -- could that be confusing things? Also, two
other requests that were accepted today, still list themselves as "pending".
Is this supposed to happen???
--
Eli Schwartz
signature.asc
Description: OpenPGP digital signature
ated. As
for pagination, just return co-maintainers at the end (the last page)...
I assume since co-maintained packages are "lesser", people will be less
interested in them.
There is no need to restrict the co-maintainers search to your own
packages only, so it has nothing to do with &qu
good, the TUs won't
care whether you are the maintainer.
--
Eli Schwartz
signature.asc
Description: OpenPGP digital signature
onfirm current running cgit version?
I'd assume, whichever version is packaged in the Arch repos. ;) The
archlinux.org infrastructure runs on Arch Linux after all...
--
Eli Schwartz
signature.asc
Description: OpenPGP digital signature
` (without needing a new commit).
Only TUs/Devs can force-push or (re)publish a blacklisted package (e.g.
something that already exists in the repos) but aside from that the same
logic applies everywhere in the backend AFAIK.
--
Eli Schwartz
signature.asc
Description: OpenPGP digital signature
he maintainer to copy-paste things into a file and then patch with that.
Likewise with build errors, I would much rather people post a one-line
error message with a pastebin reference to the full build log.
--
Eli Schwartz
signature.asc
Description: OpenPGP digital signature
87 matches
Mail list logo
