Re: [aur-dev] [PATCH v3] Redirect at previous page after a successful login

2015-06-25 Thread Lukas Fleischer
On Thu, 18 Jun 2015 at 21:28:17, Gordian Edenhofer wrote: After the user was authenticated a redirect to the site which linked the user to the login page is done. This fixes FS#32481. --- Here you go. Changes since v2: * Formatting * Usual redirect to register page if it is the referer

[aur-dev] [PATCH] Display (reverse) optional dependencies as Required by

2015-06-25 Thread Lukas Fleischer
Also, change pkg_required() such that the returned array has the same structure as the result of pkg_dependencies(). Fixes FS#45452. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- web/lib/pkgfuncs.inc.php | 13 - web/template/pkg_details.php | 9 +++-- 2 files

Re: [aur-dev] [PATCH v2] Redirect at previous page after a successful login

2015-06-25 Thread Lukas Fleischer
On Thu, 18 Jun 2015 at 21:28:17, Gordian Edenhofer wrote: After the user was authenticated a redirect to the site which linked the user to the login page is done. This fixes FS#32481. --- Thanks for the replies. I fixed the concerning htmlspecialchars invocation and changed the formatting.

Re: [aur-dev] [PATCH] Add Arabic translation

2015-06-25 Thread Lukas Fleischer
On Thu, 25 Jun 2015 at 11:20:54, Safa Alfulaij wrote: [...] For example, Notify is used in both table header and action combobox. Each should be translated in a different way, noun (header) and verb (action). (Almost these are the most problematic strings). Well, technically, Notify isn't a

Re: [aur-dev] [PATCH 1/4] git: Use AUR_USER env var instead of ForceCommand argument

2015-06-23 Thread Lukas Fleischer
On Tue, 23 Jun 2015 at 00:00:18, Johannes Löthberg wrote: Also add an utility function for formatting the ForceCommand Missing punctuation :) Signed-off-by: Johannes Löthberg johan...@kyriasis.com --- git-interface/git-auth.py | 18 -- git-interface/git-serve.py | 2 +-

Re: [aur-dev] [PATCH 3/4] git-serve: Drop direct AccountType checking, use AUR_PRIVILEGED

2015-06-23 Thread Lukas Fleischer
On Tue, 23 Jun 2015 at 00:00:20, Johannes Löthberg wrote: Signed-off-by: Johannes Löthberg johan...@kyriasis.com --- git-interface/git-serve.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/git-interface/git-serve.py b/git-interface/git-serve.py index

Re: [aur-dev] [PATCH v3 2/5] git: Use AUR_USER env var instead of ForceCommand argument

2015-06-23 Thread Lukas Fleischer
On Tue, 23 Jun 2015 at 12:26:35, Johannes Löthberg wrote: Also add an utility function for formatting the ForceCommand, using shlex.quote to quote the value. Manually replacing '\' with '\\' is required under OpenSSH due to it replacing `\` with ``, which breaks any command part that

Re: [aur-dev] [PATCH v3 3/5] git-auth: Set AUR_PRIVILEGED env var for TUs devs

2015-06-23 Thread Lukas Fleischer
On Tue, 23 Jun 2015 at 12:26:36, Johannes Löthberg wrote: Signed-off-by: Johannes Löthberg johan...@kyriasis.com --- git-interface/git-auth.py | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/git-interface/git-auth.py b/git-interface/git-auth.py index

[aur-dev] [PATCH] Remove can_submit_blacklisted()

2015-06-20 Thread Lukas Fleischer
This function is unneeded since commit 74edb6f (Use Git repositories to store packages, 2014-06-06). Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- web/lib/credentials.inc.php | 2 -- web/lib/pkgfuncs.inc.php| 12 2 files changed, 14 deletions(-) diff --git a/web

Re: [aur-dev] [PATCH v2] Remove hostname from URLPath in JSON RPC

2015-06-19 Thread Lukas Fleischer
On Fri, 19 Jun 2015 at 10:16:47, Mikkel Oscar Lyderik wrote: Prior to aur4, URLPath in the JSON RPC didn't include the hostname, only the path. This removes the hostname and make aur4 compatible with programs expecting the old semantics (e.i. cower) Closes FS#45333 ---

Re: [aur-dev] [PATCH] Redirect at previous page after a successful login

2015-06-19 Thread Lukas Fleischer
On Fri, 19 Jun 2015 at 15:50:57, Marcel Korpel wrote: * Lukas Fleischer lfleisc...@archlinux.org (Fri, 19 Jun 2015 15:04:14 +0200): + input id=id_referer type=hidden name=referer value=?= !empty($_SERVER['HTTP_REFERER']) ? $_SERVER['HTTP_REFERER

Re: [aur-dev] [PATCH] Remove hostname from URLPath in JSON RPC

2015-06-18 Thread Lukas Fleischer
On Thu, 18 Jun 2015 at 22:46:45, Mikkel Oscar Lyderik wrote: [...] If it is intentional that it should be possible to use a different domain then we can just drop this. However, then the documentation for the JSON RPC should be updated instead to reflect this change, I don't know what the

Re: [aur-dev] [PATCH] Improve INSTALL details for nginx and config

2015-06-18 Thread Lukas Fleischer
On Wed, 17 Jun 2015 at 23:40:43, Leonidas Spyropoulos wrote: Signed-off-by: Leonidas Spyropoulos artafi...@gmail.com --- INSTALL | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/INSTALL b/INSTALL index 9040c17..78d041a 100644 --- a/INSTALL

Re: [aur-dev] [PATCH v6] pkg_details.php: Show keywords

2015-06-18 Thread Lukas Fleischer
On Thu, 18 Jun 2015 at 00:57:14, Marcel Korpel wrote: Keywords are hyperlinked so a user can search for other packages with the same name and/or keyword. Nice addition, thanks! Signed-off-by: Marcel Korpel marcel.kor...@gmail.com --- Small improvement to make the focus border stick out of

Re: [aur-dev] [PATCH] Improve INSTALL details for nginx and config.

2015-06-17 Thread Lukas Fleischer
On Wed, 17 Jun 2015 at 13:07:50, Marcel Korpel wrote: * Lukas Fleischer lfleisc...@archlinux.org (Wed, 17 Jun 2015 10:26:38 +0200): [...] Ah! I thought you said that these lines should be outside of the server block, but this is much better! No, just outside the location block

Re: [aur-dev] [PATCH] Improve INSTALL details for nginx and config.

2015-06-17 Thread Lukas Fleischer
On Tue, 16 Jun 2015 at 23:29:22, Leonidas Spyropoulos wrote: Signed-off-by: Leonidas Spyropoulos artafi...@gmail.com --- INSTALL | 39 +-- 1 file changed, 33 insertions(+), 6 deletions(-) diff --git a/INSTALL b/INSTALL index 9040c17..d78740a 100644 ---

Re: [aur-dev] [PATCH 1/2] Merge user ids in CommentNotify

2015-06-17 Thread Lukas Fleischer
On Wed, 17 Jun 2015 at 02:08:19, Marcel Korpel wrote: Fixes FS#27687. Signed-off-by: Marcel Korpel marcel.kor...@gmail.com --- web/lib/pkgbasefuncs.inc.php | 18 ++ 1 file changed, 18 insertions(+) diff --git a/web/lib/pkgbasefuncs.inc.php b/web/lib/pkgbasefuncs.inc.php

[aur-dev] [PATCH] Clarify that HTTPs clone URIs are for read-only access

2015-06-17 Thread Lukas Fleischer
Fixes FS#45335. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- web/template/pkg_details.php | 2 +- web/template/pkgbase_details.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/web/template/pkg_details.php b/web/template/pkg_details.php index ae49e24

Re: [aur-dev] Difficulties setting up local aurweb server

2015-06-16 Thread Lukas Fleischer
On Tue, 16 Jun 2015 at 13:32:40, Marcel Korpel wrote: * Marcel Korpel marcel.kor...@gmail.com (Tue, 16 Jun 2015 11:55:36 +0200): Also, when going to /packages/, I get a 404 and the log says that the server is looking for /packages/index.php, so there's clearly something wrong with URL

Re: [aur-dev] [PATCH] Update french translation

2015-06-16 Thread Lukas Fleischer
On Tue, 16 Jun 2015 at 11:12:54, Xorg wrote: Hi. Because I'm not a member of french team on Transifex, I can't push the updated translation on Transifex. This is my first patch-send on a mailing-list, sorry if I'm wrong. I added you to the French team on Transifex. You should be able to

[aur-dev] [PATCH] Store 10 significant digits of the popularity score

2015-06-15 Thread Lukas Fleischer
Even if we only display two digits after the decimal point, storing more digits internally allows us to order the search results more accurately. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- schema/aur-schema.sql | 2 +- upgrading/4.0.0.txt | 2

Re: [aur-dev] [PATCH] Add explanation for Popularity field in search results.

2015-06-15 Thread Lukas Fleischer
On Mon, 15 Jun 2015 at 10:45:19, Leonidas Spyropoulos wrote: Fixes FS#45327 Clarification: We do not end the commit title with a full stop. Only sentences in the detailed description below. What I meant is that the commit message should look like Add explanation for Popularity field in

Re: [aur-dev] Difficulties setting up local aurweb server

2015-06-15 Thread Lukas Fleischer
On Mon, 15 Jun 2015 at 23:32:12, Marcel Korpel wrote: [...] But now I get a 404 when trying to access a (simple) PHP script on localhost: and the Primary script unknown message in my log. Move the root and index directives out of the location block (directly under the server block).

Re: [aur-dev] [PATCH] Add help cursor for Popularity field hover.

2015-06-15 Thread Lukas Fleischer
On Mon, 15 Jun 2015 at 22:26:00, Leonidas Spyropoulos wrote: Signed-off-by: Leonidas Spyropoulos artafi...@gmail.com --- web/html/css/aurweb.css | 1 + 1 file changed, 1 insertion(+) diff --git a/web/html/css/aurweb.css b/web/html/css/aurweb.css index 5394281..346f2ea 100644 ---

Re: [aur-dev] Difficulties setting up local aurweb server

2015-06-15 Thread Lukas Fleischer
On Mon, 15 Jun 2015 at 22:42:40, Marcel Korpel wrote: Hi, I tried to setup an nginx server locally for testing aurweb, but I encountered several difficulties. I wanted to start with a clean setup, so first, I deleted the aur user in my system and database and the AUR database in MySQL,

Re: [aur-dev] [PATCH] Fix name

2015-06-15 Thread Lukas Fleischer
On Mon, 15 Jun 2015 at 02:10:53, Giovanni Scafora wrote: Signed-off-by: Giovanni Scafora giova...@archlinux.org --- AUTHORS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AUTHORS b/AUTHORS index 8bcbfaf..6be7759 100644 --- a/AUTHORS +++ b/AUTHORS @@ -66,7 +66,7 @@

Re: [aur-dev] [PATCH] Add explanation for Popularity field in search results

2015-06-15 Thread Lukas Fleischer
Thanks, looks better than the initial submission! Some comments below. On Sun, 14 Jun 2015 at 23:29:34, Leonidas Spyropoulos wrote: Fixes FS#45327 We usually end sentences (and half sentences) with a full stop in the commit message body. I know this seems really nit-picky but I thought I'd

[aur-dev] [PATCH] Split keywords at commas and semicolons

2015-06-14 Thread Lukas Fleischer
Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- web/html/pkgbase.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/html/pkgbase.php b/web/html/pkgbase.php index ac50888..5179d0c 100644 --- a/web/html/pkgbase.php +++ b/web/html/pkgbase.php @@ -97,7 +97,7

[aur-dev] [PATCH 2/2] Show co-maintainers next to maintainers in details

2015-06-14 Thread Lukas Fleischer
Implements FS#45313. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- web/lib/aur.inc.php | 25 + web/template/pkg_details.php | 3 ++- web/template/pkgbase_details.php | 3 ++- 3 files changed, 29 insertions(+), 2 deletions(-) diff --git

Re: [aur-dev] [PATCH 2/3] confparser: Add function for checking if config key exists

2015-06-14 Thread Lukas Fleischer
On Sun, 14 Jun 2015 at 13:32:38, Johannes Löthberg wrote: Signed-off-by: Johannes Löthberg johan...@kyriasis.com --- web/lib/confparser.inc.php | 7 +++ 1 file changed, 7 insertions(+) diff --git a/web/lib/confparser.inc.php b/web/lib/confparser.inc.php index ae862d3..09fee5a 100644

[aur-dev] [PATCH v2] Replace categories with keywords

2015-06-14 Thread Lukas Fleischer
Remove package base categories. Instead, users can now specify up to twenty custom keywords that are taken into consideration when searching. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- Fixed the RPC interface. schema/aur-schema.sql | 44 --- upgrading

Re: [aur-dev] [PATCH] Adding PackagerUID to the generated dummy data

2015-06-14 Thread Lukas Fleischer
Minor nit: We usually write commit message in imperative mood. Also, there is no need to add a cover letter when you only submit a single patch. On Sun, 14 Jun 2015 at 17:36:52, Leonidas Spyropoulos wrote: --- schema/gendummydata.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

Re: [aur-dev] [PATCH v2] footer: Link version number to release log

2015-06-14 Thread Lukas Fleischer
On Sun, 14 Jun 2015 at 19:11:47, Johannes Löthberg wrote: Fixes FS#45321 Signed-off-by: Johannes Löthberg johan...@kyriasis.com --- Add ENT_QUOTES to htmlspecialchars web/template/footer.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) [...] Applied, thanks!

[aur-dev] [PATCH v4 4/5] home: Add submitting packages section

2015-06-14 Thread Lukas Fleischer
From: Johannes Löthberg johan...@kyriasis.com Link to the ArchWiki and lists any SSH fingerprints configured in the AUR configuration file. Fixes FS#45322. Signed-off-by: Johannes Löthberg johan...@kyriasis.com Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- web/html/home.php | 22

[aur-dev] [PATCH v4 2/5] confparser: Add function for checking if config section exists

2015-06-14 Thread Lukas Fleischer
From: Johannes Löthberg johan...@kyriasis.com Signed-off-by: Johannes Löthberg johan...@kyriasis.com Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- web/lib/confparser.inc.php | 7 +++ 1 file changed, 7 insertions(+) diff --git a/web/lib/confparser.inc.php b/web/lib

[aur-dev] [PATCH v4 5/5] config.proto: Add sample fingerprints section

2015-06-14 Thread Lukas Fleischer
From: Johannes Löthberg johan...@kyriasis.com Signed-off-by: Johannes Löthberg johan...@kyriasis.com Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- conf/config.proto | 5 + 1 file changed, 5 insertions(+) diff --git a/conf/config.proto b/conf/config.proto index 628dac3..25c8830

[aur-dev] [PATCH v4 0/5] Fix FS#45322

2015-06-14 Thread Lukas Fleischer
This is a reroll of Johannes's recent patch series that fixes FS#45322. I did change a couple of minor things, so I am submitting this for review. Johannes Löthberg (5): confparser: Split loading of config into own function confparser: Add function for checking if config section exists

[aur-dev] [PATCH v3] Replace categories with keywords

2015-06-14 Thread Lukas Fleischer
Remove package base categories. Instead, users can now specify up to twenty custom keywords that are taken into consideration when searching. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- * Split keywords at commas and semicolons. * Fix FS#45328. schema/aur-schema.sql

Re: [aur-dev] [PATCH] Add explanation for Popularity feild in search results Fixes FS#45327

2015-06-14 Thread Lukas Fleischer
s/feild/field/ in the commit message. Also, please move the Fixes FS#45327 to a separate paragraph. On Sun, 14 Jun 2015 at 19:43:39, Leonidas Spyropoulos wrote: Signed-off-by: Leonidas Spyropoulos artafi...@gmail.com --- web/template/pkg_search_results.php | 2 +- 1 file changed, 1

Re: [aur-dev] Prepared statements, was: Re: [PATCH] Adding PackagerUID to the generated dummy data

2015-06-14 Thread Lukas Fleischer
On Sun, 14 Jun 2015 at 20:39:20, Marcel Korpel wrote: * Lukas Fleischer lfleisc...@archlinux.org (Sun, 14 Jun 2015 17:45:24 +0200): Wow. This part of the code is really ugly. Using %s for integer values and not escaping strings in queries. I wonder if somebody cares enough to rewrite

[aur-dev] [PATCH] Make Learn more... translatable

2015-06-13 Thread Lukas Fleischer
Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- web/html/home.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/html/home.php b/web/html/home.php index 569f322..6b54af3 100644 --- a/web/html/home.php +++ b/web/html/home.php @@ -41,7 +41,7 @@ html_header

[aur-dev] [PATCH] Replace categories with keywords

2015-06-13 Thread Lukas Fleischer
Remove package base categories. Instead, users can now specify up to twenty custom keywords that are taken into consideration when searching. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- schema/aur-schema.sql | 44 --- upgrading/4.0.0.txt

Re: [aur-dev] [PATCH/RFC] git-update: Replace aurinfo.py with python-srcinfo

2015-06-13 Thread Lukas Fleischer
On Sat, 13 Jun 2015 at 17:13:13, Johannes Löthberg wrote: python-srcinfo is a more transparent and simpler library for parsing SRCINFO files. Signed-off-by: Johannes Löthberg johan...@kyriasis.com --- This patch has not been tested yet so should not be merged git-interface/aurinfo.py

Re: [aur-dev] [PATCH/RFC] git-update: Replace aurinfo.py with python-srcinfo

2015-06-13 Thread Lukas Fleischer
On Sat, 13 Jun 2015 at 18:42:21, Johannes Löthberg wrote: [...] I think you replied to the wrong email, or did you test this out already? :p Whoops, you're right. I applied the bug fix for space indents! -- Sincerely, Johannes Löthberg PGP Key ID: 0x50FB9B273A9D0BB5

Re: [aur-dev] [PATCH] False 'File Request' buttons for unconfirmed users

2015-06-12 Thread Lukas Fleischer
On Thu, 11 Jun 2015 at 00:35:59, Gordian Edenhofer wrote: On Wed, 2015-06-10 at 20:45 +0200, Marcel Korpel wrote: * Gordian Edenhofer gordian.edenho...@gmail.com (Wed, 10 Jun 2015 19:56:12 +0200): Displaying flag, notify, vote and file requet buttons for users which did not authenticate

[aur-dev] [PATCH] Improve the regular expression to match HTTP clones

2015-06-12 Thread Lukas Fleischer
Specifically check for URIs git-http-backend(1) can handle. This also allows us to make the .git suffix optional. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- INSTALL | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/INSTALL b/INSTALL index a2a6153..9040c17

Re: [aur-dev] What should AURv4 helpers do to get packages?

2015-06-11 Thread Lukas Fleischer
On Thu, 11 Jun 2015 at 07:12:03, Rémy Marquis wrote: On 10 Jun 2015 20:05, Lukas Fleischer lfleisc...@archlinux.org wrote: On Wed, 10 Jun 2015 at 07:52:09, Lukas Fleischer wrote: On Wed, 10 Jun 2015 at 04:30:15, Rémy Marquis wrote: [...] Some AUR helpers (cower, aurget

[aur-dev] [PATCH] Reintroduce the URLPath field

2015-06-11 Thread Lukas Fleischer
In commit 74edb6f (Use Git repositories to store packages, 2014-06-06), the URLPath field was dropped from RPC package results. Reintroduce the field for backwards compatibility, even though it is no longer recommended to use the snapshot tarballs. Signed-off-by: Lukas Fleischer lfleisc

[aur-dev] [PATCH] Make URIs to the individual cgit pages configurable

2015-06-11 Thread Lukas Fleischer
Make the locations of the PKGBUILD preview, the log and the snapshot tarball configurable. This increases flexibility and simplifies the code a bit. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- conf/config.proto| 4 +++- web/template/pkg_details.php | 10

[aur-dev] [PATCH 1/2] git-update: Deny non-fast-forwards

2015-06-11 Thread Lukas Fleischer
To make sure we never lose any history, non-fast-forwards are forbidden. Instead of relying on receive.denyNonFastForwards, add a simple check to the update hook. This has the added benefit of more flexibility. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- INSTALL

[aur-dev] [PATCH 2/4] Add a field for package base popularity

2015-06-11 Thread Lukas Fleischer
Create a new field Popularity in the PackageBases table. The field is updated by the popupdate script and reflects the popularity of a package. Popularity is the sum of all votes with each vote being weighted with a factor of 0.98 per day since its creation. Signed-off-by: Lukas Fleischer lfleisc

[aur-dev] [PATCH 1/4] Add popupdate script

2015-06-11 Thread Lukas Fleischer
This adds a simple script that can be used to recalculate the number of votes per package. It can be used in a cronjob. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- scripts/popupdate.py | 27 +++ 1 file changed, 27 insertions(+) create mode 100755 scripts

[aur-dev] [PATCH 4/4] Default to ordering packages by popularity

2015-06-11 Thread Lukas Fleischer
Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- web/html/packages.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/html/packages.php b/web/html/packages.php index 76f7563..75a574e 100644 --- a/web/html/packages.php +++ b/web/html/packages.php @@ -89,7 +89,7

[aur-dev] [PATCH] Implement a maintenance mode

2015-06-11 Thread Lukas Fleischer
Add support for a maintenance mode that disables both the website and the SSH interface and can be enabled easily using a configuration option. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- conf/config.proto | 1 + git-interface/git-serve.py | 5 + web/html/503.php

[aur-dev] [PATCH] Support exceptions in the maintenance mode

2015-06-11 Thread Lukas Fleischer
Allow for excluding certain IP addresses from the maintenance mode. This allows administrators to view the web page while the site is still under maintenance for the rest of the world. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- conf/config.proto | 1 + git-interface/git

[aur-dev] [PATCH] Do not use symrefs for manually created Git refs

2015-06-11 Thread Lukas Fleischer
received, this fixes a problem with dangling refs that were created when a user initialized a repository but did not push anything. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- git-interface/git-serve.py | 17 - git-interface/git-update.py | 10 ++ 2 files

[aur-dev] [PATCH] Redesign the home page

2015-06-11 Thread Lukas Fleischer
* Make the home page look even more like the archweb home page. * Add information on package requests. * Improve texts on discussion and bug reporting. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- web/html/css/aurweb.css | 4 web/html/home.php | 51

Re: [aur-dev] [PATCH] Autofocus input fields at login and package-search

2015-06-11 Thread Lukas Fleischer
On Fri, 12 Jun 2015 at 00:08:27, Gordian Edenhofer wrote: [...] Is it too optimistic to assume this patch might be included in AUR 4.0 or is it unlikely it will be added at this point? Thanks for bumping this thread. Your patch got lost in all the emails I had to deal with when returning

Re: [aur-dev] What should AURv4 helpers do to get packages?

2015-06-10 Thread Lukas Fleischer
On Wed, 10 Jun 2015 at 07:52:09, Lukas Fleischer wrote: On Wed, 10 Jun 2015 at 04:30:15, Rémy Marquis wrote: [...] Some AUR helpers (cower, aurget, ..) currently rely in this URLPath field for retrieving the correct tarball. It would be very useful to allow backward compatibility

[aur-dev] [PATCH] pkgbase.php: Escape error messages

2015-06-10 Thread Lukas Fleischer
Fixes FS#45284. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- web/html/pkgbase.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web/html/pkgbase.php b/web/html/pkgbase.php index 2f8f932..c834f8b 100644 --- a/web/html/pkgbase.php +++ b/web/html/pkgbase.php

[aur-dev] [PATCH] pkgbase_details.php: Fix cgit links

2015-06-09 Thread Lukas Fleischer
We forgot to amend those when switching to gitnamespaces-based storage in b44411f (Use gitnamespaces for efficient storage, 2015-06-01). Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- web/template/pkgbase_details.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[aur-dev] [PATCH] Encode cgit URIs properly

2015-06-09 Thread Lukas Fleischer
Fixes FS#45276 and FS#45277. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- web/template/pkg_details.php | 6 +++--- web/template/pkgbase_details.php | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/web/template/pkg_details.php b/web/template

[aur-dev] [PATCH] Invert order when sorting packages by age

2015-06-09 Thread Lukas Fleischer
Fixes FS#44195. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- web/lib/pkgfuncs.inc.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/lib/pkgfuncs.inc.php b/web/lib/pkgfuncs.inc.php index b467a3d..a5f24ba 100644 --- a/web/lib/pkgfuncs.inc.php +++ b/web/lib

[aur-dev] [PATCH] aurjson.class.php: Exclude hidden package bases

2015-06-09 Thread Lukas Fleischer
Do not return packages belonging to hidden package bases in RPC results. Fixes FS#45271. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- web/lib/aurjson.class.php | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/web/lib/aurjson.class.php b/web

Re: [aur-dev] What should AURv4 helpers do to get packages?

2015-06-09 Thread Lukas Fleischer
On Tue, 09 Jun 2015 at 16:52:52, Chris Warrick wrote: Hello, In AURv4, URLPath was removed due to the introduction of Git integration, which raises the question: what is the recommended way for AUR helpers to get packages? Should they: (a) manually generate a clone URL (/PKGBASE.git/) and

Re: [aur-dev] What should AURv4 helpers do to get packages?

2015-06-09 Thread Lukas Fleischer
On Wed, 10 Jun 2015 at 04:30:15, Rémy Marquis wrote: [...] Some AUR helpers (cower, aurget, ..) currently rely in this URLPath field for retrieving the correct tarball. It would be very useful to allow backward compatibility with the RPC interface v3, at least for the time being. How?

Re: [aur-dev] [PATCH] pkg_details: Use correct clone URL

2015-06-08 Thread Lukas Fleischer
On Mon, 08 Jun 2015 at 20:04:47, Johannes Löthberg wrote: The clone URLs should use the pkgbase name, not the pkgname itself Reported-by: Jonathan Steel jst...@archlinux.org Signed-off-by: Johannes Löthberg johan...@kyriasis.com --- web/template/pkg_details.php | 4 ++-- 1 file changed, 2

[aur-dev] [PATCH] git-update: Avoid duplicate notifications

2015-06-08 Thread Lukas Fleischer
Fixes FS#45254. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- git-interface/git-update.py | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/git-interface/git-update.py b/git-interface/git-update.py index 215848e..958fa7a 100755 --- a/git-interface/git

[aur-dev] aur4.archlinux.org is online

2015-06-08 Thread Lukas Fleischer
Hi, the AUR 4 setup at aur4.archlinux.org is now live. If you submitted your packages earlier today, please double-check that they are listed on the aur4.archlinux.org web interface. Regards, Lukas

[aur-dev] [PATCH] git-update: Increase maximum blob size to 250kB

2015-06-08 Thread Lukas Fleischer
Large blobs are needed in some packages, such as customized Linux kernels including kernel configurations. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- git-interface/git-update.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/git-interface/git-update.py b

Re: [aur-dev] [PATCH v2] Use extract_arch_fields when checking for source files

2015-06-08 Thread Lukas Fleischer
On Mon, 08 Jun 2015 at 13:01:35, Johannes Löthberg wrote: This fixes a bug where pushes are rejected in split PKGBUILDs if there are no arch-independent source array. Fixes FS#45253 Reported-by: Marti ma...@juffo.org Reported-by: Maxime Gauduin aluc...@archlinux.org Signed-off-by:

Re: [aur-dev] [PATCH] git-update: Drop writing git description file

2015-06-08 Thread Lukas Fleischer
On Mon, 08 Jun 2015 at 14:57:57, Johannes Löthberg wrote: All PKGBUILDs are stored in a single repository now, so there is no use for writing out a description file for the repo anymore. This fixes a bug where pkgdescs containing UTF-8 characters are rejected due to it trying to write the

[aur-dev] [PATCH] git-update: Improve error message for non-blob objects

2015-06-08 Thread Lukas Fleischer
' object has no attribute 'size' remote: error: hook declined to update refs/heads/master Explicitly check for directories and other non-blob objects and display a more intuitive message. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- git-interface/git-update.py | 11 ++- 1

[aur-dev] [PATCH] Fix package statistics

2015-06-08 Thread Lukas Fleischer
Exclude hidden package bases from the package statistics. Reported-by: Johannes Löthberg johan...@kyriasis.com Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- web/lib/stats.inc.php | 34 ++ 1 file changed, 26 insertions(+), 8 deletions(-) diff --git

[aur-dev] [PATCH 2/2] git-update: Prevent from overwriting packages

2015-06-04 Thread Lukas Fleischer
Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- git-interface/git-update.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/git-interface/git-update.py b/git-interface/git-update.py index 34633e8..047ac9b 100755 --- a/git-interface/git-update.py +++ b/git

[aur-dev] [PATCH 1/2] git-update: Only check HEAD for blacklisted packages

2015-06-04 Thread Lukas Fleischer
When a part of a package base is moved to the official repositories, it needs to be dropped from the AUR package. However, we want to allow that the moved packages still appear in the history. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- git-interface/git-update.py | 10

[aur-dev] [PATCH v2] git-update: Prevent from overwriting packages

2015-06-04 Thread Lukas Fleischer
Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- Fix the prepared statement and the handling of the query results. git-interface/git-update.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/git-interface/git-update.py b/git-interface/git-update.py index

[aur-dev] [PATCH] cgitrc.proto: Fix clone prefix

2015-06-04 Thread Lukas Fleischer
Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- conf/cgitrc.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/conf/cgitrc.proto b/conf/cgitrc.proto index 1322f93..cb77367 100644 --- a/conf/cgitrc.proto +++ b/conf/cgitrc.proto @@ -1,5 +1,5 @@ virtual-root=/cgit

[aur-dev] [PATCH] aurblup: Fix path to configuration file

2015-06-03 Thread Lukas Fleischer
Fixes a regression introduced in commit 10ecd39 (Restructure scripts, 2015-06-01). Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- scripts/aurblup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/aurblup.py b/scripts/aurblup.py index e678fee..d6d0c3c

[aur-dev] [PATCH] pkgfuncs.inc.php: Remove a conflict marker

2015-06-03 Thread Lukas Fleischer
Remove a Git conflict marker that was added accidentally in 74edb6f (Use Git repositories to store packages, 2014-06-06). Reported-by: Helped-by: Johannes Löthberg johan...@kyriasis.com Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- web/lib/pkgfuncs.inc.php | 1 - 1 file changed, 1

[aur-dev] [PATCH] git-update: Only check HEAD for matching pkgbase

2015-06-03 Thread Lukas Fleischer
When renaming a package base, we want to keep commits of the former package. Move the check that compares the package base name with the repository name such that only HEAD is validated. Fixes FS#45065. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- git-interface/git-update.py | 7

[aur-dev] [PATCH v2] Restructure scripts

2015-06-02 Thread Lukas Fleischer
* Move scripts/git-integration/ to git-interface/. * Move scripts/aurblup/aurblup.py to scripts/aurblup.py. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- INSTALL | 4 ++-- conf/config.proto| 8

[aur-dev] [PATCH] Add a Makefile for the git-auth wrapper

2015-06-02 Thread Lukas Fleischer
Avoid manual editing of the wrapper script when a non-standard path is used. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- INSTALL | 3 +-- git-interface/Makefile | 18 ++ git-interface/config.mk | 1 + git-interface/git-auth.sh

[aur-dev] [PATCH] Setup Git repositories even if package base exists

2015-06-02 Thread Lukas Fleischer
-by: Lukas Fleischer lfleisc...@archlinux.org --- git-interface/git-serve.py | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/git-interface/git-serve.py b/git-interface/git-serve.py index eebb087..fce766a 100755 --- a/git-interface/git-serve.py +++ b/git

[aur-dev] [PATCH] config.proto: Cleanup

2015-06-02 Thread Lukas Fleischer
Remove the template-path and git-update-hook options which are no longer used. Update the git_clone_uri_anon default value. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- conf/config.proto | 4 +--- git-interface/git-serve.py | 1 - 2 files changed, 1 insertion(+), 4

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-06-01 Thread Lukas Fleischer
On Mon, 01 Jun 2015 at 00:48:23, Gordian Edenhofer wrote: [...] Having a dummy file in the git repo and the true file for the checksum is somewhat odd. Using SKIP is also not a true alternative IMHO. True. Missing source files are somewhat odd, too, though. You could argue that pretending to

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-06-01 Thread Lukas Fleischer
On Mon, 01 Jun 2015 at 15:09:43, Gordian Edenhofer wrote: [...] This kind of check would see files which are named e.g. lp:foo as not missing even if they are. Sure, we only check local files and lp:foo is a remote file. Checking remote sources is something that we cannot do

[aur-dev] [PATCH] Use gitnamespaces for efficient storage

2015-06-01 Thread Lukas Fleischer
a branch for each package, allowing to browse the large repository with cgit. Helped-by: Florian Pritz bluew...@xinu.at Helped-by: Johannes Löthberg johan...@kyriasis.com Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- INSTALL | 33 ++-- conf

[aur-dev] [PATCH v2] git-update: Check for missing install and source files

2015-06-01 Thread Lukas Fleischer
Suggested-by: Marcel Korpel marcel.kor...@gmail.com Suggested-by: carstene1ns a...@carsten-teibes.de Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- scripts/git-integration/git-update.py | 11 +++ 1 file changed, 11 insertions(+) diff --git a/scripts/git-integration/git

[aur-dev] [PATCH] Restructure scripts

2015-06-01 Thread Lukas Fleischer
* Move scripts/git-integration/ to git-interface/. * Move scripts/aurblup/aurblup.py to scripts/aurblup.py. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- {scripts/git-integration = git-interface}/aurinfo.py| 0 {scripts/git-integration = git-interface}/git-auth.py | 0

[aur-dev] [PATCH] git-update: Check for missing install and source files

2015-05-31 Thread Lukas Fleischer
Suggested-by: Marcel Korpel marcel.li...@gmail.com Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- scripts/git-integration/git-update.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/scripts/git-integration/git-update.py b/scripts/git-integration/git-update.py index

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-05-31 Thread Lukas Fleischer
On Sun, 31 May 2015 at 20:14:22, Daniel Wallace wrote: How does this affect stuff like the different humble bundle games in the aur? You have to download the source and put it in the source directory so I don't think it will be in the commit tree? [...] Good question. There are two

[aur-dev] [PATCH 1/3] Allow for resetting the SSH public key

2015-05-31 Thread Lukas Fleischer
Use NULL instead of an empty string if the SSH public key field is left empty. Additionally, do not check for duplicate keys in that case. Fixes FS#45109. Signed-off-by: Lukas Fleischer lfleisc...@archlinux.org --- web/lib/acctfuncs.inc.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-05-31 Thread Lukas Fleischer
On Sun, 31 May 2015 at 22:09:19, Marcel Korpel wrote: * Daniel Wallace danielwall...@gtmanfred.com (Sun, 31 May 2015 14:33:38 -0500): The names usually end in 'hib' instead of humble bundle, standing for Humble Indie Bundle, but there are several other things out there that are similar to

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-05-31 Thread Lukas Fleischer
On Mon, 01 Jun 2015 at 00:07:58, Marcel Korpel wrote: * Lukas Fleischer lfleisc...@archlinux.org (Sun, 31 May 2015 22:49:19 +0200): On Sun, 31 May 2015 at 22:09:19, Marcel Korpel wrote: Nevertheless, there are other cases I didn't think of, like https://aur.archlinux.org/packages/ttf-ms

Re: [aur-dev] [PATCH] git-update: Check for missing install and source files

2015-05-31 Thread Lukas Fleischer
On Mon, 01 Jun 2015 at 00:00:31, Gordian Edenhofer wrote: [...] Why are checksums an issue? You can use the checksum of the correct file. It doesn't match the checksum of the dummy file but I don't see how that is an issue (it is even good since the user immediately notices that

Re: [aur-dev] [PATCH] Autofocus username input field at login screen

2015-05-27 Thread Lukas Fleischer
On Wed, 27 May 2015 at 10:34:44, Gordian Edenhofer wrote: [...] We use XHTML 1.0, not HTML5. It probably works in most browsers anyway but we should at least use 'autofocus=autofocus' for XHTML compliance and mention it in the commit message. Sorry, I forgot about that! Shell I

Re: [aur-dev] Some notes on AUR 4.0.0

2015-05-27 Thread Lukas Fleischer
On Tue, 26 May 2015 at 13:33:58, Lukas Fleischer wrote: Hi, As Florian already mentioned in another email, I am away until June 1st. I am on a roaming data plan, so I won't be able to reply to all the feedback and questions on the new AUR until then. I hope that I am going to address

Re: [aur-dev] [PATCH] Autofocus username input field at login screen

2015-05-27 Thread Lukas Fleischer
On Sun, 24 May 2015 at 22:51:19, Gordian Edenhofer wrote: At the login page, the user is promted for the username and the corresponding password. At this point the user is required to click the field in which he should place the input. This can be easily simplified with HTML5 using the

[aur-dev] Some notes on AUR 4.0.0

2015-05-26 Thread Lukas Fleischer
Hi, As Florian already mentioned in another email, I am away until June 1st. I am on a roaming data plan, so I won't be able to reply to all the feedback and questions on the new AUR until then. I hope that I am going to address at least some of the concerns and questions here, though. For the

<    2   3   4   5   6   7   8   9   10   11   >