[aur-dev] [PATCH 3/4] pkgsubmit.php: Style fixes

2014-05-06 Thread Lukas Fleischer
Move some elseif statements to the same line as the closing brace. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/pkgsubmit.php | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php index 7b7023b

[aur-dev] [PATCH 4/4] Check permissions when uploading source packages

2014-05-06 Thread Lukas Fleischer
All files contained in the source tarball must have permissions of 644 or 755. All directories must have permissions of 755. Implements FS#27754. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/pkgsubmit.php | 6 ++ 1 file changed, 6 insertions(+) diff --git a/web/html

[aur-dev] [PATCH] Set language using a POST request

2014-05-13 Thread Lukas Fleischer
Fixes FS#39027. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/translator.inc.php | 4 ++-- web/template/header.php| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/web/lib/translator.inc.php b/web/lib/translator.inc.php index 1070183..5117b99 100644

Re: [aur-dev] [PATCH] Add threading headers to notification mail

2014-05-18 Thread Lukas Fleischer
On Sat, 17 May 2014 at 14:30:36, Thomas Weißschuh wrote: It is only basic, but works in this way for other platforms. Could be enhanced to include all previous comments in 'References:' This would require to have predictable 'Message-ID:' for notification mails. Could also be used for out of

Re: [aur-dev] [PATCH v2] Add threading headers to notification mail

2014-05-20 Thread Lukas Fleischer
On Tue, 20 May 2014 at 20:42:53, Thomas Weißschuh wrote: It is only basic, but works in this way for other platforms. It works because MUAs are able to reconstruct threads originating from mails they don't know about (unknown Message-ID). This has some drawbacks: * MUAs might show the

[aur-dev] [PATCH] Avoid overflow in updates table

2014-05-22 Thread Lukas Fleischer
Fixes FS#40206. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/css/aur.css | 19 +++ web/template/stats/updates_table.php | 2 +- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/web/html/css/aur.css b/web/html/css/aur.css

[aur-dev] [PATCH] acctfuncs.inc.php: Fix typo

2014-05-22 Thread Lukas Fleischer
-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/acctfuncs.inc.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php index 5b907dc..962ebb4 100644 --- a/web/lib/acctfuncs.inc.php +++ b/web/lib/acctfuncs.inc.php

[aur-dev] [PATCH 2/2] UPGRADING: Create foreign key after modifying column

2014-05-27 Thread Lukas Fleischer
We cannot change a column after creating a foreign key: ERROR 1832 (HY000): Cannot change column 'PackageBaseID': used in a foreign key constraint 'Packages_ibfk_1' Delay the ADD FOREIGN KEY command to fix this. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- UPGRADING | 6

[aur-dev] [PATCH 1/2] UPGRADING: Add missing column to the instructions

2014-05-27 Thread Lukas Fleischer
Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- UPGRADING | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/UPGRADING b/UPGRADING index d9860bb..71b3d1d 100644 --- a/UPGRADING +++ b/UPGRADING @@ -50,8 +50,9 @@ CREATE TABLE PackageBases ( 4. Migrate data from

[aur-dev] AUR 3.0.0 released

2014-05-27 Thread Lukas Fleischer
Hello, I am pleased to announce that AUR 3.0.0 has just been released. The official AUR setup [1] has already been updated. Note that in order to build source packages for the AUR, you will now need to use a tool called mkaurball (instead of `makepkg --source`). It is included in the

[aur-dev] [PATCH 1/2] Move latest_pkgs() to pkgfuncs.inc.php

2014-05-29 Thread Lukas Fleischer
Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/aur.inc.php | 24 web/lib/pkgfuncs.inc.php | 24 2 files changed, 24 insertions(+), 24 deletions(-) diff --git a/web/lib/aur.inc.php b/web/lib/aur.inc.php index ff46455

[aur-dev] [PATCH 2/2] pkgfuncs.inc.php: Fix latest_pkgs()

2014-05-29 Thread Lukas Fleischer
This fixes a regression introduced when adding split package support and makes the RSS feed work again. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/pkgfuncs.inc.php | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/web/lib/pkgfuncs.inc.php b/web

Re: [aur-dev] [aur-general] AUR 3.0.0 released

2014-05-29 Thread Lukas Fleischer
On Thu, 29 May 2014 at 10:52:58, Andreas Radke wrote: [...] The RSS feed seems empty. Fixed in maint. Thanks! -Andy

[aur-dev] [PATCH] Accept upper case letters in valid_username()

2014-05-30 Thread Lukas Fleischer
expression validating the name to do case-insensitive pattern matching. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/acctfuncs.inc.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php index 962ebb4

Re: [aur-dev] mismatched AUR IDs

2014-05-31 Thread Lukas Fleischer
Hi Xyne, On Sat, 31 May 2014 at 04:29:21, Xyne wrote: Hi, I'm in the process of updating python3-aur for the 3.0.0 release and I have come across a bug. The IDs of recently updated packages reported by the RPC interface are incorrect. For example, etmtk is currently listed in the Recent

[aur-dev] [PATCH] Add support for TU ninja edits

2014-05-31 Thread Lukas Fleischer
Trusted Users now have the ability to overwrite packages without changing ownership. This allows for adding small fixes to PKGBUILDs without disowning the package. Implements FS#32807. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/pkgsubmit.php | 10 -- web

[aur-dev] [PATCH] Add a Search wiki link to package details

2014-05-31 Thread Lukas Fleischer
Implements FS#33153. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/template/pkg_details.php | 1 + web/template/pkgbase_details.php | 1 + 2 files changed, 2 insertions(+) diff --git a/web/template/pkg_details.php b/web/template/pkg_details.php index 12aa692..b3d02ac

[aur-dev] Git repositories for AUR packages

2014-06-02 Thread Lukas Fleischer
Hi list, The next major AUR release will come with Git integration. In this email, I am going to summarize previous ideas and make things a bit more concrete (sketch implementation details etc.) If you are new to this topic, please read [1] and [2] first. Our plan is to create one Git

Re: [aur-dev] Git repositories for AUR packages

2014-06-04 Thread Lukas Fleischer
On Wed, 04 Jun 2014 at 22:16:40, William Giokas wrote: [...] I am very much for this (and [1] is one of my mails from more than a year ago). I would recommend working with gitolite so that we can keep as much of the code we need maintained upstream, as gitolite has already proven its security

[aur-dev] [PATCH] Collapse long source lists

2014-06-04 Thread Lukas Fleischer
In commit e582cfe (Collapse long dependency lists, 2014-04-18), we added code to automatically collapse dependency and requirement lists with more than 20 entries. Add the same functionality to source lists. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/packages.php

[aur-dev] [PATCH] Display versioned conflicts/provides/replaces

2014-06-05 Thread Lukas Fleischer
Show the specific conflicts/provides/replaces versions in the web interface. Implements FS#40699. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/template/pkg_details.php | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/web/template

[aur-dev] [PATCH] Increase the size of several database fields

2014-06-05 Thread Lukas Fleischer
Several fields turned out to be too small (e.g. when long package versions are used in VCS packages). Since the type of all affected fields is VARCHAR, there is no reason to keep them as small as possible. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- UPGRADING | 17

[aur-dev] [PATCH 1/2] Fix links to AUR packages in optional dependencies

2014-06-05 Thread Lukas Fleischer
Extend the SQL query that tries to find a package's dependencies so that optional dependencies with a description are correctly resolved. Fixes FS#40700. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/pkgfuncs.inc.php | 1 + 1 file changed, 1 insertion(+) diff --git a/web

[aur-dev] [PATCH 2/2] Fix SQL query when searching for a missing submitter

2014-06-05 Thread Lukas Fleischer
uid_from_username() returns a non-integer value when the user does not exist. This results in a broken SQL query when searching for a nonexistent submitter. Fix this by explicitly converting the result of uid_from_username() to an integer. Fixes FS#40625. Signed-off-by: Lukas Fleischer archli

Re: [aur-dev] [PATCH] Add support for TU ninja edits

2014-06-05 Thread Lukas Fleischer
On Sat, 31 May 2014 at 15:18:20, Florian Pritz wrote: On 31.05.2014 12:04, Lukas Fleischer wrote: Trusted Users now have the ability to overwrite packages without changing ownership. This allows for adding small fixes to PKGBUILDs without disowning the package. This sounds like

Re: [aur-dev] [PATCH] aurjson: Add a PackageBaseID field

2014-06-05 Thread Lukas Fleischer
On Sun, 01 Jun 2014 at 20:27:39, Xyne wrote: On 2014-05-31 12:04 +0200 Lukas Fleischer wrote: This is useful to tools that automatically generate requests to orphan, delete or merge packages. Perfect, thanks! When do you plan to push the changes? This feature will be part of 3.1.0

Re: [aur-dev] Git repositories for AUR packages

2014-06-05 Thread Lukas Fleischer
Hi Rémy, On Tue, 03 Jun 2014 at 22:31:59, Rémy Marquis wrote: Thanks Lukas for the follow up, and also for the work achieved on AUR 3.0.0! Thanks! In order to submit new packages, you will be able to generate empty Git repositories via the AUR web interface. During the transition period,

[aur-dev] [PATCH 1/3] Do not return None in user functions

2014-06-05 Thread Lukas Fleischer
Return null instead of the string None in username_from_id(), uid_from_email() and uid_from_username(). Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/passreset.php | 2 +- web/lib/acctfuncs.inc.php | 2 +- web/lib/aur.inc.php | 44

[aur-dev] [PATCH 3/3] acctfuncs.inc.php: Fix indentation

2014-06-05 Thread Lukas Fleischer
Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/acctfuncs.inc.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php index f1776c0..06d4311 100644 --- a/web/lib/acctfuncs.inc.php +++ b/web/lib

[aur-dev] [PATCH 2/3] acctfuncs.inc.php: Reduce nesting in several functions

2014-06-05 Thread Lukas Fleischer
Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/acctfuncs.inc.php | 521 +++--- 1 file changed, 264 insertions(+), 257 deletions(-) diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php index a996561..f1776c0 100644

[aur-dev] AUR 3.1.0 released

2014-06-05 Thread Lukas Fleischer
Hello, I am pleased to announce that AUR 3.1.0 has just been released. The official AUR setup [1] has already been updated. This release includes several bug fixes, the RPC interface now reports package base IDs, long lists of source files are collapsed and a Search wiki link has been added to

[aur-dev] [PATCH/RFC 3/5] Add update hook template

2014-06-17 Thread Lukas Fleischer
This adds a script that can be used as an update hook to check all commits for validity and to regenerate the package details page before updating a named ref. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- scripts/git-integration/config.sample | 1 + scripts/git-integration/git

Re: [aur-dev] Git repositories for AUR packages

2014-06-24 Thread Lukas Fleischer
On Tue, 24 Jun 2014 at 09:20:08, 郑文辉 (Techlive Zheng) wrote: [...] So, this means, all the maintainers have to use git to submit packages? Any thought on keeping the old package submission form and proceed the commit process on the server? which will allow normal people to contribute

[aur-dev] [PATCH 1/6] Add support for filing package requests

2014-06-25 Thread Lukas Fleischer
is created and an email is sent to a configurable mailing list (defaults to aur-general). Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- UPGRADING| 31 ++ schema/aur-schema.sql| 28 + web/html/index.php | 3 ++ web

[aur-dev] [PATCH 6/6] Add support for merge requests

2014-06-25 Thread Lukas Fleischer
This adds a new Merge category to the list of available request types and also adds a new Merge into field that is hidden via JavaScript when Deletion or Orphan is selected. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- UPGRADING | 2 ++ schema/aur-schema.sql

[aur-dev] [PATCH 5/6] Add an accept button to the package request list

2014-06-25 Thread Lukas Fleischer
This button allows for accepting a request, disowning the affected package or redirecting to the package deletion page. The request is closed automatically when the action has been performed. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/pkgbase.php| 10

[aur-dev] [PATCH 3/6] Allow for closing package requests

2014-06-25 Thread Lukas Fleischer
This allows Trusted Users to close package requests via the request list. Also, entries are now sorted such that open requests are shown before closed requests. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- UPGRADING | 1 + schema/aur-schema.sql

[aur-dev] [PATCH] Make results consistent in RPC replies

2014-06-25 Thread Lukas Fleischer
Add RPC v3 which always returns a list of objects in RPC responses, regardless of the request type. An empty list is returned when an error occurs. The error message is moved to a separate error field. Fixes FS#40963. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib

[aur-dev] [PATCH 1/6] Allow regular users to file package requests

2014-06-25 Thread Lukas Fleischer
Move the permission check so that regular users can file requests, whereas the request list is only available to Trusted Users and developers. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/pkgreq.php | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

[aur-dev] [PATCH 3/6] Add threading headers to request notification mails

2014-06-25 Thread Lukas Fleischer
This allows for grouping mails that belong to the same request. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/pkgbasefuncs.inc.php | 4 1 file changed, 4 insertions(+) diff --git a/web/lib/pkgbasefuncs.inc.php b/web/lib/pkgbasefuncs.inc.php index 68dd656..bab8f4c

[aur-dev] [PATCH 2/6] Move package request form to a template

2014-06-25 Thread Lukas Fleischer
Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/pkgreq.php | 57 +--- web/template/pkgreq_form.php | 52 2 files changed, 53 insertions(+), 56 deletions(-) create mode 100644 web

[aur-dev] [PATCH 4/6] Send notification mail when closing a request

2014-06-25 Thread Lukas Fleischer
The mail is sent to the request mailing list and to the current package maintainer. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/pkgbasefuncs.inc.php | 45 1 file changed, 45 insertions(+) diff --git a/web/lib

[aur-dev] [PATCH 5/6] Prefix request notification mails with ID

2014-06-25 Thread Lukas Fleischer
Add a [PRQ#n] prefix to each package request notification mail. PRQ is an abbreviation for Package Request and n is replaced with the corresponding package request ID. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/pkgbasefuncs.inc.php | 11 +++ 1 file changed, 7

[aur-dev] [PATCH 6/6] Default to aur-requests for request notifications

2014-06-25 Thread Lukas Fleischer
Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/config.inc.php.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/lib/config.inc.php.proto b/web/lib/config.inc.php.proto index a9137f1..cb71fa5 100644 --- a/web/lib/config.inc.php.proto +++ b/web/lib

[aur-dev] [PATCH] Do not highlight closed requests

2014-06-29 Thread Lukas Fleischer
requests that have already been closed. Change the logic so that only *open* requests which are at least 14 days old are marked. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/template/pkgreq_results.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/template

Re: [aur-dev] [PATCH 2/6] Add a package request list

2014-07-01 Thread Lukas Fleischer
On Tue, 01 Jul 2014 at 18:37:46, Florian Pritz wrote: [...] I understand this is copied from pkg_search_page() in web/lib/pkgfuncs.inc.php, but now would be a good time to clean it up (in both places). Especially the usage of $_GET rather than a local variable should go away. Introduce

Re: [aur-dev] [PATCH 3/6] Allow for closing package requests

2014-07-01 Thread Lukas Fleischer
On Tue, 01 Jul 2014 at 18:42:09, Florian Pritz wrote: [...] + +/** + * Close a deletion/orphan request + * + * @param int $id The package request to close + * + * @return void You return an array, not void. Will send a patch to fix the documentation, thanks. + */

Re: [aur-dev] [PATCH 1/6] Add support for filing package requests

2014-07-01 Thread Lukas Fleischer
On Tue, 01 Jul 2014 at 18:50:33, Florian Pritz wrote: [...] + /* + * TODO: Add native language emails for users, based on their + * preferences. Simply making these strings translatable won't + * work, users would be getting emails in the language that the + *

[aur-dev] [PATCH 1/2] Split out package request functions

2014-07-01 Thread Lukas Fleischer
Move package request functions to a separate unit pkgreqfuncs.inc.php. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/pkgbasefuncs.inc.php | 186 +- web/lib/pkgreqfuncs.inc.php | 188 +++ 2

[aur-dev] [PATCH 1/2] Simplify code to bound integer values

2014-07-01 Thread Lukas Fleischer
Suggested-by: Florian Pritz bluew...@xinu.at Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/pkgreq.php | 10 ++ web/lib/aur.inc.php | 13 + web/lib/pkgfuncs.inc.php | 16 3 files changed, 19 insertions(+), 20 deletions(-) diff

[aur-dev] [PATCH] Fix broken indentation in pkgbase_delete_comment()

2014-07-01 Thread Lukas Fleischer
Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/pkgbasefuncs.inc.php | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/web/lib/pkgbasefuncs.inc.php b/web/lib/pkgbasefuncs.inc.php index ec48314..32c2d9b 100644 --- a/web/lib/pkgbasefuncs.inc.php

[aur-dev] [PATCH] Be explicit about accepted requests in emails

2014-07-01 Thread Lukas Fleischer
When sending notification emails after closing a request, be explicit about whether the request has been accepted or not. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/pkgbase.php | 2 +- web/lib/pkgbasefuncs.inc.php | 4 ++-- web/lib/pkgreqfuncs.inc.php | 7

[aur-dev] [PATCH] Fix documentation of pkgreq_*() return types

2014-07-01 Thread Lukas Fleischer
Reported-by: Florian Pritz bluew...@xinu.at Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/pkgreqfuncs.inc.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web/lib/pkgreqfuncs.inc.php b/web/lib/pkgreqfuncs.inc.php index 47758c3..69ba08d 100644

Re: [aur-dev] [PATCH] Fix documentation of pkgreq_*() return types

2014-07-01 Thread Lukas Fleischer
On Tue, 01 Jul 2014 at 20:09:30, Lukas Fleischer wrote: Reported-by: Florian Pritz bluew...@xinu.at Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/pkgreqfuncs.inc.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Unintentionally sent this twice. Sorry

[aur-dev] [PATCH] Fix File Request link in package base details

2014-07-01 Thread Lukas Fleischer
Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/template/pkgbase_details.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/template/pkgbase_details.php b/web/template/pkgbase_details.php index 1b40b84..2b92152 100644 --- a/web/template/pkgbase_details.php

[aur-dev] [PATCH 2/2] Set Message-ID when sending package request emails

2014-07-01 Thread Lukas Fleischer
When sending the first notification email that belongs to a certain package request, set the Message-ID instead of the In-Reply-To and References headers. This is not only more RFC compliant but also fixes thread views in several clients, such as Pipermail. Signed-off-by: Lukas Fleischer archli

[aur-dev] [PATCH] Remove extra space from text buttons in Firefox

2014-07-02 Thread Lukas Fleischer
Fixes FS#41052. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/css/aur.css | 5 + 1 file changed, 5 insertions(+) diff --git a/web/html/css/aur.css b/web/html/css/aur.css index cbebb30..9435e22 100644 --- a/web/html/css/aur.css +++ b/web/html/css/aur.css @@ -63,3 +63,8

[aur-dev] [PATCH 4/4] Fix pagination in the package request list

2014-07-02 Thread Lukas Fleischer
This was not implemented properly in commit 8260111 (Add a package request list, 2014-06-24). Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/pkgreq.php | 6 +++--- web/lib/pkgreqfuncs.inc.php | 19 +-- 2 files changed, 20 insertions(+), 5 deletions

[aur-dev] [PATCH 1/4] Fix title in package requests list

2014-07-02 Thread Lukas Fleischer
Use Requests instead of File Request as title for the package request list. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/pkgreq.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/web/html/pkgreq.php b/web/html/pkgreq.php index 401b60c..674f1c1

[aur-dev] [PATCH] po/POTFILES: Add missing files

2014-07-02 Thread Lukas Fleischer
Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- po/POTFILES | 4 1 file changed, 4 insertions(+) diff --git a/po/POTFILES b/po/POTFILES index 6ca17e7..a37384e 100644 --- a/po/POTFILES +++ b/po/POTFILES @@ -10,6 +10,7 @@ html/passreset.php html/pkgbase.php html/pkgdel.php html

[aur-dev] [PATCH 3/4] pkgbase.php: Highlight error messages

2014-07-02 Thread Lukas Fleischer
Make sure that error messages above the package list are actually visible to the user. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/pkgbase.php | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/web/html/pkgbase.php b/web/html/pkgbase.php index

[aur-dev] [PATCH 4/5] Remember whether a request has been accepted

2014-07-04 Thread Lukas Fleischer
Store whether a package request is accepted or rejected and display the reason of each closed request in the request list. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/pkgreqfuncs.inc.php | 16 web/template/pkgreq_results.php | 12 ++-- 2 files

[aur-dev] [PATCH 1/2] Handle plurals in translations

2014-07-04 Thread Lukas Fleischer
Use ngettext() to handle plurals properly. Also, split pagination captions into two strings. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- po/Makefile | 6 +++--- web/lib/translator.inc.php | 7 +++ web/template/pkg_search_results.php | 10

[aur-dev] [PATCH 2/2] Display number of pending requests in actions box

2014-07-04 Thread Lukas Fleischer
For packages with pending package requests, display the number of requests above the File Request link. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/pkgbasefuncs.inc.php | 5 - web/lib/pkgfuncs.inc.php | 5 - web/template/pkg_details.php | 1 + web

Re: [aur-dev] AUR 3.2.0 released

2014-07-05 Thread Lukas Fleischer
On Fri, 04 Jul 2014 at 20:31:48, Colin Woodbury wrote: Sorry if I missed this on the list elsewhere: is there now not any point in having both info and multiinfo? [...] multiinfo has originally been introduced for compatibility reasons. Now that we support versioned queries, it might be a good

Re: [aur-dev] [PATCH] home: requests should be done in the web interface

2014-07-12 Thread Lukas Fleischer
On Wed, 09 Jul 2014 at 18:11:42, Johannes Dewender wrote: Signed-off-by: Johannes Dewender a...@jonnyjd.net --- web/html/home.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/html/home.php b/web/html/home.php index 2757c06..24666ba 100644 --- a/web/html/home.php

[aur-dev] [PATCH 3/3] Add a new user group Trusted User Developer

2014-07-15 Thread Lukas Fleischer
This group has full permissions on everything. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- schema/aur-schema.sql | 1 + upgrading/3.4.0.txt | 5 + web/lib/acctfuncs.inc.php | 6 +- web/lib/credentials.inc.php | 12

[aur-dev] [PATCH 2/3] Disallow privileged users to use invalid user names

2014-07-15 Thread Lukas Fleischer
Prevent Trusted Users and developers from accidentally using a name that contains invalid characters. Also, remove user_is_privileged() which is no longer needed after this change. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/acctfuncs.inc.php | 23

Re: [aur-dev] [PATCH] home: requests should be filed in the web interface

2014-07-15 Thread Lukas Fleischer
On Sun, 13 Jul 2014 at 11:24:53, Johannes Dewender wrote: There is a file request link in the Package Actions box for every package. Signed-off-by: Johannes Dewender a...@jonnyjd.net --- web/html/home.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Added to my local patch

[aur-dev] [PATCH 2/3] Use Cc instead of Bcc in request notifications

2014-07-16 Thread Lukas Fleischer
Add the request creator and the current package maintainer to Cc instead of Bcc when sending notification emails for package requests. This allows users to forward any discussion to both of them by using the Group Reply function of their MUA. Signed-off-by: Lukas Fleischer archli

[aur-dev] [PATCH 3/3] Mention the target of merge requests in emails

2014-07-16 Thread Lukas Fleischer
When sending the initial notification email for a merge request, include the name of the package base that is the target of the requested merge operation. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/pkgreqfuncs.inc.php | 20 +++- 1 file changed, 15

[aur-dev] [PATCH] Fix pkgbase_votes_from_name()

2014-07-16 Thread Lukas Fleischer
. Reported-by: Felix Yan felixonm...@gmail.com Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/voters.php | 8 web/lib/pkgbasefuncs.inc.php | 17 + 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/web/html/voters.php b/web/html

Re: [aur-dev] Fix for some plural strings

2014-07-17 Thread Lukas Fleischer
Hello Safa, On Thu, 17 Jul 2014 at 15:08:18, Safa Alfulaij wrote: This is a patch to fix some strings that are not in plural. Hope you can add some comments to It must be between %s and %s characters long string parts so that the translator can understand whats going on. Also I didn't check

Re: [aur-dev] Fix for some plural strings

2014-07-21 Thread Lukas Fleischer
On Mon, 21 Jul 2014 at 11:59:45, Safa Alfulaij wrote: Hello. There is It must be between %s and %s characters long and Your password must be at least %s characters. besides the View all %n comments. Please, English differs from other languages. If a string don't need to pluralize in English,

[aur-dev] [PATCH] Drop support for source packages without .AURINFO

2014-07-23 Thread Lukas Fleischer
Disallow uploading source tarballs that do not contain .AURINFO. Also, drop the PKGBUILD parser which is no longer needed. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/pkgsubmit.php | 30 ++--- web/lib/pkgbuild-parser.inc.php | 139

[aur-dev] [PATCH 1/2] Drop comment count from translatable message

2014-07-23 Thread Lukas Fleischer
Suggested-by: Sebastian Wilzbach s...@wilzbach.me Suggested-by: kachelaqa kachel...@gmail.com Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/template/pkg_comments.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web/template/pkg_comments.php b/web/template

[aur-dev] [PATCH] Verify that the target of merge operations exists

2014-07-23 Thread Lukas Fleischer
Make sure that the target of a merge operation is either empty or an existing package base name. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/pkgreqfuncs.inc.php | 4 1 file changed, 4 insertions(+) diff --git a/web/lib/pkgreqfuncs.inc.php b/web/lib

[aur-dev] [PATCH] pkgreq_results.php: Only show non-empty merge targets

2014-07-23 Thread Lukas Fleischer
In the column that contains the merge target, only display the parentheses if the merge target is a non-empty string. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/template/pkgreq_results.php | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/web/template

[aur-dev] [PATCH] Add typeahead suggest to the merge request form

2014-07-23 Thread Lukas Fleischer
Add the typeahead implementation we already use for the package search to the merge target text field. Instead of suggesting packages, suggest package base names. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/pkgmerge.php| 17 + web/lib

[aur-dev] [PATCH] po/POTFILES: Remove pkgbuild-parser.inc.php

2014-07-23 Thread Lukas Fleischer
Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- po/POTFILES | 1 - 1 file changed, 1 deletion(-) diff --git a/po/POTFILES b/po/POTFILES index a37384e..1b4d6a6 100644 --- a/po/POTFILES +++ b/po/POTFILES @@ -27,7 +27,6 @@ lib/DB.class.php lib/feedcreator.class.php lib/gettext.php

[aur-dev] [PATCH] Prevent from merging a package base with itself

2014-07-23 Thread Lukas Fleischer
Instead of deleting the package, show an error message if a user tries to merge a package base with itself. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/pkgbase.php| 11 +++ web/lib/pkgreqfuncs.inc.php | 4 2 files changed, 11 insertions(+), 4

[aur-dev] [PATCH 1/2] Clean up user references in user_delete()

2014-07-25 Thread Lukas Fleischer
Explicitly clean up all references before deleting a user. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/acctfuncs.inc.php | 35 +++ 1 file changed, 35 insertions(+) diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php index

[aur-dev] [PATCH] Do not allow regular users to edit all accounts

2014-07-25 Thread Lukas Fleischer
Fixes a regression introduced in 03c6304 (Rework permission handling, 2014-07-15). Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/acctfuncs.inc.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php index

Re: [aur-dev] [aur-general] [HEADS-UP] Meta data and split package support in the AUR

2014-07-27 Thread Lukas Fleischer
On Sat, 05 Apr 2014 at 14:38:44, Lukas Fleischer wrote: [...] 1. We can drop the PKGBUILD parser from the AUR. The parser will still be available in the upcoming release but it will be marked as deprecated and a warning will be displayed whenever someone tries to upload a source

Re: [aur-dev] [PATCH] Make deleted comments visible to Trusted Users

2014-07-28 Thread Lukas Fleischer
On Mon, 28 Jul 2014 at 09:29:53, Alex Charron wrote: On 2014-07-27 21:12, Xyne wrote: On 2014-07-27 11:29 +1200 David Phillips wrote: So maybe we should clean them up occasionally? Makes sense. A TU's hardly going to receive complaints about abuse 12 -- or even 6 -- months after the

[aur-dev] AUR 3.4.0 released

2014-07-28 Thread Lukas Fleischer
Hello, I am pleased to announce that AUR 3.4.0 has been released. The official AUR setup [1] has already been updated. This release includes several improvements to the package request feature and a couple of bug fixes. The PKGBUILD parser has been dropped, you can no longer upload source

[aur-dev] [PATCH 1/3] Do not show deletion link on the registration page

2014-07-29 Thread Lukas Fleischer
In 7df8dc8 (Add support for deleting user accounts, 2014-07-25), a link to the account deletion page was added to the account edit form. Make sure we only show this link if the user actually wants to edit an account and do not show this link on the account registration page. Signed-off-by: Lukas

[aur-dev] [PATCH 2/3] Fix the registration form

2014-07-29 Thread Lukas Fleischer
Pass the right parameters to display_account_form() and process_account_form() when showing/processing the registration form. Fixes a regression introduced in 03c6304 (Rework permission handling, 2014-07-15). Reported-by: Karthik K hashken.dis...@gmail.com Signed-off-by: Lukas Fleischer archli

[aur-dev] [PATCH 3/3] Suppress PHP notice in process_account_form()

2014-07-29 Thread Lukas Fleischer
Add a check to remove a notice which is displayed after registration since commit 03c6304 (Rework permission handling, 2014-07-15). Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/acctfuncs.inc.php | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[aur-dev] [PATCH] Allow users to delete their own comments

2014-07-29 Thread Lukas Fleischer
Fixes a regression introduced in 03c6304 (Rework permission handling, 2014-07-15). Fixes FS#41379. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/pkgfuncs.inc.php | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/web/lib/pkgfuncs.inc.php

[aur-dev] [PATCH 1/2] Remove duplicate recipients from Cc

2014-07-29 Thread Lukas Fleischer
When a user files a request for a package maintained by himself, he is currently included in the Cc list twice. Use array_unique() to omit repeated entries. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/lib/pkgreqfuncs.inc.php | 2 ++ 1 file changed, 2 insertions(+) diff --git

[aur-dev] [PATCH] Lock fresh orphan requests

2014-07-29 Thread Lukas Fleischer
Trusted Users should almost always wait for two weeks before accepting an orphan request. Lock orphan requests during the first two weeks. Package bases can still be orphaned and package requests can still be closed manually during that period of time. Signed-off-by: Lukas Fleischer archli

[aur-dev] [PATCH 2/2] Close requests before accepting

2014-07-29 Thread Lukas Fleischer
When auto-accepting a request, we need to close the package request before performing the actual action (disown/deletion/merge). Otherwise, the former maintainer is not included in the Cc list of the acceptance/rejection notification email. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de

[aur-dev] AUR 3.4.2 released

2014-07-29 Thread Lukas Fleischer
Hello, I am pleased to announce that AUR 3.4.2 has been released. The official AUR setup [1] has already been updated. This release includes several bug fixes regarding the requests interface. For a comprehensive list of changes, please consult the Git log [2]. As usual, bugs should be reported

[aur-dev] AUR 3.4.3 released

2014-08-02 Thread Lukas Fleischer
Hello, I am pleased to announce that AUR 3.4.3 has been released. The official AUR setup [1] has already been updated. This release includes a bug fix to the user statistics and Trusted User interface, as well as Translation updates. For a comprehensive list of changes, please consult the Git

[aur-dev] [PATCH 2/2] Fix notification handling on submission and adoption

2014-08-05 Thread Lukas Fleischer
Automatically add users to the notification list when adopting a package. This used to work bug was broken by 03c6304 (Rework permission handling, 2014-07-15). Fixes FS#41426. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/pkgsubmit.php | 2 +- web/lib

[aur-dev] [PATCH 1/2] Add PCRE_DOLLAR_ENDONLY to preg_match()

2014-08-05 Thread Lukas Fleischer
registering with user names that end with a newline character. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/pkgsubmit.php | 4 ++-- web/lib/acctfuncs.inc.php | 2 +- web/lib/pkgreqfuncs.inc.php | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git

[aur-dev] [PATCH 2/2] Add permission checks to the request feature

2014-08-08 Thread Lukas Fleischer
* Only show the request form to users that are logged in. * Only show the close request form to Trusted Users and developers. * Check for a valid login in pkgreq_file(). Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/html/pkgreq.php | 8 web/lib

Re: [aur-dev] [PATCH] Group package dependencies by their type

2014-08-09 Thread Lukas Fleischer
On Sat, 09 Aug 2014 at 21:28:03, Mathieu Gaborit wrote: Sort dependencies by type, implements feature request in FS#40888 Dependencies are fetched like before and a sort is applied on dependencies type if $deps array is not empty. Display is adjusted accordingly. [...] I like the

[aur-dev] [PATCH] Group dependencies by dependency type

2014-08-10 Thread Lukas Fleischer
Implements FS#40888. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- web/template/pkg_details.php | 10 ++ 1 file changed, 10 insertions(+) diff --git a/web/template/pkg_details.php b/web/template/pkg_details.php index 7f01d2f..8a3cbcc 100644 --- a/web/template

<    1   2   3   4   5   6   7   8   9   10   >