Re: [PATCH 1/1] This patch implements FS#54906. Ability to query by pkgver via RPC or web request (url)

2018-06-10 Thread Nodiv Byzero
Hey Lukas. This patch implements additional check for package version. Of course, all clients can search by the name and then compare the version itself. But... this small improvement can help clients a lot. Here[1] is the good example. [1] https://github.com/falconindy/auracle/issues/3 On Sat,

Re: [PATCH 1/1] Highlighting row on hover in the search results. FS#53612

2018-06-10 Thread Nodiv Byzero
Thank you for this info. I'll submit my patch to archweb first. On Sat, Jun 9, 2018 at 10:30 AM, Lukas Fleischer wrote: > On Fri, 08 Jun 2018 at 23:04:20, nodivbyzero wrote: >> --- >> web/html/css/archweb.css | 12 ++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> [...] > > We

Re: Populate DB from aur-schema.sql

2018-05-01 Thread Nodiv Byzero
Thank you Lukas. Should this information be added into INSTALL file? On Mon, Apr 30, 2018 at 11:26 PM, Lukas Fleischer <lfleisc...@archlinux.org> wrote: > On Wed, 25 Apr 2018 at 06:07:46, Nodiv Byzero wrote: >> When I try to populate DB from aur-schema.sql using mysql comman

Re: [PATCH 1/1] TESTING: Adding 2 required packages in the documentation file. Replacing MySQL with SQLite in the comment

2018-03-10 Thread Nodiv Byzero
Thank you Lukas for review. I'll fix spaces issue and re-submit in two new commits. Cheers, Nodiv On Sat, Mar 10, 2018 at 7:55 AM, Lukas Fleischer <lfleisc...@archlinux.org> wrote: > Dear Nodiv, > > On Tue, 06 Mar 2018 at 03:38:08, Nodiv Byzero wrote: >> --- >> TESTIN

Re: [aur-dev][PATCH] config: allow reading both the proto file and the modified config

2018-04-12 Thread Nodiv Byzero
What do you think about adding one more line to check if $config is already set? Something like: if (!isset($config)) { ... do the parse_ini_file } Just to reduce disk operations. On Thu, Apr 12, 2018 at 10:44 AM, Eli Schwartz wrote: > This change allows aurweb

Re: [aur-dev][PATCH] config: allow reading both the proto file and the modified config

2018-04-12 Thread Nodiv Byzero
The point is that there are few places where config_load() gets called in the sequential order (the same request) and every time it loads and parses data. On Thu, Apr 12, 2018 at 11:05 AM, Eli Schwartz <eschwa...@archlinux.org> wrote: > On 04/12/2018 01:51 PM, Nodiv Byzero wrote: >&

Populate DB from aur-schema.sql

2018-04-24 Thread Nodiv Byzero
Hello, When I try to populate DB from aur-schema.sql using mysql command line I see following error: ERROR 1071 (42000) at line 20: Specified key was too long; max key length is 767 bytes Have you seen this one when installed aur-web? Is it because I use Maria DB version 10.1.30? Thanks, Nodiv

Re: [aur-dev][PATCH] config: allow reading both the proto file and the modified config

2018-04-16 Thread Nodiv Byzero
I think you're right. I looked one more time and found guard there: if (!isset($AUR_CONFIG)) Thanks for clarification. Nodiv. On Mon, Apr 16, 2018 at 1:41 AM, Eli Schwartz <eschwa...@archlinux.org> wrote: > On 04/12/2018 02:22 PM, Nodiv Byzero wrote: >> The point is that there

Re: [PATCH] Terminates execution of the script if aurweb config file not found

2018-03-16 Thread Nodiv Byzero
I spent 5 minutes to figure out why fresh aurweb install did not work for me. Because I missed aurweb/config file. I've added termination just in case there is not file. On Fri, Mar 16, 2018 at 8:17 PM, nodivbyzero wrote: > --- > web/lib/confparser.inc.php | 6 +- > 1

Re: [PATCH] Handle empty resultset getting recent 10 packages

2018-03-20 Thread Nodiv Byzero
It renders incorrectly main page(Statistics) with empty database. On Tue, Mar 20, 2018 at 8:33 PM, nodivbyzero wrote: > --- > web/lib/stats.inc.php | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/web/lib/stats.inc.php

Re: [PATCH] Handle empty resultset getting recent 10 packages

2018-03-20 Thread Nodiv Byzero
Replaced spaces w/ tabs in this version On Tue, Mar 20, 2018 at 8:47 PM, nodivbyzero wrote: > --- > web/lib/stats.inc.php | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/web/lib/stats.inc.php b/web/lib/stats.inc.php > index

[PATCH 1/1] TESTING: Adding 2 required packages in the documentation file. Replacing MySQL with SQLite in the comment

2018-03-05 Thread Nodiv Byzero
--- TESTING | 2 +- schema/Makefile | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/TESTING b/TESTING index d2c97d9..9613314 100644 --- a/TESTING +++ b/TESTING @@ -11,7 +11,7 @@ INSTALL. 2) Install php and necessary modules: -# pacman -S php php-sqlite sqlite +

Re: [aur-dev] [PATCH 1/1] Fix for issue FS#49134 - AUR site search includes packages' keywords when searching by name and description

2017-01-09 Thread Nodiv Byzero via aur-dev
I was wrong, You're right !

[aur-dev] What cgit version does AUR use?

2017-01-03 Thread Nodiv Byzero via aur-dev
Hello, I'm looking into FS#51968 - 'Atom feed of package repo have non-escaped href' issue. https://bugs.archlinux.org/task/51968?project=2 It looks like it's cgit issue. So, can somebody confirm current running cgit version? Thanks.

Re: [aur-dev] [PATCH 1/1] Fix for issue FS#49134 - AUR site search includes packages' keywords when searching by name and description

2017-01-08 Thread Nodiv Byzero via aur-dev
There is a search by 'package name & description' according to the function comment. File: pkgfuncs.inc.php /* ... SeB- property that search string (K) represents values: n - package name nd - package name & description b - package base name

[aur-dev] [PATCH 1/1] Fix for issue FS#49134 - AUR site search includes packages' keywords when searching by name and description

2016-12-23 Thread Nodiv Byzero via aur-dev
--- web/lib/pkgfuncs.inc.php |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/web/lib/pkgfuncs.inc.php b/web/lib/pkgfuncs.inc.php index 4b0fdba..f61e52c 100644 --- a/web/lib/pkgfuncs.inc.php +++ b/web/lib/pkgfuncs.inc.php @@ -755,6 +755,11 @@ function