Re: [PATCH] Move git privilege check to update.py rather than auth.py

2018-01-21 Thread Johannes Löthberg
Ehm, the subject should really be changed to something like this instead: Subject: [PATCH] Move AUR_OVERWRITE privilege check from git/auth to git/update Quoting Johannes Löthberg (2018-01-21 14:16:40) > auth.py is run as an AutherizedKeysCommand which does not get the > environment variables

[PATCH] Move git privilege check to update.py rather than auth.py

2018-01-21 Thread Johannes Löthberg
auth.py is run as an AutherizedKeysCommand which does not get the environment variables passed to it, so AUR_OVERWRITE always got hard-set to '0' by it. Signed-off-by: Johannes Löthberg --- aurweb/git/auth.py | 1 - aurweb/git/update.py | 2 +-

[PATCH v2] Move AUR_OVERWRITE privilege check from git/auth to git/update

2018-01-21 Thread Johannes Löthberg
git/auth is run as an AutherizedKeysCommand which does not get the environment variables passed to it, so AUR_OVERWRITE always got hard-set to '0' by it. Instead we need to perform the actual privilege check in git/update instead. Signed-off-by: Johannes Löthberg ---

[PATCH v3] Move AUR_OVERWRITE privilege check from git/auth to git/update

2018-01-21 Thread Johannes Löthberg
git/auth is run as an AutherizedKeysCommand which does not get the environment variables passed to it, so AUR_OVERWRITE always got hard-set to '0' by it. Instead we need to perform the actual privilege check in git/update instead. Signed-off-by: Johannes Löthberg ---

Re: [PATCH v3] Move AUR_OVERWRITE privilege check from git/auth to git/update

2018-01-21 Thread Lukas Fleischer
On Sun, 21 Jan 2018 at 17:51:02, Johannes Löthberg wrote: > git/auth is run as an AutherizedKeysCommand which does not get the > environment variables passed to it, so AUR_OVERWRITE always got > hard-set to '0' by it. Instead we need to perform the actual privilege > check in git/update instead.