[PATCH 1/4] SSO: Explain the rationale behind prompt=login

We might reconsider it in the future. --- aurweb/routers/sso.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/aurweb/routers/sso.py b/aurweb/routers/sso.py index d0802c34..e1ec7efe 100644 --- a/aurweb/routers/sso.py +++ b/aurweb/routers/sso.py @@ -28,6 +28,13 @@ oauth.register(

[PATCH 2/4] SSO: Add an SSO option in the login page

We’ll probably change the whole login page in the future, but this makes development easier. --- web/html/login.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/web/html/login.php b/web/html/login.php index 01454414..3a146f60 100644 --- a/web/html/login.php +++ b/web/html/login.php @@

[PATCH 3/4] Implement SSO logout

--- aurweb/routers/sso.py | 18 ++ web/html/logout.php | 14 +- 2 files changed, 31 insertions(+), 1 deletion(-) diff --git a/aurweb/routers/sso.py b/aurweb/routers/sso.py index e1ec7efe..a8d4b141 100644 --- a/aurweb/routers/sso.py +++ b/aurweb/routers/sso.py @@

[PATCH 4/4] Save id_token for the SSO logout

As far as I can see, Keycloak ignores it entirely. I can login in as SSO user A, then disconnect from the SSO directly and reconnect as user B, but when I disconnect user A from AUR, Keycloak disconnects B even though AUR passed it an ID token for A. --- aurweb/routers/sso.py | 19

Re: [PATCH] Exclude suspended Users from being notified

On Tue, 14 Jul 2020 at 18:25:04, Lukas Fleischer wrote: > On Mon, 13 Jul 2020 at 10:47:03, Frédéric Mangano-Tarumi wrote: > > In that last line, `+,` is not a valid Python syntax. The test suite is > > screaming. > > Thanks for the pointer Frédéric, I amended the patch. Seems like some tests are

Re: [PATCH 1/4] SSO: Explain the rationale behind prompt=login

On Tue, 14 Jul 2020 at 09:34:06, Frédéric Mangano-Tarumi wrote: > We might reconsider it in the future. > --- > aurweb/routers/sso.py | 7 +++ > 1 file changed, 7 insertions(+) Queued all patches in this patch series in pu, thanks Frédéric!

Re: [PATCH] Fix typos in CONTRIBUTING.md

On Mon, 13 Jul 2020 at 11:05:37, Frédéric Mangano-Tarumi wrote: > --- > CONTRIBUTING.md | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Merged, thanks!

Re: [PATCH] Exclude suspended Users from being notified

On Mon, 13 Jul 2020 at 10:47:03, Frédéric Mangano-Tarumi wrote: > In that last line, `+,` is not a valid Python syntax. The test suite is > screaming. Thanks for the pointer Frédéric, I amended the patch.