Re: [PATCH] First HTTP functional test of the RPC interface

2020-04-16 Thread Filipe Laíns
"")), > + > body=environ["wsgi.input"].read(int(environ.get("CONTENT_LENGTH", 0))), > + ) > +resp = conn.getresponse() > +start_response(f"{resp.status} {resp.reason}", resp.getheaders()) > +return resp > diff --git a/test/README.md b/test/README.md > index de7eff18..cc8baf33 100644 > --- a/test/README.md > +++ b/test/README.md > @@ -20,8 +20,11 @@ For all the test to run, the following Arch packages > should be installed: > - python-bleach > - python-markdown > - python-pygit2 > +- python-pytest > +- python-pytest-tap > - python-sqlalchemy > - python-srcinfo > +- python-werkzeug > > Writing tests > - > diff --git a/test/rpc.t b/test/rpc.t > new file mode 100755 > index ..f950f7df > --- /dev/null > +++ b/test/rpc.t > @@ -0,0 +1,2 @@ > +#!/bin/sh > +pytest --tap-stream "$(dirname "$0")/../aurweb/test/test_rpc.py" I think we should be using pytest-runner here. What do you think Lukas? Otherwise LGTM. Cheers, Filipe Laíns signature.asc Description: This is a digitally signed message part

Re: aurweb testing environment using Docker

2020-05-18 Thread Filipe Laíns
On Mon, 2020-05-18 at 17:01 -0400, Lukas Fleischer wrote: > On Tue, 24 Mar 2020 at 22:06:53, Lukas Fleischer wrote: > > On Tue, 24 Mar 2020 at 18:47:30, Filipe Laíns wrote: > > > I think we should build on our existent ansible infrastructure and use > > > ansible-bende

Re: TAP testing in Python

2020-03-21 Thread Filipe Laíns
extensible/has more integrations and has a larger userbase. The only caveat is that people would have to fo a quick read on fixtures before they start contributing. Choosing pycotap over tappy/pytest-tap would make sense if we already had a codebase written in unittest, but we don't. Lukas,

Re: aurweb testing environment using Docker

2020-03-24 Thread Filipe Laíns
bender to generate the containers, since we have all the components defined in separate roles, maintaining multiple containers shouldn't be that much of an issue. Cheers, Filipe Laíns signature.asc Description: This is a digitally signed message part

[PATCH] ci: remove Travis CI

2020-05-23 Thread Filipe Laíns
We are are moving to Gitlab CI. Signed-off-by: Filipe Laíns --- .travis.yml | 23 --- 1 file changed, 23 deletions(-) delete mode 100644 .travis.yml diff --git a/.travis.yml b/.travis.yml deleted file mode 100644 index 5bbfda1f.. --- a/.travis.yml +++ /dev/null

[PATCH 1/3] flake8: add initial config

2020-06-01 Thread Filipe Laíns
Signed-off-by: Filipe Laíns --- aurweb/git/auth.py| 1 - aurweb/git/serve.py | 14 +- aurweb/git/update.py | 4 +- aurweb/l10n.py| 2 +- aurweb/schema.py

[PATCH 2/3] isort: add initial config

2020-06-01 Thread Filipe Laíns
Signed-off-by: Filipe Laíns --- aurweb/git/auth.py | 2 +- aurweb/git/update.py| 2 +- aurweb/initdb.py| 7 --- aurweb/schema.py| 2 +- aurweb/scripts/aurblup.py | 3 ++- aurweb/scripts/rendercomment.py | 3 ++- migrations/env.py

[PATCH 3/3] pre-commit: add initial config

2020-06-01 Thread Filipe Laíns
Signed-off-by: Filipe Laíns --- .pre-commit-config.yaml | 23 +++ 1 file changed, 23 insertions(+) create mode 100644 .pre-commit-config.yaml diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml new file mode 100644 index ..b84a29e3 --- /dev/null +++ b

[PATCH v2 1/5] refactor code to comply with flake8 and isort

2020-06-01 Thread Filipe Laíns
Signed-off-by: Filipe Laíns --- aurweb/git/auth.py | 3 +- aurweb/git/serve.py | 14 +- aurweb/git/update.py| 6 +- aurweb/initdb.py| 7 +- aurweb/l10n.py | 2 +- aurweb/schema.py| 4 +- aurweb

[PATCH v2 4/5] pre-commit: add initial config

2020-06-01 Thread Filipe Laíns
Signed-off-by: Filipe Laíns --- .pre-commit-config.yaml | 24 1 file changed, 24 insertions(+) create mode 100644 .pre-commit-config.yaml diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml new file mode 100644 index ..525c7eb8 --- /dev/null +++ b

[PATCH v2 3/5] isort: add initial config

2020-06-01 Thread Filipe Laíns
Signed-off-by: Filipe Laíns --- setup.cfg | 4 1 file changed, 4 insertions(+) diff --git a/setup.cfg b/setup.cfg index 04f5b8ba..b868c096 100644 --- a/setup.cfg +++ b/setup.cfg @@ -2,3 +2,7 @@ max-line-length = 127 max-complexity = 10 +[isort] +line_length = 127 +lines_between_types

[PATCH v2 5/5] add CONTRIBUTING.md

2020-06-01 Thread Filipe Laíns
Signed-off-by: Filipe Laíns --- CONTRIBUTING.md | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index ..a37d980a --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,10 @@ +# Contributing

[PATCH v2 2/5] flake8: add initial config

2020-06-01 Thread Filipe Laíns
Signed-off-by: Filipe Laíns --- setup.cfg | 4 1 file changed, 4 insertions(+) create mode 100644 setup.cfg diff --git a/setup.cfg b/setup.cfg new file mode 100644 index ..04f5b8ba --- /dev/null +++ b/setup.cfg @@ -0,0 +1,4 @@ +[flake8] +max-line-length = 127 +max-complexity = 10

[PATCH] add CONTRIBUTING.md

2020-06-01 Thread Filipe Laíns
Signed-off-by: Filipe Laíns --- CONTRIBUTING.md | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index ..a37d980a --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,10 @@ +# Contributing

Re: [PATCH 1/3] flake8: add initial config

2020-06-01 Thread Filipe Laíns
On Mon, 2020-06-01 at 18:16 -0400, Lukas Fleischer wrote: > On Mon, 01 Jun 2020 at 16:51:05, Filipe Laíns wrote: > > Signed-off-by: Filipe Laíns > > --- > > aurweb/git/auth.py| 1 - > > aurweb/git/serve.py | 14 +

[PATCH 3/4] doc: add missing gendummydata.py dependencis in TESTING

2020-08-13 Thread Filipe Laíns
Signed-off-by: Filipe Laíns --- TESTING | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/TESTING b/TESTING index 17c6fbc7..d666b3ca 100644 --- a/TESTING +++ b/TESTING @@ -14,7 +14,8 @@ INSTALL. # pacman -S --needed php php-sqlite sqlite words fortune-mod

[PATCH 2/4] doc: fix AUR_CONFIG in TESTING

2020-08-13 Thread Filipe Laíns
Signed-off-by: Filipe Laíns --- TESTING | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/TESTING b/TESTING index d7df3672..17c6fbc7 100644 --- a/TESTING +++ b/TESTING @@ -29,7 +29,7 @@ INSTALL. 4) Prepare the testing database: $ cd /path/to/aurweb/ -$ python -m

[PATCH 1/4] spawn: expand AUR_CONFIG to the full path

2020-08-13 Thread Filipe Laíns
This allows using a relative path for the config. PHP didn't play well with it. Signed-off-by: Filipe Laíns --- aurweb/spawn.py | 4 1 file changed, 4 insertions(+) diff --git a/aurweb/spawn.py b/aurweb/spawn.py index 46d534d9..3c5130d7 100644 --- a/aurweb/spawn.py +++ b/aurweb/spawn.py

[PATCH 4/4] doc: simplify database setup instructions in TESTING

2020-08-13 Thread Filipe Laíns
Signed-off-by: Filipe Laíns --- TESTING | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/TESTING b/TESTING index d666b3ca..972bce2c 100644 --- a/TESTING +++ b/TESTING @@ -30,11 +30,11 @@ INSTALL. 4) Prepare the testing database: $ cd /path/to/aurweb