Something was leftover (probably from a previous update?)
Took out the extra line to sync up with how the other languages handle
it.
Signed-off-by: Kevin Morris
---
po/de.po | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/po/de.po b/po/de.po
index 00ab95c..ee5631d 100644
well written as it could be.
On Sat, Feb 16, 2019 at 9:08 PM Loui Chang wrote:
> On Sat 16 Feb 2019 17:21 -0800, Kevin Morris wrote:
> > The following is a proposal for a Django-hosted aurweb application. It is
> > meant to be a drop-in replacement for aur.archlinux.org; effectively
>
To whom it may concern,
The following is a proposal for a Django-hosted aurweb application. It is
meant to be a drop-in replacement for aur.archlinux.org; effectively
cloning its user interface and capabilities into a Python Django extension.
Following
oduce API v6 (2019-02-12 13:39:08 -0800)
> --------
> Kevin Morris (1):
> Introduce API v6
> doc/rpc.txt | 15 ++-
is a follow-up implementation to
https://patchwork.archlinux.org/patch/479/
Signed-off-by: Kevin Morris
---
doc/rpc.txt | 24 ++---
web/lib/aurjson.class.php | 105 --
2 files changed, 116 insertions(+), 13 deletions(-)
diff --git a/doc/rpc.txt
The existing notify.py script was grabbing entries regardless
of user suspension. This has been modified to only send notifications
to unsuspended users.
This change was written as a solution to
https://bugs.archlinux.org/task/65554.
Signed-off-by: Kevin Morris
---
The issue
Uh, unsure if adding conjunctive to `name` search in the search page is
what you want? I figured that made sense for both name and name-desc, like
it does on rpc currently...
Thoughts?
On Sun, Jul 5, 2020 at 5:57 PM Kevin Morris wrote:
> Newly supported API Version 6 modifies `type=sea
Alright, just left `name` as it exists in both cases, for rpc and web
search.
Should be all good now, hopefully?
On Sun, Jul 5, 2020 at 6:19 PM Kevin Morris wrote:
> Newly supported API Version 6 modifies `type=search` for _by_ type
> `name-desc`: it now behaves the same as `name-desc`
njuctive search when searching by
`name` in https://aur.archlinux.org/packages/.
Note: This change was written as a solution to
https://bugs.archlinux.org/task/49133.
PS: + Some spacing issues fixed in comments.
Signed-off-by: Kevin Morris
---
doc/rpc.txt | 4
web/lib/au
//bugs.archlinux.org/task/49133.
PS: + Some spacing issues fixed in comments.
Signed-off-by: Kevin Morris
---
doc/rpc.txt | 4
web/lib/aurjson.class.php | 33 +++--
web/lib/pkgfuncs.inc.php | 36 +++-
3 files ch
rm-data' \
-F v=5 -F type=search -F arg=test \
https://aur.archlinux.org/rpc/
```
This change was written as a solution to
https://bugs.archlinux.org/task/49089.
NOTE: This commit is not final; would like a review and a bit more
consideration on `multipart/form-data` and ensuring that we're
handling everyt
Apologies, `application/data` in the commit message's example should be
`application/json`, and will need to be updated after review(s) in the
final commit.
On Fri, Jul 3, 2020 at 10:53 AM Kevin Morris wrote:
> When we received a POST method from a client, deduce our `$data`
> by deter
-off-by: Kevin Morris
---
web/lib/acctfuncs.inc.php | 4
1 file changed, 4 insertions(+)
diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php
index d238c0e0..fb7cca8c 100644
--- a/web/lib/acctfuncs.inc.php
+++ b/web/lib/acctfuncs.inc.php
@@ -403,6 +403,10 @@ function
umi wrote:
> > > In that last line, `+,` is not a valid Python syntax. The test suite is
> > > screaming.
> >
> > Thanks for the pointer Frédéric, I amended the patch.
>
> Seems like some tests are still failing, even after fixing the typo.
> Kevin, could you please
Okay -- I'm going to need some time to study/research how these tests work
before I can confidently figure out what's going wrong. I'm on it, not sure
how long it'll take me.
On Wed, Jul 15, 2020 at 8:40 AM Kevin Morris wrote:
> [Re-post to aur-dev]
>
> Yeah. Was planning to, had a bit
:40, Kevin Morris wrote:
> > [...]
> > Signed-off-by: Kevin Morris
> > ---
> > doc/rpc.txt | 4 +++
> > web/lib/aurjson.class.php | 66 ++-
> > 2 files changed, 62 insertions(+), 8 deletions(-)
>
> Thanks
spacing issues fixed in comments.
Signed-off-by: Kevin Morris
---
doc/rpc.txt | 4 +++
web/lib/aurjson.class.php | 60 +--
2 files changed, 56 insertions(+), 8 deletions(-)
diff --git a/doc/rpc.txt b/doc/rpc.txt
index 3148ebea..b0f5c4e1 100644
--- a/d
-by: Kevin Morris
---
aurweb/scripts/notify.py | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/aurweb/scripts/notify.py b/aurweb/scripts/notify.py
index 5b18a476..94ca1936 100755
--- a/aurweb/scripts/notify.py
+++ b/aurweb/scripts/notify.py
@@ -170,6 +170,7
Updated patch inc which only modifies `scripts/notify.py` and preserves
notification records.
On Fri, Jul 3, 2020 at 12:02 PM Kevin Morris wrote:
> This path will only trigger when suspending a user through an
> account page; if the database is managed manually or through
> anoth
Alright, that's the final patch revision. This change ultimately just
removes suspended users from the sql results in `notify.py`, which excludes
them from all email notifications.
On Fri, Jul 3, 2020 at 6:29 PM Kevin Morris wrote:
> The existing notify.py script was grabbing entries regardl
The existing notify.py script was grabbing entries regardless
of user suspension. This has been modified to only send notifications
to unsuspended users.
This change was written as a solution to
https://bugs.archlinux.org/task/65554.
Signed-off-by: Kevin Morris
---
aurweb/scripts/notify.py
wrote:
> Hi Kevin,
>
> Thanks for the patch!
>
> On Tue, 30 Jun 2020 at 19:36:01, Kevin Morris wrote:
> > This commit introduces new functionality: When `search_type` is `web`,
> > search behavior matches aurweb's HTML search page.
> >
> > New parameters: `search_type`
spacing issues fixed in comments.
Signed-off-by: Kevin Morris
---
doc/rpc.txt | 4 +++
web/lib/aurjson.class.php | 66 ++-
2 files changed, 62 insertions(+), 8 deletions(-)
diff --git a/doc/rpc.txt b/doc/rpc.txt
index 3148ebea..b0f5c4e1 100644
--- a/d
Alright. Sent a new patch that implements all this -- wasn't able to figure
out how to `git send-email` into the same thread as this one, it's titled
"[PATCH] Bump RPC API Version 6". I included the `Message ID` for this
thread.
If we bump the API version, #1 is unnecessary and would be removed.
On Thu, Jul 2, 2020, 5:23 PM Lukas Fleischer
wrote:
> Hi Kevin,
>
> Thanks for your quick reply and your willingness to improve on your
> first submission!
>
> On Thu, 02 Jul 2020 at 20:04:10,
. What's the state of testing aurweb currently?
2. What are any test barriers to committing code and submitting patches?
2a. What are the testing goals?
3. Is there a thread on this mailing list about this topic?
Thank you very much for your time.
Regards,
Kevin
--
Kevin Morris
Software Developer
a solution to
https://bugs.archlinux.org/task/49133.
PS: + Some spacing issues fixed in comments.
Signed-off-by: Kevin Morris
---
doc/rpc.txt | 4
web/lib/aurjson.class.php | 29 +
web/lib/pkgfuncs.inc.php | 10 +-
3 files changed, 30 insertions(+), 1
:29:16, Kevin Morris wrote:
> > The existing notify.py script was grabbing entries regardless
> > of user suspension. This has been modified to only send notifications
> > to unsuspended users.
> >
> > This change was written as a solution to
> > https://bugs.archl
Hey Lukas,
Awesome! I do like the sound better of using the same exact search sql for
both RPC and Web, and so your suggestion seems like a great idea to me.
I'll start looking at this today!
On Sat, Jul 4, 2020 at 5:30 PM Lukas Fleischer
wrote:
> On Sat, 04 Jul 2020 at 17:14:26, Kevin Mor
Alright, patch sent; I used `-v1` this time with `git send-email`... I
can't find documentation for that switch yet. I've tested basic search
through both paths; the only refactoring that needed to be done was to
remove the extra "AND (" and ")" from the generic function, and add it
where we need
`name` or `name-desc`.
Note: This change was written as a solution to
https://bugs.archlinux.org/task/49133.
PS: + Some spacing issues fixed in comments.
Signed-off-by: Kevin Morris
---
doc/rpc.txt | 7
web/lib/aurjson.class.php | 75 +++
2
/aur.archlinux.org/rpc/?v=5=search=blah%20abc
> >
> > API Version 6 is currently only considered during a `search` of
> `name-desc`.
> >
> > Note: This change was written as a solution to
> > https://bugs.archlinux.org/task/49133.
> >
> &
his one can't hurt at all, the only thing it'd do is make
construct_keyword_search more flexible. ++ on this, change will be in the
next rev.
On Sun, Jul 5, 2020 at 11:51 AM Kevin Morris wrote:
> Do name and name-desc now behave exactly the same (see below)? If so,
>> this change in be
Okay, I was totally mistaken - `$keyword_string` is only ever sanitized in
the right place (name/name-desc) in master. Yeah, I can rework this to be a
bit cleaner as you recommended -- no problem. ++ on this, will be included
in next rev.
On Sun, Jul 5, 2020 at 11:51 AM Kevin Morris wrote:
>
Thoughts?
On Sun, Jul 5, 2020 at 6:33 AM Lukas Fleischer
wrote:
> On Sun, 05 Jul 2020 at 01:13:25, Kevin Morris wrote:
> > Alright, patch sent; I used `-v1` this time with `git send-email`... I
> > can't find documentation for that switch yet. I've tested basic search
>
35 matches
Mail list logo
