[aur-dev] [PATCH] Confirmation when deleting packages

2010-06-25 Thread Lukas Fleischer
This patch adds a confirmation checkbox for package deletion (non-Javascript solution). Fixes FS#6515 [1]. [1] http://bugs.archlinux.org/task/6515 From 1011c4643e681793377267002e32ea33f9cf9382 Mon Sep 17 00:00:00 2001 From: Lukas Fleischer archli...@cryptocrack.de Date: Fri, 25 Jun 2010 17:16:05

Re: [aur-dev] Bugs in two PKGBUILDs

2010-09-08 Thread Lukas Fleischer
On Wed, Sep 08, 2010 at 09:32:45PM +0200, Aljosha Papsch wrote: I've found two bugs in PKBUILDs: fs2_open-svn: line 31: makepkg can't delete the specified directory. Removing the line solves the problem. tbp: line 11: a = is missing (variable definition) Nice to see that people check and

Re: [aur-dev] [PATCH] Geshi AUR implementation

2010-09-29 Thread Lukas Fleischer
On Wed, Sep 29, 2010 at 01:38:36PM +0200, Manuel Tortosa wrote: +// Getting variables +if (!empty($HTTP_POST_VARS)) extract($HTTP_POST_VARS); +if (!empty($HTTP_GET_VARS)) extract($HTTP_GET_VARS); The use of $HTTP_POST_VARS and $HTTP_GET_VARS is deprecated and highly discouraged. It won't even

Re: [aur-dev] [PATCH] Simple rework of voters.php

2010-09-29 Thread Lukas Fleischer
On Wed, Sep 29, 2010 at 02:08:21PM +0200, Manuel Tortosa wrote: +echo 'br /br /br /'; That looks kinda ugly... Why do we need that? I'd just use some padding/margin if there really needs to be some space. And HTML code should always be put outside the ?php ? tags if there's actually no PHP code

Re: [aur-dev] [PATCH] Convert logout and forgot password to buttons

2010-09-29 Thread Lukas Fleischer
On Wed, Sep 29, 2010 at 02:23:39PM +0200, Manuel Tortosa wrote: + input type=button class=button value=?php print __(Logout); ? onclick=window.location.href='logout.php' + form i [...] + input type=button class=button value=?php print __(Forgot Password); ?

Re: [aur-dev] [PATCH] Make possible to post patches in comments

2010-09-29 Thread Lukas Fleischer
On Wed, Sep 29, 2010 at 05:13:18PM +0200, Manuel Tortosa wrote: +?php echo str_replace( , nbsp;, nl2br(htmlspecialchars($carr['Comments']))) ? You should definitely use pre/pre tags here instead of replacing every occurence of a whitespace ( ) by its HTML entity (nbsp;).

[aur-dev] [PATCH] Make external links in comments clickable (FS#20137).

2010-09-30 Thread Lukas Fleischer
This is a bit hacky patch to make links in AUR comments clickable (fixes FS#20137 [1]). Huge parts of this code are ripped from the DokuWiki plugin that is also used in Flyspray. I didn't have any time to test it extensively so I'd suggest to do some more tests if this will be commited. [1]

[aur-dev] [PATCH] Minor fix in French translation (FS#20111).

2010-09-30 Thread Lukas Fleischer
--- web/lang/fr.po |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/web/lang/fr.po b/web/lang/fr.po index 5728947..596f4af 100644 --- a/web/lang/fr.po +++ b/web/lang/fr.po @@ -43,7 +43,7 @@ $_t[Account Suspended] = Compte Suspendu; $_t[Status] = Etat; -$_t[New

[aur-dev] [PATCH] Add timestamp when a package is flagged out-of-date (FS#20848).

2010-09-30 Thread Lukas Fleischer
--- UPGRADING |4 support/schema/aur-schema.sql |1 + web/lang/cs.po|2 +- web/lang/de.po|2 +- web/lang/el_GR.po |2 +- web/lang/fr.po|2 +- web/lang/he.po|2 +-

Re: [aur-dev] [PATCH] Make external links in comments clickable (FS#20137).

2010-09-30 Thread Lukas Fleischer
On Thu, Sep 30, 2010 at 06:18:24PM +0200, PyroPeter wrote: + $url = str_replace('','amp;', $url); + $url = str_replace('amp;amp;', 'amp;', $url); What about the occurrences of amp;(html-entity-code-here); you produced the line before? Nothing? Any occurrence of an HTML entity code is

Re: [aur-dev] AUR update

2010-09-30 Thread Lukas Fleischer
On Thu, Sep 30, 2010 at 07:28:21PM +0200, Netanel Shine wrote: when we gonna see the AUR-gets update? adding all the fixes.. new translations and the other commites? The AUR has been updated just about a week ago :) It's now on 1.7.0.

Re: [aur-dev] AUR update

2010-09-30 Thread Lukas Fleischer
On Thu, Sep 30, 2010 at 08:34:52PM +0300, Panos Filip wrote: What I would really like to see is if the new patches from CCR will go through testing for AUR 1.8 :) Erm... http://chakra-project.org/ccr/pkgbuildview.php?pkgbuild=../../../../../etc/passwd *sigh*

Re: [aur-dev] AUR update

2010-09-30 Thread Lukas Fleischer
On Thu, Sep 30, 2010 at 11:16:55PM +0530, Gaurish Sharma wrote: OMG!! I already told Manuel about this security vulnerability yesterday [1]. He didn't seem to do anyting against it yet tho. My advice is not to include any of those patches without proper review. [1]

Re: [aur-dev] [PATCH] Geshi AUR implementation

2010-09-30 Thread Lukas Fleischer
On Wed, Sep 29, 2010 at 03:35:24PM +0200, Manuel Tortosa wrote: This introduces a remote file inclusion vulnerability allowing an attacker to read arbitrary files since $pkgbuild is not validated before passing it to file_get_contents(). Don't apply this patch until everything is fixed,

Re: [aur-dev] [PATCH] Make external links in comments clickable (FS#20137).

2010-09-30 Thread Lukas Fleischer
On Thu, Sep 30, 2010 at 08:56:56PM +0200, PyroPeter wrote: Well, but you are encoding existing entities, that are not amp; as amp;foo;. See the example below. Yep, and that's how it's supposed to be. There shouldn't be any entities that users put in the comments and that are not encoded. I

Re: [aur-dev] [PATCH] Make external links in comments clickable (FS#20137).

2010-10-01 Thread Lukas Fleischer
On Fri, Oct 01, 2010 at 02:15:41PM +0200, PyroPeter wrote: I did not mean to offend you, and after applying the patch (which I should have done before sending the mails, you are right) your code in fact seems to work a lot better then I thought. I didn't feel offended in any way, but reporting

Re: [aur-dev] AUR update

2010-10-01 Thread Lukas Fleischer
On Thu, Sep 30, 2010 at 09:54:00PM +0200, PyroPeter wrote: I tried to do something but i failed. i removed this completelly and changed all the password and so but now i'm completelly disolated.. There were no passwords in that file. (They are saved in /etc/shadow) Without that file

Re: [aur-dev] [PATCH] Make external links in comments clickable (FS#20137).

2010-10-01 Thread Lukas Fleischer
On Fri, Oct 01, 2010 at 04:59:22PM +0200, PyroPeter wrote: I fixed the / bugs and changed the indention to tabs. I also changed the regex to one that accepts everything that starts with one of 'http', 'https' or 'ftp' followed by a colon :, contains no whitespace and ends with a letter (\w)

Re: [aur-dev] [PATCH] Make external links in comments clickable (FS#20137).

2010-10-01 Thread Lukas Fleischer
On Fri, Oct 01, 2010 at 06:23:06PM +0200, PyroPeter wrote: About splitting at boundaries: Contrary to what I have said before, using regular expressions seems to be a valid and efficient way. (I thought you would have to escape tag-content and attributes in different ways (percent-encoding vs.

Re: [aur-dev] [PATCH] Add timestamp when a package is flagged out-of-date (FS#20848).

2010-10-03 Thread Lukas Fleischer
On Fri, Oct 01, 2010 at 10:39:37PM -0400, Loui Chang wrote: I was thinking - could we just change things so that OutOfDateTS is the sole indicator of whether a package has been flagged or not? If it's set, then it's out of date. If it's zero or null, then it's up to date. I basically agree

[aur-dev] [PATCH] Make external links in comments clickable (FS#20137).

2010-10-03 Thread Lukas Fleischer
Comments are now split at link boundaries and links are converted separately. I find this to be a much cleaner way than re-converting comments that have already been converted using htmlspecialchars(). This also doesn't require any callback procedure. --- web/lib/aur.inc | 24

Re: [aur-dev] [PATCH] PKGBUILD syntax highlight

2010-10-05 Thread Lukas Fleischer
On Mon, Oct 04, 2010 at 10:51:54PM +0200, PyroPeter wrote: It changes / to %2F so /etc/passwd would result in a broken path. Assuming that basename does what basename(1) does, it will never output a slash. /etc/passwd would yield passwd. Yes, there's no need to additionally use urlencode()

Re: [aur-dev] [PATCH] Add timestamp when a package is flagged out-of-date (FS#20848).

2010-10-05 Thread Lukas Fleischer
On Sun, Oct 03, 2010 at 01:35:45PM -0500, Dan McGee wrote: On Sun, Oct 3, 2010 at 1:34 PM, Lukas Fleischer archli...@cryptocrack.de wrote: I basically agree and I already changed the patch to only the OutOfDateTS column only. The only thing that I'm not sure how to implement

[aur-dev] [PATCH] Add timestamp when a package is flagged out-of-date (FS#20848).

2010-10-05 Thread Lukas Fleischer
--- UPGRADING |6 ++ support/schema/aur-schema.sql |3 +-- web/html/pkgsubmit.php |2 +- web/lang/ca.po |2 +- web/lang/cs.po |2 +- web/lang/de.po |4 ++--

Re: [aur-dev] [PATCH] Add timestamp when a package is flagged out-of-date (FS#20848).

2010-10-05 Thread Lukas Fleischer
Gnah, made a mistake with converting i8n files. This should hopefully work :) --- UPGRADING |6 ++ support/schema/aur-schema.sql |3 +-- web/html/pkgsubmit.php |2 +- web/lang/cs.po |2 +- web/lang/de.po

Re: [aur-dev] [PATCH] Add timestamp when a package is flagged out-of-date (FS#20848).

2010-10-10 Thread Lukas Fleischer
On Thu, Oct 07, 2010 at 11:09:36PM -0400, Loui Chang wrote: This: + echo br /span class='f6'.__(This package has been flagged out of date). (.$out_of_date_time.)/span; Could change to this: + echo br /span class='f6'.__(This package has been

Re: [aur-dev] bold title bar

2010-10-30 Thread Lukas Fleischer
On Wed, Oct 27, 2010 at 03:10:10AM +0200, Martti Kühne wrote: btw... when is the title bar update to be made? By the way, I posted a patch for this here some time ago [1]. [1] http://mailman.archlinux.org/pipermail/aur-dev/2010-September/001253.html

Re: [aur-dev] [PATCH] Do not display current votes in All Votes

2010-11-02 Thread Lukas Fleischer
On Tue, Nov 02, 2010 at 05:47:12PM +0100, Andrea Scarpino wrote: ?php - $q = SELECT * FROM TU_VoteInfo ORDER BY Submitted . $order . $lim; + $q = SELECT * FROM TU_VoteInfo WHERE End . time() . ORDER BY Submitted . $order . $lim; $result =

[aur-dev] [PATCH 1/2] Allow canonical links to packages (fixes FS#21600).

2010-11-06 Thread Lukas Fleischer
--- web/html/packages.php |6 ++ web/lib/pkgfuncs.inc | 16 web/template/pkg_comments.php |2 +- 3 files changed, 23 insertions(+), 1 deletions(-) diff --git a/web/html/packages.php b/web/html/packages.php index 472f6a2..c777346 100644 ---

[aur-dev] [PATCH 2/2] Allow canonical links to accounts (fixes FS#21600, FS#9582).

2010-11-06 Thread Lukas Fleischer
--- web/html/account.php | 15 +++ 1 files changed, 11 insertions(+), 4 deletions(-) diff --git a/web/html/account.php b/web/html/account.php index e8a3218..bf84989 100644 --- a/web/html/account.php +++ b/web/html/account.php @@ -69,10 +69,17 @@ if (isset($_COOKIE[AURSID])) {

Re: [aur-dev] Reqest to delete package

2010-11-11 Thread Lukas Fleischer
On Thu, Nov 11, 2010 at 05:56:06PM +1000, joker-...@yandex.ru wrote: Please, delete kdeplasma-addons-applets-smooth-tasks http://aur.archlinux.org/packages.php?ID=43404 it's dublicate of http://aur.archlinux.org/packages.php?ID=29410 (my mistake) Done. Please use the correct mailing list

[aur-dev] [PATCH] Do not overwrite package details when adding comments (fixes FS#22075).

2011-01-11 Thread Lukas Fleischer
Ensure that the $row variable isn't overwritten in web/template/pkg_comment_form.php during sending mail notifications when adding a comment. --- web/template/pkg_comment_form.php |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/web/template/pkg_comment_form.php

Re: [aur-dev] [PATCH] Make external links in comments clickable (FS#20137).

2011-01-25 Thread Lukas Fleischer
On Sun, Oct 03, 2010 at 09:51:45PM +0200, Lukas Fleischer wrote: Comments are now split at link boundaries and links are converted separately. I find this to be a much cleaner way than re-converting comments that have already been converted using htmlspecialchars(). This also doesn't require

Re: [aur-dev] [PATCH] Do not overwrite package details when adding comments (fixes FS#22075).

2011-01-25 Thread Lukas Fleischer
On Tue, Jan 11, 2011 at 10:38:24AM +0100, Lukas Fleischer wrote: Ensure that the $row variable isn't overwritten in web/template/pkg_comment_form.php during sending mail notifications when adding a comment. --- web/template/pkg_comment_form.php |2 +- 1 files changed, 1 insertions(+), 1

Re: [aur-dev] [PATCH] Drop PackageLocations table and references

2011-02-01 Thread Lukas Fleischer
On Mon, Jan 31, 2011 at 11:18:15AM -0600, Dan McGee wrote: We don't need this anymore since all packages managed here are well...managed here. Rip out all of the places we were using this field, many of which depended on the magic value '2' anyway. On the display side of things, we had a

[aur-dev] Package blacklist for the AUR

2011-02-07 Thread Lukas Fleischer
Hi! I recently started working on a package blacklist for the official AUR which can e.g. be used to prevent people from uploading packages in the official repos to [unsupported] (cf. FS#12902 [1]). Patches can be found in the pkg-blacklist branch of my working tree [2]. They currently include

Re: [aur-dev] Package blacklist for the AUR

2011-02-07 Thread Lukas Fleischer
On Mon, Feb 07, 2011 at 06:50:14PM +0100, Lukas Fleischer wrote: Blacklist helper side: * I won't lie, I think this is over-engineered a tad. This can be done in a much shorter and easier to hack shell script since all you need is package names- just pipe bsdtar output through some magic

Re: [aur-dev] Package blacklist for the AUR

2011-02-08 Thread Lukas Fleischer
On Mon, Feb 07, 2011 at 10:18:16AM -0500, Justin Davis wrote: All around pretty awesome. I wouldn't have written it in C myself but more power to you! What about provides lists from packages as well? Can you add those to the blacklist? I think you (or someone) should but maybe I am wrong.

[aur-dev] [PATCH] Use VARCHAR instead of CHAR where appropriate.

2011-02-08 Thread Lukas Fleischer
Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- UPGRADING | 16 support/schema/aur-schema.sql | 28 ++-- 2 files changed, 30 insertions(+), 14 deletions(-) diff --git a/UPGRADING b/UPGRADING index c067af5..661a6c3

Re: [aur-dev] Old, unapplied patches

2011-02-08 Thread Lukas Fleischer
On Tue, Feb 08, 2011 at 07:42:17PM +0100, PyroPeter wrote: Among them are: * The right-to-left fixes for the hebrew translation I will have a look at that. * Making links in comments clickable That's not true, I already pushed this [1]. * Deletion through the web interface What exactly do

Re: [aur-dev] [PATCH] Use VARCHAR instead of CHAR where appropriate.

2011-02-08 Thread Lukas Fleischer
On Tue, Feb 08, 2011 at 09:13:07PM -0600, Dan McGee wrote: On Tue, Feb 8, 2011 at 8:31 PM, Loui Chang louipc@gmail.com wrote: On Tue 08 Feb 2011 10:40 +0100, Lukas Fleischer wrote: -     LangPreference CHAR(5) NOT NULL DEFAULT 'en', I think LangPreference could probably remain at CHAR

[aur-dev] [PATCH] Remove fulltext index from Packages.

2011-02-09 Thread Lukas Fleischer
Drop unused fulltext indexes from Packages table (all search routines use LIKE patterns) which prevent the use of InnoDB. Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- As far as I can see, this is the only thing that prevents us from using InnoDB as the storage engine for all tables

Re: [aur-dev] Old, unapplied patches

2011-02-09 Thread Lukas Fleischer
On Mon, Feb 07, 2011 at 02:36:33PM +0100, PyroPeter wrote: there is a great backlog of patches that work well, but are not applied. Among them are: * The right-to-left fixes for the hebrew translation * Making links in comments clickable * Deletion through the web interface It would be

Re: [aur-dev] Package blacklist for the AUR

2011-02-10 Thread Lukas Fleischer
On Mon, Feb 07, 2011 at 06:50:14PM +0100, Lukas Fleischer wrote: On Mon, Feb 07, 2011 at 10:08:54AM -0600, Dan McGee wrote: AUR side: * Using CHAR as a datatype is absolutely silly in new code, use VARCHAR, and why do anything shorter than 255 or 512? * On that note, almost all CHAR

Re: [aur-dev] Adding the HE language.

2011-02-12 Thread Lukas Fleischer
Wow, I finally found some time to rebase and review all those patches... On Tue, Aug 17, 2010 at 04:51:03PM +0200, PyroPeter wrote: I am now splitting the commit into smaller ones. Attached are the first four patches: 0001. 00e497a pkg_search_results: rewrite of page navigation I have to

Re: [aur-dev] Adding the HE language.

2011-02-14 Thread Lukas Fleischer
On Mon, Feb 14, 2011 at 09:58:50PM +0100, PyroPeter wrote: I rewrote the pagination a second time, this time without changing the behavoir. Probably the world isn't ready yet for a commit that turns searching into something awesome (tm). (Children would have known what logarithmic scaling

Re: [aur-dev] Adding the HE language.

2011-02-16 Thread Lukas Fleischer
On Mon, Feb 14, 2011 at 09:58:50PM +0100, PyroPeter wrote: From 541c18f86d970051d837e9dd75e1122292d1fd4f Mon Sep 17 00:00:00 2001 From: PyroPeter abi1...@googlemail.com Date: Mon, 14 Feb 2011 20:58:42 +0100 Subject: [PATCH] pkg_search_results: rewrite of pagination * Most of the PHP-code

Re: [aur-dev] Adding the HE language.

2011-02-16 Thread Lukas Fleischer
On Tue, Feb 15, 2011 at 09:46:36PM +0100, PyroPeter wrote: On 02/15/2011 09:45 PM, PyroPeter wrote: On 02/12/2011 01:34 PM, Lukas Fleischer wrote: 0004. 76a874a Right-to-left written languages now supported Basically looks ok, except that you revert some previous bug fixes. Also, where's

Re: [aur-dev] Adding the HE language.

2011-02-17 Thread Lukas Fleischer
On Wed, Feb 16, 2011 at 07:51:32PM +0100, PyroPeter wrote: I changed the things you mentioned and also removed the CSS adjustments. Thanks.

Re: [aur-dev] Adding the HE language.

2011-02-18 Thread Lukas Fleischer
On Thu, Feb 17, 2011 at 07:54:36PM +0100, PyroPeter wrote: On 02/16/2011 04:07 PM, Lukas Fleischer wrote: Could you please use underscore as delimiters instead of camelCase here as well? Done. Thanks.

Re: [aur-dev] Adding the HE language.

2011-02-18 Thread Lukas Fleischer
On Thu, Feb 17, 2011 at 07:58:13PM +0100, PyroPeter wrote: On 02/15/2011 09:45 PM, PyroPeter wrote: I now updated this, too. What bugfixes did I revert? I hope I did not revert them this time. I merged the content of the former languages.css into arch.css. Regards, PyroPeter New version

[aur-dev] AUR 1.8.0 released

2011-02-20 Thread Lukas Fleischer
1.8.0 is finally out [1]! Please note that this release removes all the code for automatic tarball extraction. From now on, only PKGBUILDs and source tarballs will be accessible via the AUR web interface. 1.8.0 also introduces a package blacklist and a blacklist helper which can be used to avoid

Re: [aur-dev] [PATCH] logged before - logged in before in web/lib/pkgfuncs.inc

2011-02-21 Thread Lukas Fleischer
On Mon, Feb 21, 2011 at 05:18:57PM +0100, Wieland Hoffmann wrote: This fixes a small message telling people they had to be logged to edit package information into telling them they need to be logged _in_. --- web/lib/pkgfuncs.inc |4 ++-- 1 files changed, 2 insertions(+), 2

Re: [aur-dev] [PATCH] Update the german translation

2011-02-21 Thread Lukas Fleischer
On Mon, Feb 21, 2011 at 05:46:29PM +0100, Wieland Hoffmann wrote: The subject should be self-explanatory. Wieland Why did you skip some of the entries? Like Proposal cannot be empty., Add Proposal and Proposal Details?

Re: [aur-dev] [PATCH] Update the german translation

2011-02-23 Thread Lukas Fleischer
On Wed, Feb 23, 2011 at 02:48:06PM +, Viktor Leonhardt wrote: Am 21.02.2011 16:46, schrieb Wieland Hoffmann: The subject should be self-explanatory. Wieland Hi, will this Patch be pushed? If not, I use this patch as a base and add some thingt or remove the empty-ones. This is on my

Re: [aur-dev] Russian comments are '???'

2011-02-25 Thread Lukas Fleischer
On Fri, Feb 25, 2011 at 01:34:12PM +1000, Joker-jar wrote: Hi. Russian comments are like '???' now in the aur. Look: http://aur.archlinux.org/packages.php?ID=40365 I think, problem in database encoding Thanks, I'll look into that. Maybe you'd better create a bug report in the bug tracker,

Re: [aur-dev] [PATCH] Specify utf8 in database schema.

2011-02-28 Thread Lukas Fleischer
On Sun, Feb 27, 2011 at 08:38:45PM -0500, Loui Chang wrote: Signed-off-by: Loui Chang louipc@gmail.com --- support/schema/aur-schema.sql |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/support/schema/aur-schema.sql b/support/schema/aur-schema.sql index

Re: [aur-dev] A few more patches

2011-03-10 Thread Lukas Fleischer
On Thu, Mar 10, 2011 at 09:18:50AM -0600, Dan McGee wrote: Mostly to Lukas, but posting it here- I have a few more patches on my working branch you might be interested in: http://code.toofishes.net/cgit/dan/aur.git/log/?h=working * Perform a second query to find total search count * Split

[aur-dev] [PATCH] Notify package maintainers about deleted dependencies (FS#10372).

2011-03-11 Thread Lukas Fleischer
Signed-off-by: Lukas Fleischer archli...@cryptocrack.de --- While upgrading our database to InnoDB, I noticed that there are missing dependencies in the package details view for some packages. This happens when some dependency of a package gets deleted as we recently added an ON DELETE CASCADE

Re: [aur-dev] [PATCH] Fix main site package search URL

2011-03-15 Thread Lukas Fleischer
On Tue, Mar 15, 2011 at 09:24:56AM -0500, Dan McGee wrote: I've been wanting to kill this one for a long time. Signed-off-by: Dan McGee d...@archlinux.org --- web/template/pkg_details.php |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [aur-dev] [PATCH] Bump up default per-page value to 50

2011-03-24 Thread Lukas Fleischer
On Tue, Mar 22, 2011 at 10:03:56PM -0500, Dan McGee wrote: 25 is woefully small for the number of packages many searches can return, and with 28000+ packages in AUR, it makes sense to show a lot more per page by default. The new choices of (50, 100, 250) happen to match those from the main

Re: [aur-dev] [PATCH 3/5] Remove Dummy Package concept

2011-04-04 Thread Lukas Fleischer
On Wed, Mar 30, 2011 at 08:48:09PM -0500, Dan McGee wrote: Instead, we just store dependencies directly in the PackageDepends table. Since we don't use this info anywhere besides the package details page, there is little value in precalculating what is in the AUR vs. what is not. An upgrade

Re: [aur-dev] Some optimzation patches

2011-04-04 Thread Lukas Fleischer
On Sun, Apr 03, 2011 at 08:41:27PM -0700, elij wrote: Here are some patches that optimze a few things: - combine css for faster delivery (fewer tcp connections) - minimize css (faster delivery, bandwidth reduction) note: originals are retained for later editing and re-minimization -

Re: [aur-dev] [PATCH 1/3] make gendummydata script more friendly

2011-04-06 Thread Lukas Fleischer
On Tue, Apr 05, 2011 at 11:57:46PM -0700, elij wrote: - remove need to use mysql for generating the sql - just consider categories an integer range, specified to the size of that in the aur-schema. - use the logging module instead of writing directly to stderr this makes the code cleaner

Re: [aur-dev] [PATCH 3/3] convert to spaces

2011-04-06 Thread Lukas Fleischer
On Tue, Apr 05, 2011 at 11:57:48PM -0700, elij wrote: reformat with recommendation from pep8 for using spaces --- support/schema/gendummydata.py | 256 1 files changed, 128 insertions(+), 128 deletions(-) Won't push that one, as long as we don't

Re: [aur-dev] [PATCH 1/1] refer to the wiki for api documentation

2011-04-06 Thread Lukas Fleischer
On Tue, Apr 05, 2011 at 10:03:22AM -0700, elij wrote: --- web/html/rpc.php | 20 +--- 1 files changed, 5 insertions(+), 15 deletions(-) Basically sounds like a good idea, but we should try to move away from having stuff strongly linked to the Arch Linux homepage. I know

Re: [aur-dev] [PATCH 2/7] add minified aur css

2011-04-06 Thread Lukas Fleischer
On Mon, Apr 04, 2011 at 02:44:06PM -0700, elij wrote: --- web/html/css/aur.min.css | 148 ++ 1 files changed, 148 insertions(+), 0 deletions(-) create mode 100644 web/html/css/aur.min.css diff --git a/web/html/css/aur.min.css

Re: [aur-dev] [PATCH 5/7] use new css files in header template

2011-04-06 Thread Lukas Fleischer
On Mon, Apr 04, 2011 at 02:44:09PM -0700, elij wrote: --- web/template/header.php |9 + 1 files changed, 5 insertions(+), 4 deletions(-) You should split and merge this into the patches addressing the CSS file merging and the creation of the IE6 stylesheet. Keep changesets

Re: [aur-dev] [PATCH 6/7] optimize png file

2011-04-06 Thread Lukas Fleischer
On Mon, Apr 04, 2011 at 02:44:10PM -0700, elij wrote: - savings of about 1K (22%) --- web/html/css/archnavbar/archlogo.png | Bin 4192 - 3258 bytes 1 files changed, 0 insertions(+), 0 deletions(-) How did you do this? Please add some note on how to reproduce that optimization to the

Re: [aur-dev] [PATCH 2/7] add minified aur css

2011-04-06 Thread Lukas Fleischer
On Wed, Apr 06, 2011 at 02:18:22PM -0500, Dan McGee wrote: On Wed, Apr 6, 2011 at 2:15 PM, Lukas Fleischer archli...@cryptocrack.de wrote: On Mon, Apr 04, 2011 at 02:44:06PM -0700, elij wrote: ---  web/html/css/aur.min.css |  148 ++  1 files

Re: [aur-dev] [PATCH 1/3] make gendummydata script more friendly

2011-04-06 Thread Lukas Fleischer
On Wed, Apr 06, 2011 at 12:35:32PM -0700, elij wrote: On Wed, Apr 6, 2011 at 12:04 PM, Lukas Fleischer archli...@cryptocrack.de wrote:       num_comments = random.randrange(PKG_CMNTS[0], PKG_CMNTS[1])       for i in range(0, num_comments): -             fortune = esc(commands.getoutput

Re: [aur-dev] [PATCH] Update the german translation

2011-04-06 Thread Lukas Fleischer
On Mon, Apr 04, 2011 at 05:30:03PM +0200, Wieland Hoffmann wrote: Lukas Fleischer wrote: This is on my TODO list, but there's more important stuff on there. I'll probably add the missing entries myself as I'm a native German speaker. But thanks a lot! Any chance of this happening soon

Re: [aur-dev] [PATCH 3/3] convert to spaces

2011-04-06 Thread Lukas Fleischer
On Wed, Apr 06, 2011 at 12:59:10PM -0700, elij wrote: On Wed, Apr 6, 2011 at 12:06 PM, Lukas Fleischer archli...@cryptocrack.de wrote: On Tue, Apr 05, 2011 at 11:57:48PM -0700, elij wrote: reformat with recommendation from pep8 for using spaces ---  support/schema/gendummydata.py |  256

[aur-dev] Using gettext for translations?

2011-04-06 Thread Lukas Fleischer
Hi, I thought about this sometime ago. The existing i8n files shouldn't be too hard to convert and we could move translation work to some more appropriate platform like Transifex which is used by pacman already. PHP gettext integration doesn't seem to be too bad and our PHP is compiled with

Re: [aur-dev] Using gettext for translations?

2011-04-06 Thread Lukas Fleischer
On Wed, Apr 06, 2011 at 10:26:35PM +0200, Lukas Fleischer wrote: Hi, I thought about this sometime ago. The existing i8n files shouldn't be too hard to convert and we could move translation work to some more appropriate platform like Transifex which is used by pacman already. PHP gettext

Re: [aur-dev] Using gettext for translations?

2011-04-07 Thread Lukas Fleischer
On Wed, Apr 06, 2011 at 10:07:15PM -0500, Dan McGee wrote: On Wed, Apr 6, 2011 at 9:27 PM, Lukas Fleischer archli...@cryptocrack.de wrote: On Wed, Apr 06, 2011 at 10:26:35PM +0200, Lukas Fleischer wrote: Hi, I thought about this sometime ago. The existing i8n files shouldn't be too

Re: [aur-dev] Using gettext for translations?

2011-04-07 Thread Lukas Fleischer
On Thu, Apr 07, 2011 at 04:27:23AM +0200, Lukas Fleischer wrote: On Wed, Apr 06, 2011 at 10:26:35PM +0200, Lukas Fleischer wrote: Hi, I thought about this sometime ago. The existing i8n files shouldn't be too hard to convert and we could move translation work to some more appropriate

Re: [aur-dev] Patch for French translation

2011-04-07 Thread Lukas Fleischer
On Wed, Apr 06, 2011 at 11:03:41PM +0200, Cédric Girard wrote: Hi, Here is a patch for the French translation. What have been done : * Translation of notify has been changed to the literal translation notifier which seems more appropriate (cf. recent thread on AUR-general) *

Re: [aur-dev] some patches to gendummydata (take 3)

2011-04-07 Thread Lukas Fleischer
On Wed, Apr 06, 2011 at 07:27:59PM -0700, elij wrote: On Wed, Apr 6, 2011 at 7:23 PM, elij elij...@gmail.com wrote: Updated with changes Lukas requested. - split logging and mysql removal into separate patches - update logging patch with uppercase variable convention - drop tabs -

[aur-dev] AUR migrating to gettext and Transifex

2011-04-10 Thread Lukas Fleischer
Hi, folks! I've just merged my gettext wip branch into master and pushed that to gerolde. From now on, AUR translations will be managed via Transifex [1]. That removes the need for sending git-formatted patches to aur-dev and improves collaboration. It'll hopefully also support cross-project work

Re: [aur-dev] [PATCH] Fix performance issues with new PackageDepends lookups

2011-04-12 Thread Lukas Fleischer
On Tue, Apr 12, 2011 at 11:23:38AM +0200, Lukas Fleischer wrote: On Mon, Apr 11, 2011 at 08:03:43PM -0500, Dan McGee wrote: We do a lookup by DepName in the package details view, but I made the silly mistake of forgetting this index addition in the upgrade steps. Signed-off-by: Dan McGee

Re: [aur-dev] some patches to gendummydata (take 3)

2011-04-12 Thread Lukas Fleischer
On Thu, Apr 07, 2011 at 03:21:48PM +0200, Lukas Fleischer wrote: On Wed, Apr 06, 2011 at 07:27:59PM -0700, elij wrote: On Wed, Apr 6, 2011 at 7:23 PM, elij elij...@gmail.com wrote: Updated with changes Lukas requested. - split logging and mysql removal into separate patches - update

[aur-dev] AUR new package notification

2011-04-12 Thread Lukas Fleischer
I'm not subscribed to new package notifications but it seems like AUR this feature has been disabled for a while now. At least, I did neither find a cronjob running newpackage-notify nor the tupkgs.conf configuration file that is required to run this script. Browsing the aur-dev archives, I also

[aur-dev] Testing patches introducing database layout changes

2011-04-12 Thread Lukas Fleischer
Hi, folks! Just as a recommendation to (regular) contributors: Any patches changing the database layout or the way information is stored in the database should be tested by rebuilding and reloading dummy data into the database in addition to usual testing before submitting them to aur-dev:

Re: [aur-dev] [PATCH 4/4] rpc: allow multiple args on info query

2011-04-12 Thread Lukas Fleischer
On Tue, Apr 12, 2011 at 09:05:05AM -0500, Dan McGee wrote: On Tue, Apr 12, 2011 at 8:52 AM, Justin Davis jrc...@gmail.com wrote: Tuxce submitted a similiar patch awhile back: http://mailman.archlinux.org/pipermail/aur-dev/2010-November/001349.html The patch file isn't on the mailing list

Re: [aur-dev] [PATCH 4/4] rpc: allow multiple args on info query

2011-04-12 Thread Lukas Fleischer
On Tue, Apr 12, 2011 at 01:05:28PM +0200, Tuxce wrote: From d7d06859ddc9425930e586a0685f09f9798dfddc Mon Sep 17 00:00:00 2001 From: tuxce tuxce@gmail.com Date: Tue, 12 Apr 2011 12:42:30 +0200 Subject: [PATCH] rpc: unify methods return. Include maintainer in info and search method. You

Re: [aur-dev] [PATCH] Fix performance issues with new PackageDepends lookups

2011-04-12 Thread Lukas Fleischer
On Tue, Apr 12, 2011 at 09:10:13AM -0500, Dan McGee wrote: On Tue, Apr 12, 2011 at 4:36 AM, Lukas Fleischer archli...@cryptocrack.de wrote: On Tue, Apr 12, 2011 at 11:23:38AM +0200, Lukas Fleischer wrote: On Mon, Apr 11, 2011 at 08:03:43PM -0500, Dan McGee wrote: We do a lookup by DepName

Re: [aur-dev] AUR new package notification

2011-04-13 Thread Lukas Fleischer
On Tue, Apr 12, 2011 at 07:04:35PM -0400, Loui Chang wrote: On Tue 12 Apr 2011 15:16 +0200, Lukas Fleischer wrote: I'm not subscribed to new package notifications but it seems like AUR this feature has been disabled for a while now. At least, I did neither find a cronjob running newpackage

Re: [aur-dev] [PATCH 4/4] rpc: allow multiple args on info query

2011-04-13 Thread Lukas Fleischer
On Wed, Apr 13, 2011 at 08:11:18AM -0500, Dan McGee wrote: I am merely suggesting that the server sort the results for the RPC user. This makes things easier and more intuitive for the user. In the process of querying package info as a whole, you are going to have to associate query words

Re: [aur-dev] [PATCH 4/4] rpc: allow multiple args on info query

2011-04-16 Thread Lukas Fleischer
On Tue, Apr 12, 2011 at 12:15:49AM -0500, Dan McGee wrote: The majority of real world info requests [1] come in hefty batches. We would be better served to handle these in one request rather than multiple by allowing AUR clients to send multiple arguments. This enables things like this to

Re: [aur-dev] [PATCH] Add a .mailmap file

2011-04-19 Thread Lukas Fleischer
On Sat, Apr 16, 2011 at 06:30:58PM -0500, Dan McGee wrote: This takes `git shortlog -sen | wc -l` length from 69 to 56 authors for me, fixing a lot of the author fields that have snuck in over time, and allows credit to be given where due for some contributors that couldn't pick a single email

Re: [aur-dev] [PATCH 2/3] SQL: treat all UID/ID values as numbers, not strings

2011-04-26 Thread Lukas Fleischer
On Mon, Apr 25, 2011 at 11:23:01PM -0500, Dan McGee wrote: Ensure we are not quoting these values in any of our SQL queries. Thanks-to: elij elij...@gmail.com Signed-off-by: Dan McGee d...@archlinux.org --- Smoke tested: * Submitted a package update and it worked * Updated a user's

Re: [aur-dev] [PATCH 1/1] use convenience wrapper for mysql_real_escape_string to aid database portability

2011-04-26 Thread Lukas Fleischer
On Mon, Apr 25, 2011 at 10:21:55PM -0700, elij wrote: when converting to postgres, each mysql_real_escape_string instance had to be changed, which was tedious. Centralizing the escape mechanism code would allow for much easier porting, in the same way that db_query provides a lightweight query

Re: [aur-dev] [PATCH 1/1] use convenience wrapper for mysql_real_escape_string to aid database portability

2011-04-26 Thread Lukas Fleischer
On Tue, Apr 26, 2011 at 10:42:58AM -0500, Dan McGee wrote: On Tue, Apr 26, 2011 at 10:10 AM, Lukas Fleischer archli...@cryptocrack.de wrote: On Mon, Apr 25, 2011 at 10:21:55PM -0700, elij wrote: when converting to postgres, each mysql_real_escape_string instance had to be changed, which

Re: [aur-dev] [PATCH 2/3] SQL: treat all UID/ID values as numbers, not strings

2011-04-27 Thread Lukas Fleischer
On Tue, Apr 26, 2011 at 10:44:33AM -0500, Dan McGee wrote: On Tue, Apr 26, 2011 at 10:04 AM, Lukas Fleischer archli...@cryptocrack.de wrote: On Mon, Apr 25, 2011 at 11:23:01PM -0500, Dan McGee wrote: Ensure we are not quoting these values in any of our SQL queries. Thanks-to: elij elij

Re: [aur-dev] [PATCH 1/1] create variable before referencing it with .=

2011-04-27 Thread Lukas Fleischer
On Mon, Apr 25, 2011 at 11:02:38PM -0700, elij wrote: fixes php notice level error: Undefined variable: whovoted in ../tu.php --- web/html/tu.php |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Thanks, pushed that as well.

Re: [aur-dev] [PATCH 1/1] add SQL_DEBUG variable and database logging

2011-04-27 Thread Lukas Fleischer
On Tue, Apr 26, 2011 at 11:52:11AM -0700, elij wrote: add a hook to db_query to log all sql queries when SQL_DEBUG is set Additionally, provide better logging for sql error situations (provide backtrace as well as error message). --- web/lib/aur.inc | 12

Re: [aur-dev] [PATCH 2/4] test return value from db_query before assuming it is valid

2011-05-11 Thread Lukas Fleischer
On Tue, May 10, 2011 at 09:01:28PM -0700, elij wrote: make the sql query form consistent in usage by cleaning up instances where db_query's result was not inspected before attempting to fetch row data from the handle --- web/html/addvote.php | 16 +- web/html/tu.php

Re: [aur-dev] [PATCH 3/4] fix case where user does not exist

2011-05-11 Thread Lukas Fleischer
On Tue, May 10, 2011 at 09:01:29PM -0700, elij wrote: the query was being performed when $id was not set, resulting in an invalid sql query being performed. --- web/lib/acctfuncs.inc |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/web/lib/acctfuncs.inc

Re: [aur-dev] [PATCH 4/4] make return value consistent for this function

2011-05-11 Thread Lukas Fleischer
On Tue, May 10, 2011 at 09:01:30PM -0700, elij wrote: --- web/lib/aur.inc |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/web/lib/aur.inc b/web/lib/aur.inc index fb267af..f8fa715 100644 --- a/web/lib/aur.inc +++ b/web/lib/aur.inc @@ -196,7 +196,7 @@ function

  1   2   3   4   5   6   7   8   9   10   >