Re: [aur-dev][PATCH] config: allow reading both the proto file and the modified config

I think you're right. I looked one more time and found guard there: if (!isset($AUR_CONFIG)) Thanks for clarification. Nodiv. On Mon, Apr 16, 2018 at 1:41 AM, Eli Schwartz wrote: > On 04/12/2018 02:22 PM, Nodiv Byzero wrote: >> The point is that there are few places

[aur-dev][PATCH] config: allow reading both the proto file and the modified config

On 04/12/2018 02:22 PM, Nodiv Byzero wrote: > The point is that there are few places where config_load() gets called > in the sequential order (the same request) and every time it loads and > parses data. Are these also places where if (!isset($AUR_CONFIG)) fails to actually fulfill its sole

Re: [aur-dev][PATCH] config: allow reading both the proto file and the modified config

On 04/15/2018 06:11 AM, Lukas Fleischer wrote: > Maybe even better: make AUR_CONFIG default to /etc/aurweb/config and > AUR_CONFIG_DEFAULTS default to the value of AUR_CONFIG with an > additional ".defaults" suffix. Great minds think alike. :) -- Eli Schwartz Bug Wrangler and Trusted User

Re: [aur-dev][PATCH] config: allow reading both the proto file and the modified config

On Sat, 14 Apr 2018 at 16:04:58, Lukas Fleischer wrote: > On Thu, 12 Apr 2018 at 19:44:15, Eli Schwartz wrote: > > This change allows aurweb configuration to be done via either: > > - copying config.proto to config and modifying values > > - creating a new config only containing modified values,

Re: [aur-dev][PATCH] config: allow reading both the proto file and the modified config

On Thu, 12 Apr 2018 at 19:44:15, Eli Schwartz wrote: > This change allows aurweb configuration to be done via either: > - copying config.proto to config and modifying values > - creating a new config only containing modified values, next to a > config.proto containing unmodified values > > The

Re: [aur-dev][PATCH] config: allow reading both the proto file and the modified config

The point is that there are few places where config_load() gets called in the sequential order (the same request) and every time it loads and parses data. On Thu, Apr 12, 2018 at 11:05 AM, Eli Schwartz wrote: > On 04/12/2018 01:51 PM, Nodiv Byzero wrote: >> What do you

Re: [aur-dev][PATCH] config: allow reading both the proto file and the modified config

On 04/12/2018 01:51 PM, Nodiv Byzero wrote: > What do you think about adding one more line to check if $config is already > set? > Something like: > if (!isset($config)) { > ... do the parse_ini_file > } > > Just to reduce disk operations. What is the point? We only check if $AUR_CONFIG

Re: [aur-dev][PATCH] config: allow reading both the proto file and the modified config

What do you think about adding one more line to check if $config is already set? Something like: if (!isset($config)) { ... do the parse_ini_file } Just to reduce disk operations. On Thu, Apr 12, 2018 at 10:44 AM, Eli Schwartz wrote: > This change allows aurweb

[aur-dev][PATCH] config: allow reading both the proto file and the modified config

This change allows aurweb configuration to be done via either: - copying config.proto to config and modifying values - creating a new config only containing modified values, next to a config.proto containing unmodified values The motivation for this change is to enable ansible configuration by