Okay -- I'm going to need some time to study/research how these tests work
before I can confidently figure out what's going wrong. I'm on it, not sure
how long it'll take me.
On Wed, Jul 15, 2020 at 8:40 AM Kevin Morris wrote:
> [Re-post to aur-dev]
>
> Yeah. Was planning to, had a bit too much
[Re-post to aur-dev]
Yeah. Was planning to, had a bit too much on my plate to get started when I
saw Frederic's first message. I have a bit of an issue at this point -- on
my dev system, I don't run arch on my current dev machine, and
test/README.md seems to hint that this is an issue (dep:
On Tue, 14 Jul 2020 at 18:25:04, Lukas Fleischer wrote:
> On Mon, 13 Jul 2020 at 10:47:03, Frédéric Mangano-Tarumi wrote:
> > In that last line, `+,` is not a valid Python syntax. The test suite is
> > screaming.
>
> Thanks for the pointer Frédéric, I amended the patch.
Seems like some tests are
On Mon, 13 Jul 2020 at 10:47:03, Frédéric Mangano-Tarumi wrote:
> In that last line, `+,` is not a valid Python syntax. The test suite is
> screaming.
Thanks for the pointer Frédéric, I amended the patch.
Hi Kevin,
Kevin Morris [2020-07-03 18:29:16 -0700]
> diff --git a/aurweb/scripts/notify.py b/aurweb/scripts/notify.py
> index 5b18a476..223ed61f 100755
> --- a/aurweb/scripts/notify.py
> +++ b/aurweb/scripts/notify.py
> @@ -171,7 +171,8 @@ class CommentNotification(Notification):
>
No problem, Lukas! Yeah, basically all my patches except the most recent
one are obsolete.. pretty new to git send-email, wasn't sure about that --
I'll check out -v for future submissions. Thanks for the tip!
On Sat, Jul 4, 2020 at 5:50 AM Lukas Fleischer
wrote:
> On Fri, 03 Jul 2020 at
On Fri, 03 Jul 2020 at 21:29:16, Kevin Morris wrote:
> The existing notify.py script was grabbing entries regardless
> of user suspension. This has been modified to only send notifications
> to unsuspended users.
>
> This change was written as a solution to
>
Alright, that's the final patch revision. This change ultimately just
removes suspended users from the sql results in `notify.py`, which excludes
them from all email notifications.
On Fri, Jul 3, 2020 at 6:29 PM Kevin Morris wrote:
> The existing notify.py script was grabbing entries regardless