Re: [aur-general] PKGBUILD Critique

10.02.2015, 22:22, "Florian Bruhin" : > - Is it really a good idea to check /etc/locale.conf? Wouldn't >   something like   [[ ${LANG,,} == *utf-8* ]]   be more appropriate? > correcting my last reply to you regarding locale.connf and $LANG. /etc/locale.conf is what sets the $LANG parameter.

Re: [aur-general] PKGBUILD Critique

10.02.2015, 22:22, "Florian Bruhin" : > > Some more remarks: > > - Is it really a good idea to check /etc/locale.conf? Wouldn't >   something like   [[ ${LANG,,} == *utf-8* ]]   be more appropriate? I don't know. Is it? Is $LANG set automatically or all arch users will have that set for sure?

Re: [aur-general] PKGBUILD Critique

10.02.2015, 22:33, "David Phillips" : > I question whether checking the locale is appropriate at all. It isn't > something that should be compiled-in, surely? > Dave, The INSTALL file in he source states: "the source files of the fortunes are coded in ISO-8859-15 format, and are installed as t

Re: [aur-general] PKGBUILD Critique

10.02.2015, 22:22, "Florian Bruhin" : >  * stef204 [2015-02-10 18:02:15 -0700]: >>   Anyway, here is an updated version. >> >>    >> >>   Better? >  Some more remarks: > >  - Is it really a good idea to check /etc/locale.conf? Wouldn't >    something like   [[

Re: [aur-general] PKGBUILD Critique

10.02.2015, 18:25, "Daniel Wallace" : > When you do grep like that, you should use two [[, to make sure that it > doesn't care about spaces. > > http://stackoverflow.com/questions/669452/is-preferable-over-in-bash-scripts > > and in this case, you don't need them at all > > if grep -qi 'u

Re: [aur-general] PKGBUILD Critique

I question whether checking the locale is appropriate at all. It isn't something that should be compiled-in, surely? -- Four word witty remark

Re: [aur-general] PKGBUILD Critique

* stef204 [2015-02-10 18:02:15 -0700]: > Anyway, here is an updated version. > > > > Better? Some more remarks: - Is it really a good idea to check /etc/locale.conf? Wouldn't something like [[ ${LANG,,} == *utf-8* ]] be more appropriate? (the ,,

Re: [aur-general] PKGBUILD Critique

10.02.2015, 17:20, "David Phillips" : >  . There are >  a few points that need clearing up before your PKGBUILD can be >  released for use. > >  I'm probably really crap at explaining this, but it was worth a shot. Dave, Thanks for feedback. It's helpful. You're right about just using ./configur

Re: [aur-general] PKGBUILD Critique

When you do grep like that, you should use two [[, to make sure that it doesn't care about spaces. http://stackoverflow.com/questions/669452/is-preferable-over-in-bash-scripts and in this case, you don't need them at all if grep -qi 'utf-*8' /etc/locale.conf; then The above will fail a

[aur-general] PKGBUILD Critique

Hi fellow archers, Would you be so kind as to provide a critique of my PKGBUILD? This is only my third package so bear with me, please. Notes: 1)I have emailed current owner/maintainer but no response yet; hopefully he will reply soon. If not will try again and i

Re: [aur-general] PKGBUILD Critique

Hi stef, contragulations on writing your first (?) PKGBUILD. There are a few points that need clearing up before your PKGBUILD can be released for use. > 2) You can see I have some questions/doubts re. line 26/27 (original PKGBUILD > has 26, I changed it to 27, out of habit I guess. I don't thi