Re: [aur-general] PKGBUILD review request: libdime-hg

2016-08-15 Thread Frederik “Freso” S . Olesen
Den 31-07-2016 kl. 04:22 skrev Eli Schwartz via aur-general: > *-hg/*-git/*-svn packages do not mean the source was checked out using > those protocols, they mean that the package builds from the latest > development sources and that therefore the PKGBUILD will automatically > build e.g. the

Re: [aur-general] PKGBUILD review request: libdime-hg

2016-08-01 Thread Alessandro Menti
I forgot to remove the (now) useless build dependency on mercurial - sorry for the spam. Cheers, Alessandro Menti - The PKGBUILD follows: # Maintainer: Alessandro Menti pkgname=libdime pkgver=r187 _commit=7cd55bc6a6d0 pkgrel=1 pkgdesc="A DXF

Re: [aur-general] PKGBUILD review request: libdime-hg

2016-08-01 Thread Alessandro Menti
Hi Eli, I've fixed all the issues you found, the revised PKGBUILD is below. >> depends=('gcc-libs') > > gcc-libs is part of the base group, and therefore all Arch Linux systems > are expected to have it installed. I am not sure why there are any > packages that (seemingly unnecessarily, except

Re: [aur-general] PKGBUILD review request: libdime-hg

2016-07-31 Thread Eli Schwartz via aur-general
On 07/31/2016 02:52 AM, Alessandro Menti wrote: > Hi Eli, > thanks for the review. > [...] > which suggests the tarball originally released by the authors was a > nightly release (incidentally, r187 corresponds to the current hg "tip"). > > Regarding the pkgver, I think using the ISO 8601

Re: [aur-general] PKGBUILD review request: libdime-hg

2016-07-31 Thread Alessandro Menti
Hi Eli, thanks for the review. > Unless you actually mean to indicate that that package fundamentally > builds the development version from hg "tip", please use the version > tarballs available at > https://bitbucket.org/${user}/${repo}/get/${revision}.tar.gz > > In this case, there do not

Re: [aur-general] PKGBUILD review request: libdime-hg

2016-07-30 Thread Eli Schwartz via aur-general
On 07/30/2016 11:56 AM, Alessandro Menti wrote: > Hi everyone, > I've just started writing some PKGBUILDs for some programs that are not > present neither in the official package repository nor in the AUR. > Specifically, I've packaged libdime [1] as a required dependency for the > X-Plane

[aur-general] PKGBUILD review request: libdime-hg

2016-07-30 Thread Alessandro Menti
Hi everyone, I've just started writing some PKGBUILDs for some programs that are not present neither in the official package repository nor in the AUR. Specifically, I've packaged libdime [1] as a required dependency for the X-Plane developer tools [2]. I'm attaching the PKGBUILD below - if