Re: [aur-general] Package review bitcoin-classic

2017-01-11 Thread Bruno Pagani via aur-general
Le 11/01/2017 à 19:43, Eli Schwartz via aur-general a écrit : > On 01/11/2017 01:15 PM, Bruno Pagani via aur-general wrote: > >> After a quick glance at your install file, I think it should be as >> simple and short as this (+eventual notice for CoW): >> post_install() { >> systemd-sysusers bi

Re: [aur-general] Package review bitcoin-classic

2017-01-11 Thread Bruno Pagani via aur-general
Le 07/01/2017 à 16:41, Tom Zander a écrit : > Hi, > > I created some AUR packages after various people requested it (I'm the > upstream release manager) and since I'm rather new to packaging in Arch, I > would love to have some feedback. Arch packaging is consederably easier than > debian, I m

Re: [aur-general] Package review bitcoin-classic

2017-01-11 Thread Eli Schwartz via aur-general
On 01/11/2017 01:15 PM, Bruno Pagani via aur-general wrote: > After a quick glance at your install file, I think it should be as > simple and short as this (+eventual notice for CoW): > post_install() { > systemd-sysusers bitcoin-classic.conf > systemd-tmpfiles --create bitcoin-classic.con

Re: [aur-general] Package review bitcoin-classic

2017-01-11 Thread Bruno Pagani via aur-general
Le 11/01/2017 à 16:19, Doug Newgard a écrit : > On Wed, 11 Jan 2017 13:22:05 +0100 > Tom Zander wrote: > >> On Saturday, 7 January 2017 14:29:58 CET Doug Newgard wrote: >>> Hardcoding the >>> version here also makes no sense when you could just use $pkgver and only >>> have to update it in one pl

Re: [aur-general] Package review bitcoin-classic

2017-01-11 Thread Bruno Pagani via aur-general
Le 11/01/2017 à 18:01, Tom Zander a écrit : > On Wednesday, 11 January 2017 09:19:45 CET Doug Newgard wrote: >> I'm not talking about the package function, I'm talking about the .install >> file with the post_{install,upgrade,remove} scriptlets. Specifically: > My apologies, I must have misread :)

Re: [aur-general] Package review bitcoin-classic

2017-01-11 Thread Eli Schwartz via aur-general
On 01/11/2017 12:01 PM, Tom Zander wrote: > I have not found out how pacman treats config files on upgrades, removes and > reinstalls. > The point here is that the config file should not be overwritten by the > package version on upgrade, it should not be deleted when the package is > deleted (a

Re: [aur-general] Package review bitcoin-classic

2017-01-11 Thread Tom Zander
On Wednesday, 11 January 2017 09:19:45 CET Doug Newgard wrote: > I'm not talking about the package function, I'm talking about the .install > file with the post_{install,upgrade,remove} scriptlets. Specifically: My apologies, I must have misread :) I have to ask a bit more since your pointers are

Re: [aur-general] Package review bitcoin-classic

2017-01-11 Thread Doug Newgard
On Wed, 11 Jan 2017 13:22:05 +0100 Tom Zander wrote: > On Saturday, 7 January 2017 14:29:58 CET Doug Newgard wrote: > > Alright, I've looked at the first one. There's a whole lot of > > simplification you could do, and a few actual problems. > > > > Problems: > > > > You need to rename the sour

Re: [aur-general] Package review bitcoin-classic

2017-01-11 Thread Bruno Pagani via aur-general
Le 11/01/2017 à 13:22, Tom Zander a écrit : > On Saturday, 7 January 2017 14:29:58 CET Doug Newgard wrote: >> Alright, I've looked at the first one. There's a whole lot of >> simplification you could do, and a few actual problems. >> >> Problems: >> >> You need to rename the source file. It's just

Re: [aur-general] Package review bitcoin-classic

2017-01-11 Thread Tom Zander
On Saturday, 7 January 2017 18:53:46 CET Bruno Pagani via aur-general wrote: > > There are 4, almost identical, versions. > > > > https://aur.archlinux.org/packages/bitcoin-classic/ > > https://aur.archlinux.org/packages/bitcoin-classic-daemon/ > > https://aur.archlinux.org/packages/bitcoin-classi

Re: [aur-general] Package review bitcoin-classic

2017-01-11 Thread Tom Zander
On Saturday, 7 January 2017 14:29:58 CET Doug Newgard wrote: > Alright, I've looked at the first one. There's a whole lot of > simplification you could do, and a few actual problems. > > Problems: > > You need to rename the source file. It's just "v1.2.0.tar.gz" which is > very generic and could

Re: [aur-general] Package review bitcoin-classic

2017-01-07 Thread Doug Newgard
On Sat, 07 Jan 2017 16:41:42 +0100 Tom Zander wrote: > Hi, > > I created some AUR packages after various people requested it (I'm the > upstream release manager) and since I'm rather new to packaging in Arch, I > would love to have some feedback. Arch packaging is consederably easier than >

Re: [aur-general] Package review bitcoin-classic

2017-01-07 Thread Bruno Pagani via aur-general
Hi Tom, Le 07/01/2017 à 16:41, Tom Zander a écrit : > Hi, > > I created some AUR packages after various people requested it (I'm the > upstream release manager) and since I'm rather new to packaging in Arch, I > would love to have some feedback. Arch packaging is consederably easier than > deb

[aur-general] Package review bitcoin-classic

2017-01-07 Thread Tom Zander
Hi, I created some AUR packages after various people requested it (I'm the upstream release manager) and since I'm rather new to packaging in Arch, I would love to have some feedback. Arch packaging is consederably easier than debian, I might add ;) There are 4, almost identical, versions. h