On 10/7/18 10:45 PM, Tom Hale wrote:
> Thanks all for the great reviews.
>
> Thank you in particular to those who said WHY changes were suggested. I
> now feel empowered to go on to package rambox-os.
>
> I believe I have incorporated all the feedback I received in the below.
>
> If I missed
Thanks all for the great reviews.
Thank you in particular to those who said WHY changes were suggested. I
now feel empowered to go on to package rambox-os.
I believe I have incorporated all the feedback I received in the below.
If I missed something it is by mistake - and I ask for your
On Sun, Oct 07, 2018 at 10:46:56AM -0400, Eli Schwartz via aur-general wrote:
> On 10/7/18 5:58 AM, Florian Bruhin wrote:
> > That seems like a good idea, but I'm not sure a PKGBUILD should set it.
> > Maybe makepkg even does it by itself?
> Who says it's a good idea? When is it a good idea? How
On 10/7/18 5:32 AM, Tom Hale wrote:
> Here's a version which builds from HEAD of the default branch.
>
> Comments please.
Well, by convention you would post this inline instead of as an
attachment since it is easier to review that way...
> _pkgname=nixnote2
>
On 7/10/18 4:58 pm, Florian Bruhin wrote:
On Sun, Oct 07, 2018 at 04:32:04PM +0700, Tom Hale wrote:
Guess you could use $_pkgname here for nixnote2. Also not sure
specifying the version there is a good idea.
https://wiki.archlinux.org/index.php/PKGBUILD#provides says:
Note: The version
On Sun, Oct 07, 2018 at 04:32:04PM +0700, Tom Hale wrote:
> Comments please.
Some random stuff I noticed:
> _repo_url="https://github.com/robert7/${_pkgname}.git;
Probably not needed when you only need it in source.
> provides=("nixnote=${pkgver%.r*}" "nixnote2=${pkgver%.r*}")
Guess you could
Here's a version which builds from HEAD of the default branch.
Comments please.
--
Tom Hale
# Maintainer: Tom Hale
# Contributor: twa022
_pkgname=nixnote2
_repo_url="https://github.com/robert7/${_pkgname}.git;
pkgname=${_pkgname}-git
pkgver=v2.1.0.beta3.r95.g8f235769
pkgrel=1
On Sat, 6 Oct 2018 23:09:57 +0700
Tom Hale wrote:
> I want avoid the latest commit for greater stability.
>
> Updated attachment: I've dropped the "-git" from the pkgname as I build
> from the latest annotated tag.
>
> On 6/10/18 10:48 pm, Doug Newgard via aur-general wrote:
> > -git
I want avoid the latest commit for greater stability.
Updated attachment: I've dropped the "-git" from the pkgname as I build
from the latest annotated tag.
On 6/10/18 10:48 pm, Doug Newgard via aur-general wrote:
-git PKGBUILDS need to build from the latest commit on master or the default
On Sat, 6 Oct 2018 22:41:43 +0700
Tom Hale wrote:
> I took over the disowned package nixnote2-git.
>
> Attached is my first attempt at a PKGBUILD. I would appreciate
> constructive feedback.
>
> Thanks in advance,
>
> --
> Tom Hale
-git PKGBUILDS need to build from the latest commit on
I took over the disowned package nixnote2-git.
Attached is my first attempt at a PKGBUILD. I would appreciate
constructive feedback.
Thanks in advance,
--
Tom Hale
# Maintainer: Tom Hale
# Contributor: twa022
# Build the highest versioned tag of nixnote2.
# For versioning, see
11 matches
Mail list logo
