Forwarding my answer to the ML

-------- Message transféré --------
Sujet : Re: unable to build with makepkg (No such file or directory)
Date : Sat, 29 Jul 2023 18:05:03 +0200
De : Robin Candau <an...@archlinux.org>
Pour : james smith <cinemassac...@gmail.com>

Le 29/07/2023 à 17:45, james smith a écrit :
trying to build this https://github.com/matthewq337/auto-fdisk <https://github.com/matthewq337/auto-fdisk> https://bpa.st/H6XQ <https://bpa.st/H6XQ>

Hi,

Can you provide a bit more details? You can provide the output of `makepkg` for instance.

On a side note, by quickly looking at your PKGBUILD, I can see a bunch of issue:

- Your PKGBUILD seems to build a VCS package. Your pkgname has to reflect that by adopting a `-git` suffix.
- The "source." prefix in your pkgver is un-necessary.
- Auto-fdisk is licensed under the MIT license so it has to be packaged by the PKGBUILD. See the first bullet point of the related wiki "license" chapter for more details [1]. - The package should depend on `bash` rather than `sh`. For what it's worth, bash being a member of the `base` metapackage [2], you don't even have to list it as a dependency if you prefer, as the `base` metapackage is assumed installed at runtime.
- Missing `git` as a makedepends.

And, most importantly, why did you fork the upstream project [3] and deliver your fork in the PKGBUILD [4] instead of relying on the actual upstream repo [5] directly? Is there any particular reason for that?

[1] https://wiki.archlinux.org/title/PKGBUILD#license
[2] https://archlinux.org/packages/core/any/base/
[3] https://github.com/matthewq337/auto-fdisk
[4] https://bpa.st/H6XQ#1L7-L7
[5] https://github.com/ivmm/Auto-fdisk

--
Regards,
Robin Candau / Antiz

Attachment: OpenPGP_0xFDC3040B92ACA748.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to