Re: [aur-general] Exact purpose of check()

2019-01-02 Thread Eli Schwartz via aur-general
On 1/2/19 10:02 AM, Morten Linderud via aur-general wrote: > We can also add a more explicit warning in the package guidelines. > > https://wiki.archlinux.org/index.php/Python_package_guidelines#Check Let's do this anyway:

Re: [aur-general] Exact purpose of check()

2019-01-02 Thread Morten Linderud via aur-general
We can also add a more explicit warning in the package guidelines. https://wiki.archlinux.org/index.php/Python_package_guidelines#Check -- Morten Linderud PGP: 9C02FF419FECBE16 signature.asc Description: PGP signature

Re: [aur-general] Exact purpose of check()

2019-01-02 Thread Morten Linderud via aur-general
On Wed, Jan 02, 2019 at 03:44:46PM +0100, Julien Nicoulaud via aur-general wrote: > There is a bit of debate at the borgmatic package ( > https://aur.archlinux.org/packages/borgmatic) about what check() should do. > The upstream borgmatic project uses tox to execute its tests. tox creates > an

Re: [aur-general] Exact purpose of check()

2019-01-02 Thread Levente Polyak via aur-general
Tox should never ever be used for check() exactly for the reasons your pointed out. It is supposed to check the build/package works without regression in the environment it will run in. Running the test against system libraries that are later after install used by the runtime is the way check()

Re: [aur-general] Exact purpose of check()

2019-01-02 Thread Eli Schwartz via aur-general
On 1/2/19 9:44 AM, Julien Nicoulaud via aur-general wrote: > Hi, > > There is a bit of debate at the borgmatic package ( > https://aur.archlinux.org/packages/borgmatic) about what check() should do. > The upstream borgmatic project uses tox to execute its tests. tox creates > an isolated python