Re: [PATCH] use m4_require to implement AS_REQUIRE

2008-10-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paolo Bonzini on 10/12/2008 10:20 AM: The implementation is easy, though I had to try several times before getting it right. Anyway, the attached patch works and adds a testcase for the first behavior. The second bug is already

Re: [PATCH] use m4_require to implement AS_REQUIRE

2008-10-17 Thread Paolo Bonzini
It's still not perfect. This file is failing: AS_INIT foo=bar AS_VAR_PUSHDEF([tmp], [foo]) AS_VAR_IF(tmp, [bar], [echo yes], [echo no]) AS_VAR_POPDEF([tmp]) because it is expanding _AS_TR_SH_PREPARE in the middle of AS_VAR_IF rather than hoisting it into M4SH-INIT right after

Re: [PATCH] use m4_require to implement AS_REQUIRE

2008-10-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paolo Bonzini on 10/17/2008 6:19 AM: That's related to tmp being underquoted, see the following even more reduced testcase AS_INIT m4_defun([AS_DOIT], [: $1]) m4_define([tmp], [AS_TR_SH(foo)]) AS_DOIT(tmp) = : # Sed expression

Re: [PATCH] use m4_require to implement AS_REQUIRE

2008-10-17 Thread Paolo Bonzini
Eric Blake wrote: According to Paolo Bonzini on 10/17/2008 6:19 AM: That's related to tmp being underquoted, see the following even more reduced testcase AS_INIT m4_defun([AS_DOIT], [: $1]) m4_define([tmp], [AS_TR_SH(foo)]) AS_DOIT(tmp) = : # Sed expression to map a string onto a valid

Re: Add and document AS_VAR_COPY, speed up configure

2008-10-17 Thread Ralf Wildenhues
Hi Eric, * Eric Blake wrote on Fri, Oct 17, 2008 at 07:43:51PM CEST: I'm planning on committing this to savannah later today, unless someone reviews it sooner. Overall very nice, only nits. Thanks! Subject: [PATCH] Add AS_VAR_COPY. +# AS_VAR_SET(VARIABLE, VALUE) +#

reduce vertical whitespace

2008-10-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Looking at configure, there was a big window of vertical whitespace. This narrows it to be a bit more legible (configure scripts, as generated files, will never be perfectly easy to read, but every little bit helps. Applying this: - -- Don't work

Re: naming m4_transform

2008-10-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 10/14/2008 5:31 PM: I like it. Here's three preliminary patches along this front: aaee3a9 Document m4_map_args. 4cd6caa Add m4_set_map. 3bdb8d4 Improve suggested test filtering. But m4 doesn't make it easy to

Re: [CFT] Shell functionization patch (if you don't know what that means, it's faster Autoconf and leaner configure scripts)

2008-10-17 Thread Ralf Wildenhues
Hi Paolo, * Paolo Bonzini wrote on Thu, Oct 16, 2008 at 06:38:19PM CEST: Also, the zsh issue has to be understood better (and could be a deal breaker, though I don't think so). It basically means that you cannot call exit nor trap inside a shell function. Nor can you use $? at the start of a

RE: cache problem

2008-10-17 Thread Duft Markus
Hello Markus, thanks for the reports. [snip] FWIW, I'm not yet sure whether this is a valid problem. Even if it is, you should be able to work around it by adding AC_CANONICAL_HOST to the toplevel configure.ac. But anyway, before discussing validity let's try to reproduce it: I

Re: [RFH] zsh shell function portability issue

2008-10-17 Thread Paolo Bonzini
Do you think that: (eval $ac_link) 25 ac_status=$? (eval $ac_try) 25 ac_status=$? are portable? Pretty likely not: $ zsh --version zsh 4.2.3 (powerpc-apple-darwin8.0) $ zsh $ f () { ( exit 1); echo $?; }; f 0 $ f () { ( exit 1) echo bad; }; f bad

Re: cache problem

2008-10-17 Thread Ralf Wildenhues
* Duft Markus wrote on Fri, Oct 17, 2008 at 09:00:16AM CEST: I haven't been able to do so yet. Here's what I tried. Please modify the example so that it shows the failure (maybe it only needs different flags passed to configure?) Hehe, the problem occured when using the same cache file

Re: [CFT] Shell functionization patch (if you don't know what that means, it's faster Autoconf and leaner configure scripts)

2008-10-17 Thread Paolo Bonzini
Also, the zsh issue has to be understood better (and could be a deal breaker, though I don't think so). It basically means that you cannot call exit nor trap inside a shell function. Nor can you use $? at the start of a function. But you'll deal with that anyway since you will want to

Re: cache problem

2008-10-17 Thread Paolo Bonzini
I recently posted a patch to do just this. It wasn't applied, one reason being that we didn't see a way how two configure scripts could be running simultaneously; with AC_CONFIG_SUBDIRS at least (the GCC tree uses a different way but uses per-configure cache files). How do you get two

Re: [RFH] zsh shell function portability issue

2008-10-17 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Fri, Oct 17, 2008 at 09:14:20AM CEST: But the only arguments in the eval *when the eval appears in shell functions* (I don't care about user code relying on _AC_DO, because it will appear outside functions) are: $ac_cpp $ac_compile $ac_link

Re: [RFH] zsh shell function portability issue

2008-10-17 Thread Paolo Bonzini
Right. Might want to explicitly discourage touching those variables. (This is hopefully not common today, but probably not so uncommon in legacy code.) I'll look at http://www.google.com/codesearch?q=ac_(compile|link|cpp)%3D+file%3Aconfigure.ac

RE: cache problem

2008-10-17 Thread Duft Markus
* Duft Markus wrote on Fri, Oct 17, 2008 at 09:00:16AM CEST: I haven't been able to do so yet. Here's what I tried. Please modify the example so that it shows the failure (maybe it only needs different flags passed to configure?) Hehe, the problem occured when using the same

Re: [RFH] zsh shell function portability issue

2008-10-17 Thread Paolo Bonzini
Paolo Bonzini wrote: Right. Might want to explicitly discourage touching those variables. (This is hopefully not common today, but probably not so uncommon in legacy code.) I'll look at http://www.google.com/codesearch?q=ac_(compile|link|cpp)%3D+file%3Aconfigure.ac

Re: [CFT] Shell functionization patch (if you don't know what that means, it's faster Autoconf and leaner configure scripts)

2008-10-17 Thread Paolo Bonzini
Eric Blake wrote: According to Paolo Bonzini on 10/16/2008 10:38 AM: Hi all, this is *the* patch to add shell functions to Autoconf at last. I am submitting it in one piece for testing, but I'm not really calling for review; for that, I'll submit it split in 12 pieces. Also, the zsh issue

Re: cache problem

2008-10-17 Thread Olly Betts
On 2008-10-17, Eric Blake [EMAIL PROTECTED] wrote: According to Olly Betts on 10/16/2008 7:40 PM: On 2008-10-16, Ralf Wildenhues [EMAIL PROTECTED] wrote: How do you get two concurrent configure scripts updating the same config.cache file? Open terminal (or screen) windows for two