Re: [PATCH 1/2] autoreconf: integrate gtkdocize into the standard reconfiguration tools

2020-03-13 Thread Eli Schwartz
On 3/17/19 3:01 PM, Eli Schwartz wrote: > When the GTK_DOC_CHECK macro is in use, this flags a given configure.ac > as belonging the the common class of gtk-related software that requires > the gtkdocize tool to be run before autoreconf, in order to install the > gtk-doc macro and Makefile

Re: [PATCH] Define $as_echo and $as_echo_n for backward compatibility.

2020-03-13 Thread Chet Ramey
On 3/13/20 3:32 PM, Eric Blake wrote: > I'm wondering if Chet has an update on the matter (adding bug-bash). > Repeating some context: > https://www.mail-archive.com/austin-group-l@opengroup.org/msg04237.html > was a mail to the POSIX folks last June complaining about how bash 5.0's > change to

Re: [PATCH] Define $as_echo and $as_echo_n for backward compatibility.

2020-03-13 Thread Eric Blake
On 3/13/20 2:22 PM, Zack Weinberg wrote: On Fri, Mar 13, 2020 at 3:13 PM Eric Blake wrote: Unpatched bash 5.0 has a bug where calling $as_echo that contains \ can result in unintended globbing, where the behavior of the expansion is dependent on the contents of the current directory. Nasty!

Re: [PATCH] Define $as_echo and $as_echo_n for backward compatibility.

2020-03-13 Thread Zack Weinberg
On Fri, Mar 13, 2020 at 3:13 PM Eric Blake wrote: > > Unpatched bash 5.0 has a bug where calling $as_echo that contains \ can > result in unintended globbing, where the behavior of the expansion is > dependent on the contents of the current directory. Nasty! Yikes! And not just unpatched

Re: [PATCH] Define $as_echo and $as_echo_n for backward compatibility.

2020-03-13 Thread Eric Blake
On 3/13/20 1:57 PM, Zack Weinberg wrote: Commit 2b59b6f8a79b8bf77e178ff4e5aa0ede433d39cf removed the internal shell variables $as_echo and $as_echo_n. It turns out that these are used by several widely-used third-party m4 files (notably both gnulib-common.m4 from gnulib, and ax_pthread.m4 from

Re: [PATCH] _AS_REEXEC_WITH_SHELL: don’t use AS_EXIT.

2020-03-13 Thread Nick Bowler
On 2020-03-13, Zack Weinberg wrote: > This is only a theoretical bug because, as the comments say, “all the > known shells bail out after a failed exec.” However, a shell that > doesn’t bail out will instead give the user a flood of nonsensical > error messages (starting with “as_fn_exit: not

[PATCH] Define $as_echo and $as_echo_n for backward compatibility.

2020-03-13 Thread Zack Weinberg
Commit 2b59b6f8a79b8bf77e178ff4e5aa0ede433d39cf removed the internal shell variables $as_echo and $as_echo_n. It turns out that these are used by several widely-used third-party m4 files (notably both gnulib-common.m4 from gnulib, and ax_pthread.m4 from the Autoconf macro archive) as well as any

Re: [PATCH] _AS_REEXEC_WITH_SHELL: don’t use AS_EXIT.

2020-03-13 Thread Eric Blake
On 3/13/20 12:52 PM, Zack Weinberg wrote: If _AS_REEXEC_WITH_SHELL fails to exec the selected “better” shell interpreter, and that failure somehow doesn’t terminate the process, it calls AS_EXIT([255]). This expands to an invocation of as_fn_exit. However, the definition of as_fn_exit goes into

[PATCH] _AS_REEXEC_WITH_SHELL: don’t use AS_EXIT.

2020-03-13 Thread Zack Weinberg
If _AS_REEXEC_WITH_SHELL fails to exec the selected “better” shell interpreter, and that failure somehow doesn’t terminate the process, it calls AS_EXIT([255]). This expands to an invocation of as_fn_exit. However, the definition of as_fn_exit goes into the M4SH-INIT-FN diversion, whereas