Re: [PATCH] AS_INIT: don't encode full path

On 20-07-05 10:16, Zack Weinberg wrote: | On Sun, Jul 5, 2020 at 12:13 AM Luke Mewburn wrote: | > | > I've updated the patch to address your comments: | > 1) Added a testsuite. | > 2) Added the comment. | > 3) Improved the regex. (Thanks for the heads up about M4 greedy regex.) |

Re: [PATCH] AS_INIT: don't encode full path

On Sun, Jul 5, 2020 at 12:13 AM Luke Mewburn wrote: > > I've updated the patch to address your comments: > 1) Added a testsuite. > 2) Added the comment. > 3) Improved the regex. (Thanks for the heads up about M4 greedy regex.) Thanks for the quick reply! I adjusted the wording of the comment a

Re: [PATCH] AS_INIT: don't encode full path

On 20-07-04 13:00, Zack Weinberg wrote: | On Fri, Jul 3, 2020 at 8:42 PM Luke Mewburn wrote: | > | > Fix AS_INIT to use the basename of __file__ instead of the full path. | > Allows for reproducible builds. | | I like the idea here, but I think the patch isn't quite ready yet. |

Re: [PATCH] AS_INIT: don't encode full path

On Fri, Jul 3, 2020 at 8:42 PM Luke Mewburn wrote: > > Fix AS_INIT to use the basename of __file__ instead of the full path. > Allows for reproducible builds. I like the idea here, but I think the patch isn't quite ready yet. Most importantly, please write a test for the testsuite to ensure that

[PATCH] AS_INIT: don't encode full path

Fix AS_INIT to use the basename of __file__ instead of the full path. Allows for reproducible builds. --- lib/m4sugar/m4sh.m4 |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/m4sugar/m4sh.m4 b/lib/m4sugar/m4sh.m4 index af28685..78419e9 100644 --- a/lib/m4sugar/m4sh.m4