Re: [PATCH] _AS_REEXEC_WITH_SHELL: don’t use AS_EXIT.

2020-03-13 Thread Nick Bowler
On 2020-03-13, Zack Weinberg wrote: > This is only a theoretical bug because, as the comments say, “all the > known shells bail out after a failed exec.” However, a shell that > doesn’t bail out will instead give the user a flood of nonsensical > error messages (starting with “as_fn_exit: not

Re: [PATCH] _AS_REEXEC_WITH_SHELL: don’t use AS_EXIT.

2020-03-13 Thread Eric Blake
On 3/13/20 12:52 PM, Zack Weinberg wrote: If _AS_REEXEC_WITH_SHELL fails to exec the selected “better” shell interpreter, and that failure somehow doesn’t terminate the process, it calls AS_EXIT([255]). This expands to an invocation of as_fn_exit. However, the definition of as_fn_exit goes into

[PATCH] _AS_REEXEC_WITH_SHELL: don’t use AS_EXIT.

2020-03-13 Thread Zack Weinberg
If _AS_REEXEC_WITH_SHELL fails to exec the selected “better” shell interpreter, and that failure somehow doesn’t terminate the process, it calls AS_EXIT([255]). This expands to an invocation of as_fn_exit. However, the definition of as_fn_exit goes into the M4SH-INIT-FN diversion, whereas