Re: [PATCH 1/2] Fix detection of GNU M4 on mksh

Hi/2. Zack Weinberg wrote: > On Wed, Oct 18, 2023, at 10:09 AM, KO Myung-Hun wrote: >> Zack Weinberg wrote: >>> Details please? >> >> Commit message was not enough ? > > I'm afraid not. I needed to know everything you say in the next two > paragraphs: > >> $ac_snip2 contains NL. And in order

Re: [PATCH 1/2] Fix detection of GNU M4 on mksh

On Wed, Oct 18, 2023, at 10:09 AM, KO Myung-Hun wrote: > Zack Weinberg wrote: >> Details please? > > Commit message was not enough ? I'm afraid not. I needed to know everything you say in the next two paragraphs: > $ac_snip2 contains NL. And in order to print it, `print -r --' command > is used

Re: [PATCH 1/2] Fix detection of GNU M4 on mksh

Hi/2. Zack Weinberg wrote: > On Sun, Oct 15, 2023, at 2:58 AM, KO Myung-Hun wrote: >> Zack Weinberg wrote: >>> On Sat, Oct 14, 2023, at 9:19 AM, KO Myung-Hun wrote: * m4/m4.m4 (AC_PROG_GNU_M4): Double-quotes $ac_snip2. >>> Please explain why it isn't also necessary to add double quotes >>>

Re: [PATCH 1/2] Fix detection of GNU M4 on mksh

On Sun, Oct 15, 2023, at 2:58 AM, KO Myung-Hun wrote: > Zack Weinberg wrote: >> On Sat, Oct 14, 2023, at 9:19 AM, KO Myung-Hun wrote: >>> * m4/m4.m4 (AC_PROG_GNU_M4): Double-quotes $ac_snip2. >> Please explain why it isn't also necessary to add double quotes >> around all the other variable

Re: [PATCH 1/2] Fix detection of GNU M4 on mksh

Hi/2. Zack Weinberg wrote: > On Sat, Oct 14, 2023, at 9:19 AM, KO Myung-Hun wrote: >> * m4/m4.m4 (AC_PROG_GNU_M4): Double-quotes $ac_snip2. > > Please explain why it isn't also necessary to add double quotes > around all the other variable expansions in this check, particularly > $ac_snippet and

Re: [PATCH 1/2] Fix detection of GNU M4 on mksh

On Sat, Oct 14, 2023, at 9:19 AM, KO Myung-Hun wrote: > * m4/m4.m4 (AC_PROG_GNU_M4): Double-quotes $ac_snip2. Please explain why it isn't also necessary to add double quotes around all the other variable expansions in this check, particularly $ac_snippet and $ac_path_M4. Also, typo in your

[PATCH 1/2] Fix detection of GNU M4 on mksh

* m4/m4.m4 (AC_PROG_GNU_M4): Double-quotes $ac_snip2. --- m4/m4.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/m4.m4 b/m4/m4.m4 index e6203118..76fbd04f 100644 --- a/m4/m4.m4 +++ b/m4/m4.m4 @@ -46,7 +46,7 @@ AC_PATH_PROGS_FEATURE_CHECK([M4], [m4 gm4 gnum4], test