Re: [PATCH v2] AC_HEADER_MAJOR: port to glibc 2.25

Doh, one small correction: > +@verbatim > +#include > +#ifdef MAJOR_IN_MKDEV > +# include > +#elif MAJOR_IN_SYSMACROS > +# include > +#endif > +@end verbatim That should be `#elif defined MAJOR_IN_SYSMACROS`. This was originally my mistake and I just realized it _was_ a mistake, sorry.

Re: [PATCH v2] AC_HEADER_MAJOR: port to glibc 2.25

On 09/14/2016 08:14 PM, Zack Weinberg wrote: > Doh, one small correction: > >> +@verbatim >> +#include >> +#ifdef MAJOR_IN_MKDEV >> +# include >> +#elif MAJOR_IN_SYSMACROS >> +# include >> +#endif >> +@end verbatim > > That should be `#elif defined MAJOR_IN_SYSMACROS`. This was > originally

Re: [PATCH v2] AC_HEADER_MAJOR: port to glibc 2.25

On Wed, Sep 14, 2016 at 3:00 PM, Eric Blake wrote: > > Thanks for the wordsmithing help, and forcing me to think about > mingw. This version updates some wording, and changes the macro > to leave the relative order of mkdev.h vs. sysmacros.h checking > unchanged (by merely

[PATCH v2] AC_HEADER_MAJOR: port to glibc 2.25

glibc 2.25 is deprecating the namespace pollution of sys/types.h injecting major(), minor(), and makedev() into the compilation environment, with a warning that insists that users include instead. However, because the expansion of AC_HEADER_MAJOR didn't bother checking sys/sysmacros.h until