Re: dist-xz compression level

2010-04-11 Thread Ralf Wildenhues
Hello Pavel, * Pavel Sanda wrote on Wed, Apr 07, 2010 at 01:22:06PM CEST: the newly added dist-xz target produce worse compressed archives than lzma-dist. The reason is that automake call lzma with best compression while it won't use -9 level for xz. Is this intention or bug? Bug, I guess.

Re: [PATCH] Check that symlinks are resolved by `make dist'.

2010-04-11 Thread Ralf Wildenhues
Hello Stefano, * Stefano Lattarini wrote on Sun, Apr 04, 2010 at 08:57:19PM CEST: At Sunday 04 April 2010, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Fri, Apr 02, 2010 at 12:29:49AM CEST: By the way, how is the Automake-generated Makefile expected to behave if a file in e.g.

Re: [PATCH] Avoid possible false negatives in cond46.test.

2010-04-11 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Apr 09, 2010 at 02:19:32AM CEST: Avoid possible false negatives in cond46.test. * tests/cond46.test: Enable shell `errexit' flag (and bumped copyright years). Due to this change, the testcase should now fail on unexpected failures in calls to

Re: [PATCH 2/2] Bugfix in confh5.test w.r.t. Solaris/Heirloom Sh.

2010-04-11 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Apr 09, 2010 at 05:11:44PM CEST: * tests/confh5.test: In the generated Makefile.am: do not use `test ! -e FILE' to check for the non-existence of a file, since that is not supported by Solarish/Heirloom Sh. Applied to maint. Thanks! Ralf

Re: [PATCH 1/2] Use `set -e' in confsub.test (avoid false negatives).

2010-04-11 Thread Ralf Wildenhues
Hello Stefano, * Stefano Lattarini wrote on Fri, Apr 09, 2010 at 07:25:31PM CEST: -$ACLOCAL || Exit 1 -$AUTOMAKE || Exit 1 +$ACLOCAL +$AUTOMAKE there is no need to actually remove these. They may not be strictly required any more with 'set -e', but they may still serve as visual reminder

Re: [PATCH 1/2] Use `set -e' in confsub.test (avoid false negatives).

2010-04-11 Thread Stefano Lattarini
At Sunday 11 April 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: Hello Stefano, * Stefano Lattarini wrote on Fri, Apr 09, 2010 at 07:25:31PM CEST: -$ACLOCAL || Exit 1 -$AUTOMAKE || Exit 1 +$ACLOCAL +$AUTOMAKE there is no need to actually remove these. Strictly speaking, no;

Re: [PATCH] Avoid possible false negatives in cond46.test.

2010-04-11 Thread Stefano Lattarini
At Sunday 11 April 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: * Stefano Lattarini wrote on Fri, Apr 09, 2010 at 02:19:32AM CEST: Avoid possible false negatives in cond46.test. * tests/cond46.test: Enable shell `errexit' flag (and bumped copyright years). Due to this change, the

Re: dist-xz compression level

2010-04-11 Thread Ralf Wildenhues
Hello Andreas, * Andreas Jellinghaus wrote on Sun, Apr 11, 2010 at 09:37:13PM CEST: isn't xz extremely slw with -9? maybe it wasn't a bug, bit intentionally not used, as that huge extra amount of time doesn't result in that many bytes saved. Well, does somebody have numbers (memory,

[PATCH 0/5] Prepend 'error: ' or 'warning: ' to messages.

2010-04-11 Thread Ralf Wildenhues
Hello Bruno, all, I'm sure it was you who requested this feature, but I can't find the reference to this issue now. Anyway, here's a small patch series to let automake and aclocal consistenly prefix warning and error messages, applied to git master. I wasn't completely sure about the case of

Re: [PATCH] Avoid possible false negatives in cond46.test.

2010-04-11 Thread Stefano Lattarini
At Sunday 11 April 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: How'd you suggest to shorten the log entry above, while keeping it meaningful? By cutting the part which I did not quote. :-) Oops, I missed that. Being verbose is fine for things that are unobvious, but you may

[PATCH 2/5] Fix capitalization of error messages, reword one message.

2010-04-11 Thread Ralf Wildenhues
* lib/Automake/Variable.pm (define): Do not capitalize the first word in the error message. * automake.in (require_file_internal): Likewise. Also, reword and line-wrap for better readability. * tests/distcom7.test, tests/pluseq5.test, tests/pluseq9.test: Adjust tests. Signed-off-by: Ralf

[PATCH 3/5] Prepend type to warning, error, and fatal messages.

2010-04-11 Thread Ralf Wildenhues
For the first part of messages of types `error' or `fatal', prepend `error: ' to the message. Prepend `warning: ' to warning messages, whatever the setting of -Werror. * lib/Automake/Channels.pm (partial): Move up definition. (_format_message): Emit `header' and `footer' strings only with the

[PATCH 4/5] Ensure we don't print 'warning:' or 'error:' twice.

2010-04-11 Thread Ralf Wildenhues
* Makefile.am (sc_ensure_testsuite_has_run): New helper rule. (sc_tests_logs_duplicate_prefixes): New rule, to check for wrong-looking warning and error messages in the test suite logs. * aclocal.in (scan_configure_dep, scan_file): Remove duplicate `warning: ' prefix. * tests/vars3.test: Rename

[PATCH 5/5] Print 'warnings are treated as errors' note if needed.

2010-04-11 Thread Ralf Wildenhues
* lib/Automake/Channels.pm: Fix typo in comment. (_print_message): If -Werror is enabled, print a 'warnings are treated as errors' note before the first such warning. * tests/warnopts.test: Adjust comment to mention expected warning. Adjust code to ignore 'warnings are treated as errors' note. *

[PATCH] Fix typos in comments in test confh5.test

2010-04-11 Thread Stefano Lattarini
I've just found a couple of stupid typos in the last version of the patch. They are in a comment, so no big deal, but a fix is always welcome, right? Thanks, and sorry for the noise, Stefano From 8005809d6e64af309d2e4b5499ac93317f1f1d3b Mon Sep 17 00:00:00 2001 From: Stefano Lattarini

Re: [PATCH 0/5] Prepend 'error: ' or 'warning: ' to messages.

2010-04-11 Thread Bruno Haible
Hello Ralf, I'm sure it was you who requested this feature, but I can't find the reference to this issue now. Yes, I raised it, but I'm sure others have wanted the same feature before me. I wasn't completely sure about the case of warnings in the presence of -Werror. ... we print a note

PATCH 1/2] Avoid possible false negatives in canon-name.test.

2010-04-11 Thread Stefano Lattarini
Avoid possible false negatives in canon-name.test (by enabling `set -e'). * tests/canon-name.test: Enable shell `errexit' flag (and bumped copyright years). Due to this change, the testcase should now fail on unexpected failures of aclocal, and on failures in grepping the expected diagnostic in

Re: [PATCH] Avoid possible false negatives in cond46.test.

2010-04-11 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Apr 11, 2010 at 10:30:19PM CEST: At Sunday 11 April 2010, Ralf Wildenhues wrote: Being verbose is fine for things that are unobvious, but you may assume that developers know autoconf.info. Quite right. However, as you said when discussing my proposed patch

Makefile.in and Makefile not generated when using a static library

2010-04-11 Thread isulsz
Hi, I am new to GNU Auto tools and I am trying to build a project that contains several source files and a static library. My directory is like: (project root)/src/app/: This contains the source files to build a binary (project root)/src/Random/: This contains the source files to build a library

Re: Makefile.in and Makefile not generated when using a static library

2010-04-11 Thread Jason Curl
On 11/04/2010 03:10, isulsz wrote: Hi, I am new to GNU Auto tools and I am trying to build a project that contains several source files and a static library. My directory is like: (project root)/src/app/: This contains the source files to build a binary (project root)/src/Random/: This contains

Re: Makefile.in and Makefile not generated when using a static library

2010-04-11 Thread William Pursell
isulsz wrote: I am new to GNU Auto tools and I am trying to build a project that contains several source files and a static library. snip The configure.in is AC_INIT(./src/app/SimpMSourSimu.cpp) AM_INIT_AUTOMAKE(MultiSour, 0.8) AC_PROG_CXX AC_PROG_INSTALL AC_PROG_RANLIB

Re: dist-xz compression level

2010-04-11 Thread Ralf Wildenhues
Hello Pavel, * Pavel Sanda wrote on Wed, Apr 07, 2010 at 01:22:06PM CEST: the newly added dist-xz target produce worse compressed archives than lzma-dist. The reason is that automake call lzma with best compression while it won't use -9 level for xz. Is this intention or bug? Bug, I guess.

Re: dist-xz compression level

2010-04-11 Thread Andreas Jellinghaus
isn't xz extremely slw with -9? maybe it wasn't a bug, bit intentionally not used, as that huge extra amount of time doesn't result in that many bytes saved. is the compression level configureable somehow? Regards, Andreas

Re: dist-xz compression level

2010-04-11 Thread Ralf Wildenhues
Hello Andreas, * Andreas Jellinghaus wrote on Sun, Apr 11, 2010 at 09:37:13PM CEST: isn't xz extremely slw with -9? maybe it wasn't a bug, bit intentionally not used, as that huge extra amount of time doesn't result in that many bytes saved. Well, does somebody have numbers (memory,

Re: dist-xz compression level

2010-04-11 Thread Pavel Sanda
isn't xz extremely slw with -9? maybe it wasn't a bug, bit intentionally not used, as that huge extra amount of time doesn't result in that many bytes saved. Compared to the total time of make dist its IMHO acceptable. But configurability won't hurt of course. Pavel

Re: dist-xz compression level

2010-04-11 Thread Pavel Sanda
Well, does somebody have numbers (memory, time, compression) as to what is reasonable? I didn't make any testing, but the report came from the observation that result was +300kb on 9 mb. The compression was slow, but decompression is not affected. pavel

Re: Makefile.in and Makefile not generated when using a static library

2010-04-11 Thread Stefano Lattarini
AC_OUTPUT(src/app/Makefile, src/Random/Makefile, Makefile) If you want to pass two or more files to AC_OUTPUT, you must separate them by white spaces, not by commas. Otherwise, only the first one is considered (in this case only `src/app/Makefile'), which is hardly what you want. That said,

Re: dist-xz compression level

2010-04-11 Thread Bob Friesenhahn
On Sun, 11 Apr 2010, Pavel Sanda wrote: isn't xz extremely slw with -9? maybe it wasn't a bug, bit intentionally not used, as that huge extra amount of time doesn't result in that many bytes saved. Compared to the total time of make dist its IMHO acceptable. But configurability won't hurt

Re: dist-xz compression level

2010-04-11 Thread Pavel Sanda
Are you assuming 'make dist' after 'make' or 'make dist' from scratch? Other than the time spent compressing data, 'make dist' after 'make' should be quite fast. Yep, I mean the make dist from the scratch; i.e. what one usually does when creating new release. The compression is used very

Re: dist-xz compression level

2010-04-11 Thread Bob Friesenhahn
On Sun, 11 Apr 2010, Pavel Sanda wrote: Are you assuming 'make dist' after 'make' or 'make dist' from scratch? Other than the time spent compressing data, 'make dist' after 'make' should be quite fast. Yep, I mean the make dist from the scratch; i.e. what one usually does when creating new

Re: dist-xz compression level

2010-04-11 Thread Pavel Sanda
The same can be said about currently used -9 for lzma, no? Yes. The argument is that it should be possible to optionally set the compression level. In most cases, the compression default should be the tool's compression default. I have no problem with such solution. Pavel

Re: Makefile.in and Makefile not generated when using a static library

2010-04-11 Thread Stefano Lattarini
AC_OUTPUT(src/app/Makefile, src/Random/Makefile, Makefile) If you want to pass two or more files to AC_OUTPUT, you must separate them by white spaces, not by commas. Otherwise, only the first one is considered (in this case only `src/app/Makefile'), which is hardly what you want. That said,

Re: Makefile.in and Makefile not generated when using a static library

2010-04-11 Thread Stefano Lattarini
Hello William. I hope you don't mind a little nitpicking on your overall good suggestions... Rename the file configure.ac, and modify the contents to be: AC_INIT([MultiSour], [0.8]) AC_CONFIG_SRCDIR([src/app/SimpMSourSimu.cpp]) AM_INIT_AUTOMAKE([foreign]) AC_PROG_CXX AC_PROG_INSTALL

Re: Makefile.in and Makefile not generated when using a static library

2010-04-11 Thread William Pursell
Stefano Lattarini wrote: Hello William. I hope you don't mind a little nitpicking on your overall good suggestions... Absolutely not. One of the main reasons I ever post solutions on any forum is to get criticism. I've discovered that learning things about which I am totally ignorant is

Re: Makefile.in and Makefile not generated when using a static library

2010-04-11 Thread isulsz
Thanks. I see the problem and I use the white spaces instead of commas and it seemes to work, I see the Makefile.in and Makefile in src/Random directory. But I have a new problem. When I try to make the project, I get this error: *** No rule to make target `../../src/Random/librng.a', needed by

Re: Makefile.in and Makefile not generated when using a static library

2010-04-11 Thread Ralf Wildenhues
Hello William, * William Pursell wrote on Mon, Apr 12, 2010 at 04:34:48AM CEST: Stefano Lattarini wrote: Strictly speaking, AC_PROG_INSTALL is redundant here, being already AC_REQUIRE'd by AM_INIT_AUTOMAKE (this should hold from Automake 1.4 at least, I think). Yes, I thought the

Re: Makefile.in and Makefile not generated when using a static library

2010-04-11 Thread Ralf Wildenhues
Hello, * isulsz wrote on Mon, Apr 12, 2010 at 04:38:08AM CEST: But I have a new problem. When I try to make the project, I get this error: *** No rule to make target `../../src/Random/librng.a', needed by `MultiSour'. Stop. You probably need to reorder your SUBDIRS entry in the Makefile.am