bug#10766: bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Stefano Lattarini
Hi Peter. On 07/11/2012 11:21 PM, Peter Rosin wrote: On 2012-07-11 14:44, Stefano Lattarini wrote: On 07/09/2012 07:04 PM, Max Horn wrote: I am currently looking into packaging automake 1.12.1 for Fink http://www.finkproject.org/ on Mac OS X 10.7. Doing that, several test suite failures

bug#10766: bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Peter Rosin
On 2012-07-12 10:51, Stefano Lattarini wrote: Hi Peter. On 07/11/2012 11:21 PM, Peter Rosin wrote: On 2012-07-11 14:44, Stefano Lattarini wrote: On 07/09/2012 07:04 PM, Max Horn wrote: I am currently looking into packaging automake 1.12.1 for Fink http://www.finkproject.org/ on Mac OS X

bug#10766: bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Stefano Lattarini
On 07/12/2012 04:00 PM, Peter Rosin wrote: Stefano Lattarini wrote: Since that requirement is only needed for bootstrapping, I could send you a (patched) tarball to test (so that you'll only require an autoconf = 2.62). Would that be more acceptable? Shoot! Sent in private. So,

bug#11924: t/aclocal7.sh fails after updating from 1.12.1 to 1.12.2

2012-07-12 Thread Peter Simons
Hi, we have recently updated from Automake 1.12.1 to 1.12.2 in the NixOS Linux distribution. That change caused a unit test failure in t/aclocal7.sh. The complete build log is available here: http://hydra.nixos.org/build/2786726 Unfortunately, the log shows very little information about the

bug#11924: t/aclocal7.sh fails after updating from 1.12.1 to 1.12.2

2012-07-12 Thread Stefano Lattarini
forcemerge 11924 11896 close 11924 thanks On 07/12/2012 10:15 AM, Peter Simons wrote: Hi, Hi Peter, thanks for the report. we have recently updated from Automake 1.12.1 to 1.12.2 in the NixOS Linux distribution. That change caused a unit test failure in t/aclocal7.sh. The complete build

bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Eric Blake
On 07/12/2012 10:23 AM, Stefano Lattarini wrote: Other than that, the only supported method in existing POSIX for checking for equal files is by parsing 'ls -i' output; but I don't know if 'ls -i' is portable to ancient hosts. I was fearing this would have got quickly complex and messy ...

bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Peter Rosin
On 2012-07-12 17:48, Eric Blake wrote: On 07/12/2012 08:37 AM, Stefano Lattarini wrote: Agreed (albeit it does its dirty work for now). Any suggestion on how to make it more reliable? Is test /usr/bin/CC -ef /usr/bin/cc portable enough? I have no idea ... it seems to work on Cygwin 1.5

bug#10766: bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Peter Rosin
On 2012-07-12 16:37, Stefano Lattarini wrote: On 07/12/2012 04:00 PM, Peter Rosin wrote: Stefano Lattarini wrote: Since that requirement is only needed for bootstrapping, I could send you a (patched) tarball to test (so that you'll only require an autoconf = 2.62). Would that be more

bug#10766: bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Eric Blake
On 07/12/2012 12:42 PM, Stefano Lattarini wrote: In the light of our discussion, attached is the patch I'd finally like to push. WDYT? Looks fine to me (although I have not actually tested it). -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library

bug#8880: depcomp for Portland Group Compilers: get rid of file locking hack?

2012-07-12 Thread Stefano Lattarini
Reading the documentation provided here: http://www.pgroup.com/doc/pgiref.pdf I see that the the '-MD' option should also accept an argument: -MD,filename (pgcpp only) Generate make dependence lists and print them to file filename. maybe we could we use this

Re: bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Stefano Lattarini
Hi Peter. On 07/11/2012 11:21 PM, Peter Rosin wrote: On 2012-07-11 14:44, Stefano Lattarini wrote: On 07/09/2012 07:04 PM, Max Horn wrote: I am currently looking into packaging automake 1.12.1 for Fink http://www.finkproject.org/ on Mac OS X 10.7. Doing that, several test suite failures

Re: bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Peter Rosin
On 2012-07-12 10:51, Stefano Lattarini wrote: Hi Peter. On 07/11/2012 11:21 PM, Peter Rosin wrote: On 2012-07-11 14:44, Stefano Lattarini wrote: On 07/09/2012 07:04 PM, Max Horn wrote: I am currently looking into packaging automake 1.12.1 for Fink http://www.finkproject.org/ on Mac OS X

[PATCH 2/3] ylwrap: simplify the list of renamings

2012-07-12 Thread Akim Demaille
* lib/ylwrap (pairwise): Instead of being a straightforward copy from the command line arguments, and having to deal with y.tab vs. y_tab later, let pairwise store the real file names to process, y_tab conversion included when needed. (main loop): Use $to instead of $2, for symmetry with $from.

[PATCH 0/3] ylwrap: handle header inclusion properly

2012-07-12 Thread Akim Demaille
The following patches address a bug in ylwrap that cause it to be unable to handle Bison glr parsers, but also prevents future Bison releases from also using header inclusion in yacc mode. A related, but different, matter consists in using the -o option when supported by yacc. BTW, there are

[PATCH 1/3] ylwrap: refactor

2012-07-12 Thread Akim Demaille
* lib/ylwrap (guard): New function. Move functions before actual code. --- lib/ylwrap | 48 1 file changed, 28 insertions(+), 20 deletions(-) diff --git a/lib/ylwrap b/lib/ylwrap index 6879d8d..fd29af8 100755 --- a/lib/ylwrap +++ b/lib/ylwrap @@

Re: [PATCH 0/3] ylwrap: handle header inclusion properly

2012-07-12 Thread Stefano Lattarini
Hi Akim. On 07/12/2012 03:51 PM, Akim Demaille wrote: The following patches address a bug in ylwrap that cause it to be unable to handle Bison glr parsers, but also prevents future Bison releases from also using header inclusion in yacc mode. Thanks! A review of your patches will follow

Re: bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Eric Blake
On 07/12/2012 08:37 AM, Stefano Lattarini wrote: Agreed (albeit it does its dirty work for now). Any suggestion on how to make it more reliable? Is test /usr/bin/CC -ef /usr/bin/cc portable enough? I have no idea ... it seems to work on Cygwin 1.5 though. In general, 'test a -ef b' is

Re: [PATCH 1/3] ylwrap: refactor

2012-07-12 Thread Stefano Lattarini
On 07/12/2012 03:51 PM, Akim Demaille wrote: * lib/ylwrap (guard): New function. Move functions before actual code. --- ACK. Just one nit: in the summary line, please expand the IMHO too terse ylwrap: refactor to ylwrap: refactor: less duplication Thanks, Stefano

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-12 Thread Stefano Lattarini
On 07/12/2012 03:51 PM, Akim Demaille wrote: * lib/am/yacc.am (am__yacc_c2h): Shorten. See below. * lib/ylwrap (rename_sed): New. (main loop): Use it the rename the dependencies to other files. Oops, diving straight into the details, no rationale. No good. As an outsider, it is not clear

Re: bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Stefano Lattarini
Hi Eric. On 07/12/2012 05:48 PM, Eric Blake wrote: On 07/12/2012 08:37 AM, Stefano Lattarini wrote: Agreed (albeit it does its dirty work for now). Any suggestion on how to make it more reliable? Is test /usr/bin/CC -ef /usr/bin/cc portable enough? I have no idea ... it seems to work

Re: bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Eric Blake
On 07/12/2012 10:23 AM, Stefano Lattarini wrote: Other than that, the only supported method in existing POSIX for checking for equal files is by parsing 'ls -i' output; but I don't know if 'ls -i' is portable to ancient hosts. I was fearing this would have got quickly complex and messy ...

Re: bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Eric Blake
On 07/12/2012 11:06 AM, Eric Blake wrote: Minor correction: That said, /bin/RMDIR is probably completely portable, but seems like it ^ not would be reliable in practice. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library

Re: bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Peter Rosin
On 2012-07-12 17:48, Eric Blake wrote: On 07/12/2012 08:37 AM, Stefano Lattarini wrote: Agreed (albeit it does its dirty work for now). Any suggestion on how to make it more reliable? Is test /usr/bin/CC -ef /usr/bin/cc portable enough? I have no idea ... it seems to work on Cygwin 1.5

Re: bug#10766: bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Stefano Lattarini
On 07/12/2012 07:06 PM, Eric Blake wrote: On 07/12/2012 10:23 AM, Stefano Lattarini wrote: Other than that, the only supported method in existing POSIX for checking for equal files is by parsing 'ls -i' output; but I don't know if 'ls -i' is portable to ancient hosts. I was fearing this

Re: bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Peter Rosin
On 2012-07-12 16:37, Stefano Lattarini wrote: On 07/12/2012 04:00 PM, Peter Rosin wrote: Stefano Lattarini wrote: Since that requirement is only needed for bootstrapping, I could send you a (patched) tarball to test (so that you'll only require an autoconf = 2.62). Would that be more

Re: bug#10766: bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Eric Blake
On 07/12/2012 12:42 PM, Stefano Lattarini wrote: In the light of our discussion, attached is the patch I'd finally like to push. WDYT? Looks fine to me (although I have not actually tested it). -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library

[FYI] {depcomp-pgcc} depcomp: style changes to Portland Group Compilers support

2012-07-12 Thread Stefano Lattarini
* lib/depcomp (pgcc): Quote 'like this', not `like this'. Other minor quoting improvements. Remove a commented-out command. In comments, use proper capitalization and punctuation. Make a more consistent use of whitespace. Make fatal error messages more nicely formatted, and send them to

[PATCH] depcomp: initial support for Portland Group Compilers

2012-07-12 Thread Stefano Lattarini
From: Dave Goodell good...@mcs.anl.gov * lib/depcomp: Here. See automake bug#8880. Co-authored-by: Jeff A. Daily jeff.da...@pnnl.gov Acked-by: Stefano Lattarini stefano.lattar...@gmail.com Signed-off-by: Stefano Lattarini stefano.lattar...@gmail.com --- lib/depcomp | 76

depcomp for Portland Group Compilers: get rid of file locking hack?

2012-07-12 Thread Stefano Lattarini
Reading the documentation provided here: http://www.pgroup.com/doc/pgiref.pdf I see that the the '-MD' option should also accept an argument: -MD,filename (pgcpp only) Generate make dependence lists and print them to file filename. maybe we could we use this

Re: GNU Automake 1.11.6 released (fixes a SECURITY VULNERABILITY!)

2012-07-12 Thread Eric Dorland
* Stefano Lattarini (stefano.lattar...@gmail.com) wrote: On 07/10/2012 12:14 AM, Eric Dorland wrote: Are older versions of automake also vulnerable? Yes, all those back to 1.4 (at least). Sorry for not stating that explicitly. So I'm not obviously finding this vulnerability in

Re: GNU Automake 1.11.6 released (fixes a SECURITY VULNERABILITY!)

2012-07-12 Thread Stefano Lattarini
On 07/12/2012 08:23 PM, Eric Dorland wrote: * Stefano Lattarini (stefano.lattar...@gmail.com) wrote: On 07/10/2012 12:14 AM, Eric Dorland wrote: Are older versions of automake also vulnerable? Yes, all those back to 1.4 (at least). Sorry for not stating that explicitly. So I'm not

Re: GNU Automake 1.11.6 released (fixes a SECURITY VULNERABILITY!)

2012-07-12 Thread Eric Dorland
* Stefano Lattarini (stefano.lattar...@gmail.com) wrote: On 07/12/2012 08:23 PM, Eric Dorland wrote: * Stefano Lattarini (stefano.lattar...@gmail.com) wrote: On 07/10/2012 12:14 AM, Eric Dorland wrote: Are older versions of automake also vulnerable? Yes, all those back to 1.4 (at