adding a command line option for ACLOCAL_PATH-type search paths

2022-01-18 Thread Mike Frysinger
the ACLOCAL_PATH functionality is useful (adding search dirs after -I), but a bit unwieldy as an env var. any reason we can't add a command line option for this ? call it --aclocal-path ? or --extra-system-acdir ? or some other other boring name ? for context, when cross-compiling, autotools

Re: PATCH: silence Shellcheck warning

2022-01-18 Thread Ben Elliston
On Tue, Jan 18, 2022 at 09:50:04PM -0500, Mike Frysinger wrote: > shell does not lend itself to being written correctly. shellcheck > has proven its worth to me multiple times over, especially because i > can stop having to point out the same mistakes to people over & over > that it easily

Re: [PATCH] build: fix race in parallel builds

2022-01-18 Thread Mike Frysinger
On 18 Jan 2022 04:53, Mike Frysinger wrote: > As reported by Hongxu Jia: > > The automake-$(APIVERSION) is a hardlink of automake, if it is > > created later than update_mans executing, there is a failure > > [snip] > > |: && mkdir -p doc && ./pre-inst-env /usr/bin/env perl > >

bug#38043: Python version language support

2022-01-18 Thread Mike Frysinger
On 18 Jan 2022 16:15, Karl Berry wrote: > i'm inclined to drop support for > My recollection is, plenty of people are still using <3.6, EOL or not. > Tempting though it is. dissertation follows. i know it's a lot, and i don't normally like writing this much at a time, but i think this is

Re: multiple online manual versions

2022-01-18 Thread Mike Frysinger
On 18 Jan 2022 19:27, Karl Berry wrote: > Having multiple versions of the manual online sounds all to the good to > me. As long as it's being done at all, I wouldn't hesitate to put up > the manuals for every release, not just the major releases. For 1.16.x, > I'm afraid I rather broke the

bug#31728: [PATCH] dmalloc: mark macro as obsolete

2022-01-18 Thread Mike Frysinger
On 18 Jan 2022 16:15, Karl Berry wrote: > To me, the question is, does the current AM_WITH_DMALLOC actually work? > Or not? If it does, I see no reason to have it issue a warning, and > thus annoy anyone who has it in their configure.ac, where it is > presumably residing harmlessly. how are you

Re: PATCH: silence Shellcheck warning

2022-01-18 Thread Mike Frysinger
On 18 Jan 2022 21:25, Ben Elliston wrote: > On Tue, Jan 18, 2022 at 04:18:52AM -0500, Mike Frysinger wrote: > > that said, automake targets lower than POSIX, so i agree that we > > should leave it be for automake specifically. feel like posting a > > patch to suppress this particular check in

Re: [PATCH] tests: fix py-compile-basedir.sh: add missing test call

2022-01-18 Thread Mike Frysinger
On 18 Jan 2022 11:29, Jim Meyering wrote: > On Tue, Jan 18, 2022 at 10:29 AM Mike Frysinger wrote: > > On 18 Jan 2022 09:48, Jim Meyering wrote: > ... > > > But IMHO that's too much duplication/syntax. > > > How about this instead? > > > > > > case $(echo "$files" | wc -l) in 4|6) ;; *) false;;

Re: multiple online manual versions

2022-01-18 Thread Karl Berry
Having multiple versions of the manual online sounds all to the good to me. As long as it's being done at all, I wouldn't hesitate to put up the manuals for every release, not just the major releases. For 1.16.x, I'm afraid I rather broke the previous rules for major releases anyway.

Re: PATCH: silence Shellcheck warning

2022-01-18 Thread Jacob Bachmeyer
Ben Elliston wrote: On Tue, Jan 18, 2022 at 04:18:52AM -0500, Mike Frysinger wrote: that said, automake targets lower than POSIX, so i agree that we should leave it be for automake specifically. feel like posting a patch to suppress this particular check in lib/missing instead ? If

bug#38043: Incorrect Python byte-compiling for Python 3 and PyPy3

2022-01-18 Thread Karl Berry
i'm inclined to drop support for

bug#31728: [PATCH] dmalloc: mark macro as obsolete

2022-01-18 Thread Karl Berry
To me, the question is, does the current AM_WITH_DMALLOC actually work? Or not? If it does, I see no reason to have it issue a warning, and thus annoy anyone who has it in their configure.ac, where it is presumably residing harmlessly. I agree it does not "fit with Automake's mission", and

Re: minor docs alteration

2022-01-18 Thread Jim Meyering
On Tue, Jan 18, 2022 at 10:01 AM Mike Frysinger wrote: > On 31 May 2018 22:44, Jefferson Carpenter wrote: > > Subject: [PATCH] automake.texi: clarify relationship between configure and > > build dir > > > > I know you what this meant, but as a kid this would have confused me - the > > word "in"

Re: [PATCH] Use gender-neutral pronouns in HACKING and t/README

2022-01-18 Thread Jim Meyering
On Tue, Jan 18, 2022 at 10:03 AM Mike Frysinger wrote: > On 08 Apr 2018 16:07, Matthew Leeds wrote: > > --- > > HACKING | 4 ++-- > > t/README | 2 +- > > thanks for the patch. looks like Jim fixed HACKING: >

Re: [PATCH] tests: fix py-compile-basedir.sh: add missing test call

2022-01-18 Thread Jim Meyering
On Tue, Jan 18, 2022 at 10:29 AM Mike Frysinger wrote: > On 18 Jan 2022 09:48, Jim Meyering wrote: ... > > But IMHO that's too much duplication/syntax. > > How about this instead? > > > > case $(echo "$files" | wc -l) in 4|6) ;; *) false;; esac > > looks reasonable for POSIX shell. not a fan

Re: PATCH: silence Shellcheck warning

2022-01-18 Thread Ben Elliston
On Tue, Jan 18, 2022 at 04:18:52AM -0500, Mike Frysinger wrote: > that said, automake targets lower than POSIX, so i agree that we > should leave it be for automake specifically. feel like posting a > patch to suppress this particular check in lib/missing instead ? If it's welcome, sure. Some

[PATCH] build: fix race in parallel builds

2022-01-18 Thread Mike Frysinger
As reported by Hongxu Jia: > The automake-$(APIVERSION) is a hardlink of automake, if it is > created later than update_mans executing, there is a failure > [snip] > |: && mkdir -p doc && ./pre-inst-env /usr/bin/env perl > ../automake-1.16.1/doc/help2man --output=doc/aclocal-1.16.1 aclocal-1.16 >

Re: [PATCH] tests: fix py-compile-basedir.sh: add missing test call

2022-01-18 Thread Mike Frysinger
On 18 Jan 2022 09:48, Jim Meyering wrote: > On Tue, Jan 18, 2022 at 7:46 AM Mike Frysinger wrote: > > From: Thomas Deutschmann > > > > Commit b279a0d46dfeca1ca40057c3c910ab1657d60be5 ("tests: in python > > tests, do not require .pyo files (for python3)") had a slight logic > > error in that it

Re: PATCH: silence Shellcheck warning

2022-01-18 Thread Mike Frysinger
On 22 Jul 2018 14:41, Nick Bowler wrote: > On 7/21/18, Ben Elliston wrote: > > This patch silences a warning from Shellcheck about using old-style > > `...` command substitutions. > [...] > > commit 4d35c7aae97234bf055519075ef03cd4090a1dfc > > Author: Ben Elliston > > Date: Sun Jul 22 08:22:44

Re: [PATCH] doc: Fix a typo

2022-01-18 Thread Mike Frysinger
On 08 Apr 2018 16:06, Matthew Leeds wrote: > --- a/doc/automake.texi > +++ b/doc/automake.texi > All of these actions are performed in a temporary directory. Please > note that the exact location and the exact structure of such a directory > (where the read-only sources are placed, how the

Re: [PATCH] lib: drop unused shell variables

2022-01-18 Thread Mike Frysinger
lgtm, and still applies cleanly -mike signature.asc Description: PGP signature

Re: [PATCH] Use gender-neutral pronouns in HACKING and t/README

2022-01-18 Thread Mike Frysinger
On 08 Apr 2018 16:07, Matthew Leeds wrote: > --- > HACKING | 4 ++-- > t/README | 2 +- thanks for the patch. looks like Jim fixed HACKING: http://git.savannah.gnu.org/cgit/automake.git/commit/?h=7665b8e209888c73ee4dc05256f4f09a703a01e5 but your change to t/README still applies cleanly. -mike

Re: minor docs alteration

2022-01-18 Thread Mike Frysinger
On 31 May 2018 22:44, Jefferson Carpenter wrote: > Subject: [PATCH] automake.texi: clarify relationship between configure and > build dir > > I know you what this meant, but as a kid this would have confused me - the > word "in" seems to imply that the "configure" file is inside of the build

Re: [PATCH] tests: fix py-compile-basedir.sh: add missing test call

2022-01-18 Thread Jim Meyering
On Tue, Jan 18, 2022 at 7:46 AM Mike Frysinger wrote: > From: Thomas Deutschmann > > Commit b279a0d46dfeca1ca40057c3c910ab1657d60be5 ("tests: in python > tests, do not require .pyo files (for python3)") had a slight logic > error in that it missed a `test` call. > > Reported to Gentoo at

Re: multiple online manual versions

2022-01-18 Thread Jim Meyering
On Tue, Jan 18, 2022 at 8:14 AM Mike Frysinger wrote: > currently the automake website only hosts one manual version -- the latest. > when working with older code bases, especially when trying to update them > to newer versions, it can be helpful to have the older manual available to > quickly