bug#68274: automake 1.16j nonnumerical version confuses scripts

2024-01-22 Thread Mike Frysinger
On 21 Jan 2024 14:42, Karl Berry wrote: > I changed the pretest version to 1.16.90. Closing. thx bud. i appreciates you. -mike signature.asc Description: PGP signature

bug#54020: Impossible to pass `-no-suppress` to `libtool` via automake files

2024-01-18 Thread Mike Frysinger
On 17 Jan 2024 00:11, Mike Frysinger wrote: > On 15 Feb 2022 23:03, Damian Szuberski wrote: > > A standard `libtool` invocation line generated by automake looks like: > > ``` > > LTCOMPILE = $(LIBTOOL) $(AM_V_lt) --tag=CC $(AM_LIBTOOLFLAGS) \ > > $(LIBTOOLFLAGS)

bug#54020: Impossible to pass `-no-suppress` to `libtool` via automake files

2024-01-16 Thread Mike Frysinger
On 15 Feb 2022 23:03, Damian Szuberski wrote: > A standard `libtool` invocation line generated by automake looks like: > ``` > LTCOMPILE = $(LIBTOOL) $(AM_V_lt) --tag=CC $(AM_LIBTOOLFLAGS) \ > $(LIBTOOLFLAGS) --mode=compile $(CC) $(DEFS) \ > $(DEFAULT_INCLUDES) $(INCLUDES)

bug#54020: Allow user-defined libtool options

2024-01-16 Thread Mike Frysinger
On 16 Jan 2024 22:43, Roumen Petrov wrote: > Mike Frysinger wrote: > > On 13 Jan 2024 22:29, Bogdan wrote: > >> Mike Frysinger , 2024-01-13 07:19: > >>> On 15 Mar 2023 17:31, Bogdan wrote: > >>>> Another patch from my side. This one makes it possibl

bug#54020: Allow user-defined libtool options

2024-01-16 Thread Mike Frysinger
On 14 Jan 2024 18:55, Bogdan wrote: > Mike Frysinger , 2024-01-14 02:06: > > On 13 Jan 2024 22:29, Bogdan wrote: > >> Mike Frysinger , 2024-01-13 07:19: > >>> On 15 Mar 2023 17:31, Bogdan wrote: > >>>> Another patch from my side. This one makes it

bug#68274: automake 1.16j nonnumerical version confuses scripts

2024-01-13 Thread Mike Frysinger
On 13 Jan 2024 15:58, Karl Berry wrote: > Another alternative: when this came up 30-odd years ago, rms changed the > GNU maintainers doc to suggest x.y.90, .91, etc. for pretests. Doing > that would at least have the benefit of following a recommendation, and > as a side effect, would also fix

[bug#68416] [PATCH] python: add 3.20 - 3.16 to the version search list

2024-01-13 Thread Mike Frysinger
On 13 Jan 2024 19:12, Karl Berry wrote: > Not proposing to try anything for our upcoming release, but I wonder if > there is some more general way to handle Python versions? We don't have > to laboriously list every possible version for anything else. yeah, it sucks. i'm on the fence whether we

bug#54020: Allow user-defined libtool options

2024-01-13 Thread Mike Frysinger
On 13 Jan 2024 22:29, Bogdan wrote: > Mike Frysinger , 2024-01-13 07:19: > > On 15 Mar 2023 17:31, Bogdan wrote: > >>Another patch from my side. This one makes it possible for users to > >> pass additional options to libtool in 'compile' mode. Fixes #54020. >

[bug#68416] [PATCH] python: add 3.20 - 3.16 to the version search list

2024-01-12 Thread Mike Frysinger
With Python 3.12 out now, and 3.13 out in ~9 months, the existing runway is running out. Bump up to 3.20 for the next Automake release. * m4/python.m4: Add python3.20 - python3.16. * NEWS: Mention new Python versions. --- NEWS | 2 +- m4/python.m4 | 1 + 2 files changed, 2

Re: [question] how to install a directory to pythondir?

2024-01-12 Thread Mike Frysinger
On 06 Apr 2023 02:34, Wu Zhenyu wrote: > https://www.gnu.org/software/automake/manual/html_node/Python.html > describe how to package python by automake. I have > > $ tree src/foobar >  src/foobar > ├──  __init__.py > ├──  __main__.py > └──  utils >├──  a.py >

bug#8362: make install prefix inserted in source code with generated python files

2024-01-12 Thread Mike Frysinger
On 21 Mar 2023 23:05, Bogdan wrote: > Third, and most important (I think) is that we need to note that > "prog/x.py" is GENERATED, but is NOT marked so. Adding > > BUILT_SOURCES = prog/x.py i don't think this is a correct use of BUILT_SOURCES.

bug#54020: Allow user-defined libtool options

2024-01-12 Thread Mike Frysinger
On 15 Mar 2023 17:31, Bogdan wrote: > Another patch from my side. This one makes it possible for users to > pass additional options to libtool in 'compile' mode. Fixes #54020. > > Added documentation and a test case including the '-no-suppress' > option. All tests with 'lt' or 'libtool' in

Re: propably automake bug

2024-01-12 Thread Mike Frysinger
i think you might be describing this bug report: https://debbugs.gnu.org/60508 -mike signature.asc Description: PGP signature

bug#62069: Support xz parallel compression in dist-xz

2024-01-12 Thread Mike Frysinger
On 09 Mar 2023 08:47, Sam James wrote: > xz supports parallel compression which obviously speeds up > the time taken to run the 'dist-xz' rule, but it also > speeds up *decompression* too, as the parallel compressor > creates different output which can be decompressed in parallel. > > There's two

Re: fix: autoreconf fails due to .m4 files added but not installed

2024-01-12 Thread Mike Frysinger
On 28 May 2022 12:14, Jim Meyering wrote: > A few days ago I was preparing to release grep and wanted to make sure > it'd work with the latest automake and autoconf, so I built and installed > each from master. That exposed these errors when bootstrapping grep. I > think it was a prerequisite to

bug#68274: automake 1.16j nonnumerical version confuses scripts

2024-01-12 Thread Mike Frysinger
On 06 Jan 2024 15:37, Karl Berry wrote: > Automake and other packages have used letters for pretests for decades, true ... > and it's not plausible to change now. eh ? there is nothing requiring or restricting the current version behavior other than "it's always been this way". but that

bug#62896: [Configure] Bug with check for PERL when path has spaces (i.e. Windows)

2023-12-03 Thread Mike Frysinger
On 02 Dec 2023 21:55, Paul Eggert wrote: > -if test -z "$PERL"; then > +case $PERL in AS_CASE ? -mike signature.asc Description: PGP signature

bug#62791: BUILT_SOURCES not honoured in parallel build?

2023-12-02 Thread Mike Frysinger
On 12 Apr 2023 18:14, Reuben Thomas via Bug reports for Automake wrote: > On Wed, 12 Apr 2023 at 17:59, Reuben Thomas wrote: > > On Wed, 12 Apr 2023 at 16:17, Reuben Thomas wrote: > > > >> I am bootstrapping GNU a2ps git master[1] with automake 1.16.5. When I do > >> a parallel build (in my

bug#67539: GNU Automake 1.16.5 FAILS one test objc-megademo

2023-12-02 Thread Mike Frysinger
On 30 Nov 2023 22:45, Nick Bowler wrote: > Interestingly the libtool manual also says "If [libtool] can't infer a > tag, then it defaults to the configuration for the C language", which is > clearly not the case (it seems what actually happens is that if libtool > can't infer a tag then it

bug#62896: [Configure] Bug with check for PERL when path has spaces (i.e. Windows)

2023-12-02 Thread Mike Frysinger
On 02 Dec 2023 15:53, Karl Berry wrote: > also, can we really not trust the exit status of grep ? > if echo "$PERL" | grep -q '[\t ]'; then > > Exit status yes, but at least historically, grep -q has been considered > non-portable, in favor of grep ... >/dev/null. i get that

[bug#67498] Fixes for Windows

2023-12-02 Thread Mike Frysinger
On 27 Nov 2023 14:35, Karl Berry wrote: > https://savannah.gnu.org/patch/?10417 > > Unfortunately, last I heard, the new libtool maintainer was AWOL and no > one is left actively maintaining it. Or even looking for a maintainer. A > sad state of affairs :(. --best, karl. i've always been

Re: rhel8 test failure confirmation?

2023-12-02 Thread Mike Frysinger
On 02 Dec 2023 17:07, Jacob Bachmeyer wrote: > Mike Frysinger wrote: > > On 06 Apr 2023 21:29, Jacob Bachmeyer wrote: > >> Karl Berry wrote: > >>> jb> a more thorough test would locate the autom4te script and grep it > >>> for the

Re: rhel8 test failure confirmation?

2023-12-02 Thread Mike Frysinger
On 02 Dec 2023 18:33, Jacob Bachmeyer wrote: > Zack Weinberg wrote: > > On Sat, Dec 2, 2023, at 6:37 PM, Karl Berry wrote: > >> The best way to check if high-resolution > >> timestamps are available to autom4te is to have perl load > >> Autom4te::FileUtils and check if that also loaded

Re: rhel8 test failure confirmation?

2023-12-02 Thread Mike Frysinger
On 02 Dec 2023 19:17, Zack Weinberg wrote: > On Sat, Dec 2, 2023, at 6:37 PM, Karl Berry wrote: > > The best way to check if high-resolution > > timestamps are available to autom4te is to have perl load > > Autom4te::FileUtils and check if that also loaded Time::HiRes. > > > > The

[bug#67268] [PATCH] texinfo: add pointer about combining tests

2023-12-02 Thread Mike Frysinger
On 02 Dec 2023 15:09, Karl Berry wrote: > very extensive "Portable Shell Programming" chapter: > > https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.71/html_node/Portable-Shell.html > > I know. The Autoconf manual already describes this issue in detail. > The point of

Re: rhel8 test failure confirmation?

2023-12-02 Thread Mike Frysinger
On 06 Apr 2023 21:29, Jacob Bachmeyer wrote: > Karl Berry wrote: > > jb> a more thorough test would locate the autom4te script and grep it > > for the perllibdir that was substituted when autoconf was > > configured. > > > > I guess that would work. > > Challenge accepted. Here's a

bug#62896: [Configure] Bug with check for PERL when path has spaces (i.e. Windows)

2023-12-02 Thread Mike Frysinger
On 27 May 2023 19:12, Karl Berry wrote: > I (finally) installed this patch to quit early if the perl path has > spaces. Thanks. > > As for MKDIR_P and INSTALL, I guess it is somewhere in the > prerequisite/autoconf stuff. I suppose it would be rare that they would > be found in a path with spaces

[bug#67268] [PATCH] texinfo: add pointer about combining tests

2023-12-02 Thread Mike Frysinger
On 18 Nov 2023 19:27, Karl Berry wrote: > Hi Michael, > > > Date: Sun, 16 Oct 2016 18:35:53 +0200 > From: Michael Stapelberg > To: automake-patches@gnu.org > Subject: [PATCH] texinfo: add pointer about combining tests > >

Re: Getting long SOURCES lines with subdirs shorter

2023-12-01 Thread Mike Frysinger
On 01 Dec 2023 17:39, Nick Bowler wrote: > On 2023-12-01 15:37, Jan Engelhardt wrote: > > On Friday 2023-12-01 21:13, Mike Frysinger wrote: > >> On 17 Jul 2023 16:51, Karl Berry wrote: > >>> Hi Jan, > >>> > >>> Curren

Re: Getting long SOURCES lines with subdirs shorter

2023-12-01 Thread Mike Frysinger
On 01 Dec 2023 21:37, Jan Engelhardt wrote: > On Friday 2023-12-01 21:13, Mike Frysinger wrote: > >On 17 Jul 2023 16:51, Karl Berry wrote: > >> Hi Jan, > >> > >> Current automake likely won't have anything in store already, > >> > >> Not

[bug#67516] [PATCH] aclocal: handle both # and dnl for serial number lines

2023-12-01 Thread Mike Frysinger
On 01 Dec 2023 16:10, Karl Berry wrote: > without realizing it's basically silently ignored. if we don't want > to support dnl, we should prob be chatty about it at some log level. > > The "Serials" node in the manual only mentions "#". I guess I don't see > a need to go out of our way

Re: Getting long SOURCES lines with subdirs shorter

2023-12-01 Thread Mike Frysinger
On 17 Jul 2023 16:51, Karl Berry wrote: > Hi Jan, > > Current automake likely won't have anything in store already, > > Not that I know of. > > a_SOURCES = $(addprefix aprog/,main.c foo.c bar.c baz.c) > > I've often wanted this myself. I'd certainly welcome a patch for it. > > Please

[bug#67516] [PATCH] aclocal: handle both # and dnl for serial number lines

2023-12-01 Thread Mike Frysinger
On 28 Nov 2023 16:27, Nick Bowler wrote: > On 2023-11-28 16:06, Karl Berry wrote: > > Hi Ross - you sent a change to automake-patches back in February 2017. > > Sorry for the absurdly delayed reply. > > > > > > https://lists.gnu.org/archive/html/automake-patches/2017-02/msg1.html > > >

bug#33779: Color-coded output from autoconf/automake (was Re: bug#33779: Wrong lib-list in install-%DIR%LTLIBRARIES)

2023-01-24 Thread Mike Frysinger
On 24 Jan 2023 07:06, Bert Wesarg via Bug reports for Automake wrote: > On Mon, Jan 23, 2023 at 3:29 PM Zack Weinberg wrote: > > On Mon, Jan 23, 2023, at 4:38 AM, Bert Wesarg via Bug reports for Automake > > wrote: > > > On Fri, Jan 13, 2023 at 6:58 AM Mike Frysinger

[bug#59990] [PATCH] tests: depcomp: ensure make_ok() fails when run_make fails

2023-01-15 Thread Mike Frysinger
thanks, lgtm, merged -mike

[bug#60829] [PATCH] m4: use AS_IF to avoid ! portability issues

2023-01-15 Thread Mike Frysinger
Since the ! builtin has portability issues (as documented in the Autoconf manual), switch to AS_IF which takes care of these issues for us. * m4/sanity.m4: Switch `if` to AS_IF. --- m4/sanity.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/m4/sanity.m4 b/m4/sanity.m4

[bug#60807] [PATCH 1/2] mtime: use Time::HiRes::stat when available for subsecond resolution

2023-01-15 Thread Mike Frysinger
On 14 Jan 2023 21:27, Jacob Bachmeyer wrote: > Mike Frysinger wrote: > > --- a/lib/Automake/FileUtils.pm > > +++ b/lib/Automake/FileUtils.pm > > @@ -42,6 +42,11 @@ use Exporter; > > use File::stat; > > use IO::File; > > > > +# Perl's builtin stat

[bug#60807] [PATCH v2] tests: reuse am_cv_filesystem_timestamp_resolution

2023-01-15 Thread Mike Frysinger
On 14 Jan 2023 21:43, Jacob Bachmeyer wrote: > Mike Frysinger wrote: > > --- a/t/aclocal-no-force.sh > > +++ b/t/aclocal-no-force.sh > > @@ -19,6 +19,18 @@ > > > > . test-init.sh > > > > +# Automake relies on high resolution timestamps in perl

[bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P

2023-01-14 Thread Mike Frysinger
On 14 Jan 2023 17:05, Karl Berry wrote: > most of the code directly preceding & following this line use @. > i.e. the vast majority of the current distdir logic. > > Yeah. > > If you feel like changing those @'s to AM_v_at while we're here, sounds > good to me ... -k i'd like to give it

[bug#60807] [PATCH v2] tests: reuse am_cv_filesystem_timestamp_resolution

2023-01-14 Thread Mike Frysinger
Rather than assume such coarse delays, re-use existing logic for probing the current filesystem resolution. This speeds up the testsuite significantly. On my system, it speeds -j1 up quite a lot -- by ~30%. While I didn't gather many samples to produce a statistically significant distribution,

[bug#60807] [PATCH 1/2] mtime: use Time::HiRes::stat when available for subsecond resolution

2023-01-14 Thread Mike Frysinger
On 14 Jan 2023 14:52, Karl Berry wrote: > +my $have_time_hires = eval { require Time::HiRes; }; > > I don't object. Although if there's no speed up in practice, I wonder if > it's worth the extra code (simple-enough though it is). -k there's no speed up in the execution of a single process,

[bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P

2023-01-14 Thread Mike Frysinger
On 14 Jan 2023 15:17, Karl Berry wrote: > imo we overly rely on explicit @ in many places which can make debugging > failures painful. > > FWIW, I agree. Although I see no @ here. most of the code directly preceding & following this line use @. i.e. the vast majority of the current

[bug#60807] [PATCH 1/2] mtime: use Time::HiRes::stat when available for subsecond resolution

2023-01-14 Thread Mike Frysinger
Perl's builtin stat function returns timestamps that have 1 second resolution. This can lead automake needlessly regenerating files because it compares timestamps as "older than or equal to" rather than only "older than". This is perfectly reasonable as we have no way of knowing what file is

[bug#60808] [PATCH 2/2] tests: reuse am_cv_filesystem_timestamp_resolution

2023-01-14 Thread Mike Frysinger
Rather than assume such coarse delays, re-use existing logic for probing the current filesystem resolution. This speeds up the testsuite significantly. On my system, it speeds -j1 up quite a lot -- by ~30%. While I didn't gather many samples to produce a statistically significant distribution,

bug#55025: Automake should allow one to enable POSIX make behavior

2023-01-13 Thread Mike Frysinger
On 14 Jan 2023 01:30, Nick Bowler wrote: > On 2023-01-13, Mike Frysinger wrote: > > On 13 Jan 2023 16:01, Karl Berry wrote: > >> I am doubtful about blithely defining .POSIX unconditionally. I feel > >> sure that will break existing Makefiles. I don't think we should d

[bug#60772] [PATCH] tests: rework gettext to only check 'external' behavior

2023-01-13 Thread Mike Frysinger
On 13 Jan 2023 16:52, Karl Berry wrote: > Subject: [bug#60772] [PATCH] tests: rework gettext to only check > 'external' > behavior > > Good catch, thanks. Please commit. > > +# po/ is required. intl/ should not be used. > > Perhaps add the bit of information from your mail to

bug#54421: AM_PROG_AR and LT_INIT don't work together when using lib.exe

2023-01-13 Thread Mike Frysinger
On 13 Jan 2023 13:52, Tim Ruffing wrote: > On Fri, 2023-01-13 at 05:52 +0000, Mike Frysinger wrote: > > i think the expectation is that, if you're using libtool, then you > > use libtool.  > > Well, I *use* libtool. libtool needs some AR. I choose to use > libtool.exe

bug#55025: Automake should allow one to enable POSIX make behavior

2023-01-13 Thread Mike Frysinger
On 13 Jan 2023 16:01, Karl Berry wrote: > I am doubtful about blithely defining .POSIX unconditionally. I feel > sure that will break existing Makefiles. I don't think we should do that. > > Detecting .POSIX in an existing Makefile.am and moving it to the front > sounds desirable, since that is

[bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P

2023-01-13 Thread Mike Frysinger
On 13 Jan 2023 15:36, Karl Berry wrote: > - test -d "$(distdir)" || mkdir "$(distdir)" > + $(AM_V_at)$(MKDIR_P) "$(distdir)" > > Ok by me, but why the AM_V_at for this particular command? > I don't see it used anywhere else in distdir.am. this is certainly true, and it's something i want

[bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h

2023-01-13 Thread Mike Frysinger
On 13 Jan 2023 13:49, Frederic Berat wrote: > I probably won't be able to do so before next week at least. > If you happen to have time (and be willing) to do it earlier, don't > hesitate ;) that timeframe is fine. as you can see, we take a long view in Automake. -mike signature.asc

[bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P

2023-01-13 Thread Mike Frysinger
We don't need to do the `test -d ... || mkdir ...` dance when we have the MKDIR_P helper, so simplify this code a bit. * lib/am/distdir.am: Use $(MKDIR_P). * lib/am/lisp.am: Drop redundant `test -d`. --- lib/am/distdir.am | 2 +- lib/am/lisp.am| 2 +- 2 files changed, 2 insertions(+), 2

[bug#59993] [PATCH v2 3/3] tests: Fix implicit function declaration in ax/depcomp.sh

2023-01-13 Thread Mike Frysinger
On 13 Jan 2023 09:14, Frederic Berat wrote: > I made one more build with a different patchset list, could it be that the > failure you encounter is with "t/subobj.sh" ? to be clear, i applied this patch only to current git master. i didn't try including anything else. with that in mind, the

bug#54390: YACC rules don't check DESTDIR existence for VPATH builds

2023-01-13 Thread Mike Frysinger
On 13 Jan 2023 07:07, Sam James wrote: > $ /tmp/libaacs/configure YACC=bison LEX=flex the problem is you're forcing `YACC=bison`. Automake defaults to `bison -y` which tells bison to operate in POSIX-yacc-compatible mode because Automake's rules target POSIX. the end result is that you've

bug#54390: YACC rules don't check DESTDIR existence for VPATH builds

2023-01-12 Thread Mike Frysinger
On 13 Jan 2023 06:29, Sam James wrote: > > On 13 Jan 2023, at 06:13, Mike Frysinger wrote: > > On 14 Mar 2022 17:21, Sam James wrote: > >> It appears that YACC rules don't check for whether the destination > >> directory exists before executing ylwrap. > >&g

[bug#59993] [PATCH v2 3/3] tests: Fix implicit function declaration in ax/depcomp.sh

2023-01-12 Thread Mike Frysinger
this breaks `make check`, so i can't merge it -mike

[bug#59992] [PATCH 1/2] tests: Fix 'type defaults' error in link_cond due to main not being properly declared

2023-01-12 Thread Mike Frysinger
thanks, merged now -mike

[bug#59992] [PATCH 1/2] tests: Fix 'type defaults' error in link_cond due to main not being properly declared

2023-01-12 Thread Mike Frysinger
severity 59992 wishlist close 59992 thankyou

[bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h

2023-01-12 Thread Mike Frysinger
On Mon, 12 Dec 2022 15:20:46 -0500, Zack Weinberg wrote: > On 2022-12-12 2:07 AM, Frederic Berat wrote: > > > > This patch is mainly a proposal. While the macro can simply be removed > > as explained below, another possibility it to add a flex option > > "--never-interactive" to prevent flex to

bug#55025: Automake should allow one to enable POSIX make behavior

2023-01-12 Thread Mike Frysinger
On 19 Apr 2022 17:33, Vincent Lefevre wrote: > https://pubs.opengroup.org/onlinepubs/9699919799/utilities/make.html > says about the target rules: > > .POSIX > The application shall ensure that this special target is specified > without prerequisites or commands. If it appears as the

bug#54390: YACC rules don't check DESTDIR existence for VPATH builds

2023-01-12 Thread Mike Frysinger
On 14 Mar 2022 17:21, Sam James wrote: > It appears that YACC rules don't check for whether the destination directory > exists before executing ylwrap. > > When trying to package libaacs (https://code.videolan.org/videolan/libaacs) > with an out-of-source build, I hit an unexpected build

bug#33779: Wrong lib-list in install-%DIR%LTLIBRARIES

2023-01-12 Thread Mike Frysinger
On Mon, 17 Dec 2018 20:11:48 +0100, Bert Wesarg wrote: > looking at lib/am/ltlib.am, the rule for installing libraries looks > weird for the !LIBTOOL case. Though I have the impression that this > file should not be used at all, if libtool is not used. Nevertheless, > the install command in this

bug#60773: AM_PROG_AR and LT_INIT don't work together when using lib.exe

2023-01-12 Thread Mike Frysinger
On Wed, 16 Mar 2022 15:24:37 +0100, Tim Ruffing wrote: > Assume environment variable AR="lib.exe" and configure.ac has > > ``` > AM_PROG_AR > LT_INIT > ``` i think the expectation is that, if you're using libtool, then you use libtool. it can create static convenience libraries too:

[bug#60772] [PATCH] tests: rework gettext to only check 'external' behavior

2023-01-12 Thread Mike Frysinger
The gettext project deprecated non-external use back in 2010 with the 0.18 release, and made it fatal with the 0.20 release in 2019. With that version, calling AM_GNU_GETTEXT() fails, which means all Automake tests are now skipped. The t/gettext-macros.sh helper probes gettext as such: >+

[bug#60771] [PATCH] tests: disable git log pager usage

2023-01-12 Thread Mike Frysinger
When running this code locally, the git log call can trigger a pager depending on the local settings, which in turn forces the test to be interactive. Run git with --no-pager to force disable it. * t/get-sysconf.sh: Run git with --no-pager. --- t/get-sysconf.sh | 2 +- 1 file changed, 1

[bug#60764] [PATCH] tests: change `sort|uniq` to `sort -u`

2023-01-12 Thread Mike Frysinger
These are equivalent, but more performant. We already use `sort -u` elsewhere in the codebase, so nothing new here really. * t/add-missing.tap: Change `sort|uniq` to `sort -u`. * t/CheckListOfTests.am: Likewise. --- t/CheckListOfTests.am | 2 +- t/add-missing.tap | 2 +- 2 files changed, 2

[bug#60763] [PATCH] tests: change `sort|uniq` to `sort -u`

2023-01-12 Thread Mike Frysinger
These are equivalent, but more performant. We already use `sort -u` elsewhere in the codebase, so nothing new here really. * t/add-missing.tap: Change `sort|uniq` to `sort -u`. * t/CheckListOfTests.am: Likewise. --- t/CheckListOfTests.am | 2 +- t/add-missing.tap | 2 +- 2 files changed, 2

[bug#60535] [PATCH] depend2: switch echo|sed to automatic vars

2023-01-11 Thread Mike Frysinger
On 05 Jan 2023 16:47, Karl Berry wrote: > Please excuse my curmudgeonness, but it's not clear to me that avoiding > sed is worth these hassles in working around the implementation-specific > bugs in the automatic variables. Especially if we have to invoke a shell > and various commands anyway, how

[bug#60747] [PATCH] dirstamp: switch to a pattern rule

2023-01-11 Thread Mike Frysinger
We can leverage $(@D) to generate a single pattern rule for all dirstamp rules. This saves many lines in the output -- normally we create 2 rules (or 6 lines) per subdir, and projects that use subdirs tend to use them quite a bit. In the most extreme & unlikely case (1 subdir, no depdir

[bug#60746] [PATCH] dirstamp: use append too instead of truncate

2023-01-11 Thread Mike Frysinger
We changed the depfiles logic to use >> (append) instead of > (truncate) due to it being slightly faster & nicer to the disk. Do the same with the dirstamp files as we only need the files to exist -- we don't care about their content, and we never put anything in them ourselves. If someone else

[bug#60535] [PATCH] depend2: switch echo|sed to automatic vars

2023-01-04 Thread Mike Frysinger
On 04 Jan 2023 21:10, Nick Bowler wrote: > Except for one minor detail, $(@F) and $(@D) are highly portable. I > expect they were in the very first POSIX.2 specs as they predate the > earliest standards; I believe they first appeared in UNIX System V (ca. > 1983) and were later added to BSD in

[bug#60541] [PATCH] check: drop unused trs_list variable

2023-01-04 Thread Mike Frysinger
On 04 Jan 2023 16:54, Karl Berry wrote: > When the code that used this variable was removed, the variable > itself was left behind. Clean that up now too. > * lib/am/check.am: Delete trs_list. > > I can't find when the code using trs_list was removed (no mention in any > ChangeLog),

[bug#60542] [PATCH/committed] maint: Update files from upstream with 'make fetch'

2023-01-03 Thread Mike Frysinger
Pulls some 2023 copyright updates. * lib/config.guess: Update. * lib/config.sub: Likewise. * lib/gendocs.sh: Likewise. * lib/gendocs_template: Likewise. * lib/gitlog-to-changelog: Likewise. * lib/gnupload: Likewise. * lib/texinfo.tex: Likewise. * lib/update-copyright: Likewise. ---

[bug#60541] [PATCH] check: drop unused trs_list variable

2023-01-03 Thread Mike Frysinger
When the code that used this variable was removed, the variable itself was left behind. Clean that up now too. * lib/am/check.am: Delete trs_list. --- lib/am/check.am | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/am/check.am b/lib/am/check.am index

[bug#60538] [PATCH] rm: convert more cases to am__rm_f

2023-01-03 Thread Mike Frysinger
Fixes automake bug https://bugs.gnu.org/10828. Clean up a few more cases where we were doing `test ... || rm ...` to avoid calling `rm -f` without arguments by leveraging am__rm_f. These were harder to find in the source due to their constructed nature. The clean programs rules in particular

[bug#60536] [PATCH] depend: trim spurious leading tab

2023-01-03 Thread Mike Frysinger
These vars are replaced with a list of remove commands that are joined with a \n and each line always has a leading \t inserted. That means the literal tab here before the var leads to 2 tabs included in the output. While not functionally a problem, it can be a bit confusing when reading the

[bug#60535] [PATCH] depend2: switch echo|sed to automatic vars

2023-01-03 Thread Mike Frysinger
The echo|sed is used to split the dirname & filename so it can insert $(DEPDIR) in the middle, and then chop the trailing object suffix. In the generic case, %OBJ% is $@, so we can leverage the POSIX vars $(@D) and $(@F) to do the pathname splitting and insert $(DEPDIR) in between. For chopping

bug#60508: archive DEPENDENCIES incorrectly depends on ordering

2023-01-02 Thread Mike Frysinger
i have a project that generates a bunch of arch-specific archives. i also have an intermediate archive for holding common objects (so only need to build them once). i noticed that while (ab)using LIBADD & OBJECTS variables, Automake incorrectly omits propagating OBJECTS variables from LIBADD to

bug#54363: [PATCH] doc: refer to automake manual in all man pages

2022-03-12 Thread Mike Frysinger
Fixes automake bug https://bugs.gnu.org/54363. There is no "aclocal" manual as it's all integrated into the automake manual, so have all the help2man calls force automake as the manual. * doc/local.mk: Use --info-page=automake for man pages. --- doc/local.mk | 2 +- 1 file changed, 1

bug#54363: aclocal info page is not installed

2022-03-12 Thread Mike Frysinger
On 13 Mar 2022 00:45, Esteve Varela Colominas wrote: > Running "man aclocal" mentions the availability of a full texinfo manual for > the tool at the bottom. However, running "info aclocal" brings up the same > man page. I'd like to have this texinfo page shipped alongside the texinfo > page

bug#32868: [PATCH v2] m4: rework silent-rules macros to avoid double expansion

2022-02-28 Thread Mike Frysinger
On 28 Feb 2022 15:58, Karl Berry wrote: > Fixes automake bug https://bugs.gnu.org/32868. > > Looks fine to me. > > +./configure -C > +grep '^AM_DEFAULT_VERBOSITY = 1' Makefile > > Good :). > > I remain steadfastly opposed to (ever) changing the default to be silent > rules, as

bug#32868: [PATCH v2] m4: rework silent-rules macros to avoid double expansion

2022-02-27 Thread Mike Frysinger
Fixes automake bug https://bugs.gnu.org/32868. The AM_SILENT_RULES macro defines all the silent-rules related setup. It's also called by users to change the default verbosity level. This leads to a quirk where automake calls it, expands the full context, and then users call it, and it's fully

bug#19418: AC_CONFIG_FILES / stamp-h? problem

2022-02-26 Thread Mike Frysinger
On 22 Feb 2022 12:53, Jeff Squyres (jsquyres) wrote: > I'm afraid I can't easily tell. > > It looks like I added a workaround in > https://github.com/open-mpi/ompi/commit/40dd4c5b766ff62a681692b1fa6b72a1023fc81f > on Dec 20, 2014 (the same day that I initially filed this bug report). > > Half

bug#54063: automake cannot run without generated Texinfo manual

2022-02-25 Thread Mike Frysinger
On 25 Feb 2022 16:06, Karl Berry wrote: > Adding a note to the manual is fine, but what would be (much) more > likely to actually get noticed by users is a runtime warning. What is > the actual behavior when the basename and @setfilename don't match? i don't think it's possible to detect from

bug#33819: automake-1.16.1 test failures on NetBSD

2022-02-24 Thread Mike Frysinger
On 24 Feb 2022 11:23, Thomas Klausner wrote: > FAIL: t/distcheck-override-infodir > FAIL: t/instdir-texi > FAIL: t/silent-texi > FAIL: t/txinfo-builddir > FAIL: t/txinfo-clean > FAIL: t/txinfo-info-in-srcdir > FAIL: t/txinfo-include > FAIL: t/txinfo-many-output-formats > FAIL:

bug#54063: [PATCH] automake: fall back gracefully when texinfo inputs don't exist

2022-02-24 Thread Mike Frysinger
Fixes automake bug https://bugs.gnu.org/54063. The function scanning for @setfilename will fall back to a default value if the input doesn't have one defined. But we need to handle the case where the file doesn't even exist before falling back. * bin/automake.in: Scan /dev/null for @setfilename

bug#54063: automake cannot run without generated Texinfo manual

2022-02-24 Thread Mike Frysinger
On 24 Feb 2022 11:19, Patrice Dumas wrote: > On Thu, Feb 24, 2022 at 01:52:21AM -0500, Mike Frysinger wrote: > > On 19 Feb 2022 15:03, Patrice Dumas wrote: > > > In Texinfo, we have a texinfo manual which is automatically generated > > > from Pod sections from

bug#20713: [PATCH] m4: handle id failures when checking ustar support

2022-02-24 Thread Mike Frysinger
Fixes automake bug https://bugs.gnu.org/20713. If `id` fails, display a specific warning message to the user. * m4/tar.m4: Check $am_uid & $am_gid if they're unknown. --- m4/tar.m4 | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/m4/tar.m4 b/m4/tar.m4 index

bug#54063: automake cannot run without generated Texinfo manual

2022-02-23 Thread Mike Frysinger
On 19 Feb 2022 15:03, Patrice Dumas wrote: > In Texinfo, we have a texinfo manual which is automatically generated > from Pod sections from Texinfo perl modules. When this generated manual > is removed, automake cannot run anymore. To workaround this issue, we > have a generation of a fake

bug#33819: automake-1.16.1 test failures on NetBSD

2022-02-23 Thread Mike Frysinger
On 21 Dec 2018 10:46, Thomas Klausner wrote: > When running the self tests on NetBSD (8.99.27/amd64) with perl > 5.28.1, I see 26 test failures. > > The log is attached. from the log: > FAIL: t/instspc this seems to be due to install-sh being used over normal mkdir -p. but that should be fine

bug#34151: GNU Automake 1.16.1 FAIL: 4 on Solaris 10 SPARC

2022-02-23 Thread Mike Frysinger
On 20 Jan 2019 22:00, Dennis Clarke wrote: > The usual. Nothing new here. Four failed tests on ye old Solaris 10 > sparc with Oracle Studio 12.6 compiler tools. > > test-suite.log attached. from the log: > FAIL: t/dist-formats > + bzip2 -d parallel-compression-1.0.tar.bz2 > bzip2: Caught a

bug#32800: [PATCH/committed] tests: make silent-custom regex a little more robust

2022-02-23 Thread Mike Frysinger
Fixes automake bug https://bugs.gnu.org/32800. Have the regex match the entire path with word boundaries on both sides. This should reduce false positives when the full cwd happens to match parent directories. * t/silent-custom.sh: Update the header output regex. --- t/silent-custom.sh | 2 +-

bug#7610: [PATCH v2 committed] automake: support embedded \# in variable appends

2022-02-23 Thread Mike Frysinger
Fixes automake bug https://bugs.gnu.org/7610. Use of \# is not portable. POSIX does not provide any way of retaining the # marker in variables. There is wide spread support for \# though in GNU & BSD Make implementations. Today, with plain variable assignments, Automake leaves the line alone:

bug#54020: Impossible to pass `-no-suppress` to `libtool` via automake files

2022-02-22 Thread Mike Frysinger
On 23 Feb 2022 01:12, Mike Frysinger wrote: > my inclination is to introduce two new variables that would be used for > libtool > & non-libtool, and only when compiling. > * xxx_COMPILE: to provide parity with existing xxx_LINK setting -- override > the compiler on

bug#54020: Impossible to pass `-no-suppress` to `libtool` via automake files

2022-02-22 Thread Mike Frysinger
On 17 Feb 2022 16:33, Karl Berry wrote: > Hi Damian - thanks for the report. > > LTCOMPILE = $(LIBTOOL) $(AM_V_lt) --tag=CC $(AM_LIBTOOLFLAGS) \ > $(LIBTOOLFLAGS) --mode=compile $(CC) $(DEFS) \ > $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) \ >

[bug#54120] [PATCH] manual: mention LT_INIT

2022-02-22 Thread Mike Frysinger
The AC_PROG_LIBTOOL macro name is the old/deprecated one, so include LT_INIT here too to avoid confusing people who have switched. * doc/automake.texi: Add LT_INIT after AC_PROG_LIBTOOL. --- doc/automake.texi | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/automake.texi

bug#20713: aclocal/tar.m4 and solaris 5.10

2022-02-22 Thread Mike Frysinger
On 22 Feb 2022 16:29, Karl Berry wrote: > The "test" item, most of the way down in the "Limitations of Shell > Builtins" node of the Autoconf manual, reports a lot of the things that > have led to the common forms/workarounds. >

bug#20713: aclocal/tar.m4 and solaris 5.10

2022-02-21 Thread Mike Frysinger
On 21 Feb 2022 16:26, Karl Berry wrote: > should we change "unknown" to $GID & $UID respectively ? > > I guess it couldn't hurt, although I doubt it makes any difference in > practice. i feel like you just accidentally wrote Automake's motto :p > if test $am_uid = "unknown"; then > >

bug#17614: parallel compilation fails

2022-02-21 Thread Mike Frysinger
On 21 Feb 2022 12:15, Peter Johansson wrote: > On 25/1/22 16:24, Mike Frysinger wrote: > > On 19 Jan 2022 18:32, Peter Johansson wrote: > >> On 19/1/22 18:10, Mike Frysinger wrote: > >>> assuming it still fails with Automake 1.16 ... > >> > >> I'll

bug#20713: aclocal/tar.m4 and solaris 5.10

2022-02-20 Thread Mike Frysinger
On Mon, 01 Jun 2015 21:02:32 +, Karl Berry wrote: > Running a configure script on solaris 5.10 generated with automake-1.15, > I got these errors about id, which being pre-POSIX, does not support -u: > > id: illegal option -- u > Usage: id [-ap] [user] > id: illegal option --

bug#20300: [PATCH] automake: allow required files to be in subdirs

2022-02-20 Thread Mike Frysinger
Fixes automake bug https://bugs.gnu.org/20300. The internal method for caching path lookups expects the $filename to only be a filename. If it's actually a subdir/file itself, then the cache logic gets confused, and it never matches. This manifests as AC_REQUIRE_AUX_FILE([subdir/file]) claiming

  1   2   3   >