I'd like to add also the following optimization patch.
Regards,
Stefano
-*-*-*-
Internationalization tests: prefer `make distdir' over `make dist'.
Instead of running `make dist', then uncompressing the created
tarball, and then grepping the uncompressed tar archive, we can
simply run `make
This patch fixes potential false negatives in the new tests.
Regards,
Stefano
-*-*-*-
Internationalization tests: do not ignore failures.
Some tests used the idiom:
test $builddir = '.' || test ! -f posub/foo-bar.pot
to check that a file is build in the source directory, not in
the build
This is mostly a cosmetic/consistency patch. I hope you'll find it
worth applying nonetheless.
Regards,
Stefano
-*-*-
Internationalization tests: prefer `test ! -r' over `test ! -f'
We now use `test ! -r' rather than `test ! -f' to check that
a file does not exists (`test ! -e' would be
On 09/06/2010 05:18 PM, Stefano Lattarini wrote:
This is mostly a cosmetic/consistency patch. I hope you'll find it
worth applying nonetheless.
Regards,
Stefano
-*-*-
Internationalization tests: prefer `test ! -r' over `test ! -f'
test -r is non-portable.
Very old shells do not support
Hi Stefano,
* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 11:28:27AM CEST:
On Monday 06 September 2010, Ralf Wildenhues wrote:
Well, in v1.11-139-g6fee87c and before that in v1.11-138-gc6bbc45
the above line was move resp. introduced. Was that a buglet in the
latter patch?
No,
Hello Stefano,
* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 05:06:23PM CEST:
This patch fixes potential false negatives in the new tests.
Internationalization tests: do not ignore failures.
Some tests used the idiom:
test $builddir = '.' || test ! -f posub/foo-bar.pot
to check that
Hello Stefano,
* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 03:07:30PM CEST:
I noticed some problems (both serious and cosmetic) in your patch.
Here is a summary of the in decreasing order of relevance:
1. You sometimes failed to use `$MAKE' instead of `make' and `Exit'
instead of
* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 04:56:50PM CEST:
Internationalization tests: prefer `make distdir' over `make dist'.
Instead of running `make dist', then uncompressing the created
tarball, and then grepping the uncompressed tar archive, we can
simply run `make distdit' and
On Monday 06 September 2010, Ralf Wildenhues wrote:
Unfortunately, there is no bug fixed by this patch. I can only
offer the above argumentation (plus consistency of $testsrcdir
and $top_testsrcdir).
Your verbose explanation above and this seem to contradict each
other. ;-)
I'll
* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 08:59:20PM CEST:
On Monday 06 September 2010, Ralf Wildenhues wrote:
Unfortunately, there is no bug fixed by this patch. I can only
offer the above argumentation (plus consistency of $testsrcdir
and $top_testsrcdir).
Your verbose
* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 09:22:51PM CEST:
On Monday 06 September 2010, Ralf Wildenhues wrote:
* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 05:06:23PM CEST:
That also means, that we should probably be more cautious with
removing `|| Exit 1' instances from tests.
On Monday 06 September 2010, Ralf Wildenhues wrote:
Hello Stefano,
* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 05:06:23PM CEST:
This patch fixes potential false negatives in the new tests.
Internationalization tests: do not ignore failures.
Some tests used the idiom:
test
On Monday 06 September 2010, Ralf Wildenhues wrote:
* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 09:22:51PM CEST:
What about my pending patch Testsuite: use $SHELL to run tests
which are shell scripts.?
I'll reply in that thread.
That should ensure that the tests are run with
a
Hi Stefano,
And the attached patch should be squashed in previous patch n.3.
This is also fine with me. Thanks!
Bruno
On Sunday 05 September 2010, Ralf Wildenhues wrote:
Hello,
* Jim Meyering wrote on Sat, Sep 04, 2010 at 07:28:58PM CEST:
Stefano Lattarini wrote:
What about instead making the names of the temporaries
source/build/install directories used by make distcheck
configurable?
It turns out
Hi Stefano,
simply run `make distdit' and anylize. This is both faster and
s/anylize/analyze/
This patch is a nice simplification. And maybe it also increases portability
(I don't know which file names a tarball will contain when you create it on
a file system which is case-insignificant with
On Monday 06 September 2010, Ralf Wildenhues wrote:
* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 04:56:50PM CEST:
Internationalization tests: prefer `make distdir' over `make
dist'.
Instead of running `make dist', then uncompressing the created
tarball, and then grepping the
Hi Stefano,
Internationalization tests: prefer `test ! -r' over `test ! -f'
Why? Why is it more important to check that an expected file has
read permissions, than to check that it is a regular file?
This is not an objection. I just find it odd to use 'test -f' for
the positive test and 'test
On Monday 06 September 2010, Bruno Haible wrote:
Hi Stefano,
... since the failing `test' is in a
`||' compound command. Fix this problem by explicitly calling
`Exit 1' where needed.
Yes, please apply. I did not know until today that and ||
commands behave specially under 'set -e'.
On Monday 06 September 2010, Bruno Haible wrote:
Hi Stefano,
Internationalization tests: prefer `test ! -r' over `test ! -f'
Why? Why is it more important to check that an expected file has
read permissions, than to check that it is a regular file?
Just in case the file is erroneously
Hi Stefano,
Internationalization tests: prefer `test ! -r' over `test ! -f'
Why? ...
Just in case the file is erroneously created as (say) a directory or
a symlink, a situation `test -f' would not catch.
I see, thanks. This is indeed more probable than that an unreadable
file is
On Monday 06 September 2010, Bruno Haible wrote:
Hello Stefano,
Hi Bruno. Thanks for your all your quick reviews.
Ralf said:
Give Bruno some time for comments before applying to the
pot-primary branch, please.
Yes, please. Give me always between 2 days (48 hours) and 7 days to
react.
I
Oh, and I forgot to ask: OK to push with this last amending applied?
Regards,
Stefano
On 09/06/2010 07:51 PM, Ralf Wildenhues wrote:
Hello Ralf,
* Ralf Corsepius wrote on Mon, Sep 06, 2010 at 07:49:04PM CEST:
On 09/06/2010 05:18 PM, Stefano Lattarini wrote:
This is mostly a cosmetic/consistency patch. I hope you'll find it
worth applying nonetheless.
Internationalization
24 matches
Mail list logo
