Re: More problems with `make -n' in automake-generated rules.

2010-11-07 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Nov 06, 2010 at 08:23:30PM CET: On Saturday 06 November 2010, Stefano Lattarini wrote: On Saturday 06 November 2010, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Sat, Nov 06, 2010 at 05:52:57PM CET: Hi Ralf, I've just spotted a bug in the patch

Re: [PATCH] Modernize, improve and/or tweak various test scripts.

2010-11-07 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Mon, Sep 13, 2010 at 11:22:37AM CEST: I updated the patch slighty (see test `depdist.test') to follow the emerging principle of preferring semantic tests to grepping tests in the Automake testsuite. OK with nits addressed. and in another mail:

Re: [PATCH] Modernize, improve and/or tweak various test scripts.

2010-11-07 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Nov 07, 2010 at 11:18:49AM CET: On Sunday 07 November 2010, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Mon, Sep 13, 2010 at 11:22:37AM CEST: * tests/ctarget1.test: Renamed ... Please don't rename tests unless for a very good reason, The good

Re: [PATCH] Modernize, improve and/or tweak various test scripts.

2010-11-07 Thread Stefano Lattarini
On Sunday 07 November 2010, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Sun, Nov 07, 2010 at 11:18:49AM CET: On Sunday 07 November 2010, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Mon, Sep 13, 2010 at 11:22:37AM CEST: * tests/ctarget1.test: Renamed ... Please

Re: [PATCH] Modernize, improve and/or tweak various test scripts.

2010-11-07 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Nov 07, 2010 at 11:44:44AM CET: On Sunday 07 November 2010, Ralf Wildenhues wrote: The test might not ever have made it to revision control, In this case I don't see any problem, no? Unless it's in a personal git clone only (not likely with existing history

Re: [PATCH] {maint} Fix a bug in variable concatanation with `+='.

2010-11-07 Thread Ralf Wildenhues
Hello Stefano, Andy, * Stefano Lattarini wrote on Sat, Nov 06, 2010 at 06:10:44PM CET: On Friday 05 November 2010, Stefano Lattarini wrote: I can confirm the bug with latest automake (from git master), with a much-reduced minimal testcase (see attachment). I still haven't looked for an

Re: [FYI] {master} Fix potential bug in generated tests `instpc-*.test'. (was: Re: tests updates)

2010-11-07 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Nov 05, 2010 at 09:21:28PM CET: Nonetheless, there was still a potential bug (introduced by the merge) lurking in there, which didn't manifest itself because, by sheer luck, the Automake parallel test driver worked around it (by exporting srcdir=$(srcdir) in

Re: [PATCH] {maint} Fix a bug in variable concatanation with `+='.

2010-11-07 Thread Stefano Lattarini
On Sunday 07 November 2010, Ralf Wildenhues wrote: Hello Stefano, Andy, * Stefano Lattarini wrote on Sat, Nov 06, 2010 at 06:10:44PM CET: On Friday 05 November 2010, Stefano Lattarini wrote: I can confirm the bug with latest automake (from git master), with a much-reduced minimal

[PATCH 0/7] Refactoring of testcases initialization code (was: Re: [PATCH 0/5] More cosmetic and consistency changes for tests/defs)

2010-11-07 Thread Stefano Lattarini
Hello automakers. On Wednesday 08 September 2010, Stefano Lattarini wrote: Stefano Lattarini (5): Tests defs: various reorderings, some improvements. Tests defs: prefer $curdir over `pwd`, where possible. Tests defs: rename $curdir - $testbuilddir Tests defs: do not print message

[PATCH 2/7] Tests defs: prefer $curdir over `pwd`.

2010-11-07 Thread Stefano Lattarini
* tests/defs.in: We already save the value of `pwd` in $curdir early in the file, so there no need to recalculate it later, when the current working directory is not changed. --- ChangeLog |5 + tests/defs.in |6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) From

[PATCH 3/7] Tests defs: rename $curdir - $testbuilddir

2010-11-07 Thread Stefano Lattarini
* tests/defs.in: Rename $curdir to $testbuildir, for clarity and consistency with $testsrcdir and $top_testsrcdir. --- ChangeLog |4 tests/defs.in | 14 +++--- 2 files changed, 11 insertions(+), 7 deletions(-) From ddc690b22264d5c6213ea89ef451c0c2bdec02c0 Mon Sep 17

[PATCH 4/7] Tests defs: do not print message Running test $0 anymore.

2010-11-07 Thread Stefano Lattarini
* tests/defs.in: Printing the message === Running test $0 at the beginning of each tests made sense when Automake used the old test-driver, which sent all the output directly to stdout/stderr. Now that the parallel test-driver is used, which saves output of each test in its correspoding log file,

[PATCH 6/7] Tests defs: new AC_SUBST'ed variable $top_testsbuilddir.

2010-11-07 Thread Stefano Lattarini
* tests/defs.in ($top_testsbuilddir): New variable, initialized with the value AC_SUBST'ed from @abs_top_build...@. Mostly for completeness and consistency with $testsrcdir and $top_testsrcdir. --- ChangeLog |5 + tests/defs.in |1 + 2 files changed, 6 insertions(+), 0