Re: [PATCH 1/2] tests: make test runner a script, not a shell function

2011-06-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Jun 20, 2011 at 11:12:23PM CEST: > Maybe we should also say that using TESTS_ENVIRONMENT to define a custom > test runner is now not only strongly deprecated (as it already was I hope), No it wasn't. "test runner" is not a term I would recognize, btw. > but also

Re: [PATCH v4 3/3] parallel-tests: allow each test to have multiple results

2011-06-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Jun 20, 2011 at 10:58:05PM CEST: > On Monday 20 June 2011, Ralf Wildenhues wrote: > > For example the parallel BSD makes tend to reuse shells for running > > the recipe commands; > > > But only for the commands in the same recipe, right? I think not. > > I'm not

Re: [FYI] {maint} maintcheck: avoid few spurious failures

2011-06-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Jun 20, 2011 at 11:59:57PM CEST: > On Monday 20 June 2011, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Mon, Jun 20, 2011 at 05:05:45PM CEST: > > > sc_tests_plain_automake: > > > - @if grep -v '^#' $(srcdir)/tests/*.test | grep -E ':[ > > > ]*automak

Re: [FYI] {maint} maintcheck: avoid few spurious failures

2011-06-20 Thread Stefano Lattarini
On Monday 20 June 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Mon, Jun 20, 2011 at 05:05:45PM CEST: > > * Makefile.am (sc_tests_plain_aclocal, sc_tests_plain_perl, > > sc_tests_plain_autoconf, sc_tests_plain_automake, > > sc_tests_plain_autoupate): Be stricter in matching an erroneo

Re: [FYI] {maint} maintcheck: avoid few spurious failures

2011-06-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Jun 20, 2011 at 05:05:45PM CEST: > * Makefile.am (sc_tests_plain_aclocal, sc_tests_plain_perl, > sc_tests_plain_autoconf, sc_tests_plain_automake, > sc_tests_plain_autoupate): Be stricter in matching an erroneous > literal command, i.e., `aclocal', `automake', `per

Re: [PATCH 1/2] tests: make test runner a script, not a shell function

2011-06-20 Thread Stefano Lattarini
On Monday 20 June 2011, Ralf Wildenhues wrote: > * Jim Meyering wrote on Mon, Jun 20, 2011 at 10:29:50PM CEST: > > Ralf Wildenhues wrote: > > > One thing I've regularly done with new code that is not 100% backward > > > compatible is have a new Automake option for them. That is exactly why > > > t

Re: [PATCH v4 3/3] parallel-tests: allow each test to have multiple results

2011-06-20 Thread Stefano Lattarini
On Monday 20 June 2011, Ralf Wildenhues wrote: > Hi Stefano, > > * Stefano Lattarini wrote on Mon, Jun 20, 2011 at 10:26:06PM CEST: > > On Monday 20 June 2011, Ralf Wildenhues wrote: > > > Why not just split the whole documentation change into a followup patch > > > then? > > > > > Because that wo

Re: [PATCH 1/2] tests: make test runner a script, not a shell function

2011-06-20 Thread Stefano Lattarini
On Monday 20 June 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Mon, Jun 20, 2011 at 10:22:28AM CEST: > > [Adding bug-grep, dropping bug-coreutils and automake-patches] > > re-adding the latter. > > > I've noticed that grep uses a definition of TESTS_ENVIRONMENT very similar > > to

Re: [PATCH 1/2] tests: make test runner a script, not a shell function

2011-06-20 Thread Ralf Wildenhues
* Jim Meyering wrote on Mon, Jun 20, 2011 at 10:29:50PM CEST: > Ralf Wildenhues wrote: > > One thing I've regularly done with new code that is not 100% backward > > compatible is have a new Automake option for them. That is exactly why > > there is a 'parallel-tests': it is not fully compatible wi

Re: [PATCH] check: don't use multi-line coloring for the report

2011-06-20 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Mon, Jun 20, 2011 at 10:29:02PM CEST: > * Stefano Lattarini wrote on Mon, Jun 20, 2011 at 10:33:53AM CEST: > > +# Prefix each line by 'col' and terminate each with 'std', for coloring. > > +# Multi line coloring is problematic with "less -R", so we really need > > +# to c

Re: [PATCH v4 3/3] parallel-tests: allow each test to have multiple results

2011-06-20 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Mon, Jun 20, 2011 at 10:26:06PM CEST: > On Monday 20 June 2011, Ralf Wildenhues wrote: > > Why not just split the whole documentation change into a followup patch > > then? > > > Because that would only postpone, not avoid, the continous tweaking and > amen

Re: [PATCH 1/2] tests: make test runner a script, not a shell function

2011-06-20 Thread Jim Meyering
Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Mon, Jun 20, 2011 at 10:22:28AM CEST: >> [Adding bug-grep, dropping bug-coreutils and automake-patches] > > re-adding the latter. > >> I've noticed that grep uses a definition of TESTS_ENVIRONMENT very similar >> to that of coreutils (the one we

Re: [PATCH] check: don't use multi-line coloring for the report

2011-06-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Jun 20, 2011 at 10:33:53AM CEST: > OK, I've amended the patch on Bert's behalf, as he can't do that himself > at the moment. Attached is what I've pushed (to maint). Thanks for handling this, and to Bert for the report and patch! Minor nit: > --- a/lib/am/check

Re: [PATCH v4 3/3] parallel-tests: allow each test to have multiple results

2011-06-20 Thread Stefano Lattarini
On Monday 20 June 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Fri, Jun 17, 2011 at 09:33:13AM CEST: > > On Friday 17 June 2011, Ralf Wildenhues wrote: > > > > > Actually, why not s/testcase/test/g globally in all your text. > > > > > Because I'm trying to make a distinction between

Re: [PATCH 1/2] tests: make test runner a script, not a shell function

2011-06-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Jun 20, 2011 at 10:22:28AM CEST: > [Adding bug-grep, dropping bug-coreutils and automake-patches] re-adding the latter. > I've noticed that grep uses a definition of TESTS_ENVIRONMENT very similar > to that of coreutils (the one we've just fixed), so it will brea

Re: [PATCH v4 1/3] parallel-tests: add auxiliary script 'pt-driver', refactor

2011-06-20 Thread Stefano Lattarini
On Thursday 16 June 2011, Stefano Lattarini wrote: > This refactoring should cause no API of functionality change, > and is meant only to simplify the future implementation of TAP > and SubUnit testsuite drivers. More precisely, our roadmap is > to move most of the "testsuite driving" features out

[FYI] {testuite-work} maintcheck: avoid few spurious failures

2011-06-20 Thread Stefano Lattarini
* tests/depmod-data.test: Use creative quoting to avoid spuriously triggering the `sc_tests_Exit_not_exit' maintainer check. Commit `v1.11-900-g3453b8e' attempted to fix it, but succeeded only partially. * tests/cond33.test: Fix header comments, not to reference obsolescent make variable `$(mkdir_

[FYI] {maint} maintcheck: avoid few spurious failures

2011-06-20 Thread Stefano Lattarini
* Makefile.am (sc_tests_plain_aclocal, sc_tests_plain_perl, sc_tests_plain_autoconf, sc_tests_plain_automake, sc_tests_plain_autoupate): Be stricter in matching an erroneous literal command, i.e., `aclocal', `automake', `perl', etc. --- ChangeLog |8 Makefile.am | 10 +- M

Re: [PATCH] check: don't use multi-line coloring for the report

2011-06-20 Thread Stefano Lattarini
On Friday 17 June 2011, Stefano Lattarini wrote: > Hi Bert, and thanks again for your patch. > > I have some minor observations and objections below (please do not take > them as a belittling of your work; they are either constructive criticism, > or requests for cosmetic changes mandated by the G

Re: [PATCH] {maint} distcheck: add support for AM_DISTCHECK_CONFIGURE_FLAGS

2011-06-20 Thread Stefano Lattarini
On Saturday 18 June 2011, Stefano Lattarini wrote: > On Wednesday 15 June 2011, Eric Blake wrote: > > [CUT] > > Here is the amended patch. Note that in the end I haven't made use of > the version information I've asked Eric previously, since adding it would > have broken the flow of discourse IMHO

Re: [PATCH] {maint} Deprecate de-ansification support, it should go away in automake 1.12

2011-06-20 Thread Stefano Lattarini
On Thursday 16 June 2011, Stefano Lattarini wrote: > On Thursday 16 June 2011, Stefano Lattarini wrote: > > Hi Bob. > > > > On Thursday 16 June 2011, Bob Friesenhahn wrote: > > > On Wed, 15 Jun 2011, Stefano Lattarini wrote: > > > >> > > > > Problem: it seems that there are few (and luckily only f