Re: PATCH: silence Shellcheck warning

2018-07-22 Thread Nick Bowler
On 7/21/18, Ben Elliston wrote: > This patch silences a warning from Shellcheck about using old-style > `...` command substitutions. [...] > commit 4d35c7aae97234bf055519075ef03cd4090a1dfc > Author: Ben Elliston > Date: Sun Jul 22 08:22:44 2018 +1000 > > * missing: Use $(..) command

Re: [PATCH 2/2] python tests: Do not require .pyo files

2018-07-22 Thread Lukas Fleischer
On Mon, 09 Jul 2018 at 16:59:36, Lukas Fleischer wrote: > So, we should either rewrite the test cases to explicitly use python2 > or, even better, keep using python and make the tests work with both > Python 2 and Python 3, the latter of which is achieved by the two > patches I submitted. Any

PATCH: silence Shellcheck warning

2018-07-22 Thread Ben Elliston
This patch silences a warning from Shellcheck about using old-style `...` command substitutions. Ben commit 4d35c7aae97234bf055519075ef03cd4090a1dfc Author: Ben Elliston Date: Sun Jul 22 08:22:44 2018 +1000 * missing: Use $(..) command substitution syntax. diff --git a/lib/missing