Re: [PATCH] t/pm: Use Test::Simple for Perl tests

2018-09-07 Thread Matthias Paulmier
Hello, Here are the reworked patches for enabling the Test::Simple tests in Automake's test suite. I split the original patch into 4 smaller/easier to review ones. I hope this is better this way. -- Matthias Paulmier >From c39c9e0d749a8f977bfea30a10e8cb60aafe90e2 Mon Sep 17 00:00:00 2001

Re: [PATCH] t/pm: Use Test::Simple for Perl tests

2018-09-06 Thread Mathieu Lirzin
Matthias Paulmier writes: > I sure can, I was feeling like it was a bit long but for some reason > thought it was better that way. No problem, the appropriate granularity for patches is a subjective matter. However in practice software projects tend to agree that new features, bug fixes, and

Re: [PATCH] t/pm: Use Test::Simple for Perl tests

2018-09-06 Thread Matthias Paulmier
Mathieu Lirzin writes: > Hello Matthias, > > Matthias Paulmier writes: > >> [...] > > This patch is too fat for me to properly review it. The changelog > description makes me think it could easily be separated in smaller > chunks. For example you could make one patch adding support for >

Re: [PATCH] t/pm: Use Test::Simple for Perl tests

2018-09-05 Thread Mathieu Lirzin
Hello Matthias, Matthias Paulmier writes: > This patch enables the use of the Test::Simple (and Test::More) library > for the Perl lib tests. One point that may need reflexion is wether or > not to keep the "old" way of testing Perl libraries into Automake (that > is without using

[PATCH] t/pm: Use Test::Simple for Perl tests

2018-09-05 Thread Matthias Paulmier
This patch enables the use of the Test::Simple (and Test::More) library for the Perl lib tests. One point that may need reflexion is wether or not to keep the "old" way of testing Perl libraries into Automake (that is without using Test::Simple/More). This patch is part of my GSoC project. I