On Tue, Jan 18, 2022 at 09:50:04PM -0500, Mike Frysinger wrote:
> shell does not lend itself to being written correctly. shellcheck
> has proven its worth to me multiple times over, especially because i
> can stop having to point out the same mistakes to people over & over
> that it easily
On 18 Jan 2022 04:53, Mike Frysinger wrote:
> As reported by Hongxu Jia:
> > The automake-$(APIVERSION) is a hardlink of automake, if it is
> > created later than update_mans executing, there is a failure
> > [snip]
> > |: && mkdir -p doc && ./pre-inst-env /usr/bin/env perl
> >
On 18 Jan 2022 21:25, Ben Elliston wrote:
> On Tue, Jan 18, 2022 at 04:18:52AM -0500, Mike Frysinger wrote:
> > that said, automake targets lower than POSIX, so i agree that we
> > should leave it be for automake specifically. feel like posting a
> > patch to suppress this particular check in
On 18 Jan 2022 11:29, Jim Meyering wrote:
> On Tue, Jan 18, 2022 at 10:29 AM Mike Frysinger wrote:
> > On 18 Jan 2022 09:48, Jim Meyering wrote:
> ...
> > > But IMHO that's too much duplication/syntax.
> > > How about this instead?
> > >
> > > case $(echo "$files" | wc -l) in 4|6) ;; *) false;;
Ben Elliston wrote:
On Tue, Jan 18, 2022 at 04:18:52AM -0500, Mike Frysinger wrote:
that said, automake targets lower than POSIX, so i agree that we
should leave it be for automake specifically. feel like posting a
patch to suppress this particular check in lib/missing instead ?
If
On Tue, Jan 18, 2022 at 10:01 AM Mike Frysinger wrote:
> On 31 May 2018 22:44, Jefferson Carpenter wrote:
> > Subject: [PATCH] automake.texi: clarify relationship between configure and
> > build dir
> >
> > I know you what this meant, but as a kid this would have confused me - the
> > word "in"
On Tue, Jan 18, 2022 at 10:03 AM Mike Frysinger wrote:
> On 08 Apr 2018 16:07, Matthew Leeds wrote:
> > ---
> > HACKING | 4 ++--
> > t/README | 2 +-
>
> thanks for the patch. looks like Jim fixed HACKING:
>
On Tue, Jan 18, 2022 at 10:29 AM Mike Frysinger wrote:
> On 18 Jan 2022 09:48, Jim Meyering wrote:
...
> > But IMHO that's too much duplication/syntax.
> > How about this instead?
> >
> > case $(echo "$files" | wc -l) in 4|6) ;; *) false;; esac
>
> looks reasonable for POSIX shell. not a fan
On Tue, Jan 18, 2022 at 04:18:52AM -0500, Mike Frysinger wrote:
> that said, automake targets lower than POSIX, so i agree that we
> should leave it be for automake specifically. feel like posting a
> patch to suppress this particular check in lib/missing instead ?
If it's welcome, sure. Some
As reported by Hongxu Jia:
> The automake-$(APIVERSION) is a hardlink of automake, if it is
> created later than update_mans executing, there is a failure
> [snip]
> |: && mkdir -p doc && ./pre-inst-env /usr/bin/env perl
> ../automake-1.16.1/doc/help2man --output=doc/aclocal-1.16.1 aclocal-1.16
>
On 18 Jan 2022 09:48, Jim Meyering wrote:
> On Tue, Jan 18, 2022 at 7:46 AM Mike Frysinger wrote:
> > From: Thomas Deutschmann
> >
> > Commit b279a0d46dfeca1ca40057c3c910ab1657d60be5 ("tests: in python
> > tests, do not require .pyo files (for python3)") had a slight logic
> > error in that it
On 22 Jul 2018 14:41, Nick Bowler wrote:
> On 7/21/18, Ben Elliston wrote:
> > This patch silences a warning from Shellcheck about using old-style
> > `...` command substitutions.
> [...]
> > commit 4d35c7aae97234bf055519075ef03cd4090a1dfc
> > Author: Ben Elliston
> > Date: Sun Jul 22 08:22:44
On 08 Apr 2018 16:06, Matthew Leeds wrote:
> --- a/doc/automake.texi
> +++ b/doc/automake.texi
> All of these actions are performed in a temporary directory. Please
> note that the exact location and the exact structure of such a directory
> (where the read-only sources are placed, how the
lgtm, and still applies cleanly
-mike
signature.asc
Description: PGP signature
On 08 Apr 2018 16:07, Matthew Leeds wrote:
> ---
> HACKING | 4 ++--
> t/README | 2 +-
thanks for the patch. looks like Jim fixed HACKING:
http://git.savannah.gnu.org/cgit/automake.git/commit/?h=7665b8e209888c73ee4dc05256f4f09a703a01e5
but your change to t/README still applies cleanly.
-mike
On 31 May 2018 22:44, Jefferson Carpenter wrote:
> Subject: [PATCH] automake.texi: clarify relationship between configure and
> build dir
>
> I know you what this meant, but as a kid this would have confused me - the
> word "in" seems to imply that the "configure" file is inside of the build
On Tue, Jan 18, 2022 at 7:46 AM Mike Frysinger wrote:
> From: Thomas Deutschmann
>
> Commit b279a0d46dfeca1ca40057c3c910ab1657d60be5 ("tests: in python
> tests, do not require .pyo files (for python3)") had a slight logic
> error in that it missed a `test` call.
>
> Reported to Gentoo at
17 matches
Mail list logo
