Re: [PATCH] Enable `set -e' in more tests (plus some tweakings).

2010-11-14 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Nov 11, 2010 at 03:52:39PM CET: Pinging this patch again, following this: http://lists.gnu.org/archive/html/automake-patches/2010-11/msg3.html Patch is OK. I didn't check whether any of the tests contained constructs problematic for set -e. I'll wait

testsuite results from master

2010-11-14 Thread Ralf Wildenhues
Hello Stefano, I think it is time to reevaluate some of the work that has been done in the last few weeks. I'd like to ask you to postpone pushes of pending stuff that has a clock ticking, and look at the lots of new failures that a testsuite run shows on a few hosts; you can find them in some

Re: testsuite results from master

2010-11-14 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Nov 15, 2010 at 12:19:00AM CET: On Sunday 14 November 2010, Ralf Wildenhues wrote: I think it is time to reevaluate some of the work that has been done in the last few weeks. Do you mean go and fix the newly introduced regressions before doing other

Re: Testsuite failures on AIX 5.3

2010-11-15 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Nov 14, 2010 at 10:14:54PM CET: http://autobuild.josefsson.org/automake/log-20101114190221478.txt + /bin/grep -F -v @SET_MAKE@ Makefile.in + 1 Makefile.sed + make -f Makefile.sed SHELL=/bin/sh test1 echo ' @top_srcdir@/configure.in

Re: Testsuite failures on Tru64 OSF 5.1

2010-11-15 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Mon, Nov 15, 2010 at 09:19:44AM CET: This is based off of master (but I guess it also applies to tests-init) but the backport to the msvc branch is trivial. I stole the xsi-test from libtool. Would be good if someone tested on that Alpha before pushing I

Re: Testsuite failures on Tru64 OSF 5.1

2010-11-15 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Nov 14, 2010 at 11:00:16PM CET: http://autobuild.josefsson.org/automake/log-201011141902490189000.txt FAIL: backcompat5.test (exit: 1) [CUT] find ../foo-1.0 -print ## useful for debugging find: missing conjunction

Re: Testsuite failures on AIX 5.3

2010-11-16 Thread Ralf Wildenhues
by setting the `$(SHELL)' macro on the command line of make, but this is not supported by the AIX 5.3 make implementation. This bug has been lurking for a long time, and was activated by commit v1.11-125-gc1f6cdb Enable `errexit' shell flag in various tests. Report by Ralf Wildenhues. [...]

Re: [SIMPLE PATCH] {master} Be more consistent in copyright notices.

2010-11-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Wed, Nov 17, 2010 at 12:22:57AM CET: While modifying the test script `suffix13.test' recently, I noticed that it uses an obsolete form of copyright notice: # This file is part of GNU Automake. # # GNU Automake is free software; you can redistribute it and/or

Re: [PATCHES] Fix spurious failures of some tests `silent*.test' with SunStudio Fortran

2010-11-17 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Wed, Nov 17, 2010 at 07:25:32PM CET: On Wednesday 17 November 2010, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Wed, Nov 17, 2010 at 03:25:02PM CET: F77bar.o NOTICE: Invoking /opt/SunStudio/sunstudio12.1/prod/bin/f90 -f77 -ftrap=%none -g -c

Re: [PATCHES] Fix spurious Lex/Yacc-related failures in tests `silent*.test' w.r.t. Solaris XPG4 make.

2010-11-17 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Wed, Nov 17, 2010 at 09:10:08PM CET: I'm seeing this failure with Solaris XPG4 make: $ MAKE=/usr/xpg4/bin/make sh silentyacc.test silentyacc: running bison --version bison (GNU Bison) 2.4.1 Written by Robert Corbett and Richard Stallman. [...] A similar

Re: [PATCH] New test on repeated automake options.

2010-11-19 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Fri, Nov 19, 2010 at 12:26:18PM CET: * tests/repeated-options.test: New test, check that automake does not complain on repeated options, nor generate broken or incorrect makefiles. * tests/Makefile.am (TESTS): Updated. OK. Thanks, Ralf

Sync config-ml.in from GCC.

2010-11-19 Thread Ralf Wildenhues
I pushed this to maint in Ian's name, to sync the script from GCC. Cheers, Ralf 2010-11-19 Ian Lance Taylor i...@... Sync config-ml.in from GCC. * config-ml.in: Add Go support: treat GOC and GOCFLAGS like other compiler/flag environment variables. diff --git

Re: [PATCH] {master} release-stats: account for generated `instspc-*.test' tests.

2010-11-19 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Nov 19, 2010 at 09:18:33PM CET: I've realized that my patch on instspc.test split refactoring has broken the release-stats target, since now there are other generated tests besides the `*-p.test' tests. The attached patch fix this glitch in a quick dirty

Re: [RFC] Docs: document silent make rules in a new chapter

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Nov 18, 2010 at 09:22:48PM CET: On Thursday 18 November 2010, Nick Bowler wrote: On 2010-11-18 20:31 +0100, Stefano Lattarini wrote: +...@vindex @code{AM_V_GEN} +...@c FIXME: wouldn't $(AM_V_SILENT) be clearer? Should we deprecate +...@c $(AM_V_at)?

libtool --help: honor $AUTOCONF, $AUTOMAKE

2010-11-20 Thread Ralf Wildenhues
I came across an interesting bug: the perl coverage output for a full run of the Automake test suite was showing a single invocation of the installed automake program, rather than the uninstalled $builddir/tests/automake-1.11a which should have been run. Some tracking revealed that this

Re: [PATCH] {maint} Improve and extend tests on de-ansification support.

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Tue, Nov 16, 2010 at 12:15:12AM CET: On Monday 15 November 2010, Ralf Wildenhues wrote: Well then we should adjust maintainer-check to not complain. Either way, maintainer-check results should not deteriorate. I'm not keen on meddling with the current

Re: [PATCH 4/5] Tests defs: avoid some useless subshells.

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:26:05PM CET: * tests/defs: In the loop on $required tools: avoid subshells where not neded. OK except for the last hunk: --- a/tests/defs +++ b/tests/defs @@ -297,12 +297,12 @@ do *) # Generic case: the tool must support

Re: [PATCH 5/5] Tests required tools: also try `-v' option for GNU compilers.

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:27:43PM CET: * tests/defs.in: In the loop on $required tools, for gcc and g++, also run gcc -v (resp. g++ -v), to get more information, and for consistency with gcj. Did this help you for anything in any way? Patch is OK. Thanks, Ralf

Re: [PATCH 0/5] More patches for the tests-init branch

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:18:15PM CET: Tests defs: don't let useless variables leak in test scripts. Tests defs: new subroutine `skip' for test skipping. Tests defs: some cleanup and minor fixes. No ticking clock for this patches at the moment; the clock will

Re: [PATCH 4/5] Tests defs: avoid some useless subshells.

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Nov 20, 2010 at 02:14:57PM CET: On Saturday 20 November 2010, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:26:05PM CET: # Generic case: the tool must support --version. echo $me: running $tool --version

Re: [SIMPLE PATCH] {master} Remove long-deprecated options --Werror and --Wno-error.

2010-11-27 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Nov 26, 2010 at 04:11:54PM CET: It seems the automake options `--Werror' and `--Wno-error' (kept for backward-compatibility only and, according to the git/CVS history, deprecated since commit c037f202602bf50f4e82a7f63d4624c3256df7f7, git-describe

Re: [FYI] {maint} Fix many typos in ChangeLog

2010-11-27 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Thu, Nov 25, 2010 at 12:25:47PM CET: I applied the attached patch to maint as abvious, merged into master and branch-1.11, and pushed. Thanks, also for the other patch. From 2601fd8f5688a2e9cb4c723c1c42007d3c019fca Mon Sep 17 00:00:00 2001 From:

Re: [FYI] {maint} Tests: fix spurious failures in silent*.test for $CC != gcc

2010-11-28 Thread Ralf Wildenhues
silent rules, we forced the use of gcc depmode to improve testsuite coverage; but this has unsurprisingly led to spurious failures when some non-GNU C compilers were used. So we are now careful to require GCC in tests that force gcc depmode. From reports by Ralf Wildenhues. * silent5

Re: [PATCH] {master} Improve and extend tests on `:=' variable assignments.

2010-11-28 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Nov 25, 2010 at 02:37:28PM CET: The attached patch is based off of maint, and intended for master. OK to apply? With nits addressed. Thanks, Ralf Improve and extend tests on `:=' variable assignments. * tests/colneq.test: Avoid useless use of wildcards

Re: [PATCH] {master} Improve and extend tests on `:=' variable assignments.

2010-11-29 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Nov 29, 2010 at 09:09:59PM CET: On Monday 29 November 2010, Ralf Wildenhues wrote: I approve the patch but ask you to keep that coverage in, now you update the patch with an unrelated new change whose applicability depends on completely different factors

savannah git repo updated again

2010-12-01 Thread Ralf Wildenhues
Hello Stefano, all, I pushed the commits that were missing from the rewound git repo upstream again, please check that the tree matches yours, then it should be good for pushing to again. Thanks, Ralf

Re: [PATCHES] {master} Optimize tests `instspc-*.test' for speed.

2010-12-02 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Dec 02, 2010 at 06:17:49PM CET: Since Savannah is up again now, I'm pinging this patch. Thanks. I'll wait the customary 72 hours (until sunday evening) before pushing, if there are no objections. I think this patch deserves a proper review. Sorry for the

Re: [PATCH] Extend checks on remake rules.

2010-12-05 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Dec 05, 2010 at 06:06:00PM CET: I'll wait the customary 72 hours (until wednesday evening) before pushing. This patch should have proper testing on several systems, and seems ok when tested and with nitse below addressed. If you still don't have access, please

Re: [PATCH] {master} Extend and improve tests on DejaGnu support.

2010-12-10 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Fri, Dec 10, 2010 at 06:06:53PM CET: On Thursday 09 December 2010, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Sun, Nov 14, 2010 at 02:29:33PM CET: + $MAKE distcheck Can't you either omit this distcheck, or the vpath = : case above

Re: [PATCH] {master} More uses of AS_HELP_STRING in automake macros.

2010-12-13 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Sun, Dec 12, 2010 at 02:47:35PM CET: * m4/depend.m4 (AM_DEP_TRACK): Use `AS_HELP_STRING' to format the help message added to the generated configure. * m4/dmalloc.m4 (AM_WITH_DMALLOC): Likewise. * m4/lispdir.m4 (AM_PATH_LISPDIR): Likewise. *

Re: [PATCH] {tests-init} Tests defs: de-uglify code for requiring an XSI-capable shell.

2010-12-13 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Dec 12, 2010 at 10:06:58PM CET: This is just a cosmetic patch. I will push in 72 hours (Wednesday evening) if nobody objects. Please don't. It's a feature that the code is the same as the one tested in Libtool _LT_CHECK_SHELL_FEATURES: bug-tested and all. I

Fix testsuite failure of check12.test without DejaGNU.

2010-12-13 Thread Ralf Wildenhues
Merged to master. Cheers, Ralf Fix testsuite failure of check12.test without DejaGNU. * tests/check12.test: Require runtest. diff --git a/tests/check12.test b/tests/check12.test index caa8e0f..34c8409 100755 --- a/tests/check12.test +++ b/tests/check12.test @@ -17,6 +17,7 @@ #

Re: [PATCH 0/2] Tests initialization: put default definition of AC_CONFIG_AUX_DIR in the pre-populated configure.in.

2010-12-13 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Dec 13, 2010 at 09:42:08PM CET: On Monday 13 December 2010, Ralf Wildenhues wrote: I'm undecided on this one. On the one hand, the safety increase is a plus, but on the other hand, the tests become less readable, if only because it is less obvious what

Re: [PATCH] Improve tests on generated portions of configure help screen. (was: Re: [PATCH] {master} More uses of AS_HELP_STRING in automake macros.)

2010-12-14 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Tue, Dec 14, 2010 at 10:41:17AM CET: OK, I've split the patch in two parts: the first part (for maint) improves the tests on automake-generated portions of configure help screens, the second part (for master) introduces more uses of `AS_HELP_STRING' in

Re: Fix testsuite failure of check12.test without DejaGNU.

2010-12-14 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Dec 13, 2010 at 08:37:35PM CET: On Monday 13 December 2010, Ralf Wildenhues wrote: Fix testsuite failure of check12.test without DejaGNU. * tests/check12.test: Require runtest. JFTR, notice that I tend to have available and installed as many

Re: [PATCH 2/2] Extended tests on AC_CONFIG_AUX_DIR.

2010-12-15 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Wed, Dec 15, 2010 at 09:49:55PM CET: On Tuesday 14 December 2010, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Sat, Dec 11, 2010 at 03:00:34PM CET: Can you update this patch to not require the previous 1/2? Yes, the updated patch is attached. I

Re: [PATCH] Extend checks on remake rules.

2010-12-15 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Dec 16, 2010 at 01:27:10AM CET: On Wednesday 15 December 2010, Ralf Wildenhues wrote: [ magic strings ] Why all the variation in these? That makes the tests harder to read. I'd rather not change the use of magic strings on the other remake tests, unless

Avoid false positive in sc_tests_plain_make maintainer-check.

2010-12-16 Thread Ralf Wildenhues
I'm seeing this in master now: ../automake/tests/remake11.test:makefiles_am_list=`find . -name Makefile.am | LC_ALL=C sort` ../automake/tests/remake11.test:makefiles_list=`echo $makefiles_am_list | sed 's/\.am$//'` Do not run make in the above tests. Use $MAKE instead. Makefile:1090: recipe

Re: [PATCH] Improvements and extend tests on canonicalization.

2010-12-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Dec 11, 2010 at 06:41:46PM CET: Ping on this? Reference: http://lists.gnu.org/archive/html/automake-patches/2010-09/msg00106.html The updated patch is attached. I will push it in 72 hours (by tuesday evening) unless there are objections. --- /dev/null

Re: [PATCH] Improvements and extend tests on canonicalization.

2010-12-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Dec 16, 2010 at 08:16:25PM CET: On Thursday 16 December 2010, Ralf Wildenhues wrote: --- a/tests/canon7.test +++ b/tests/canon7.test @@ -43,7 +43,7 @@ dummy_dynamic_SOURCES = $(dummy_static_SOURCES) dummy_static_LDADD = $(noinst_LIBRARIES

Re: [PATCH] {master} Extend, fix and improve tests on Lex and Yacc support.

2010-12-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Dec 13, 2010 at 07:54:05PM CET: OK to apply to a temporary branch off of maint, and merge to master? The patch is ok with nits addressed. BTW, notice that I'm planning to further extend the Lex/Yacc tests and make them more semantic, but that should be better

Re: [PATCH] {master} Extend, fix and improve tests on Lex and Yacc support.

2010-12-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Dec 16, 2010 at 10:10:29PM CET: On Thursday 16 December 2010, Ralf Wildenhues wrote: BTW, notice that I'm planning to further extend the Lex/Yacc tests and make them more semantic, but that should be better done in a follow-up patch IMVHO

Re: [PATCH] Test `$(var:suf=rpl)' expansion in special automake variables.

2010-12-17 Thread Ralf Wildenhues
Hello Stefano, * Stefano Lattarini wrote on Thu, Dec 09, 2010 at 01:46:48PM CET: Test `$(var:suf=rpl)' expansion in special automake variables. * tests/posixsubst-data.test: New test. [...] * tests/posixsubst-scripts.test: Likewise. --- /dev/null +++ b/tests/posixsubst-scripts.test @@

Re: [PATCH] {master} Extend, fix and improve tests on Lex and Yacc support.

2010-12-17 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Dec 17, 2010 at 03:33:32PM CET: On Friday 17 December 2010, Ralf Wildenhues wrote: The *current* tests are good enough for the current code. Yes, but not enough if we plan to modify that code You can add tests as you go modifying the code. Doing

Re: [PATCH] Test `$(var:suf=rpl)' expansion in special automake variables.

2010-12-18 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Dec 18, 2010 at 10:35:43AM CET: On Saturday 18 December 2010, Ralf Wildenhues wrote: +# Try also with `:=', to ensure the parser is not unduly confused +# into thinking that it's an unportable assignement operator. This comment is bogus, right

Re: [FYI] distlinksbrk.test: Work around botched make -k.

2010-12-21 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Tue, Dec 21, 2010 at 03:49:49PM CET: I've applied the patch below to a temporary bug-fixing branch, merged it to maint, merged maint to master, and pushed. The testcase still works with GNU make, FreeBSD make and Solaris make, but I couldn't test if it really

Happy New Year!

2011-01-01 Thread Ralf Wildenhues
... and apologies for my longer than predicted time off the net. All the best to you and GNU! Pushed to maint as below. Cheers, Ralf Bump copyright years. * aclocal.in (write_aclocal, version): Bump copyright years. * automake.in (gen_copyright, version): Likewise. *

Re: [PATCH v3] Work around a bug in Solaris make's file-inclusion mechanism.

2011-01-01 Thread Ralf Wildenhues
Hi Stefano, this has since been applied to maint: * Stefano Lattarini wrote on Fri, Dec 17, 2010 at 08:46:26PM CET: Subject: [PATCH] Work around a bug in file-inclusion mechanism of Solaris make. * automake.in (handle_single_transform): In the name of the dependency file: collapse

Re: [FYI] {master} Add some tests on 'cygnus' mode

2011-01-01 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Wed, Dec 22, 2010 at 11:55:04PM CET: Attached is what I pushed (to *master* only). From 7e7a8a6497cbc2473a3e25dd1067f2d44346325e Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Tue, 21 Dec 2010 22:59:19 +0100

Re: [PATCH] docs: how to work around checks on invalid primary/directory couples

2011-01-02 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Jan 02, 2011 at 12:23:48PM CET: On Sunday 02 January 2011, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Sat, Dec 25, 2010 at 10:57:57AM CET: Ok for maint? OK with nits addressed. Do we have testsuite coverage for this? Not yet, but once

Re: [PATCH 01/10] Add new tests on strictness and warnings precedence and overriding.

2011-01-02 Thread Ralf Wildenhues
Hi Stefano, I'm not sure if I'll get through the whole series today, but I gotta start somewhere, so here we go. Feel free to push the patch series (as far as OKed) on a new branch based off of maint, if that is helpful for you. Thanks. * stefano.lattar...@gmail.com wrote on Thu, Dec 23, 2010

Re: [PATCH 02/10] New test on silent-rules mode and portability warnings.

2011-01-02 Thread Ralf Wildenhues
* stefano.lattar...@gmail.com wrote on Thu, Dec 23, 2010 at 12:27:38PM CET: * tests/silent-rules-nowarn.test: New test. * tests/Makefile.am (TESTS): Update. How about silent-nowarn.test for consistency with the other names? OK with or without that change. Thanks, Ralf

Re: [PATCH 03/10] Warnings win over strictness on command line.

2011-01-02 Thread Ralf Wildenhues
* stefano.lattar...@gmail.com wrote on Thu, Dec 23, 2010 at 12:27:39PM CET: 2010-12-20 Stefano Lattarini stefano.lattar...@gmail.com + Warnings win over strictness on command line. Please add a line like For PR automake/547: on a line by itself here, as done in some (older)

Re: [PATCH 12/10] More checks on warnings/strictness in precedence (metawarnings).

2011-01-02 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Dec 24, 2010 at 09:21:56PM CET: More checks on warnings/strictness in precedence (metawarnings). metawarnings is not a proper word, how about just eliding the part in parentheses? Yes, I know I'm probably too picky on language; if it starts bothering you, I'll

Re: [PATCH 08/10] Add more tests about AUTOMAKE_OPTIONS.

2011-01-02 Thread Ralf Wildenhues
* stefano.lattar...@gmail.com wrote on Thu, Dec 23, 2010 at 12:27:44PM CET: In view of soon-to-follow refactorings (still in the pursuit of a fix for Automake bug#7669 a.k.a. PR/547), we add some more tests How about s/we // on AUTOMAKE_OPTIONS support, to prevent obvious regressions. *

Re: [PATCH 12/10] More checks on warnings/strictness in precedence (metawarnings).

2011-01-02 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Jan 02, 2011 at 07:49:16PM CET: On Sunday 02 January 2011, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Fri, Dec 24, 2010 at 09:21:56PM CET: I'm not sure it works to put AM_INIT_AUTOMAKE in an included macro. Apparently it does, at least when only

Re: [PATCH] {master} Tests: normalize use of the 'errexit' shell flag.

2011-01-03 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Mon, Jan 03, 2011 at 03:04:05PM CET: * tests/maken3.test (check_targets): Remove redundant call to 'set -e'. * tests/maken4.test: Likewise. * tests/ansi5.test: Call 'set -e' just after './defs' has been sourced. * tests/ansi6.test: Likewise. *

Re: [PATCH] {maint} Improve, extend and tweak tests on Texinfo support.

2011-01-03 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Jan 03, 2011 at 02:38:48PM CET: Subject: [PATCH] Improve, extend and tweak tests on Texinfo support. * tests/instdir-texi.test: Add a call to `ls -l' after that to `make', for debugging. When looking for required tools, do not redirect the output of $tool

Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE.

2011-01-06 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Wed, Jan 05, 2011 at 08:22:13PM CET: On Wednesday 05 January 2011, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Tue, Jan 04, 2011 at 06:38:04PM CET: + # will take precedence over warning settings defined implicitly by the + # strictness. Well

Re: [PATCH] {master} yacc: make clean removes .c and .h files from non-distributed .y

2011-01-07 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Fri, Jan 07, 2011 at 04:02:59PM CET: The patch is based off of maint. OK to apply to a temporary branch and merge to master? Yes. Thank you! And thing you developed it off of maint, it might be a candidate for later merging into branch-1.11. Cheers,

Re: bug#7773: (lack of) config.h description in manual

2011-01-08 Thread Ralf Wildenhues
As part of addressing Automake bug#7766 and bug#7773, I'm pushing the following in Karl's name, to the maint branch. Cheers, Ralf 2011-01-08 Karl Berry k...@freefriends.org Eric Blake ebl...@redhat.com docs: reference defining directories in amhello node. *

Re: [PATCH] yacc: extend and improve tests

2011-01-08 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Sat, Jan 08, 2011 at 02:33:34PM CET: Here are some testsuite enhancements that might help the on-going work on Yacc support. OK for a proper temporary branch off of 'yacc-clean' (after having merged into it the older temporary branch

Re: [PATCHES] yacc: support variable expansions in *YFLAGS definition

2011-01-08 Thread Ralf Wildenhues
[ dropping the PR Cc: ] * Stefano Lattarini wrote on Fri, Jan 07, 2011 at 11:50:51PM CET: On Friday 07 January 2011, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Fri, Jan 07, 2011 at 03:36:43PM CET: Currently, automake is not smart enough to resolve variable expansions

Re: [PATCHES] yacc: support variable expansions in *YFLAGS definition (was: Re: bug#7800: automake fails to honor `-d' in AM_YFLAGS when variable expansions are involved)

2011-01-08 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Jan 07, 2011 at 11:50:51PM CET: Subject: [PATCH 2/2] yacc: support variable expansions in *YFLAGS definition. This commit fixes automake bug#7800. OK with nits addressed. Thanks! Ralf * automake.in (lang_yacc_target_hook): Use 'value_as_list_recursive'

Re: bug#7766: (lack of) config.h description in manual

2011-01-08 Thread Ralf Wildenhues
Hi Karl, * Karl Berry wrote on Sat, Jan 01, 2011 at 01:00:20AM CET: Finally, the amhello explained node is pretty long. It seems to break up naturally into three pieces, for each of the files being explained. Perhaps it would be good to make them each separate (sub)nodes. Hmm, I see a

Re: [PATCH] yacc: extend and improve tests

2011-01-08 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Jan 08, 2011 at 08:33:28PM CET: On Saturday 08 January 2011, Ralf Wildenhues wrote: --- /dev/null +++ b/tests/yacc-d-basic.test @@ -0,0 +1,157 @@ +#! /bin/sh +# Copyright (C) 2011 Free Software Foundation, Inc. If this supersedes yacc3.test

Re: [Automake-commit] [SCM] GNU Automake branch, maint, updated. v1.11-268-gbb528a7

2011-01-09 Thread Ralf Wildenhues
[ from -commit ] * Stefano Lattarini wrote on Sun, Jan 09, 2011 at 03:30:43PM CET: cosmetics: remove trailing whitespaces * doc/automake.texi: Remove trailing whitespaces. [...] --- a/doc/automake.texi +++ b/doc/automake.texi @@ -157,8 +157,8 @@ Use Cases for the GNU Build

Re: [PATCH] {maint} Improve, extend and tweak tests on Texinfo support.

2011-01-10 Thread Ralf Wildenhues
Hi Stefano, sorry for the delay. * Stefano Lattarini wrote on Tue, Jan 04, 2011 at 03:41:45PM CET: On Monday 03 January 2011, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Mon, Jan 03, 2011 at 02:38:48PM CET: Subject: [PATCH] Improve, extend and tweak tests on Texinfo support

Re: [PATCH] {maint} Improve, extend and tweak tests on Texinfo support.

2011-01-10 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Tue, Jan 11, 2011 at 02:14:26AM CET: On Monday 10 January 2011, Ralf Wildenhues wrote: The longer the names, and the more the tests, the earlier we will exceed the command line length limit in our 'check' rules (important to fix on all systems it happens

Re: [PATCH] {master} tests: more consistent checks about invalid options

2011-01-11 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Tue, Jan 11, 2011 at 01:48:41PM CET: Another (minor) testsuite patch. Discouraged, but OK with nit addressed. Thanks, Ralf * tests/aclocal.test: Grepping of automake stderr for messages reporting invalid options made stricter. *

Re: documentation about '-d' in AM_YFLAGS is suboptimal

2011-01-12 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Wed, Jan 12, 2011 at 01:36:08PM CET: On Wednesday 12 January 2011, Юрий Пухальский wrote: Package isn't enclosed because otherwise the message doesn't get through. Finally had time to make some tests, and now i've got it:) When i set AM_YFLAGS to -dt it

Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE.

2011-01-12 Thread Ralf Wildenhues
Here comes my (belated, as always) re-review; I am not repeating nits already dealt with before. * Stefano Lattarini wrote on Wed, Jan 05, 2011 at 08:22:13PM CET: On Wednesday 05 January 2011, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Tue, Jan 04, 2011 at 06:38:04PM CET

Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE.

2011-01-12 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Wed, Jan 12, 2011 at 09:11:41PM CET: On Wednesday 12 January 2011, Ralf Wildenhues wrote: So, now with that said, I'm not sure whether I should approve this patch. What do you think? I think that you should, provided that I add the sanity check you suggested

Avoid testsuite failures due to Autoconf Fortran change

2011-01-13 Thread Ralf Wildenhues
My recent Autoconf change provoked some testsuite failures in Automake, see http://hydra.nixos.org/build/856303/log/raw. I'm pushing the fix below to maint and merging to branch-1.11 and master. Cheers, Ralf Avoid testsuite failures due to Autoconf Fortran change. Autoconf

Re: [PATCH] {maint} Improve, extend and tweak tests on Texinfo support.

2011-01-13 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Mon, Jan 03, 2011 at 02:38:48PM CET: From f236e0eb21df62ff4e5c01ecfaefe75d2e3d3d9b Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Fri, 24 Dec 2010 02:56:35 +0100 Subject: [PATCH] Improve, extend and tweak tests on

Re: [PATCH 6/9] Change signature of 'Automake::Options::_process_option_list()'.

2011-01-13 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Tue, Jan 04, 2011 at 06:48:06PM CET: Change signature of 'Automake::Options::_process_option_list()'. This only modifies internal details in the automake implementation, bearing no externally visible effect, but preparing the way for the final fix of Automake

Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE.

2011-01-13 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Jan 13, 2011 at 10:27:48PM CET: On Thursday 13 January 2011, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Wed, Jan 12, 2011 at 09:11:41PM CET: On Wednesday 12 January 2011, Ralf Wildenhues wrote: So, now with that said, I'm not sure whether I

Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE.

2011-01-13 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Jan 14, 2011 at 12:11:27AM CET: [Ralf Wildenhues] If some code later calls it like process_option_list (first-set-of-options); process_option_list (second-set-of-options); then things will go wrong again. I suspect that it will mean

Re: bug#7833: automake uses two different values for DejaGNU srcdir

2011-01-14 Thread Ralf Wildenhues
* Ian Lance Taylor wrote on Thu, Jan 13, 2011 at 06:29:39PM CET: Ralf Wildenhues writes: Am I correct in assuming that it is hopeless to assume GCC will work when either values are relative? Actually, as far as I know, GCC is likely to work with a relative srcdir. The problem arises

autobuild logs

2011-01-15 Thread Ralf Wildenhues
I've put up a set of logs at http://autobuild.josefsson.org/automake/ again. Quite a few new failures, so I think some maintenance work is warranted. Cheers, Ralf

testsuite issues on MinGW/MSYS

2011-01-15 Thread Ralf Wildenhues
I'm seeing a couple of weird issues on MinGW/MSYS. First of all, several spurious failures of this kind: ./defs: line 33: /bin/sed: Resource temporarily unavailable The line in question is: me=`echo $argv0 | sed -e 's,.*[\\/],,;s/\.test$//'` This is on a loaded system, but I don't remember

Re: [PATCH 1/5] Tests defs: don't let useless variables leak in test scripts.

2011-01-15 Thread Ralf Wildenhues
Hi Stefano, and apologies for the long delay, there were three patches in this series that haven't been reviewed yet: * Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:21:16PM CET: * tests/defs ($priv_check_temp, $overwrite_status, $ro_dir_temp, $create_status, $r2h, $libtool_found,

Re: [PATCH 2/5] Tests defs: new subroutine `skip' for test skipping.

2011-01-15 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:23:21PM CET: Tests defs: new subroutine `skip' for test skipping. I don't like having this patch alone. If we switch to functions, then we should so wholesale, and at once, and fully. Also, there is precedent in

Avoid VPATH-related distcheck failures with non-GNU make

2011-01-15 Thread Ralf Wildenhues
OK, so all the added '$MAKE distcheck' for safety at the end of the tests caused roughly a thousand new test failures across the board, it seems, drowning other signals. Most of these failures apparently have two reasons: 1) Cleanup failed to remove some directory because of stale NFS handles,

Re: [PATCH] tests: fix comment typo

2011-01-15 Thread Ralf Wildenhues
Hi Jim, * Jim Meyering wrote on Sat, Jan 15, 2011 at 10:49:07AM CET: It looks like I never sent this patch: Thanks. I added a ChangeLog entry, bumped copyright years, and pushed to maint. Cheers, Ralf From 2a898e3a7bc80dac3506f8ef325a95ef375971ef Mon Sep 17 00:00:00 2001 From: Jim Meyering

Fix remake rule-induced test failures with HP-UX make.

2011-01-15 Thread Ralf Wildenhues
Quoting parts of: http://autobuild.josefsson.org/automake/log-201101150749395803000.txt | FAIL: colon6.test (exit: 1) | === | |

Fix libobj2.test failure with non-GNU make: define $(AR).

2011-01-15 Thread Ralf Wildenhues
automake currently defines $(AR) only if it sees a _LIBRARIES primary. That may be an issue or not (and the wrong value for cross setups that it defines is definitely an issue), but not important for this test IMVHO, so how about this patch to avoid a spurious test failure as in

Re: tests: always update generated tests silently

2011-01-15 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Jan 15, 2011 at 12:26:24PM CET: As I wrote (or copied? I can't remember) in my pending documentation patch on silent rules support: @cindex default verbosity for silent-rules Note that silent rules are @emph{disabled} by default; the user must enable

Re: testsuite issues on MinGW/MSYS

2011-01-15 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Jan 15, 2011 at 12:07:45PM CET: On Saturday 15 January 2011, Ralf Wildenhues wrote: I'm seeing a couple of weird issues on MinGW/MSYS. First of all, several spurious failures of this kind: ./defs: line 33: /bin/sed: Resource temporarily unavailable

Re: [PATCH] Update docs w.r.t. warning and strictness options.

2011-01-15 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Jan 15, 2011 at 12:41:16PM CET: And here finally is the promised documentation patch, which should conclude the patch series (this time for good, I hope!). Thanks, and sorry for the delay, No problem. Let's see if we can get through it quickly. I think you

Re: Fix remake rule-induced test failures with HP-UX make.

2011-01-15 Thread Ralf Wildenhues
[ adding autoconf-patches ] * Ralf Wildenhues wrote on Sat, Jan 15, 2011 at 11:31:55AM CET: Quoting parts of: http://autobuild.josefsson.org/automake/log-201101150749395803000.txt I'm not quite sure why HP-UX make seems to trigger rebuild rules for prerequisites that have the exact time

Re: Fix remake rule-induced test failures with HP-UX make.

2011-01-15 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Jan 15, 2011 at 01:51:54PM CET: On Saturday 15 January 2011, Ralf Wildenhues wrote: Quoting parts of: http://autobuild.josefsson.org/automake/log-201101150749395803000.txt [...] How about the patch below to not let this cause spurious testsuite failures

Re: [PATCH] Update docs w.r.t. warning and strictness options.

2011-01-15 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Jan 15, 2011 at 02:23:56PM CET: On Saturday 15 January 2011, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Sat, Jan 15, 2011 at 12:41:16PM CET: And here finally is the promised documentation patch, which should conclude the patch series (this time

docs: ensure example are separated with empty lines in the input (was: [PATCH] Update docs w.r.t. warning and strictness options.)

2011-01-15 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Sat, Jan 15, 2011 at 02:49:33PM CET: * Stefano Lattarini wrote on Sat, Jan 15, 2011 at 02:23:56PM CET: On Saturday 15 January 2011, Ralf Wildenhues wrote: Empty lines before @example and after @end example, and before @noindent (the last two should be collapsed

Re: [PATCH 2/5] Tests defs: new subroutine `skip' for test skipping.

2011-01-15 Thread Ralf Wildenhues
[ Jim, I have a question below ] * Stefano Lattarini wrote on Sat, Jan 15, 2011 at 03:16:51PM CET: On Saturday 15 January 2011, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:23:21PM CET: Tests defs: new subroutine `skip' for test skipping. I don't like

Re: Avoid VPATH-related distcheck failures with non-GNU make

2011-01-16 Thread Ralf Wildenhues
Hello Stefano, * Stefano Lattarini wrote on Sat, Jan 15, 2011 at 04:50:31PM CET: On Saturday 15 January 2011, Ralf Wildenhues wrote: ensure_distcheck_ () { if $MAKE --version -v | grep GNU; then $MAKE distcheck else : fi } Hmm... To me, this sounds an awful lot

Re: tests: avoid new failures due to nonexistent makeinfo.

2011-01-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Jan 16, 2011 at 12:05:33PM CET: I have serious doubts about this patch ... On Sunday 16 January 2011, Ralf Wildenhues wrote: http://hydra.nixos.org/build/858836/log/raw and other logs show new testsuite failures of txinfo.test and txinfo8.test: I'm

Fix parallel-tests.test failure with HP-UX make

2011-01-16 Thread Ralf Wildenhues
Now that we know HP-UX make updates files with the same time stamp as their prerequisites, it is obvious how to fix the long-standing parallel-tests.test failure. Pushing to maint as below. Cheers, Ralf Fix parallel-tests.test failure with HP-UX make. * tests/parallel-tests.test:

tests: avoid failing command substitution in errexit mode.

2011-01-16 Thread Ralf Wildenhues
Quoting http://autobuild.josefsson.org/automake/log-20110115074814053.txt | FAIL: vartypos.test (exit: 1) | = | |

Re: tests-init branch

2011-01-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Jan 16, 2011 at 04:11:04PM CET: I've just merged the tests-init branch into master, and pushed. Thanks. At this point, that branch has IMHO pretty much exhausted its usefulness, and could be removed. Future non-obvious testsuite work could be done in more

<    4   5   6   7   8   9   10   11   >