[bug#68416] [PATCH] python: add 3.20 - 3.16 to the version search list

2024-01-15 Thread Jacob Bachmeyer
Frederic Berat wrote: On Sun, Jan 14, 2024 at 3:13 AM Karl Berry wrote: With Python 3.12 out now, and 3.13 out in ~9 months, the existing runway is running out. Bump up to 3.20 for the next Automake release. Applied, thanks. Not proposing to try anything for our upcoming

[bug#67841] [PATCH] Clarify error messages for misuse of m4_warn and --help for -W.

2023-12-19 Thread Jacob Bachmeyer
Karl Berry wrote: "All possible characters have a UTF-8 representation so this function [encode_utf8] cannot fail." What about non-characters, i.e., byte sequences that are invalid UTF-8? Each individual byte gets encoded as UTF-8. 0x00..0x7F are an identity map, while

[bug#67841] [PATCH] Clarify error messages for misuse of m4_warn and --help for -W.

2023-12-18 Thread Jacob Bachmeyer
Zack Weinberg wrote: On Fri, Dec 15, 2023, at 7:08 PM, Jacob Bachmeyer wrote: Zack Weinberg wrote: [...] Also, there’s a perl 2.14ism in one place (s///a) which I need to figure out how to make 2.6-compatible before it can land. ... + $q_channel =~ s/([^\x20-\x7e])/&quo

[bug#67841] [PATCH] Clarify error messages for misuse of m4_warn and --help for -W.

2023-12-15 Thread Jacob Bachmeyer
Zack Weinberg wrote: [...] Since this touches code shared between Autoconf and Automake, I’m not checking it in yet and I’m requesting comments from both sides of the fence. Also, there’s a perl 2.14ism in one place (s///a) which I need to figure out how to make 2.6-compatible before it can

[bug#61240] [PATCH 2/2] Gracefully degrade if Time::HiRes is not available

2023-03-28 Thread Jacob Bachmeyer
to older Perl, and if Jacob Bachmeyer or some other Perl expert can vouch for the change, we might as well put it in. I have since checked and it appears that the same patch I submitted for Automake on this bug should also work for Autoconf, applied atop commit

[bug#61240] [PATCH 2/2] Gracefully degrade if Time::HiRes is not available

2023-03-28 Thread Jacob Bachmeyer
[expanding CC list to cover later message] Paul Eggert wrote: On 2023-02-07 21:29, Jacob Bachmeyer wrote: use Exporter; -use Time::HiRes qw(stat); use IO::File; +# use sub-second resolution timestamps if available, +# carry on with one-second resolution timestamps if that is all we have

[bug#61671] [PATCH] Remove parentheses around test argument lists

2023-02-21 Thread Jacob Bachmeyer
This works around a parser bug in Perl 5.6.2. * t/pm/General.pl: Remove parentheses on argument lists. --- t/pm/General.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/pm/General.pl b/t/pm/General.pl index bb99fce83..fafedbc46 100644 --- a/t/pm/General.pl +++

[bug#61670] [PATCH] Improve test for blocked signals

2023-02-21 Thread Jacob Bachmeyer
This fixes ERRORs reported by: * t/parallel-tests-interrupt.tap * t/self-check-exit.tap * t/self-check-is-blocked-signal.tap * t/tap-signal.tap * t/ax/am-test-lib.sh (is_blocked_signal): Revise Perl code to more closely follow documented interfaces where

[bug#61240] [PATCH 1/2] revert Perl version requirement bump

2023-02-07 Thread Jacob Bachmeyer
Paul Eggert wrote: On 2023-02-05 21:43, Jacob Bachmeyer wrote: Should the patch be relative to commit 6d6fc91c472fd84bd71a1b012fa9ab77bd94efea (before the version requirement bump) or should it include reverting commit 4e3744a15c4d8bdb46c11ead2fb56c5f591b714b (the version requirement bump

[bug#61240] [PATCH 2/2] Gracefully degrade if Time::HiRes is not available

2023-02-07 Thread Jacob Bachmeyer
Paul Eggert wrote: On 2023-02-05 21:43, Jacob Bachmeyer wrote: Should the patch be relative to commit 6d6fc91c472fd84bd71a1b012fa9ab77bd94efea (before the version requirement bump) or should it include reverting commit 4e3744a15c4d8bdb46c11ead2fb56c5f591b714b (the version requirement bump

[bug#61240] [PATCH 0/2] restore support for 5.6 and gracefully degrade timestamps

2023-02-07 Thread Jacob Bachmeyer
Paul Eggert wrote: On 2023-02-05 21:43, Jacob Bachmeyer wrote: Should the patch be relative to commit 6d6fc91c472fd84bd71a1b012fa9ab77bd94efea (before the version requirement bump) or should it include reverting commit 4e3744a15c4d8bdb46c11ead2fb56c5f591b714b (the version requirement bump

[bug#61240] improve high-res file timestamp in Automake

2023-02-05 Thread Jacob Bachmeyer
Paul Eggert wrote: On 2023-02-05 17:14, Jacob Bachmeyer wrote: [...] Looking at the code, commit 01bf65daf6f6627b56fbe78fc436fd877ccd3537 appears fine, all I am asking is that commit 4e3744a15c4d8bdb46c11ead2fb56c5f591b714b be reverted. The current Automake Git master should actually work

[bug#61240] improve high-res file timestamp in Automake

2023-02-05 Thread Jacob Bachmeyer
Paul Eggert wrote: On 2023-02-04 16:02, Jacob Bachmeyer wrote: In any case, you will still need to account for the possibility that Time::HiRes::stat() might not actually have higher resolution, depending on the filesystem. That's fine. All we want is the exact file timestamp. If the file

[bug#61240] improve high-res file timestamp in Automake

2023-02-04 Thread Jacob Bachmeyer
Paul Eggert wrote: On 2023-02-03 18:27, Jacob Bachmeyer wrote: Where are you actually using a 5.10 feature? Where lib/Automake/FileUtils.pm says "use Time::HiRes qw(stat);". This does not work with Perl 5.6. Time::HiRes is (perhaps was) installable from CPAN and is definitely /n

[bug#61240] improve high-res file timestamp in Automake

2023-02-03 Thread Jacob Bachmeyer
Paul Eggert wrote: I installed the attached to port a FileUtils.pm patch back from Autoconf into Automake. I wish Perl supported file timestamps with nanosecond resolution, but apparently not, so this is the best we could do easily. Although this bumps the required Perl version from 5.6

[bug#60807] [PATCH v2] tests: reuse am_cv_filesystem_timestamp_resolution

2023-01-16 Thread Jacob Bachmeyer
Mike Frysinger wrote: On 14 Jan 2023 21:43, Jacob Bachmeyer wrote: [...] You could also exploit that || short-circuits in the shell and replace the "if" block with " $PERL ... || sleep='sleep ''2' ". This allows you to directly execute a command on a false

[bug#60807] [PATCH v2] tests: reuse am_cv_filesystem_timestamp_resolution

2023-01-14 Thread Jacob Bachmeyer
Mike Frysinger wrote: Rather than assume such coarse delays, re-use existing logic for probing the current filesystem resolution. This speeds up the testsuite significantly. On my system, it speeds -j1 up quite a lot -- by ~30%. While I didn't gather many samples to produce a statistically

[bug#60807] [PATCH 1/2] mtime: use Time::HiRes::stat when available for subsecond resolution

2023-01-14 Thread Jacob Bachmeyer
Mike Frysinger wrote: Perl's builtin stat function returns timestamps that have 1 second resolution. This can lead automake needlessly regenerating files because it compares timestamps as "older than or equal to" rather than only "older than". This is perfectly reasonable as we have no way of

[bug#59989] [PATCH] tests: Fix txinfo-include test for texinfo 7.x

2022-12-12 Thread Jacob Bachmeyer
Karl Berry wrote: Hi Frederic, Texinfo modified its behavior regarding apostrophes, which are now replaced by UTF-8 right single quotes by default. Sorry to hear it, but not surprised. -GNU's Not Unix. +@verb{.GNU's Not Unix..} I don't think there's any guarantee that verb

Re: [PATCH] python: prioritize python 3.x over 2.x

2022-01-27 Thread Jacob Bachmeyer
Zack Weinberg wrote: On Wed, Jan 26, 2022, at 10:10 PM, Mike Frysinger wrote: On 26 Jan 2022 10:07, Zack Weinberg wrote: Please also move the plain "python" command down to the python2 block (right after "python2" would be the best place I think). Any system on which "python" runs

Re: PATCH: silence Shellcheck warning

2022-01-18 Thread Jacob Bachmeyer
Ben Elliston wrote: On Tue, Jan 18, 2022 at 04:18:52AM -0500, Mike Frysinger wrote: that said, automake targets lower than POSIX, so i agree that we should leave it be for automake specifically. feel like posting a patch to suppress this particular check in lib/missing instead ? If

[PATCH v1] Fix misuse of DejaGnu in Automake testsuite

2021-07-13 Thread Jacob Bachmeyer
This is a revised patch that changes the DejaGnu tests in the Automake testsuite to properly use a testsuite/ directory. A previous "v0" of this patch was sent to the general Automake list as an illustration of the problem, but that version of the patch broke compatibility with all older

Re: Add support for EXTRA_DIST_LINKS

2021-05-31 Thread Jacob Bachmeyer
madmurphy wrote: But what if a developer wants to package something *for another developer*? It is not unusual to have a non-bootstraped “dev” version of a package circulating among developers How is Git not adequate for this? If you need to pass files around, there is the "git bundle"

Re: Add support for EXTRA_DIST_LINKS

2021-05-30 Thread Jacob Bachmeyer
madmurphy wrote: P.S. *“If I remember correctly, Autoconf also falls back to hardlinks or copying the files if the system does not support symbolic links.”*: Same goes for my patch. I use $(LN_S) for creating the links, and that falls back to hardlinks when ln -s is not supported. The

Re: Add support for EXTRA_DIST_LINKS

2021-05-30 Thread Jacob Bachmeyer
madmurphy wrote: I have created a patch for Automake to support a new Makefile variable named EXTRA_DIST_LINKS. The purpose of the variable is that of creating symlinks for the distributed archive. The syntax is very simple: a space-separated list of tokens of the form DEST:SOURCE – it is